)]}'
{"manifests/metadata/novajoin/api.pp":[{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"036c59ce41f25bf4717de8f60dac92a0cccde96d","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"  if $enable_ipa_client_install {"},{"line_number":178,"context_line":"    require ::ipaclient"},{"line_number":179,"context_line":"\t\t# If we\u0027re installing IPA here, the hostname fact won\u0027t be populated yet,"},{"line_number":180,"context_line":"\t\t# so we\u0027ll use a command to get it."},{"line_number":181,"context_line":"\t\t$ipa_hostname_real \u003d \u0027`grep xmlrpc_uri /etc/ipa/default.conf | cut -d/ -f3`\u0027"},{"line_number":182,"context_line":"\t} else {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bf659307_5d50045f","line":179,"range":{"start_line":179,"start_character":1,"end_line":179,"end_character":2},"updated":"2018-04-09 07:30:32.000000000","message":"Should be a space, not a tab :)","commit_id":"389f1371138d7a7db25f6f24518aba2cbd3ea58d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2a1392dc49f53c8f2de0f030fc13b2d46962e484","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    require ::ipaclient"},{"line_number":179,"context_line":"    # If we\u0027re installing IPA here, the hostname fact won\u0027t be populated yet,"},{"line_number":180,"context_line":"    # so we\u0027ll use a command to get it."},{"line_number":181,"context_line":"    $ipa_hostname_real \u003d \u0027`grep xmlrpc_uri /etc/ipa/default.conf | cut -d/ -f3`\u0027"},{"line_number":182,"context_line":"  } else {"},{"line_number":183,"context_line":"    # This assumes that the current node is already IPA enrolled, so the"},{"line_number":184,"context_line":"    # fact will work here."}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bf659307_fc7a2cb8","line":181,"updated":"2018-04-09 16:51:00.000000000","message":"I assume this works because of the \u0027require ::ipaclient\u0027 gets processed before this var?","commit_id":"150bff424fd9f0fa539649733304cad334f42902"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"bf4ffb2fabfda50b5a494c430b7e36b9f7c425ce","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    require ::ipaclient"},{"line_number":179,"context_line":"    # If we\u0027re installing IPA here, the hostname fact won\u0027t be populated yet,"},{"line_number":180,"context_line":"    # so we\u0027ll use a command to get it."},{"line_number":181,"context_line":"    $ipa_hostname_real \u003d \u0027`grep xmlrpc_uri /etc/ipa/default.conf | cut -d/ -f3`\u0027"},{"line_number":182,"context_line":"  } else {"},{"line_number":183,"context_line":"    # This assumes that the current node is already IPA enrolled, so the"},{"line_number":184,"context_line":"    # fact will work here."}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bf659307_923677b4","line":181,"in_reply_to":"bf659307_2f22a802","updated":"2018-04-09 17:48:19.000000000","message":"well... it doesn\u0027t really matter much. as long as the require above gets evaluated first.","commit_id":"150bff424fd9f0fa539649733304cad334f42902"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0332ad81abbd48071e591bae5dad823125a918a4","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    require ::ipaclient"},{"line_number":179,"context_line":"    # If we\u0027re installing IPA here, the hostname fact won\u0027t be populated yet,"},{"line_number":180,"context_line":"    # so we\u0027ll use a command to get it."},{"line_number":181,"context_line":"    $ipa_hostname_real \u003d \u0027`grep xmlrpc_uri /etc/ipa/default.conf | cut -d/ -f3`\u0027"},{"line_number":182,"context_line":"  } else {"},{"line_number":183,"context_line":"    # This assumes that the current node is already IPA enrolled, so the"},{"line_number":184,"context_line":"    # fact will work here."}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bf659307_32e1abfd","line":181,"in_reply_to":"bf659307_923677b4","updated":"2018-04-09 17:53:44.000000000","message":"i might be confusing it with the ruby stuff where `` shells out. if it\u0027s working for you, then we can leave it. I\u0027ve always preferred the $() bash syntax over ``","commit_id":"150bff424fd9f0fa539649733304cad334f42902"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"964e5f6c059540c94c3ae60d981e0aeb10ddc409","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    require ::ipaclient"},{"line_number":179,"context_line":"    # If we\u0027re installing IPA here, the hostname fact won\u0027t be populated yet,"},{"line_number":180,"context_line":"    # so we\u0027ll use a command to get it."},{"line_number":181,"context_line":"    $ipa_hostname_real \u003d \u0027`grep xmlrpc_uri /etc/ipa/default.conf | cut -d/ -f3`\u0027"},{"line_number":182,"context_line":"  } else {"},{"line_number":183,"context_line":"    # This assumes that the current node is already IPA enrolled, so the"},{"line_number":184,"context_line":"    # fact will work here."}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bf659307_2f22a802","line":181,"in_reply_to":"bf659307_cf1bec70","updated":"2018-04-09 17:26:01.000000000","message":"If i remember correctly, yes it can.  If you wanted it to be evaluated in the cmdline, do the \u0027$(grep xmlrpc_uri /etc/ipa/default.conf | cut -d/ -f3)\u0027 instead.","commit_id":"150bff424fd9f0fa539649733304cad334f42902"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"55ec32731cc0a9f742575b85468aab777142dbf3","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    require ::ipaclient"},{"line_number":179,"context_line":"    # If we\u0027re installing IPA here, the hostname fact won\u0027t be populated yet,"},{"line_number":180,"context_line":"    # so we\u0027ll use a command to get it."},{"line_number":181,"context_line":"    $ipa_hostname_real \u003d \u0027`grep xmlrpc_uri /etc/ipa/default.conf | cut -d/ -f3`\u0027"},{"line_number":182,"context_line":"  } else {"},{"line_number":183,"context_line":"    # This assumes that the current node is already IPA enrolled, so the"},{"line_number":184,"context_line":"    # fact will work here."}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bf659307_cf1bec70","line":181,"in_reply_to":"bf659307_fc7a2cb8","updated":"2018-04-09 16:53:18.000000000","message":"does the stuff in `` get evaluated by puppet? I thought it didn\u0027t, and then it would get evaluated as part of the exec statement in line 272. Either way, tested it out and it worked.","commit_id":"150bff424fd9f0fa539649733304cad334f42902"}]}