)]}'
{"manifests/compute/nfs.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"2f6d374c9324d44d8acc98cadc8c1f905cdbea0b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  file { $instances_dir:"},{"line_number":64,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":"  -\u003e exec { \u0027NFS mount for storage backend for nova\u0027:"},{"line_number":67,"context_line":"    path    \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/usr/bin\u0027],"},{"line_number":68,"context_line":"    command \u003d\u003e \"mount -t nfs \u0027${nfs_share}\u0027 \u0027${instances_dir}\u0027 ${options_part}\","},{"line_number":69,"context_line":"    unless  \u003d\u003e \"mount | grep \u0027 ${instances_dir} \u0027\","}],"source_content_type":"text/x-puppet","patch_set":12,"id":"9f6a8fd7_e5f8587d","line":66,"range":{"start_line":66,"start_character":2,"end_line":66,"end_character":4},"updated":"2018-05-01 15:25:38.000000000","message":"might be cleaner with a require, but not required","commit_id":"9004b2b004d5c29f7423ba931d1d36da825b0e7d"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"3a574e674fc9fbe1710905c7a29e545708ff52a2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#   (Optional) Whether to persist the mount info to fstab."},{"line_number":30,"context_line":"#   Defaults to true."},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*fstab_fstype*]"},{"line_number":33,"context_line":"#   (Optional) File system type to use in fstab for the mount."},{"line_number":34,"context_line":"#   Defaults to \u0027nfs4\u0027."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*fstab_prepend_options*]"},{"line_number":37,"context_line":"#   (Optional) Extra mount options for fstab (prepended to $options)."}],"source_content_type":"text/x-puppet","patch_set":15,"id":"9f6a8fd7_75c144e4","line":34,"range":{"start_line":32,"start_character":0,"end_line":34,"end_character":23},"updated":"2018-05-02 10:26:05.000000000","message":"as nfs4 is required I don\u0027t think this should be an option. How about using nfs as the fstype and validating that the options set the nfs version to 4?","commit_id":"99dc5a13e6adc94eff6e4f3854ef77eb179c1caa"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"e8863fec342d52113d64fbe5e5ca8d55b3a5a7fb","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#   (Optional) Whether to persist the mount info to fstab."},{"line_number":30,"context_line":"#   Defaults to true."},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*fstab_fstype*]"},{"line_number":33,"context_line":"#   (Optional) File system type to use in fstab for the mount."},{"line_number":34,"context_line":"#   Defaults to \u0027nfs4\u0027."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*fstab_prepend_options*]"},{"line_number":37,"context_line":"#   (Optional) Extra mount options for fstab (prepended to $options)."}],"source_content_type":"text/x-puppet","patch_set":15,"id":"5f7c97a3_809e6505","line":34,"range":{"start_line":32,"start_character":0,"end_line":34,"end_character":23},"in_reply_to":"9f6a8fd7_75c144e4","updated":"2018-05-04 09:52:24.000000000","message":"Done","commit_id":"99dc5a13e6adc94eff6e4f3854ef77eb179c1caa"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"3a574e674fc9fbe1710905c7a29e545708ff52a2","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  file { $instances_dir:"},{"line_number":64,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":"  -\u003e exec { \u0027NFS mount for storage backend for nova\u0027:"},{"line_number":67,"context_line":"    path    \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/usr/bin\u0027],"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"9f6a8fd7_751dc471","line":64,"updated":"2018-05-02 10:26:05.000000000","message":"might be best to ensure this runs in the config stage e.g:\nrequire \u003d\u003e Anchor[\u0027nova::config::begin\u0027],\nbefore  \u003d\u003e Anchor[\u0027nova::config::end\u0027],","commit_id":"99dc5a13e6adc94eff6e4f3854ef77eb179c1caa"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"e8863fec342d52113d64fbe5e5ca8d55b3a5a7fb","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  file { $instances_dir:"},{"line_number":64,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":"  -\u003e exec { \u0027NFS mount for storage backend for nova\u0027:"},{"line_number":67,"context_line":"    path    \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/usr/bin\u0027],"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"5f7c97a3_2056712b","line":64,"in_reply_to":"9f6a8fd7_751dc471","updated":"2018-05-04 09:52:24.000000000","message":"Done","commit_id":"99dc5a13e6adc94eff6e4f3854ef77eb179c1caa"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"3a574e674fc9fbe1710905c7a29e545708ff52a2","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":"  -\u003e exec { \u0027NFS mount for storage backend for nova\u0027:"},{"line_number":67,"context_line":"    path    \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/usr/bin\u0027],"},{"line_number":68,"context_line":"    command \u003d\u003e \"mount -t nfs \u0027${nfs_share}\u0027 \u0027${instances_dir}\u0027 ${options_part}\","},{"line_number":69,"context_line":"    unless  \u003d\u003e \"mount | grep \u0027 ${instances_dir} \u0027\","},{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"9f6a8fd7_159fa803","line":68,"range":{"start_line":68,"start_character":25,"end_line":68,"end_character":28},"updated":"2018-05-02 10:26:05.000000000","message":"that will negotiate the nfs version, ignoring the fstab_fstype param","commit_id":"99dc5a13e6adc94eff6e4f3854ef77eb179c1caa"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"e8863fec342d52113d64fbe5e5ca8d55b3a5a7fb","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":"  -\u003e exec { \u0027NFS mount for storage backend for nova\u0027:"},{"line_number":67,"context_line":"    path    \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/usr/bin\u0027],"},{"line_number":68,"context_line":"    command \u003d\u003e \"mount -t nfs \u0027${nfs_share}\u0027 \u0027${instances_dir}\u0027 ${options_part}\","},{"line_number":69,"context_line":"    unless  \u003d\u003e \"mount | grep \u0027 ${instances_dir} \u0027\","},{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"5f7c97a3_40b12d8f","line":68,"range":{"start_line":68,"start_character":25,"end_line":68,"end_character":28},"in_reply_to":"9f6a8fd7_159fa803","updated":"2018-05-04 09:52:24.000000000","message":"Done","commit_id":"99dc5a13e6adc94eff6e4f3854ef77eb179c1caa"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"3a574e674fc9fbe1710905c7a29e545708ff52a2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  -\u003e exec { \u0027NFS mount for storage backend for nova\u0027:"},{"line_number":67,"context_line":"    path    \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/usr/bin\u0027],"},{"line_number":68,"context_line":"    command \u003d\u003e \"mount -t nfs \u0027${nfs_share}\u0027 \u0027${instances_dir}\u0027 ${options_part}\","},{"line_number":69,"context_line":"    unless  \u003d\u003e \"mount | grep \u0027 ${instances_dir} \u0027\","},{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  if $edit_fstab {"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"9f6a8fd7_10cc96ba","line":69,"range":{"start_line":69,"start_character":4,"end_line":69,"end_character":50},"updated":"2018-05-02 10:26:05.000000000","message":"so we can\u0027t change the mount options once it\u0027s initially mounted?","commit_id":"99dc5a13e6adc94eff6e4f3854ef77eb179c1caa"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"e8863fec342d52113d64fbe5e5ca8d55b3a5a7fb","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  -\u003e exec { \u0027NFS mount for storage backend for nova\u0027:"},{"line_number":67,"context_line":"    path    \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/usr/bin\u0027],"},{"line_number":68,"context_line":"    command \u003d\u003e \"mount -t nfs \u0027${nfs_share}\u0027 \u0027${instances_dir}\u0027 ${options_part}\","},{"line_number":69,"context_line":"    unless  \u003d\u003e \"mount | grep \u0027 ${instances_dir} \u0027\","},{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  if $edit_fstab {"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"5f7c97a3_0080158b","line":69,"range":{"start_line":69,"start_character":4,"end_line":69,"end_character":50},"in_reply_to":"9f6a8fd7_10cc96ba","updated":"2018-05-04 09:52:24.000000000","message":"IIUC, you mean mount location here, not mount options.\nI have added param to take user defined directory location to mount.","commit_id":"99dc5a13e6adc94eff6e4f3854ef77eb179c1caa"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"4f959661c373e1e53c94764459670574619ae493","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#   (Optional) Whether to persist the mount info to fstab."},{"line_number":30,"context_line":"#   Defaults to true."},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*fstype*]"},{"line_number":33,"context_line":"#   (Optional) File system type to use for the mount."},{"line_number":34,"context_line":"#   Defaults to \u0027nfs\u0027."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*fstab_prepend_options*]"},{"line_number":37,"context_line":"#   (Optional) Extra mount options for fstab (prepended to $options)."}],"source_content_type":"text/x-puppet","patch_set":16,"id":"5f7c97a3_8013c566","line":34,"range":{"start_line":32,"start_character":1,"end_line":34,"end_character":22},"updated":"2018-05-04 10:15:19.000000000","message":"sames as fstab_fstype, this isn\u0027t an option, must be \u0027nfs\u0027.","commit_id":"68d9056eb74a362f56e35109b5c6f30ad68adbdc"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d272489c2e81e87cc959061c5bc19667b3399baf","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#   (Optional) Whether to persist the mount info to fstab."},{"line_number":30,"context_line":"#   Defaults to true."},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*fstype*]"},{"line_number":33,"context_line":"#   (Optional) File system type to use for the mount."},{"line_number":34,"context_line":"#   Defaults to \u0027nfs\u0027."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*fstab_prepend_options*]"},{"line_number":37,"context_line":"#   (Optional) Extra mount options for fstab (prepended to $options)."}],"source_content_type":"text/x-puppet","patch_set":16,"id":"5f7c97a3_9beed886","line":34,"range":{"start_line":32,"start_character":1,"end_line":34,"end_character":22},"in_reply_to":"5f7c97a3_8013c566","updated":"2018-05-04 10:48:42.000000000","message":"Done","commit_id":"68d9056eb74a362f56e35109b5c6f30ad68adbdc"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"4f959661c373e1e53c94764459670574619ae493","unresolved":false,"context_lines":[{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"class nova::compute::nfs ("},{"line_number":46,"context_line":"  $nfs_share,"},{"line_number":47,"context_line":"  $options               \u003d \u0027vers\u003d4,context\u003dsystem_u:object_r:nova_var_lib_t:s0\u0027,"},{"line_number":48,"context_line":"  $edit_fstab            \u003d true,"},{"line_number":49,"context_line":"  $fstype                \u003d \u0027nfs\u0027,"},{"line_number":50,"context_line":"  $fstab_prepend_options \u003d \u0027_netdev,bg\u0027,"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"5f7c97a3_80b74587","line":47,"range":{"start_line":47,"start_character":28,"end_line":47,"end_character":34},"updated":"2018-05-04 10:15:19.000000000","message":"we must have this, so just having it as a default isn\u0027t enough.\nalways appending this to $options should work, even if the user specifies it (or a different version) earlier in the options. Might be best to do this for nfsvers also","commit_id":"68d9056eb74a362f56e35109b5c6f30ad68adbdc"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d272489c2e81e87cc959061c5bc19667b3399baf","unresolved":false,"context_lines":[{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"class nova::compute::nfs ("},{"line_number":46,"context_line":"  $nfs_share,"},{"line_number":47,"context_line":"  $options               \u003d \u0027vers\u003d4,context\u003dsystem_u:object_r:nova_var_lib_t:s0\u0027,"},{"line_number":48,"context_line":"  $edit_fstab            \u003d true,"},{"line_number":49,"context_line":"  $fstype                \u003d \u0027nfs\u0027,"},{"line_number":50,"context_line":"  $fstab_prepend_options \u003d \u0027_netdev,bg\u0027,"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"5f7c97a3_7be97c7e","line":47,"range":{"start_line":47,"start_character":28,"end_line":47,"end_character":34},"in_reply_to":"5f7c97a3_80b74587","updated":"2018-05-04 10:48:42.000000000","message":"Done","commit_id":"68d9056eb74a362f56e35109b5c6f30ad68adbdc"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"4f959661c373e1e53c94764459670574619ae493","unresolved":false,"context_lines":[{"line_number":52,"context_line":") {"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  if $options and $options !\u003d \u0027\u0027 {"},{"line_number":55,"context_line":"    $options_part \u003d \"-o ${options}\""},{"line_number":56,"context_line":"  } else {"},{"line_number":57,"context_line":"    $options_part \u003d \u0027\u0027"},{"line_number":58,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"5f7c97a3_207d11b1","line":55,"range":{"start_line":55,"start_character":20,"end_line":55,"end_character":35},"updated":"2018-05-04 10:15:19.000000000","message":"i.e \"-o ${options},vers\u003d4,nfsver\u003d4\"","commit_id":"68d9056eb74a362f56e35109b5c6f30ad68adbdc"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d272489c2e81e87cc959061c5bc19667b3399baf","unresolved":false,"context_lines":[{"line_number":52,"context_line":") {"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  if $options and $options !\u003d \u0027\u0027 {"},{"line_number":55,"context_line":"    $options_part \u003d \"-o ${options}\""},{"line_number":56,"context_line":"  } else {"},{"line_number":57,"context_line":"    $options_part \u003d \u0027\u0027"},{"line_number":58,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"5f7c97a3_dbf4505e","line":55,"range":{"start_line":55,"start_character":20,"end_line":55,"end_character":35},"in_reply_to":"5f7c97a3_207d11b1","updated":"2018-05-04 10:48:42.000000000","message":"Done","commit_id":"68d9056eb74a362f56e35109b5c6f30ad68adbdc"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"4f959661c373e1e53c94764459670574619ae493","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  if $options and $options !\u003d \u0027\u0027 {"},{"line_number":55,"context_line":"    $options_part \u003d \"-o ${options}\""},{"line_number":56,"context_line":"  } else {"},{"line_number":57,"context_line":"    $options_part \u003d \u0027\u0027"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  if $fstab_prepend_options and $fstab_prepend_options !\u003d \u0027\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"5f7c97a3_80450573","line":57,"range":{"start_line":57,"start_character":20,"end_line":57,"end_character":22},"updated":"2018-05-04 10:15:19.000000000","message":"and \u0027vers\u003d4,nfsvers\u003d4\u0027","commit_id":"68d9056eb74a362f56e35109b5c6f30ad68adbdc"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d272489c2e81e87cc959061c5bc19667b3399baf","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  if $options and $options !\u003d \u0027\u0027 {"},{"line_number":55,"context_line":"    $options_part \u003d \"-o ${options}\""},{"line_number":56,"context_line":"  } else {"},{"line_number":57,"context_line":"    $options_part \u003d \u0027\u0027"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  if $fstab_prepend_options and $fstab_prepend_options !\u003d \u0027\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"5f7c97a3_bbef1486","line":57,"range":{"start_line":57,"start_character":20,"end_line":57,"end_character":22},"in_reply_to":"5f7c97a3_80450573","updated":"2018-05-04 10:48:42.000000000","message":"Done","commit_id":"68d9056eb74a362f56e35109b5c6f30ad68adbdc"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"4f959661c373e1e53c94764459670574619ae493","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  -\u003e exec { \u0027NFS mount for storage backend for nova\u0027:"},{"line_number":72,"context_line":"    path    \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/usr/bin\u0027],"},{"line_number":73,"context_line":"    command \u003d\u003e \"mount -t \u0027${fstype}\u0027 \u0027${nfs_share}\u0027 \u0027${instances_dir}\u0027 ${options_part}\","},{"line_number":74,"context_line":"    unless  \u003d\u003e \"mount | grep \u0027 ${instances_dir} \u0027\","},{"line_number":75,"context_line":"  }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  if $edit_fstab {"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"5f7c97a3_3b40e435","line":74,"range":{"start_line":74,"start_character":15,"end_line":74,"end_character":50},"updated":"2018-05-04 10:15:19.000000000","message":"What I mean is:\n\nif we mount it on the first puppet-apply,\nthen change the mount options for the next puppet-apply,\nthe mount options will not be updated\n\nsame goes for the nfs_share etc...\n\nIf this is just repeating what puppet-glance etc.. already does then hrmm.. ok... maybe add a comment here to warn about it, and maybe raise a bug to fix it later.","commit_id":"68d9056eb74a362f56e35109b5c6f30ad68adbdc"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d272489c2e81e87cc959061c5bc19667b3399baf","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  -\u003e exec { \u0027NFS mount for storage backend for nova\u0027:"},{"line_number":72,"context_line":"    path    \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/usr/bin\u0027],"},{"line_number":73,"context_line":"    command \u003d\u003e \"mount -t \u0027${fstype}\u0027 \u0027${nfs_share}\u0027 \u0027${instances_dir}\u0027 ${options_part}\","},{"line_number":74,"context_line":"    unless  \u003d\u003e \"mount | grep \u0027 ${instances_dir} \u0027\","},{"line_number":75,"context_line":"  }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  if $edit_fstab {"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"5f7c97a3_1be1689b","line":74,"range":{"start_line":74,"start_character":15,"end_line":74,"end_character":50},"in_reply_to":"5f7c97a3_3b40e435","updated":"2018-05-04 10:48:42.000000000","message":"You can change it by modifying it in this env file.\nhttps://review.openstack.org/#/c/564179/5/environments/storage/nova-nfs.yaml","commit_id":"68d9056eb74a362f56e35109b5c6f30ad68adbdc"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"71b615ce9b1bc0a8f950a18d9c8c124ae6f8ce9d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  $instances_dir \u003d \u0027/var/lib/nova/instances\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  if $options and $options !\u003d \u0027\u0027 {"},{"line_number":47,"context_line":"    $options_part \u003d \"-o vers\u003d4,nfsvers\u003d4,${options}\""},{"line_number":48,"context_line":"  } else {"},{"line_number":49,"context_line":"    $options_part \u003d \u0027vers\u003d4,nfsvers\u003d4\u0027"},{"line_number":50,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"5f7c97a3_513b4137","line":47,"range":{"start_line":47,"start_character":24,"end_line":47,"end_character":41},"updated":"2018-05-04 13:07:36.000000000","message":"append","commit_id":"66e520317ad08a0241cab0c42219fb8a5af66ad4"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"f7c04d12dc39e52ce95cb052920f00d47cee57aa","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    $fstab_prepend_part \u003d \u0027\u0027"},{"line_number":56,"context_line":"  }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  # TODO: (ratailor) As of now, there is no way of changing the mount"},{"line_number":59,"context_line":"  # options, once /var/lib/nova/instances is mounted. In future, Need"},{"line_number":60,"context_line":"  # to provide a way to modify NFS mount options as well as NFS share."},{"line_number":61,"context_line":"  file { $instances_dir:"},{"line_number":62,"context_line":"    ensure  \u003d\u003e directory,"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"5f7c97a3_7182fdca","line":59,"range":{"start_line":58,"start_character":32,"end_line":59,"end_character":11},"updated":"2018-05-04 13:11:08.000000000","message":"fstab entry would be updated though, so it would switch over on reboot","commit_id":"66e520317ad08a0241cab0c42219fb8a5af66ad4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d6829f1862e7a688e60310cf99513a31d86e9c97","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#   Defaults to \u0027bg\u0027, so that a potentially failed mount doesn\u0027t"},{"line_number":35,"context_line":"#   prevent the machine from booting."},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"class nova::compute::nfs ("},{"line_number":38,"context_line":"  $nfs_share,"},{"line_number":39,"context_line":"  $options               \u003d \u0027context\u003dsystem_u:object_r:nova_var_lib_t:s0\u0027,"},{"line_number":40,"context_line":"  $edit_fstab            \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"5f7c97a3_756089cf","line":37,"updated":"2018-05-07 16:34:18.000000000","message":"I\u0027m not sure we want to do this in puppet now. With the ansible support, we might want to do this as a host prep task. There\u0027s already a proposed patch for glance to do a similar thing.\n\nhttps://review.openstack.org/#/c/562930/13/puppet/services/glance-api.yaml@342","commit_id":"c564c925822f6f59408f5ef66baf34718d5a49c7"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"dd4489ec8aac2e1ddbac81f2307131edc36a2c77","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#   Defaults to \u0027bg\u0027, so that a potentially failed mount doesn\u0027t"},{"line_number":35,"context_line":"#   prevent the machine from booting."},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"class nova::compute::nfs ("},{"line_number":38,"context_line":"  $nfs_share,"},{"line_number":39,"context_line":"  $options               \u003d \u0027context\u003dsystem_u:object_r:nova_var_lib_t:s0\u0027,"},{"line_number":40,"context_line":"  $edit_fstab            \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"5f7c97a3_fcbf98f8","line":37,"in_reply_to":"5f7c97a3_3533f1ad","updated":"2018-05-08 05:24:59.000000000","message":"AFAIK yes. We only need to ensure that.","commit_id":"c564c925822f6f59408f5ef66baf34718d5a49c7"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"854a41624ab9b02f29e232c944955ac98160bf70","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#   Defaults to \u0027bg\u0027, so that a potentially failed mount doesn\u0027t"},{"line_number":35,"context_line":"#   prevent the machine from booting."},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"class nova::compute::nfs ("},{"line_number":38,"context_line":"  $nfs_share,"},{"line_number":39,"context_line":"  $options               \u003d \u0027context\u003dsystem_u:object_r:nova_var_lib_t:s0\u0027,"},{"line_number":40,"context_line":"  $edit_fstab            \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"5f7c97a3_3533f1ad","line":37,"in_reply_to":"5f7c97a3_756089cf","updated":"2018-05-07 16:43:46.000000000","message":"I know this is puppet-nova, but i\u0027m not sure if we should be including this in puppet-nova as well. It seems like something the operator should be handling externally prior to puppet config. Is the only thing that we need to do is ensure the nova packages are installed prior to mounting /var/lib/nova/instances?","commit_id":"c564c925822f6f59408f5ef66baf34718d5a49c7"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"dd4489ec8aac2e1ddbac81f2307131edc36a2c77","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#   Defaults to \u0027bg\u0027, so that a potentially failed mount doesn\u0027t"},{"line_number":35,"context_line":"#   prevent the machine from booting."},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"class nova::compute::nfs ("},{"line_number":38,"context_line":"  $nfs_share,"},{"line_number":39,"context_line":"  $options               \u003d \u0027context\u003dsystem_u:object_r:nova_var_lib_t:s0\u0027,"},{"line_number":40,"context_line":"  $edit_fstab            \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"5f7c97a3_9c7304b2","line":37,"in_reply_to":"5f7c97a3_756089cf","updated":"2018-05-08 05:24:59.000000000","message":"I think, puppet modules are not only used with tripleo, so it might be required if puppet-nova is used without tripleo.","commit_id":"c564c925822f6f59408f5ef66baf34718d5a49c7"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"6002da8edda1be6fae37e8adba0f88e50913db4b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#   Defaults to \u0027bg\u0027, so that a potentially failed mount doesn\u0027t"},{"line_number":35,"context_line":"#   prevent the machine from booting."},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"class nova::compute::nfs ("},{"line_number":38,"context_line":"  $nfs_share,"},{"line_number":39,"context_line":"  $options               \u003d \u0027context\u003dsystem_u:object_r:nova_var_lib_t:s0\u0027,"},{"line_number":40,"context_line":"  $edit_fstab            \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"5f7c97a3_ee403538","line":37,"in_reply_to":"5f7c97a3_9083e5cc","updated":"2018-05-08 12:04:18.000000000","message":"I think, we have already done it here.\nhttps://review.openstack.org/#/c/564178/2/manifests/profile/base/nova/compute.pp","commit_id":"c564c925822f6f59408f5ef66baf34718d5a49c7"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"19b0358317839f636787c6638ab380c6d598d969","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#   Defaults to \u0027bg\u0027, so that a potentially failed mount doesn\u0027t"},{"line_number":35,"context_line":"#   prevent the machine from booting."},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"class nova::compute::nfs ("},{"line_number":38,"context_line":"  $nfs_share,"},{"line_number":39,"context_line":"  $options               \u003d \u0027context\u003dsystem_u:object_r:nova_var_lib_t:s0\u0027,"},{"line_number":40,"context_line":"  $edit_fstab            \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"5f7c97a3_dab17391","line":37,"in_reply_to":"5f7c97a3_9c7304b2","updated":"2018-05-08 15:19:38.000000000","message":"So I don\u0027t think this functionality should live in puppet-nova w/o some actual reason to. We aren\u0027t managing any nfs services so I\u0027m concerned about what this class is doing. There are no nova specific configurations or package management so IMHO it doesn\u0027t make sense to exist in puppet-nova.  If we were doing some nova_config in with $instances_dir being configurable, it might make sense to have this somewhere in puppet-nova. However the current state of this patch doesn\u0027t seem to make sense for puppet-nova. puppet-nova should manage nova specific things and a mount doesn\u0027t seem correct if we apply that restriction to functionality.  At quick glance I didn\u0027t see use managing mounts in puppet-glance or puppet-cinder either.","commit_id":"c564c925822f6f59408f5ef66baf34718d5a49c7"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"6a221f697b7e047046ffb10547d1ee3b0e0df811","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#   Defaults to \u0027bg\u0027, so that a potentially failed mount doesn\u0027t"},{"line_number":35,"context_line":"#   prevent the machine from booting."},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"class nova::compute::nfs ("},{"line_number":38,"context_line":"  $nfs_share,"},{"line_number":39,"context_line":"  $options               \u003d \u0027context\u003dsystem_u:object_r:nova_var_lib_t:s0\u0027,"},{"line_number":40,"context_line":"  $edit_fstab            \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"5f7c97a3_857cfceb","line":37,"in_reply_to":"5f7c97a3_dab17391","updated":"2018-05-08 15:48:15.000000000","message":"ack, had assumed glance/cinder were doing the same...\nI\u0027m fine with doing this in t-h-t/puppet-tripleo","commit_id":"c564c925822f6f59408f5ef66baf34718d5a49c7"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"5d91170c391bd30cbd044a8d775fea10072de688","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#   Defaults to \u0027bg\u0027, so that a potentially failed mount doesn\u0027t"},{"line_number":35,"context_line":"#   prevent the machine from booting."},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"class nova::compute::nfs ("},{"line_number":38,"context_line":"  $nfs_share,"},{"line_number":39,"context_line":"  $options               \u003d \u0027context\u003dsystem_u:object_r:nova_var_lib_t:s0\u0027,"},{"line_number":40,"context_line":"  $edit_fstab            \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"5f7c97a3_9083e5cc","line":37,"in_reply_to":"5f7c97a3_fcbf98f8","updated":"2018-05-08 09:40:18.000000000","message":"nfs4 is required, so maybe good to enforce that here...\nalso for the sake of consistency with glance \u0026 cinder","commit_id":"c564c925822f6f59408f5ef66baf34718d5a49c7"}],"spec/classes/nova_compute_nfs_spec.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"2f6d374c9324d44d8acc98cadc8c1f905cdbea0b","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    context \u0027edit fstab\u0027 do"},{"line_number":28,"context_line":"      before :each do"},{"line_number":29,"context_line":"\tparams.merge!("},{"line_number":30,"context_line":"\t  :edit_fstab \u003d\u003e true"},{"line_number":31,"context_line":"\t)"},{"line_number":32,"context_line":"      end"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"      it { is_expected.to contain_file_line(\u0027NFS for nova in fstab\u0027).with("}],"source_content_type":"text/x-ruby","patch_set":12,"id":"9f6a8fd7_a5f26099","line":31,"range":{"start_line":29,"start_character":0,"end_line":31,"end_character":2},"updated":"2018-05-01 15:25:38.000000000","message":"please remove tabs","commit_id":"9004b2b004d5c29f7423ba931d1d36da825b0e7d"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"2f6d374c9324d44d8acc98cadc8c1f905cdbea0b","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"      it { is_expected.to contain_file_line(\u0027NFS for nova in fstab\u0027).with("},{"line_number":35,"context_line":"        :ensure  \u003d\u003e \"present\","},{"line_number":36,"context_line":"\t:line    \u003d\u003e \"#{params[:nfs_share]} /var/lib/nova/instances #{params[:fstab_fstype]} #{params[:fstab_prepend_options]},#{params[:options]} 0 0\","},{"line_number":37,"context_line":"        :match   \u003d\u003e \"/var/lib/nova/instances\","},{"line_number":38,"context_line":"        :path    \u003d\u003e \"/etc/fstab\""},{"line_number":39,"context_line":"      ) }"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"9f6a8fd7_652a08e8","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":1},"updated":"2018-05-01 15:25:38.000000000","message":"another tab","commit_id":"9004b2b004d5c29f7423ba931d1d36da825b0e7d"}]}