)]}'
{"manifests/compute.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"99acea48218ac1ef66363e8212b88ad0ad0bb996","unresolved":false,"context_lines":[{"line_number":169,"context_line":"  $manage_service                              \u003d true,"},{"line_number":170,"context_line":"  $ensure_package                              \u003d \u0027present\u0027,"},{"line_number":171,"context_line":"  $vnc_enabled                                 \u003d true,"},{"line_number":172,"context_line":"  $spice_enabled                               \u003d false,"},{"line_number":173,"context_line":"  $vncserver_proxyclient_address               \u003d \u0027127.0.0.1\u0027,"},{"line_number":174,"context_line":"  $vncproxy_host                               \u003d false,"},{"line_number":175,"context_line":"  $vncproxy_protocol                           \u003d \u0027http\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f6a8fd7_866e7dc7","line":172,"range":{"start_line":172,"start_character":2,"end_line":172,"end_character":55},"updated":"2018-04-27 12:08:55.000000000","message":"add release note for this option","commit_id":"a123b2b3e97cfa113594bfb49ab3fb5799824fb7"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"835a89725834e4b6491288ecec2698eaf3d38df6","unresolved":false,"context_lines":[{"line_number":169,"context_line":"  $manage_service                              \u003d true,"},{"line_number":170,"context_line":"  $ensure_package                              \u003d \u0027present\u0027,"},{"line_number":171,"context_line":"  $vnc_enabled                                 \u003d true,"},{"line_number":172,"context_line":"  $spice_enabled                               \u003d false,"},{"line_number":173,"context_line":"  $vncserver_proxyclient_address               \u003d \u0027127.0.0.1\u0027,"},{"line_number":174,"context_line":"  $vncproxy_host                               \u003d false,"},{"line_number":175,"context_line":"  $vncproxy_protocol                           \u003d \u0027http\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f6a8fd7_8dc45194","line":172,"range":{"start_line":172,"start_character":2,"end_line":172,"end_character":55},"in_reply_to":"9f6a8fd7_866e7dc7","updated":"2018-04-27 19:03:53.000000000","message":"I very much would like to do so, though I have never written a release note with Reno. Can you help me to do it? Also, the code should check that one cannot set both spice_enabled and vnc_enabled at the same time (neither Nova nor the Debian package support that).","commit_id":"a123b2b3e97cfa113594bfb49ab3fb5799824fb7"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"99acea48218ac1ef66363e8212b88ad0ad0bb996","unresolved":false,"context_lines":[{"line_number":270,"context_line":"  }"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"  nova_config {"},{"line_number":273,"context_line":"    \u0027vnc/enabled\u0027: value \u003d\u003e $vnc_enabled;"},{"line_number":274,"context_line":"    \u0027spice/enabled\u0027: value \u003d\u003e $spice_enabled;"},{"line_number":275,"context_line":"  }"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f6a8fd7_a67381b1","line":273,"range":{"start_line":273,"start_character":18,"end_line":273,"end_character":24},"updated":"2018-04-27 12:08:55.000000000","message":"align these \"value\"","commit_id":"a123b2b3e97cfa113594bfb49ab3fb5799824fb7"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"835a89725834e4b6491288ecec2698eaf3d38df6","unresolved":false,"context_lines":[{"line_number":270,"context_line":"  }"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"  nova_config {"},{"line_number":273,"context_line":"    \u0027vnc/enabled\u0027: value \u003d\u003e $vnc_enabled;"},{"line_number":274,"context_line":"    \u0027spice/enabled\u0027: value \u003d\u003e $spice_enabled;"},{"line_number":275,"context_line":"  }"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f6a8fd7_ed44ed1d","line":273,"range":{"start_line":273,"start_character":18,"end_line":273,"end_character":24},"in_reply_to":"9f6a8fd7_a67381b1","updated":"2018-04-27 19:03:53.000000000","message":"Done","commit_id":"a123b2b3e97cfa113594bfb49ab3fb5799824fb7"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f6103fe80911b1e5914507b4da2e56a60f46d3e6","unresolved":false,"context_lines":[{"line_number":169,"context_line":"  $manage_service                              \u003d true,"},{"line_number":170,"context_line":"  $ensure_package                              \u003d \u0027present\u0027,"},{"line_number":171,"context_line":"  $vnc_enabled                                 \u003d true,"},{"line_number":172,"context_line":"  $spice_enabled                               \u003d false,"},{"line_number":173,"context_line":"  $vncserver_proxyclient_address               \u003d \u0027127.0.0.1\u0027,"},{"line_number":174,"context_line":"  $vncproxy_host                               \u003d false,"},{"line_number":175,"context_line":"  $vncproxy_protocol                           \u003d \u0027http\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9f6a8fd7_8b5bd452","line":172,"range":{"start_line":172,"start_character":1,"end_line":172,"end_character":55},"updated":"2018-04-28 08:43:48.000000000","message":"Reno is awesome, install reno with pip on your compute, from inside the modules simply run `reno new your-slug-here`. Replace your-slug-nere with something describing your commit, example would be vnc-support-debian. You will then get a template file in the releasenotes folder which you should edit (file path will be in output).\n\nRemove any sections that does not apply and then amend it to your commit. See [1] for docs and [2] for an example.\n\n[1] https://docs.openstack.org/reno/latest/user/usage.html\n[2] https://review.openstack.org/#/c/564770/8/releasenotes/notes/horizon-add-dashboard-support-0d14ebc190c01070.yaml","commit_id":"2084bc106a37c4ef836cb9a206255e00e6e2a9f8"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"4408c1d86bf06175db1892b757f98dd0a2442cde","unresolved":false,"context_lines":[{"line_number":169,"context_line":"  $manage_service                              \u003d true,"},{"line_number":170,"context_line":"  $ensure_package                              \u003d \u0027present\u0027,"},{"line_number":171,"context_line":"  $vnc_enabled                                 \u003d true,"},{"line_number":172,"context_line":"  $spice_enabled                               \u003d false,"},{"line_number":173,"context_line":"  $vncserver_proxyclient_address               \u003d \u0027127.0.0.1\u0027,"},{"line_number":174,"context_line":"  $vncproxy_host                               \u003d false,"},{"line_number":175,"context_line":"  $vncproxy_protocol                           \u003d \u0027http\u0027,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"9f6a8fd7_e50e3c31","line":172,"range":{"start_line":172,"start_character":2,"end_line":172,"end_character":55},"updated":"2018-04-28 16:19:51.000000000","message":"Then just the simple release note with reno :)","commit_id":"2b5f97123a38f322ddd1a2df7051a7eb2ae84cf5"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9e9b5feb928fc6cb87961901c0abc27099626932","unresolved":false,"context_lines":[{"line_number":271,"context_line":""},{"line_number":272,"context_line":"  nova_config {"},{"line_number":273,"context_line":"    \u0027vnc/enabled\u0027:   value \u003d\u003e $vnc_enabled;"},{"line_number":274,"context_line":"    \u0027spice/enabled\u0027: value \u003d\u003e $spice_enabled;"},{"line_number":275,"context_line":"  }"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"  if $neutron_enabled !\u003d true and $install_bridge_utils {"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"5f7c97a3_320a5026","line":274,"updated":"2018-05-03 21:47:46.000000000","message":"so this will dupe if a user has nova::compute::spice defined\n\nhttps://github.com/openstack/puppet-nova/blob/master/manifests/compute/spice.pp#L61","commit_id":"1783f06fe25c43c7946e2ba3d4cf5bed9ecf300f"}],"manifests/spicehtml5proxy.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"99acea48218ac1ef66363e8212b88ad0ad0bb996","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  include ::nova::deps"},{"line_number":40,"context_line":"  include ::nova::params"},{"line_number":41,"context_line":"  include ::nova::compute"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  # We don\u0027t need to set spice/enabled or vnc/enabled, that\u0027s"},{"line_number":44,"context_line":"  # already set in ::nova::compute."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f6a8fd7_0634addd","line":41,"range":{"start_line":41,"start_character":2,"end_line":41,"end_character":25},"updated":"2018-04-27 12:08:55.000000000","message":"should not need this include","commit_id":"a123b2b3e97cfa113594bfb49ab3fb5799824fb7"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"835a89725834e4b6491288ecec2698eaf3d38df6","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  include ::nova::deps"},{"line_number":40,"context_line":"  include ::nova::params"},{"line_number":41,"context_line":"  include ::nova::compute"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  # We don\u0027t need to set spice/enabled or vnc/enabled, that\u0027s"},{"line_number":44,"context_line":"  # already set in ::nova::compute."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f6a8fd7_ad46f520","line":41,"range":{"start_line":41,"start_character":2,"end_line":41,"end_character":25},"in_reply_to":"9f6a8fd7_0634addd","updated":"2018-04-27 19:03:53.000000000","message":"Done","commit_id":"a123b2b3e97cfa113594bfb49ab3fb5799824fb7"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"99acea48218ac1ef66363e8212b88ad0ad0bb996","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  if $::os_package_type \u003d\u003d \u0027debian\u0027 {"},{"line_number":58,"context_line":"    if $enabled {"},{"line_number":59,"context_line":"      service { \u0027nova-spicehtml5proxy\u0027:"},{"line_number":60,"context_line":"        ensure \u003d\u003e \u0027running\u0027,"},{"line_number":61,"context_line":"        name \u003d\u003e $::apache::params::spice_service_name,"},{"line_number":62,"context_line":"        enable \u003d\u003e $enabled,"},{"line_number":63,"context_line":"        hasstatus \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f6a8fd7_c64b155d","line":60,"range":{"start_line":60,"start_character":15,"end_line":60,"end_character":17},"updated":"2018-04-27 12:08:55.000000000","message":"align all these assignments","commit_id":"a123b2b3e97cfa113594bfb49ab3fb5799824fb7"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"835a89725834e4b6491288ecec2698eaf3d38df6","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  if $::os_package_type \u003d\u003d \u0027debian\u0027 {"},{"line_number":58,"context_line":"    if $enabled {"},{"line_number":59,"context_line":"      service { \u0027nova-spicehtml5proxy\u0027:"},{"line_number":60,"context_line":"        ensure \u003d\u003e \u0027running\u0027,"},{"line_number":61,"context_line":"        name \u003d\u003e $::apache::params::spice_service_name,"},{"line_number":62,"context_line":"        enable \u003d\u003e $enabled,"},{"line_number":63,"context_line":"        hasstatus \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f6a8fd7_6d50ddd5","line":60,"range":{"start_line":60,"start_character":15,"end_line":60,"end_character":17},"in_reply_to":"9f6a8fd7_c64b155d","updated":"2018-04-27 19:03:53.000000000","message":"Done","commit_id":"a123b2b3e97cfa113594bfb49ab3fb5799824fb7"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"99acea48218ac1ef66363e8212b88ad0ad0bb996","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    if $enabled {"},{"line_number":59,"context_line":"      service { \u0027nova-spicehtml5proxy\u0027:"},{"line_number":60,"context_line":"        ensure \u003d\u003e \u0027running\u0027,"},{"line_number":61,"context_line":"        name \u003d\u003e $::apache::params::spice_service_name,"},{"line_number":62,"context_line":"        enable \u003d\u003e $enabled,"},{"line_number":63,"context_line":"        hasstatus \u003d\u003e true,"},{"line_number":64,"context_line":"        require \u003d\u003e ["}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f6a8fd7_06902d95","line":61,"range":{"start_line":61,"start_character":17,"end_line":61,"end_character":25},"updated":"2018-04-27 12:08:55.000000000","message":"this is wrong, should be nova","commit_id":"a123b2b3e97cfa113594bfb49ab3fb5799824fb7"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"835a89725834e4b6491288ecec2698eaf3d38df6","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    if $enabled {"},{"line_number":59,"context_line":"      service { \u0027nova-spicehtml5proxy\u0027:"},{"line_number":60,"context_line":"        ensure \u003d\u003e \u0027running\u0027,"},{"line_number":61,"context_line":"        name \u003d\u003e $::apache::params::spice_service_name,"},{"line_number":62,"context_line":"        enable \u003d\u003e $enabled,"},{"line_number":63,"context_line":"        hasstatus \u003d\u003e true,"},{"line_number":64,"context_line":"        require \u003d\u003e ["}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f6a8fd7_cd5809fc","line":61,"range":{"start_line":61,"start_character":17,"end_line":61,"end_character":25},"in_reply_to":"9f6a8fd7_06902d95","updated":"2018-04-27 19:03:53.000000000","message":"Indeed, thanks for spotting this!","commit_id":"a123b2b3e97cfa113594bfb49ab3fb5799824fb7"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"99acea48218ac1ef66363e8212b88ad0ad0bb996","unresolved":false,"context_lines":[{"line_number":69,"context_line":"      }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"      file_line { \u0027/etc/default/nova-consoleproxy:NOVA_CONSOLE_PROXY_TYPE\u0027:"},{"line_number":72,"context_line":"        path \u003d\u003e \u0027/etc/default/nova-consoleproxy\u0027,"},{"line_number":73,"context_line":"        match \u003d\u003e \u0027^NOVA_CONSOLE_PROXY_TYPE\u003d(.*)$\u0027,"},{"line_number":74,"context_line":"        line \u003d\u003e \u0027NOVA_CONSOLE_PROXY_TYPE\u003dspicehtml5\u0027,"},{"line_number":75,"context_line":"        tag \u003d\u003e \u0027nova-consoleproxy-type-line\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f6a8fd7_e650990d","line":72,"range":{"start_line":72,"start_character":13,"end_line":72,"end_character":15},"updated":"2018-04-27 12:08:55.000000000","message":"align all these assignments","commit_id":"a123b2b3e97cfa113594bfb49ab3fb5799824fb7"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"99acea48218ac1ef66363e8212b88ad0ad0bb996","unresolved":false,"context_lines":[{"line_number":76,"context_line":"      }"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"      package { \u0027nova-spicehtml5proxy\u0027:"},{"line_number":79,"context_line":"        ensure \u003d\u003e $ensure_package,"},{"line_number":80,"context_line":"        name \u003d\u003e $::nova::params::spicehtml5proxy_service_name,"},{"line_number":81,"context_line":"        tag \u003d\u003e [\u0027openstack\u0027, \u0027nova-vncproxy-package\u0027],"},{"line_number":82,"context_line":"        before \u003d\u003e file_line[\u0027/etc/default/nova-consoleproxy:NOVA_CONSOLE_PROXY_TYPE\u0027],"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f6a8fd7_86551dfd","line":79,"range":{"start_line":79,"start_character":15,"end_line":79,"end_character":18},"updated":"2018-04-27 12:08:55.000000000","message":"align all these assignments","commit_id":"a123b2b3e97cfa113594bfb49ab3fb5799824fb7"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f6103fe80911b1e5914507b4da2e56a60f46d3e6","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  # the standard nova::generic_service"},{"line_number":56,"context_line":"  if $::os_package_type \u003d\u003d \u0027debian\u0027 {"},{"line_number":57,"context_line":"    if $enabled {"},{"line_number":58,"context_line":"      service { \u0027nova-spicehtml5proxy\u0027:"},{"line_number":59,"context_line":"        ensure    \u003d\u003e \u0027running\u0027,"},{"line_number":60,"context_line":"        name      \u003d\u003e $::nova::params::spice_service_name,"},{"line_number":61,"context_line":"        enable    \u003d\u003e $enabled,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9f6a8fd7_0b99041e","line":58,"range":{"start_line":58,"start_character":6,"end_line":58,"end_character":39},"updated":"2018-04-28 08:43:48.000000000","message":"should try to remove this, see last comment in this file.","commit_id":"2084bc106a37c4ef836cb9a206255e00e6e2a9f8"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"e7e9218d0c3ae4e1ad888b9625bedb46902aef8d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  # the standard nova::generic_service"},{"line_number":56,"context_line":"  if $::os_package_type \u003d\u003d \u0027debian\u0027 {"},{"line_number":57,"context_line":"    if $enabled {"},{"line_number":58,"context_line":"      service { \u0027nova-spicehtml5proxy\u0027:"},{"line_number":59,"context_line":"        ensure    \u003d\u003e \u0027running\u0027,"},{"line_number":60,"context_line":"        name      \u003d\u003e $::nova::params::spice_service_name,"},{"line_number":61,"context_line":"        enable    \u003d\u003e $enabled,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9f6a8fd7_c1ed2d8c","line":58,"range":{"start_line":58,"start_character":6,"end_line":58,"end_character":39},"in_reply_to":"9f6a8fd7_0b99041e","updated":"2018-04-28 15:49:54.000000000","message":"Done","commit_id":"2084bc106a37c4ef836cb9a206255e00e6e2a9f8"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f6103fe80911b1e5914507b4da2e56a60f46d3e6","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    if $enabled {"},{"line_number":58,"context_line":"      service { \u0027nova-spicehtml5proxy\u0027:"},{"line_number":59,"context_line":"        ensure    \u003d\u003e \u0027running\u0027,"},{"line_number":60,"context_line":"        name      \u003d\u003e $::nova::params::spice_service_name,"},{"line_number":61,"context_line":"        enable    \u003d\u003e $enabled,"},{"line_number":62,"context_line":"        hasstatus \u003d\u003e true,"},{"line_number":63,"context_line":"        require   \u003d\u003e ["}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9f6a8fd7_6b268019","line":60,"range":{"start_line":60,"start_character":21,"end_line":60,"end_character":56},"updated":"2018-04-28 08:43:48.000000000","message":"should be $::nova::params::spicehtml5proxy_service_name","commit_id":"2084bc106a37c4ef836cb9a206255e00e6e2a9f8"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"e7e9218d0c3ae4e1ad888b9625bedb46902aef8d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    if $enabled {"},{"line_number":58,"context_line":"      service { \u0027nova-spicehtml5proxy\u0027:"},{"line_number":59,"context_line":"        ensure    \u003d\u003e \u0027running\u0027,"},{"line_number":60,"context_line":"        name      \u003d\u003e $::nova::params::spice_service_name,"},{"line_number":61,"context_line":"        enable    \u003d\u003e $enabled,"},{"line_number":62,"context_line":"        hasstatus \u003d\u003e true,"},{"line_number":63,"context_line":"        require   \u003d\u003e ["}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9f6a8fd7_21e3c9a6","line":60,"range":{"start_line":60,"start_character":21,"end_line":60,"end_character":56},"in_reply_to":"9f6a8fd7_6b268019","updated":"2018-04-28 15:49:54.000000000","message":"Done","commit_id":"2084bc106a37c4ef836cb9a206255e00e6e2a9f8"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f6103fe80911b1e5914507b4da2e56a60f46d3e6","unresolved":false,"context_lines":[{"line_number":82,"context_line":"      }"},{"line_number":83,"context_line":"    }"},{"line_number":84,"context_line":"  } else {"},{"line_number":85,"context_line":"    nova::generic_service { \u0027spicehtml5proxy\u0027:"},{"line_number":86,"context_line":"      enabled        \u003d\u003e $enabled,"},{"line_number":87,"context_line":"      manage_service \u003d\u003e $manage_service,"},{"line_number":88,"context_line":"      package_name   \u003d\u003e $::nova::params::spicehtml5proxy_package_name,"},{"line_number":89,"context_line":"      service_name   \u003d\u003e $::nova::params::spicehtml5proxy_service_name,"},{"line_number":90,"context_line":"      ensure_package \u003d\u003e $ensure_package,"},{"line_number":91,"context_line":"    }"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9f6a8fd7_eb9370ff","line":91,"range":{"start_line":85,"start_character":4,"end_line":91,"end_character":5},"updated":"2018-04-28 08:43:48.000000000","message":"Try to keep this for Debian and instead only create the File_line resources in the if statement, you can then add the anchor on the File_line `require \u003d\u003e Anchor[\u0027nova::config::begin\u0027]` and the resource will be created before the service is started.\n\nThe anchors and dependencies in deps.pp will manage that for you.","commit_id":"2084bc106a37c4ef836cb9a206255e00e6e2a9f8"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"e7e9218d0c3ae4e1ad888b9625bedb46902aef8d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"      }"},{"line_number":83,"context_line":"    }"},{"line_number":84,"context_line":"  } else {"},{"line_number":85,"context_line":"    nova::generic_service { \u0027spicehtml5proxy\u0027:"},{"line_number":86,"context_line":"      enabled        \u003d\u003e $enabled,"},{"line_number":87,"context_line":"      manage_service \u003d\u003e $manage_service,"},{"line_number":88,"context_line":"      package_name   \u003d\u003e $::nova::params::spicehtml5proxy_package_name,"},{"line_number":89,"context_line":"      service_name   \u003d\u003e $::nova::params::spicehtml5proxy_service_name,"},{"line_number":90,"context_line":"      ensure_package \u003d\u003e $ensure_package,"},{"line_number":91,"context_line":"    }"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9f6a8fd7_61022141","line":91,"range":{"start_line":85,"start_character":4,"end_line":91,"end_character":5},"in_reply_to":"9f6a8fd7_eb9370ff","updated":"2018-04-28 15:49:54.000000000","message":"Done","commit_id":"2084bc106a37c4ef836cb9a206255e00e6e2a9f8"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"4408c1d86bf06175db1892b757f98dd0a2442cde","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  # We don\u0027t need to set spice/enabled or vnc/enabled, that\u0027s"},{"line_number":43,"context_line":"  # already set in ::nova::compute."},{"line_number":44,"context_line":"  nova_config {"},{"line_number":45,"context_line":"    \u0027spice/agent_enabled\u0027:   value \u003d\u003e $enabled;"},{"line_number":46,"context_line":"    \u0027spice/html5proxy_host\u0027: value \u003d\u003e $host;"},{"line_number":47,"context_line":"    \u0027spice/html5proxy_port\u0027: value \u003d\u003e $port;"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"9f6a8fd7_250d1437","line":44,"range":{"start_line":44,"start_character":2,"end_line":44,"end_character":15},"updated":"2018-04-28 16:19:51.000000000","message":"add back spice/enabled here, it\u0027s a breaking change which does not following deprecation policy","commit_id":"2b5f97123a38f322ddd1a2df7051a7eb2ae84cf5"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"b067a651fd9d4ac7e60ccb675fc7e3b9473afe7c","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  # We don\u0027t need to set spice/enabled or vnc/enabled, that\u0027s"},{"line_number":43,"context_line":"  # already set in ::nova::compute."},{"line_number":44,"context_line":"  nova_config {"},{"line_number":45,"context_line":"    \u0027spice/agent_enabled\u0027:   value \u003d\u003e $enabled;"},{"line_number":46,"context_line":"    \u0027spice/html5proxy_host\u0027: value \u003d\u003e $host;"},{"line_number":47,"context_line":"    \u0027spice/html5proxy_port\u0027: value \u003d\u003e $port;"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"9f6a8fd7_11392940","line":44,"range":{"start_line":44,"start_character":2,"end_line":44,"end_character":15},"in_reply_to":"9f6a8fd7_250d1437","updated":"2018-04-30 09:33:01.000000000","message":"Done","commit_id":"2b5f97123a38f322ddd1a2df7051a7eb2ae84cf5"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"4408c1d86bf06175db1892b757f98dd0a2442cde","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  # Other OS don\u0027t need this scheduling and can use"},{"line_number":55,"context_line":"  # the standard nova::generic_service"},{"line_number":56,"context_line":"  if $::os_package_type \u003d\u003d \u0027debian\u0027 {"},{"line_number":57,"context_line":"    if $enabled {"},{"line_number":58,"context_line":"      file_line { \u0027/etc/default/nova-consoleproxy:NOVA_CONSOLE_PROXY_TYPE\u0027:"},{"line_number":59,"context_line":"        path    \u003d\u003e \u0027/etc/default/nova-consoleproxy\u0027,"},{"line_number":60,"context_line":"        match   \u003d\u003e \u0027^NOVA_CONSOLE_PROXY_TYPE\u003d(.*)$\u0027,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"9f6a8fd7_c511b855","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":17},"updated":"2018-04-28 16:19:51.000000000","message":"You might want to handle if enabled is set to false to comment out or remove that line again otherwise the functionality cannot be \"turned off\".","commit_id":"2b5f97123a38f322ddd1a2df7051a7eb2ae84cf5"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"b067a651fd9d4ac7e60ccb675fc7e3b9473afe7c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  # Other OS don\u0027t need this scheduling and can use"},{"line_number":55,"context_line":"  # the standard nova::generic_service"},{"line_number":56,"context_line":"  if $::os_package_type \u003d\u003d \u0027debian\u0027 {"},{"line_number":57,"context_line":"    if $enabled {"},{"line_number":58,"context_line":"      file_line { \u0027/etc/default/nova-consoleproxy:NOVA_CONSOLE_PROXY_TYPE\u0027:"},{"line_number":59,"context_line":"        path    \u003d\u003e \u0027/etc/default/nova-consoleproxy\u0027,"},{"line_number":60,"context_line":"        match   \u003d\u003e \u0027^NOVA_CONSOLE_PROXY_TYPE\u003d(.*)$\u0027,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"9f6a8fd7_244c2d75","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":17},"in_reply_to":"9f6a8fd7_c511b855","updated":"2018-04-30 09:33:01.000000000","message":"Done","commit_id":"2b5f97123a38f322ddd1a2df7051a7eb2ae84cf5"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"50f82916d600abd412db154906d51988e2d9213b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#   Defaults to \u0027present\u0027"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"class nova::spicehtml5proxy("},{"line_number":32,"context_line":"  $enabled        \u003d $::nova::compute::spice_enabled,"},{"line_number":33,"context_line":"  $manage_service \u003d true,"},{"line_number":34,"context_line":"  $host           \u003d \u00270.0.0.0\u0027,"},{"line_number":35,"context_line":"  $port           \u003d \u00276082\u0027,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"9f6a8fd7_049d6958","line":32,"range":{"start_line":32,"start_character":20,"end_line":32,"end_character":51},"updated":"2018-04-30 10:02:22.000000000","message":"Set this default value back to true so we dont change the current usage.","commit_id":"85dd0fc9d919bba315d3d728cc358915f78f1b4b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"50f82916d600abd412db154906d51988e2d9213b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      \u0027vnc/enabled\u0027:           value \u003d\u003e true;"},{"line_number":50,"context_line":"      \u0027spice/enabled\u0027:         value \u003d\u003e false;"},{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":"  }"},{"line_number":53,"context_line":"  nova_config {"},{"line_number":54,"context_line":"    \u0027spice/agent_enabled\u0027:   value \u003d\u003e $enabled;"},{"line_number":55,"context_line":"    \u0027spice/html5proxy_host\u0027: value \u003d\u003e $host;"},{"line_number":56,"context_line":"    \u0027spice/html5proxy_port\u0027: value \u003d\u003e $port;"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"9f6a8fd7_24b74ddb","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":15},"updated":"2018-04-30 10:02:22.000000000","message":"small nit, but maybe a new line between these two lines","commit_id":"85dd0fc9d919bba315d3d728cc358915f78f1b4b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"50f82916d600abd412db154906d51988e2d9213b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    \u0027spice/html5proxy_port\u0027: value \u003d\u003e $port;"},{"line_number":57,"context_line":"  }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  # The Debian package needs some scheduling:"},{"line_number":60,"context_line":"  # 1/ Install the packagin"},{"line_number":61,"context_line":"  # 2/ Fix /etc/default/nova-consoleproxy"},{"line_number":62,"context_line":"  # 3/ Start the service"},{"line_number":63,"context_line":"  # Other OS don\u0027t need this scheduling and can use"},{"line_number":64,"context_line":"  # the standard nova::generic_service"},{"line_number":65,"context_line":"  if $::os_package_type \u003d\u003d \u0027debian\u0027 {"},{"line_number":66,"context_line":"    if $enabled {"},{"line_number":67,"context_line":"      file_line { \u0027/etc/default/nova-consoleproxy:NOVA_CONSOLE_PROXY_TYPE\u0027:"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"9f6a8fd7_e4b075e0","line":64,"range":{"start_line":59,"start_character":2,"end_line":64,"end_character":38},"updated":"2018-04-30 10:02:22.000000000","message":"you can probably remove these to make it more clean","commit_id":"85dd0fc9d919bba315d3d728cc358915f78f1b4b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"20301f5f57b4da6fc68280eac1e67f2550ce3b4b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  include ::nova::params"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  nova_config {"},{"line_number":43,"context_line":"    \u0027spice/enabled\u0027:         value \u003d\u003e $enabled;"},{"line_number":44,"context_line":"    \u0027spice/agent_enabled\u0027:   value \u003d\u003e $enabled;"},{"line_number":45,"context_line":"    \u0027spice/html5proxy_host\u0027: value \u003d\u003e $host;"},{"line_number":46,"context_line":"    \u0027spice/html5proxy_port\u0027: value \u003d\u003e $port;"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5f7c97a3_d7d677f2","side":"PARENT","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":47},"updated":"2018-05-03 12:12:00.000000000","message":"Can we get a confirmation that this config option is NOT required by the spicehtml5proxy service, otherwise we need to figure out how we can make sure it stays here without a duplicate issue.\n\nIf we can confirm this I\u0027m ok with +1 this patch","commit_id":"2e84826e909d3a0ffce3b061d16602fa6cc94ac3"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e26efceb00864d8ce68eb77325a227be273cbeb8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  include ::nova::params"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  nova_config {"},{"line_number":43,"context_line":"    \u0027spice/enabled\u0027:         value \u003d\u003e $enabled;"},{"line_number":44,"context_line":"    \u0027spice/agent_enabled\u0027:   value \u003d\u003e $enabled;"},{"line_number":45,"context_line":"    \u0027spice/html5proxy_host\u0027: value \u003d\u003e $host;"},{"line_number":46,"context_line":"    \u0027spice/html5proxy_port\u0027: value \u003d\u003e $port;"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5f7c97a3_72d528b9","side":"PARENT","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":47},"in_reply_to":"5f7c97a3_285c264a","updated":"2018-05-03 21:33:19.000000000","message":"The comments in the config file seem to indicate that this probably should still be set.\n\nhttps://github.com/openstack/nova/blob/ae0d20ddf20b6b584e7dcf8aa5e6bac5fa0956dd/nova/conf/spice.py#L26\n\nLet\u0027s add it back in for good measure since it is an actual config item in nova","commit_id":"2e84826e909d3a0ffce3b061d16602fa6cc94ac3"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b34e0a2c2d34ba287e6cccabfa4a18d6489409f9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  include ::nova::params"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  nova_config {"},{"line_number":43,"context_line":"    \u0027spice/enabled\u0027:         value \u003d\u003e $enabled;"},{"line_number":44,"context_line":"    \u0027spice/agent_enabled\u0027:   value \u003d\u003e $enabled;"},{"line_number":45,"context_line":"    \u0027spice/html5proxy_host\u0027: value \u003d\u003e $host;"},{"line_number":46,"context_line":"    \u0027spice/html5proxy_port\u0027: value \u003d\u003e $port;"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5f7c97a3_92624416","side":"PARENT","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":47},"in_reply_to":"5f7c97a3_72d528b9","updated":"2018-05-03 21:41:26.000000000","message":"per irc, it\u0027s actually configured for the compute stuff in nova::compute::spice. So this should be ok.\n\nhttps://github.com/openstack/puppet-nova/blob/8938e4cff9fb7aa02f6b01037f3afef22792b8c8/manifests/compute/spice.pp#L61","commit_id":"2e84826e909d3a0ffce3b061d16602fa6cc94ac3"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"d6612cd8bffe2b99ca88b3a8ea0379c9e1c34eac","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  include ::nova::params"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  nova_config {"},{"line_number":43,"context_line":"    \u0027spice/enabled\u0027:         value \u003d\u003e $enabled;"},{"line_number":44,"context_line":"    \u0027spice/agent_enabled\u0027:   value \u003d\u003e $enabled;"},{"line_number":45,"context_line":"    \u0027spice/html5proxy_host\u0027: value \u003d\u003e $host;"},{"line_number":46,"context_line":"    \u0027spice/html5proxy_port\u0027: value \u003d\u003e $port;"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5f7c97a3_285c264a","side":"PARENT","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":47},"in_reply_to":"5f7c97a3_d7d677f2","updated":"2018-05-03 14:50:20.000000000","message":"As much as I understand, this option in nova.conf isn\u0027t read by the proxy, it is used to pass the correct parameter to libvirt, so that it starts KVM with the spice parameter.\n\nSo yeah, it shouldn\u0027t be needed by the spicehtml5proxy if I\u0027m not mistaking (at least, that\u0027s my current understanding). If I\u0027m wrong with this fact, then it shouldn\u0027t be too hard to fix later on.","commit_id":"2e84826e909d3a0ffce3b061d16602fa6cc94ac3"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bd446f6334bb1218c478a7ec3337e8aff02c5d9b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  $host           \u003d \u00270.0.0.0\u0027,"},{"line_number":35,"context_line":"  $port           \u003d \u00276082\u0027,"},{"line_number":36,"context_line":"  $ensure_package \u003d \u0027present\u0027"},{"line_number":37,"context_line":") {"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  include ::nova::deps"},{"line_number":40,"context_line":"  include ::nova::params"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"5f7c97a3_ddef6de7","line":37,"updated":"2018-05-03 22:11:27.000000000","message":"you\u0027d need to inherit from ::nova::compute in order for the $::nova::compute::spice_enabled to work.  Which you may not want to do, So i think it might be safer to leave it and assume someone will intentionally include this class if they want the spice proxy and we wouldn\u0027t include it any other time.","commit_id":"33956d05a51dfdcc7cb39d4aa5db3ae835968c5f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"22e36ed507e8f0f3ecace7075ce75f1021042c87","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        match   \u003d\u003e \u0027^NOVA_CONSOLE_PROXY_TYPE\u003d(.*)$\u0027,"},{"line_number":64,"context_line":"        line    \u003d\u003e \u0027NOVA_CONSOLE_PROXY_TYPE\u003dspicehtml5\u0027,"},{"line_number":65,"context_line":"        tag     \u003d\u003e \u0027nova-consoleproxy\u0027,"},{"line_number":66,"context_line":"        require \u003d\u003e Anchor[\u0027nova::config::begin\u0027],"},{"line_number":67,"context_line":"      }"},{"line_number":68,"context_line":"    }"},{"line_number":69,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":37,"id":"5f7c97a3_3102e9b5","line":66,"updated":"2018-05-24 13:51:44.000000000","message":"This should probably notify \u003d\u003e Anchor[\u0027nova::config::end\u0027]","commit_id":"2cb78cb623a57c0331d2814d33e74058830b1e68"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"f904d57a1e5a8057896116e7bcac8f06e9094460","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        match   \u003d\u003e \u0027^NOVA_CONSOLE_PROXY_TYPE\u003d(.*)$\u0027,"},{"line_number":64,"context_line":"        line    \u003d\u003e \u0027NOVA_CONSOLE_PROXY_TYPE\u003dspicehtml5\u0027,"},{"line_number":65,"context_line":"        tag     \u003d\u003e \u0027nova-consoleproxy\u0027,"},{"line_number":66,"context_line":"        require \u003d\u003e Anchor[\u0027nova::config::begin\u0027],"},{"line_number":67,"context_line":"      }"},{"line_number":68,"context_line":"    }"},{"line_number":69,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":37,"id":"5f7c97a3_9d40ac09","line":66,"in_reply_to":"5f7c97a3_3102e9b5","updated":"2018-05-24 19:05:49.000000000","message":"Done","commit_id":"2cb78cb623a57c0331d2814d33e74058830b1e68"}],"manifests/vncproxy.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f6103fe80911b1e5914507b4da2e56a60f46d3e6","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  include ::nova::deps"},{"line_number":80,"context_line":"  include ::nova::params"},{"line_number":81,"context_line":"  include ::nova::compute"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  # We don\u0027t need to set spice/enabled or vnc/enabled, that\u0027s"},{"line_number":84,"context_line":"  # already set in ::nova::compute."}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9f6a8fd7_8b8434b3","line":81,"range":{"start_line":81,"start_character":2,"end_line":81,"end_character":25},"updated":"2018-04-28 08:43:48.000000000","message":"not required","commit_id":"2084bc106a37c4ef836cb9a206255e00e6e2a9f8"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"e7e9218d0c3ae4e1ad888b9625bedb46902aef8d","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  include ::nova::deps"},{"line_number":80,"context_line":"  include ::nova::params"},{"line_number":81,"context_line":"  include ::nova::compute"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  # We don\u0027t need to set spice/enabled or vnc/enabled, that\u0027s"},{"line_number":84,"context_line":"  # already set in ::nova::compute."}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9f6a8fd7_21fc293d","line":81,"range":{"start_line":81,"start_character":2,"end_line":81,"end_character":25},"in_reply_to":"9f6a8fd7_8b8434b3","updated":"2018-04-28 15:49:54.000000000","message":"Done","commit_id":"2084bc106a37c4ef836cb9a206255e00e6e2a9f8"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f6103fe80911b1e5914507b4da2e56a60f46d3e6","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    if $enabled {"},{"line_number":122,"context_line":"      service { \u0027nova-novncproxy\u0027:"},{"line_number":123,"context_line":"        ensure    \u003d\u003e \u0027running\u0027,"},{"line_number":124,"context_line":"        name      \u003d\u003e $::apache::params::vncproxy_service_name,"},{"line_number":125,"context_line":"        enable    \u003d\u003e $enabled,"},{"line_number":126,"context_line":"        hasstatus \u003d\u003e true,"},{"line_number":127,"context_line":"        require   \u003d\u003e ["}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9f6a8fd7_2b9168f2","line":124,"range":{"start_line":124,"start_character":21,"end_line":124,"end_character":61},"updated":"2018-04-28 08:43:48.000000000","message":"this is wrong","commit_id":"2084bc106a37c4ef836cb9a206255e00e6e2a9f8"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"e7e9218d0c3ae4e1ad888b9625bedb46902aef8d","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    if $enabled {"},{"line_number":122,"context_line":"      service { \u0027nova-novncproxy\u0027:"},{"line_number":123,"context_line":"        ensure    \u003d\u003e \u0027running\u0027,"},{"line_number":124,"context_line":"        name      \u003d\u003e $::apache::params::vncproxy_service_name,"},{"line_number":125,"context_line":"        enable    \u003d\u003e $enabled,"},{"line_number":126,"context_line":"        hasstatus \u003d\u003e true,"},{"line_number":127,"context_line":"        require   \u003d\u003e ["}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9f6a8fd7_618781b8","line":124,"range":{"start_line":124,"start_character":21,"end_line":124,"end_character":61},"in_reply_to":"9f6a8fd7_2b9168f2","updated":"2018-04-28 15:49:54.000000000","message":"Done","commit_id":"2084bc106a37c4ef836cb9a206255e00e6e2a9f8"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f6103fe80911b1e5914507b4da2e56a60f46d3e6","unresolved":false,"context_lines":[{"line_number":146,"context_line":"      }"},{"line_number":147,"context_line":"    }"},{"line_number":148,"context_line":"  } else {"},{"line_number":149,"context_line":"    nova::generic_service { \u0027vncproxy\u0027:"},{"line_number":150,"context_line":"      enabled        \u003d\u003e $enabled,"},{"line_number":151,"context_line":"      manage_service \u003d\u003e $manage_service,"},{"line_number":152,"context_line":"      package_name   \u003d\u003e $::nova::params::vncproxy_package_name,"},{"line_number":153,"context_line":"      service_name   \u003d\u003e $::nova::params::vncproxy_service_name,"},{"line_number":154,"context_line":"      ensure_package \u003d\u003e $ensure_package,"},{"line_number":155,"context_line":"    }"},{"line_number":156,"context_line":"  }"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9f6a8fd7_4b8e1cd1","line":154,"range":{"start_line":149,"start_character":4,"end_line":154,"end_character":40},"updated":"2018-04-28 08:43:48.000000000","message":"Same as spice, try to use nova::generic_service","commit_id":"2084bc106a37c4ef836cb9a206255e00e6e2a9f8"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"e7e9218d0c3ae4e1ad888b9625bedb46902aef8d","unresolved":false,"context_lines":[{"line_number":146,"context_line":"      }"},{"line_number":147,"context_line":"    }"},{"line_number":148,"context_line":"  } else {"},{"line_number":149,"context_line":"    nova::generic_service { \u0027vncproxy\u0027:"},{"line_number":150,"context_line":"      enabled        \u003d\u003e $enabled,"},{"line_number":151,"context_line":"      manage_service \u003d\u003e $manage_service,"},{"line_number":152,"context_line":"      package_name   \u003d\u003e $::nova::params::vncproxy_package_name,"},{"line_number":153,"context_line":"      service_name   \u003d\u003e $::nova::params::vncproxy_service_name,"},{"line_number":154,"context_line":"      ensure_package \u003d\u003e $ensure_package,"},{"line_number":155,"context_line":"    }"},{"line_number":156,"context_line":"  }"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9f6a8fd7_219189f2","line":154,"range":{"start_line":149,"start_character":4,"end_line":154,"end_character":40},"in_reply_to":"9f6a8fd7_4b8e1cd1","updated":"2018-04-28 15:49:54.000000000","message":"Done","commit_id":"2084bc106a37c4ef836cb9a206255e00e6e2a9f8"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"4408c1d86bf06175db1892b757f98dd0a2442cde","unresolved":false,"context_lines":[{"line_number":79,"context_line":"  include ::nova::deps"},{"line_number":80,"context_line":"  include ::nova::params"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  # We don\u0027t need to set spice/enabled or vnc/enabled, that\u0027s"},{"line_number":83,"context_line":"  # already set in ::nova::compute."},{"line_number":84,"context_line":"  nova_config {"},{"line_number":85,"context_line":"    \u0027vnc/novncproxy_host\u0027: value \u003d\u003e $host;"},{"line_number":86,"context_line":"    \u0027vnc/novncproxy_port\u0027: value \u003d\u003e $port;"},{"line_number":87,"context_line":"  }"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  if (!$allow_noauth and !$allow_vencrypt) {"},{"line_number":90,"context_line":"    fail(\u0027Either allow_noauth or allow_vencrypt must be true\u0027)"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"9f6a8fd7_65030c0f","line":87,"range":{"start_line":82,"start_character":2,"end_line":87,"end_character":3},"updated":"2018-04-28 16:19:51.000000000","message":"Move this back down, so all the determined values and validation is done before and add back the auth_schemas, dont remove any functionality since it\u0027s breaking changes.\n\nWe need to following deprecation if we are doing changes, but this seems like a faulty change.","commit_id":"2b5f97123a38f322ddd1a2df7051a7eb2ae84cf5"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"50f82916d600abd412db154906d51988e2d9213b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#   Defaults to undef"},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"class nova::vncproxy("},{"line_number":65,"context_line":"  $enabled           \u003d $::nova::compute::vnc_enabled,"},{"line_number":66,"context_line":"  $manage_service    \u003d true,"},{"line_number":67,"context_line":"  $vncproxy_protocol \u003d \u0027http\u0027,"},{"line_number":68,"context_line":"  $host              \u003d \u00270.0.0.0\u0027,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"9f6a8fd7_64d9c520","line":65,"range":{"start_line":65,"start_character":23,"end_line":65,"end_character":52},"updated":"2018-04-30 10:02:22.000000000","message":"I guess it would be OK to have this, but just to make the change only target Debian issues, lets just keep this back to true","commit_id":"85dd0fc9d919bba315d3d728cc358915f78f1b4b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"50f82916d600abd412db154906d51988e2d9213b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      \u0027vnc/enabled\u0027:           value \u003d\u003e false;"},{"line_number":90,"context_line":"      \u0027spice/enabled\u0027:         value \u003d\u003e true;"},{"line_number":91,"context_line":"    }"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":"  nova_config {"},{"line_number":94,"context_line":"    \u0027vnc/novncproxy_host\u0027: value \u003d\u003e $host;"},{"line_number":95,"context_line":"    \u0027vnc/novncproxy_port\u0027: value \u003d\u003e $port;"},{"line_number":96,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"9f6a8fd7_440a818a","line":93,"range":{"start_line":92,"start_character":2,"end_line":93,"end_character":15},"updated":"2018-04-30 10:02:22.000000000","message":"small nit, maybe a new line between these lines","commit_id":"85dd0fc9d919bba315d3d728cc358915f78f1b4b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"50f82916d600abd412db154906d51988e2d9213b","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    $auth_schemes \u003d \u0027none\u0027"},{"line_number":120,"context_line":"  }"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  # The Debian package needs some scheduling:"},{"line_number":123,"context_line":"  # 1/ Install the packagin"},{"line_number":124,"context_line":"  # 2/ Fix /etc/default/nova-consoleproxy"},{"line_number":125,"context_line":"  # 3/ Start the service"},{"line_number":126,"context_line":"  # Other OS don\u0027t need this scheduling and can use"},{"line_number":127,"context_line":"  # the standard nova::generic_service"},{"line_number":128,"context_line":"  if $::os_package_type \u003d\u003d \u0027debian\u0027 {"},{"line_number":129,"context_line":"    if $enabled {"},{"line_number":130,"context_line":"      file_line { \u0027/etc/default/nova-consoleproxy:NOVA_CONSOLE_PROXY_TYPE\u0027:"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"9f6a8fd7_e4fe356a","line":127,"range":{"start_line":122,"start_character":2,"end_line":127,"end_character":38},"updated":"2018-04-30 10:02:22.000000000","message":"these can prob be removed","commit_id":"85dd0fc9d919bba315d3d728cc358915f78f1b4b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"50f82916d600abd412db154906d51988e2d9213b","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        require \u003d\u003e Anchor[\u0027nova::config::begin\u0027],"},{"line_number":136,"context_line":"      }"},{"line_number":137,"context_line":"    }"},{"line_number":138,"context_line":"  }"},{"line_number":139,"context_line":"  nova::generic_service { \u0027vncproxy\u0027:"},{"line_number":140,"context_line":"    enabled        \u003d\u003e $enabled,"},{"line_number":141,"context_line":"    manage_service \u003d\u003e $manage_service,"},{"line_number":142,"context_line":"    package_name   \u003d\u003e $::nova::params::vncproxy_package_name,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"9f6a8fd7_0404897a","line":139,"range":{"start_line":138,"start_character":2,"end_line":139,"end_character":4},"updated":"2018-04-30 10:02:22.000000000","message":"small nit, maybe a new line between these lines","commit_id":"85dd0fc9d919bba315d3d728cc358915f78f1b4b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bd446f6334bb1218c478a7ec3337e8aff02c5d9b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#   Defaults to undef"},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"class nova::vncproxy("},{"line_number":65,"context_line":"  $enabled           \u003d $::nova::compute::vnc_enabled,"},{"line_number":66,"context_line":"  $manage_service    \u003d true,"},{"line_number":67,"context_line":"  $vncproxy_protocol \u003d \u0027http\u0027,"},{"line_number":68,"context_line":"  $host              \u003d \u00270.0.0.0\u0027,"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"5f7c97a3_5d835d05","line":65,"updated":"2018-05-03 22:11:27.000000000","message":"This has the same problem as the spiceproxy with this var not actually being defined. For example if you ran them on hosts other than compute hosts, this would be undefined because you don\u0027t inherit from ::nova::compute. But you wouldn\u0027t want to inherit from nova::compute because you\u0027ll end up with some extra stuff i think. puppet inheritance is complicated","commit_id":"33956d05a51dfdcc7cb39d4aa5db3ae835968c5f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"22e36ed507e8f0f3ecace7075ce75f1021042c87","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        match   \u003d\u003e \u0027^NOVA_CONSOLE_PROXY_TYPE\u003d(.*)$\u0027,"},{"line_number":128,"context_line":"        line    \u003d\u003e \u0027NOVA_CONSOLE_PROXY_TYPE\u003dnovnc\u0027,"},{"line_number":129,"context_line":"        tag     \u003d\u003e \u0027nova-consoleproxy\u0027,"},{"line_number":130,"context_line":"        require \u003d\u003e Anchor[\u0027nova::config::begin\u0027],"},{"line_number":131,"context_line":"      }"},{"line_number":132,"context_line":"    }"},{"line_number":133,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":37,"id":"5f7c97a3_f12d5146","line":130,"updated":"2018-05-24 13:51:44.000000000","message":"same about the notify","commit_id":"2cb78cb623a57c0331d2814d33e74058830b1e68"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"f904d57a1e5a8057896116e7bcac8f06e9094460","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        match   \u003d\u003e \u0027^NOVA_CONSOLE_PROXY_TYPE\u003d(.*)$\u0027,"},{"line_number":128,"context_line":"        line    \u003d\u003e \u0027NOVA_CONSOLE_PROXY_TYPE\u003dnovnc\u0027,"},{"line_number":129,"context_line":"        tag     \u003d\u003e \u0027nova-consoleproxy\u0027,"},{"line_number":130,"context_line":"        require \u003d\u003e Anchor[\u0027nova::config::begin\u0027],"},{"line_number":131,"context_line":"      }"},{"line_number":132,"context_line":"    }"},{"line_number":133,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":37,"id":"5f7c97a3_1d549cc9","line":130,"in_reply_to":"5f7c97a3_f12d5146","updated":"2018-05-24 19:05:49.000000000","message":"Done","commit_id":"2cb78cb623a57c0331d2814d33e74058830b1e68"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"d23921984be0dee78b8007a7a833865f983a591c","unresolved":false,"context_lines":[{"line_number":132,"context_line":"      }"},{"line_number":133,"context_line":"    }"},{"line_number":134,"context_line":"  }"},{"line_number":135,"context_line":"  nova::generic_service { \u0027nova-vncproxy\u0027:"},{"line_number":136,"context_line":"    enabled        \u003d\u003e $enabled,"},{"line_number":137,"context_line":"    manage_service \u003d\u003e $manage_service,"},{"line_number":138,"context_line":"    package_name   \u003d\u003e $::nova::params::vncproxy_package_name,"}],"source_content_type":"text/x-puppet","patch_set":43,"id":"5f7c97a3_2d50b85e","line":135,"range":{"start_line":135,"start_character":2,"end_line":135,"end_character":42},"updated":"2018-06-04 12:45:57.000000000","message":"Was changing this on purpose?  I suspect it might be changing behaviour.","commit_id":"acb8143b89531db7c284dd2f43d1c18f47a1f702"}],"releasenotes/notes/spice-enabled-78f1bf8f333928aa.yaml":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"50f82916d600abd412db154906d51988e2d9213b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Puppet-openstack now manages both [vnc]/enabled and [spice]/enabled. This"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f6a8fd7_24c66d18","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":3},"updated":"2018-04-30 10:02:22.000000000","message":"See below examples, make them more descriptive about what is changed and what needs to be done.","commit_id":"85dd0fc9d919bba315d3d728cc358915f78f1b4b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"50f82916d600abd412db154906d51988e2d9213b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Puppet-openstack now manages both [vnc]/enabled and [spice]/enabled. This"},{"line_number":5,"context_line":"    was needed because Debian has [spice]/enabled set to True by default, and"},{"line_number":6,"context_line":"    one cannot have both enabled in a compute node. Therefore, it was mandatory"},{"line_number":7,"context_line":"    to have [spice]/enabled set to Flase if we\u0027re using VNC."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Users of puppet-openstack will have to set ::nova::compute::spice_enabled to"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f6a8fd7_e48155c5","line":7,"range":{"start_line":4,"start_character":4,"end_line":7,"end_character":60},"updated":"2018-04-30 10:02:22.000000000","message":"\"Added support to enable SPICE on compute by settings nova::compute::spice_enabled to true, defaults to false.\"","commit_id":"85dd0fc9d919bba315d3d728cc358915f78f1b4b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"50f82916d600abd412db154906d51988e2d9213b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    to have [spice]/enabled set to Flase if we\u0027re using VNC."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Users of puppet-openstack will have to set ::nova::compute::spice_enabled to"},{"line_number":11,"context_line":"    True to make a meaningful decisioin to use Spice and not use VNC, and not"},{"line_number":12,"context_line":"    rely on ::nova::spicehtml5proxy to set it as enabled by default."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f6a8fd7_04600932","line":12,"range":{"start_line":10,"start_character":4,"end_line":12,"end_character":68},"updated":"2018-04-30 10:02:22.000000000","message":"\"If your deployment is using SPICE console we recommend you set nova::compute::spice_enabled to true, default for this value is false. No VNC behavior has been touched.\"","commit_id":"85dd0fc9d919bba315d3d728cc358915f78f1b4b"}],"spec/classes/nova_spicehtml5proxy_spec.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f6103fe80911b1e5914507b4da2e56a60f46d3e6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    end"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    it {"},{"line_number":17,"context_line":"      if facts[:os_package_type] \u003d\u003d \u0027debian\u0027"},{"line_number":18,"context_line":"        is_expected.to contain_package(\u0027nova-consoleproxy\u0027).with("},{"line_number":19,"context_line":"          :name   \u003d\u003e platform_params[:spicehtml5proxy_package_name],"},{"line_number":20,"context_line":"          :ensure \u003d\u003e \u0027present\u0027"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"9f6a8fd7_8b72f4e2","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":44},"updated":"2018-04-28 08:43:48.000000000","message":"same as the other spec file, no if statements here","commit_id":"2084bc106a37c4ef836cb9a206255e00e6e2a9f8"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"e7e9218d0c3ae4e1ad888b9625bedb46902aef8d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    end"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    it {"},{"line_number":17,"context_line":"      if facts[:os_package_type] \u003d\u003d \u0027debian\u0027"},{"line_number":18,"context_line":"        is_expected.to contain_package(\u0027nova-consoleproxy\u0027).with("},{"line_number":19,"context_line":"          :name   \u003d\u003e platform_params[:spicehtml5proxy_package_name],"},{"line_number":20,"context_line":"          :ensure \u003d\u003e \u0027present\u0027"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"9f6a8fd7_418efdd0","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":44},"in_reply_to":"9f6a8fd7_8b72f4e2","updated":"2018-04-28 15:49:54.000000000","message":"I\u0027m sorry, but then I don\u0027t know how it works. The facts[] aren\u0027t available outside of a \"it\" statement. How can I make the package name depend on the package type then?","commit_id":"2084bc106a37c4ef836cb9a206255e00e6e2a9f8"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"4408c1d86bf06175db1892b757f98dd0a2442cde","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    end"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    it {"},{"line_number":17,"context_line":"      if facts[:os_package_type] \u003d\u003d \u0027debian\u0027"},{"line_number":18,"context_line":"        is_expected.to contain_package(\u0027nova-consoleproxy\u0027).with("},{"line_number":19,"context_line":"          :name   \u003d\u003e platform_params[:spicehtml5proxy_package_name],"},{"line_number":20,"context_line":"          :ensure \u003d\u003e \u0027present\u0027"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"9f6a8fd7_41035d10","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":44},"updated":"2018-04-28 16:19:51.000000000","message":"Same here","commit_id":"2b5f97123a38f322ddd1a2df7051a7eb2ae84cf5"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"f0e82cbe9be1ff5b4fd918977fba92610daadfef","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      :tag     \u003d\u003e \u0027nova-consoleproxy\u0027,"},{"line_number":55,"context_line":"      :require \u003d\u003e \u0027Anchor[nova::config::begin]\u0027,"},{"line_number":56,"context_line":"    )}"},{"line_number":57,"context_line":"  }"},{"line_number":58,"context_line":"  end"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  context \u0027on Ubuntu system\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":19,"id":"9f6a8fd7_1bcfdfb0","line":57,"range":{"start_line":57,"start_character":2,"end_line":57,"end_character":3},"updated":"2018-05-02 00:28:37.000000000","message":"should be removed","commit_id":"eea48da2c0d5b8dee5fcc34f3cd5b4c2c5630fdc"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"83226deb8c5e3541950308d17e47ae8c17359f4b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        :spicehtml5proxy_service_name \u003d\u003e \u0027nova-spiceproxy\u0027 }"},{"line_number":81,"context_line":"    end"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    it_configures \u0027nova-spicehtml5proxy\u0027"},{"line_number":84,"context_line":"  end"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  context \u0027on Debian system\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":32,"id":"5f7c97a3_0ec7b147","line":83,"range":{"start_line":83,"start_character":4,"end_line":83,"end_character":40},"updated":"2018-05-08 12:34:29.000000000","message":"This","commit_id":"8b376f6f2818ede5b7ef6efeba838b75a208eecb"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"83226deb8c5e3541950308d17e47ae8c17359f4b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        :spicehtml5proxy_service_name \u003d\u003e \u0027nova-spicehtml5proxy\u0027 }"},{"line_number":99,"context_line":"    end"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    it_configures \u0027nova-spicehtml5proxy debian package\u0027"},{"line_number":102,"context_line":"  end"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  context \u0027on Ubuntu system with Debian packages\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":32,"id":"5f7c97a3_eecb5550","line":101,"range":{"start_line":101,"start_character":4,"end_line":101,"end_character":55},"updated":"2018-05-08 12:34:29.000000000","message":"Does not match this","commit_id":"8b376f6f2818ede5b7ef6efeba838b75a208eecb"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"22e36ed507e8f0f3ecace7075ce75f1021042c87","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    \u0027include nova\u0027"},{"line_number":7,"context_line":"  end"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  shared_examples \u0027nova-spicehtml5proxy debian package\u0027 do"},{"line_number":10,"context_line":"    it { is_expected.to contain_file_line(\u0027/etc/default/nova-consoleproxy:NOVA_CONSOLE_PROXY_TYPE\u0027).with("},{"line_number":11,"context_line":"        :path    \u003d\u003e \u0027/etc/default/nova-consoleproxy\u0027,"},{"line_number":12,"context_line":"        :match   \u003d\u003e \u0027^NOVA_CONSOLE_PROXY_TYPE\u003d(.*)$\u0027,"}],"source_content_type":"text/x-ruby","patch_set":37,"id":"5f7c97a3_31f0a9c9","line":9,"updated":"2018-05-24 13:51:44.000000000","message":"I think you might need to add a:\n\nlet :params do\n  { :enabed \u003d\u003e true }\nend","commit_id":"2cb78cb623a57c0331d2814d33e74058830b1e68"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"f904d57a1e5a8057896116e7bcac8f06e9094460","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    \u0027include nova\u0027"},{"line_number":7,"context_line":"  end"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  shared_examples \u0027nova-spicehtml5proxy debian package\u0027 do"},{"line_number":10,"context_line":"    it { is_expected.to contain_file_line(\u0027/etc/default/nova-consoleproxy:NOVA_CONSOLE_PROXY_TYPE\u0027).with("},{"line_number":11,"context_line":"        :path    \u003d\u003e \u0027/etc/default/nova-consoleproxy\u0027,"},{"line_number":12,"context_line":"        :match   \u003d\u003e \u0027^NOVA_CONSOLE_PROXY_TYPE\u003d(.*)$\u0027,"}],"source_content_type":"text/x-ruby","patch_set":37,"id":"5f7c97a3_3dbab809","line":9,"in_reply_to":"5f7c97a3_31f0a9c9","updated":"2018-05-24 19:05:49.000000000","message":"Done","commit_id":"2cb78cb623a57c0331d2814d33e74058830b1e68"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"89cfc71a9eeda2d1b0fe858610d1b98d73c34f04","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    end"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    it { is_expected.to contain_file_line(\u0027/etc/default/nova-consoleproxy:NOVA_CONSOLE_PROXY_TYPE\u0027).with("},{"line_number":15,"context_line":"        :path    \u003d\u003e \u0027/etc/default/nova-consoleproxy\u0027,"},{"line_number":16,"context_line":"        :match   \u003d\u003e \u0027^NOVA_CONSOLE_PROXY_TYPE\u003d(.*)$\u0027,"},{"line_number":17,"context_line":"        :line    \u003d\u003e \u0027NOVA_CONSOLE_PROXY_TYPE\u003dspicehtml5\u0027,"},{"line_number":18,"context_line":"        :tag     \u003d\u003e \u0027nova-consoleproxy\u0027,"},{"line_number":19,"context_line":"        :require \u003d\u003e \u0027Anchor[nova::config::begin]\u0027,"},{"line_number":20,"context_line":"    )}"},{"line_number":21,"context_line":"  end"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":46,"id":"5f7c97a3_2248ab5a","line":19,"range":{"start_line":15,"start_character":8,"end_line":19,"end_character":50},"updated":"2018-06-05 12:57:47.000000000","message":"Check the \"notify\" param for this resource","commit_id":"04c01480a7a6ca4f587cc11fd8296df48eb8d5eb"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"9b89e602cd35ec787626dbc77f326f10646aaebf","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    end"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    it { is_expected.to contain_file_line(\u0027/etc/default/nova-consoleproxy:NOVA_CONSOLE_PROXY_TYPE\u0027).with("},{"line_number":15,"context_line":"        :path    \u003d\u003e \u0027/etc/default/nova-consoleproxy\u0027,"},{"line_number":16,"context_line":"        :match   \u003d\u003e \u0027^NOVA_CONSOLE_PROXY_TYPE\u003d(.*)$\u0027,"},{"line_number":17,"context_line":"        :line    \u003d\u003e \u0027NOVA_CONSOLE_PROXY_TYPE\u003dspicehtml5\u0027,"},{"line_number":18,"context_line":"        :tag     \u003d\u003e \u0027nova-consoleproxy\u0027,"},{"line_number":19,"context_line":"        :require \u003d\u003e \u0027Anchor[nova::config::begin]\u0027,"},{"line_number":20,"context_line":"    )}"},{"line_number":21,"context_line":"  end"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":46,"id":"5f7c97a3_e22e33aa","line":19,"range":{"start_line":15,"start_character":8,"end_line":19,"end_character":50},"in_reply_to":"5f7c97a3_2248ab5a","updated":"2018-06-05 13:31:15.000000000","message":"Done","commit_id":"04c01480a7a6ca4f587cc11fd8296df48eb8d5eb"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"89cfc71a9eeda2d1b0fe858610d1b98d73c34f04","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    end"},{"line_number":60,"context_line":"  end"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"#  spec/classes/nova_spicehtml5proxy_spec.rb"},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"#    it { is_expected.to contain_file_line(\u0027/etc/default/nova-consoleproxy:NOVA_CONSOLE_PROXY_TYPE\u0027).with("},{"line_number":65,"context_line":"#      :path    \u003d\u003e \u0027/etc/default/nova-consoleproxy\u0027,"},{"line_number":66,"context_line":"#      :match   \u003d\u003e \u0027^NOVA_CONSOLE_PROXY_TYPE\u003d(.*)$\u0027,"},{"line_number":67,"context_line":"#      :line    \u003d\u003e \u0027NOVA_CONSOLE_PROXY_TYPE\u003dspicehtml5\u0027,"},{"line_number":68,"context_line":"#      :tag     \u003d\u003e \u0027nova-consoleproxy\u0027,"},{"line_number":69,"context_line":"#      :require \u003d\u003e \u0027Anchor[nova::config::begin]\u0027,"},{"line_number":70,"context_line":"#    )}"},{"line_number":71,"context_line":"#  end"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  context \u0027on Ubuntu system\u0027 do"},{"line_number":74,"context_line":"    let :facts do"}],"source_content_type":"text/x-ruby","patch_set":46,"id":"5f7c97a3_623ea3ba","line":71,"range":{"start_line":62,"start_character":0,"end_line":71,"end_character":6},"updated":"2018-06-05 12:57:47.000000000","message":"Remove this","commit_id":"04c01480a7a6ca4f587cc11fd8296df48eb8d5eb"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"9b89e602cd35ec787626dbc77f326f10646aaebf","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    end"},{"line_number":60,"context_line":"  end"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"#  spec/classes/nova_spicehtml5proxy_spec.rb"},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"#    it { is_expected.to contain_file_line(\u0027/etc/default/nova-consoleproxy:NOVA_CONSOLE_PROXY_TYPE\u0027).with("},{"line_number":65,"context_line":"#      :path    \u003d\u003e \u0027/etc/default/nova-consoleproxy\u0027,"},{"line_number":66,"context_line":"#      :match   \u003d\u003e \u0027^NOVA_CONSOLE_PROXY_TYPE\u003d(.*)$\u0027,"},{"line_number":67,"context_line":"#      :line    \u003d\u003e \u0027NOVA_CONSOLE_PROXY_TYPE\u003dspicehtml5\u0027,"},{"line_number":68,"context_line":"#      :tag     \u003d\u003e \u0027nova-consoleproxy\u0027,"},{"line_number":69,"context_line":"#      :require \u003d\u003e \u0027Anchor[nova::config::begin]\u0027,"},{"line_number":70,"context_line":"#    )}"},{"line_number":71,"context_line":"#  end"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  context \u0027on Ubuntu system\u0027 do"},{"line_number":74,"context_line":"    let :facts do"}],"source_content_type":"text/x-ruby","patch_set":46,"id":"5f7c97a3_6286a3bd","line":71,"range":{"start_line":62,"start_character":0,"end_line":71,"end_character":6},"in_reply_to":"5f7c97a3_623ea3ba","updated":"2018-06-05 13:31:15.000000000","message":"Done","commit_id":"04c01480a7a6ca4f587cc11fd8296df48eb8d5eb"}],"spec/classes/nova_vnc_proxy_spec.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f6103fe80911b1e5914507b4da2e56a60f46d3e6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      it { is_expected.to contain_nova_config(\u0027vnc/auth_schemes\u0027).with(:value \u003d\u003e \u0027none\u0027) }"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"      it {"},{"line_number":18,"context_line":"        if facts[:os_package_type] \u003d\u003d \u0027debian\u0027"},{"line_number":19,"context_line":"          is_expected.to contain_package(\u0027nova-consoleproxy\u0027).with("},{"line_number":20,"context_line":"            :name   \u003d\u003e platform_params[:nova_vncproxy_package],"},{"line_number":21,"context_line":"            :ensure \u003d\u003e \u0027present\u0027"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"9f6a8fd7_cb70ecdf","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":46},"updated":"2018-04-28 08:43:48.000000000","message":"cannot have the if statements inside the \"it\", same for all below, you should only have to correct names if you use the nova::generic_service resource","commit_id":"2084bc106a37c4ef836cb9a206255e00e6e2a9f8"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"e7e9218d0c3ae4e1ad888b9625bedb46902aef8d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      it { is_expected.to contain_nova_config(\u0027vnc/auth_schemes\u0027).with(:value \u003d\u003e \u0027none\u0027) }"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"      it {"},{"line_number":18,"context_line":"        if facts[:os_package_type] \u003d\u003d \u0027debian\u0027"},{"line_number":19,"context_line":"          is_expected.to contain_package(\u0027nova-consoleproxy\u0027).with("},{"line_number":20,"context_line":"            :name   \u003d\u003e platform_params[:nova_vncproxy_package],"},{"line_number":21,"context_line":"            :ensure \u003d\u003e \u0027present\u0027"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"9f6a8fd7_e1bcf16d","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":46},"in_reply_to":"9f6a8fd7_cb70ecdf","updated":"2018-04-28 15:49:54.000000000","message":"Can you give me an example?","commit_id":"2084bc106a37c4ef836cb9a206255e00e6e2a9f8"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f6103fe80911b1e5914507b4da2e56a60f46d3e6","unresolved":false,"context_lines":[{"line_number":166,"context_line":"      let (:platform_params) do"},{"line_number":167,"context_line":"        case facts[:osfamily]"},{"line_number":168,"context_line":"        when \u0027Debian\u0027 {"},{"line_number":169,"context_line":"          if facts[:os_package_type] \u003d\u003d \u0027debian\u0027"},{"line_number":170,"context_line":"            :nova_vncproxy_package \u003d\u003e \u0027nova-consoleproxy\u0027,"},{"line_number":171,"context_line":"          else"},{"line_number":172,"context_line":"            :nova_vncproxy_package \u003d\u003e \u0027nova-novncproxy\u0027,"},{"line_number":173,"context_line":"          end"},{"line_number":174,"context_line":"          :nova_vncproxy_service \u003d\u003e \u0027nova-novncproxy\u0027"},{"line_number":175,"context_line":"        }"},{"line_number":176,"context_line":"        when \u0027RedHat\u0027"},{"line_number":177,"context_line":"          { :nova_vncproxy_package \u003d\u003e \u0027openstack-nova-novncproxy\u0027,"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"9f6a8fd7_ab6b38ef","line":174,"range":{"start_line":169,"start_character":10,"end_line":174,"end_character":53},"updated":"2018-04-28 08:43:48.000000000","message":"You need to return a hash, see the RedHat example below. Or see here [1]\n\n[1] https://review.openstack.org/#/c/564770/8/spec/defines/horizon_dashboard_spec.rb","commit_id":"2084bc106a37c4ef836cb9a206255e00e6e2a9f8"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"4408c1d86bf06175db1892b757f98dd0a2442cde","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      it { is_expected.to contain_nova_config(\u0027vnc/auth_schemes\u0027).with(:value \u003d\u003e \u0027none\u0027) }"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"      it {"},{"line_number":18,"context_line":"        if facts[:os_package_type] \u003d\u003d \u0027debian\u0027"},{"line_number":19,"context_line":"          is_expected.to contain_package(\u0027nova-consoleproxy\u0027).with("},{"line_number":20,"context_line":"            :name   \u003d\u003e platform_params[:nova_vncproxy_package],"},{"line_number":21,"context_line":"            :ensure \u003d\u003e \u0027present\u0027"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"9f6a8fd7_21066922","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":46},"updated":"2018-04-28 16:19:51.000000000","message":"Remove the if statement and the extra is_expected to in the else part.\n\nThen do fix the \"it\" to say:\nit { is_expected.to contain_package(platform_params[:nova_vncproxy_package])...\n\nFYI what shared_examples to be run is determined in the on_supported_os with it_behaves_like.\n\nSee full example here: https://review.openstack.org/#/c/564770/8/spec/defines/horizon_dashboard_spec.rb","commit_id":"2b5f97123a38f322ddd1a2df7051a7eb2ae84cf5"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"b067a651fd9d4ac7e60ccb675fc7e3b9473afe7c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      it { is_expected.to contain_nova_config(\u0027vnc/auth_schemes\u0027).with(:value \u003d\u003e \u0027none\u0027) }"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"      it {"},{"line_number":18,"context_line":"        if facts[:os_package_type] \u003d\u003d \u0027debian\u0027"},{"line_number":19,"context_line":"          is_expected.to contain_package(\u0027nova-consoleproxy\u0027).with("},{"line_number":20,"context_line":"            :name   \u003d\u003e platform_params[:nova_vncproxy_package],"},{"line_number":21,"context_line":"            :ensure \u003d\u003e \u0027present\u0027"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"9f6a8fd7_2483cd58","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":46},"in_reply_to":"9f6a8fd7_21066922","updated":"2018-04-30 09:33:01.000000000","message":"Done","commit_id":"2b5f97123a38f322ddd1a2df7051a7eb2ae84cf5"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"50f82916d600abd412db154906d51988e2d9213b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            :manage_service \u003d\u003e false"},{"line_number":35,"context_line":"          }"},{"line_number":36,"context_line":"        end"},{"line_number":37,"context_line":"        it {"},{"line_number":38,"context_line":"          if facts[:os_package_type] \u003d\u003d \u0027debian\u0027"},{"line_number":39,"context_line":"            is_expected.to contain_service(\u0027nova-novncproxy\u0027).without_ensure"},{"line_number":40,"context_line":"          else"},{"line_number":41,"context_line":"            is_expected.to contain_service(\u0027nova-vncproxy\u0027).without_ensure"},{"line_number":42,"context_line":"          end"},{"line_number":43,"context_line":"        }"},{"line_number":44,"context_line":"      end"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"      describe \u0027with package version\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"9f6a8fd7_e4e8757d","line":43,"range":{"start_line":37,"start_character":8,"end_line":43,"end_character":9},"updated":"2018-04-30 10:02:22.000000000","message":"Need fixing, cannot have if statement in there. Remove the if statement and use contain_service(platform_params[:nova_vncproxy_service]) for the resource name","commit_id":"85dd0fc9d919bba315d3d728cc358915f78f1b4b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"50f82916d600abd412db154906d51988e2d9213b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"          {:ensure_package \u003d\u003e \u00272012.1-2\u0027}"},{"line_number":49,"context_line":"        end"},{"line_number":50,"context_line":"        it {"},{"line_number":51,"context_line":"          if facts[:os_package_type] \u003d\u003d \u0027debian\u0027"},{"line_number":52,"context_line":"            is_expected.to contain_package(\u0027nova-consoleproxy\u0027).with("},{"line_number":53,"context_line":"              \u0027ensure\u0027 \u003d\u003e \u00272012.1-2\u0027"},{"line_number":54,"context_line":"            )"},{"line_number":55,"context_line":"          else"},{"line_number":56,"context_line":"            is_expected.to contain_package(\u0027nova-vncproxy\u0027).with("},{"line_number":57,"context_line":"              \u0027ensure\u0027 \u003d\u003e \u00272012.1-2\u0027"},{"line_number":58,"context_line":"            )"},{"line_number":59,"context_line":"          end"},{"line_number":60,"context_line":"        }"},{"line_number":61,"context_line":"      end"},{"line_number":62,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"9f6a8fd7_04eec987","line":59,"range":{"start_line":51,"start_character":11,"end_line":59,"end_character":13},"updated":"2018-04-30 10:02:22.000000000","message":"same as above","commit_id":"85dd0fc9d919bba315d3d728cc358915f78f1b4b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"50f82916d600abd412db154906d51988e2d9213b","unresolved":false,"context_lines":[{"line_number":149,"context_line":"      end"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"      let (:platform_params) do"},{"line_number":152,"context_line":"        case facts[::os_package_type]"},{"line_number":153,"context_line":"        when \u0027debian\u0027"},{"line_number":154,"context_line":"          { :nova_vncproxy_package \u003d\u003e \u0027nova-consoleproxy\u0027,"},{"line_number":155,"context_line":"            :nova_vncproxy_service \u003d\u003e \u0027nova-novncproxy\u0027, }"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"9f6a8fd7_a4027d3d","line":152,"range":{"start_line":152,"start_character":19,"end_line":152,"end_character":21},"updated":"2018-04-30 10:02:22.000000000","message":"should only be one colon","commit_id":"85dd0fc9d919bba315d3d728cc358915f78f1b4b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"89cfc71a9eeda2d1b0fe858610d1b98d73c34f04","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    end"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    it { is_expected.to contain_file_line(\u0027/etc/default/nova-consoleproxy:NOVA_CONSOLE_PROXY_TYPE\u0027).with("},{"line_number":143,"context_line":"      :path    \u003d\u003e \u0027/etc/default/nova-consoleproxy\u0027,"},{"line_number":144,"context_line":"      :match   \u003d\u003e \u0027^NOVA_CONSOLE_PROXY_TYPE\u003d(.*)$\u0027,"},{"line_number":145,"context_line":"      :line    \u003d\u003e \u0027NOVA_CONSOLE_PROXY_TYPE\u003dnovnc\u0027,"},{"line_number":146,"context_line":"      :tag     \u003d\u003e \u0027nova-consoleproxy\u0027,"},{"line_number":147,"context_line":"      :require \u003d\u003e \u0027Anchor[nova::config::begin]\u0027,"},{"line_number":148,"context_line":"    )}"},{"line_number":149,"context_line":"  end"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":46,"id":"5f7c97a3_a254bbff","line":147,"range":{"start_line":143,"start_character":6,"end_line":147,"end_character":48},"updated":"2018-06-05 12:57:47.000000000","message":"Add the check for the \"notify\" params for this resource.","commit_id":"04c01480a7a6ca4f587cc11fd8296df48eb8d5eb"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"9b89e602cd35ec787626dbc77f326f10646aaebf","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    end"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    it { is_expected.to contain_file_line(\u0027/etc/default/nova-consoleproxy:NOVA_CONSOLE_PROXY_TYPE\u0027).with("},{"line_number":143,"context_line":"      :path    \u003d\u003e \u0027/etc/default/nova-consoleproxy\u0027,"},{"line_number":144,"context_line":"      :match   \u003d\u003e \u0027^NOVA_CONSOLE_PROXY_TYPE\u003d(.*)$\u0027,"},{"line_number":145,"context_line":"      :line    \u003d\u003e \u0027NOVA_CONSOLE_PROXY_TYPE\u003dnovnc\u0027,"},{"line_number":146,"context_line":"      :tag     \u003d\u003e \u0027nova-consoleproxy\u0027,"},{"line_number":147,"context_line":"      :require \u003d\u003e \u0027Anchor[nova::config::begin]\u0027,"},{"line_number":148,"context_line":"    )}"},{"line_number":149,"context_line":"  end"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":46,"id":"5f7c97a3_c2169756","line":147,"range":{"start_line":143,"start_character":6,"end_line":147,"end_character":48},"in_reply_to":"5f7c97a3_a254bbff","updated":"2018-06-05 13:31:15.000000000","message":"Done","commit_id":"04c01480a7a6ca4f587cc11fd8296df48eb8d5eb"}]}