)]}'
{"manifests/compute/libvirt.pp":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"f619c79779bcab64471a9c36d2d4f650e1cd8a73","unresolved":false,"context_lines":[{"line_number":275,"context_line":"  }"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"  if $libvirt_cpu_mode_real !\u003d \u0027none\u0027 {"},{"line_number":278,"context_line":"    validate_string($libvirt_cpu_model_extra_flags)"},{"line_number":279,"context_line":"    nova_config {"},{"line_number":280,"context_line":"      \u0027libvirt/cpu_model_extra_flags\u0027: value \u003d\u003e $libvirt_cpu_model_extra_flags;"},{"line_number":281,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f7c97a3_523fcc86","line":278,"range":{"start_line":278,"start_character":4,"end_line":278,"end_character":51},"updated":"2018-05-17 14:48:57.000000000","message":"while this doesn\u0027t fail on undef, it probably should: https://tickets.puppetlabs.com/browse/MODULES-457\n\nMight be safer refactor this and the if statement above to explicitly check for undef","commit_id":"a1ee3a084c79772cd2b0c809f1e538547ccea5e8"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"19df3978b90b413ce9f65dc30223ed1a70e0e55e","unresolved":false,"context_lines":[{"line_number":275,"context_line":"  }"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"  if $libvirt_cpu_mode_real !\u003d \u0027none\u0027 {"},{"line_number":278,"context_line":"    validate_string($libvirt_cpu_model_extra_flags)"},{"line_number":279,"context_line":"    nova_config {"},{"line_number":280,"context_line":"      \u0027libvirt/cpu_model_extra_flags\u0027: value \u003d\u003e $libvirt_cpu_model_extra_flags;"},{"line_number":281,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f7c97a3_6051c962","line":278,"range":{"start_line":278,"start_character":4,"end_line":278,"end_character":51},"in_reply_to":"5f7c97a3_001b3573","updated":"2018-05-17 20:15:53.000000000","message":"yes, but validate_string should validate that it\u0027s a string... only reason this doesn\u0027t fail is that it has always been broken","commit_id":"a1ee3a084c79772cd2b0c809f1e538547ccea5e8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"99fbcebae089efeab8e45d80e328946afa7ce36a","unresolved":false,"context_lines":[{"line_number":275,"context_line":"  }"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"  if $libvirt_cpu_mode_real !\u003d \u0027none\u0027 {"},{"line_number":278,"context_line":"    validate_string($libvirt_cpu_model_extra_flags)"},{"line_number":279,"context_line":"    nova_config {"},{"line_number":280,"context_line":"      \u0027libvirt/cpu_model_extra_flags\u0027: value \u003d\u003e $libvirt_cpu_model_extra_flags;"},{"line_number":281,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f7c97a3_001b3573","line":278,"range":{"start_line":278,"start_character":4,"end_line":278,"end_character":51},"in_reply_to":"5f7c97a3_523fcc86","updated":"2018-05-17 19:47:43.000000000","message":"undef would make the nova_config call essentially a noop. Our providers don\u0027t do anything if they get an undef.","commit_id":"a1ee3a084c79772cd2b0c809f1e538547ccea5e8"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"2308dcd99102ffc463af7ba22052350c09422d7c","unresolved":false,"context_lines":[{"line_number":275,"context_line":"  }"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"  if $libvirt_cpu_mode_real !\u003d \u0027none\u0027 {"},{"line_number":278,"context_line":"    validate_string($libvirt_cpu_model_extra_flags)"},{"line_number":279,"context_line":"    nova_config {"},{"line_number":280,"context_line":"      \u0027libvirt/cpu_model_extra_flags\u0027: value \u003d\u003e $libvirt_cpu_model_extra_flags;"},{"line_number":281,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f7c97a3_dbec502b","line":278,"range":{"start_line":278,"start_character":4,"end_line":278,"end_character":51},"in_reply_to":"5f7c97a3_6051c962","updated":"2018-05-17 20:28:42.000000000","message":"nit picking though","commit_id":"a1ee3a084c79772cd2b0c809f1e538547ccea5e8"}]}