)]}'
{"manifests/compute.pp":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"db4cc5e8d9da7cb56a03cba389161942a58cd81c","unresolved":false,"context_lines":[{"line_number":163,"context_line":"#    Accepts a string e.g \"node:0,size:1GB,count:4\" or a list of strings e.g:"},{"line_number":164,"context_line":"#    [\"node:0,size:1GB,count:4\", \"node:1,size:1GB,count:4\"]"},{"line_number":165,"context_line":"#"},{"line_number":166,"context_line":"#  [*neutron_physnets*]"},{"line_number":167,"context_line":"#    (optional) Map of physnet name as key and list of NUMA nodes as value."},{"line_number":168,"context_line":"#    Defaults to {}"},{"line_number":169,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5f7c97a3_c8ff1633","line":166,"range":{"start_line":166,"start_character":5,"end_line":166,"end_character":21},"updated":"2018-07-18 09:20:02.000000000","message":"would i make more sense to call this \u0027neutron_physnets_numa_nodes\u0027 to align with the tunnel equivalent?","commit_id":"801217d884617cb51c9b7ac5a1acfe339a58048d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"db4cc5e8d9da7cb56a03cba389161942a58cd81c","unresolved":false,"context_lines":[{"line_number":169,"context_line":"#"},{"line_number":170,"context_line":"#  [*neutron_tunnel_numa_nodes*]"},{"line_number":171,"context_line":"#    (optional) List of NUMA nodes to configure NUMA affinity for all"},{"line_number":172,"context_line":"#    tunnelled networks. Only valid, if neutron_physnets attribute"},{"line_number":173,"context_line":"#    is specified."},{"line_number":174,"context_line":"#    Defaults to []"},{"line_number":175,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5f7c97a3_e8aa1218","line":172,"range":{"start_line":172,"start_character":5,"end_line":172,"end_character":14},"updated":"2018-07-18 09:20:02.000000000","message":"tunneled","commit_id":"801217d884617cb51c9b7ac5a1acfe339a58048d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"db4cc5e8d9da7cb56a03cba389161942a58cd81c","unresolved":false,"context_lines":[{"line_number":169,"context_line":"#"},{"line_number":170,"context_line":"#  [*neutron_tunnel_numa_nodes*]"},{"line_number":171,"context_line":"#    (optional) List of NUMA nodes to configure NUMA affinity for all"},{"line_number":172,"context_line":"#    tunnelled networks. Only valid, if neutron_physnets attribute"},{"line_number":173,"context_line":"#    is specified."},{"line_number":174,"context_line":"#    Defaults to []"},{"line_number":175,"context_line":"#"},{"line_number":176,"context_line":"# DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5f7c97a3_4891c6f6","line":173,"range":{"start_line":172,"start_character":25,"end_line":173,"end_character":18},"updated":"2018-07-18 09:20:02.000000000","message":"Not true. A deployment may only use/only care about NUMA affinity of tunneled networks. Just drop this.","commit_id":"801217d884617cb51c9b7ac5a1acfe339a58048d"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"156e33f12ae306927f6ee1dad5c4853467c79155","unresolved":false,"context_lines":[{"line_number":252,"context_line":"  # This block checks for update/removal of physnet map key/values"},{"line_number":253,"context_line":"  # and remove unwanted physnet sections."},{"line_number":254,"context_line":"  if defined(Nova_config[\u0027neutron/physnets\u0027]) {"},{"line_number":255,"context_line":"    $neutron_physnets_old \u003d nova_config[\u0027neutron/physnets\u0027]"},{"line_number":256,"context_line":"    $neutron_physnets_old.each |$old_physnet| {"},{"line_number":257,"context_line":"      nova_config {"},{"line_number":258,"context_line":"        \"neutron_physnet_${old_physnet}/numa_nodes\": ensure \u003d\u003e absent;"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5f7c97a3_cd397ba2","line":255,"range":{"start_line":255,"start_character":28,"end_line":255,"end_character":59},"updated":"2018-07-17 15:42:09.000000000","message":"don\u0027t think it\u0027s possible to do this. Generally I think we assume we are working with a clean conf file, so removing old values is not necessary.","commit_id":"801217d884617cb51c9b7ac5a1acfe339a58048d"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"45e141fe68132ed5c2142693d0695a691e2eb509","unresolved":false,"context_lines":[{"line_number":252,"context_line":"  # This block checks for update/removal of physnet map key/values"},{"line_number":253,"context_line":"  # and remove unwanted physnet sections."},{"line_number":254,"context_line":"  if defined(Nova_config[\u0027neutron/physnets\u0027]) {"},{"line_number":255,"context_line":"    $neutron_physnets_old \u003d nova_config[\u0027neutron/physnets\u0027]"},{"line_number":256,"context_line":"    $neutron_physnets_old.each |$old_physnet| {"},{"line_number":257,"context_line":"      nova_config {"},{"line_number":258,"context_line":"        \"neutron_physnet_${old_physnet}/numa_nodes\": ensure \u003d\u003e absent;"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5f7c97a3_233a72c3","line":255,"range":{"start_line":255,"start_character":28,"end_line":255,"end_character":59},"in_reply_to":"5f7c97a3_cd397ba2","updated":"2018-07-18 05:40:02.000000000","message":"In that case, should I revert these changes and keep only below if block starting from line#267 ?","commit_id":"801217d884617cb51c9b7ac5a1acfe339a58048d"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"4285c925b95c681642933f4f70c8bf9d24505c95","unresolved":false,"context_lines":[{"line_number":254,"context_line":"  if defined(Nova_config[\u0027neutron/physnets\u0027]) {"},{"line_number":255,"context_line":"    $neutron_physnets_old \u003d nova_config[\u0027neutron/physnets\u0027]"},{"line_number":256,"context_line":"    $neutron_physnets_old.each |$old_physnet| {"},{"line_number":257,"context_line":"      nova_config {"},{"line_number":258,"context_line":"        \"neutron_physnet_${old_physnet}/numa_nodes\": ensure \u003d\u003e absent;"},{"line_number":259,"context_line":"      }"},{"line_number":260,"context_line":"    }"},{"line_number":261,"context_line":"    nova_config {"},{"line_number":262,"context_line":"      \u0027neutron/physnets\u0027:          ensure \u003d\u003e absent;"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5f7c97a3_1897bced","line":259,"range":{"start_line":257,"start_character":0,"end_line":259,"end_character":7},"updated":"2018-07-17 11:08:48.000000000","message":"think you\u0027ll need to skip any physnets we are setting it again below, otherwise puppet will fail with duplicate resources","commit_id":"801217d884617cb51c9b7ac5a1acfe339a58048d"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"4285c925b95c681642933f4f70c8bf9d24505c95","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        \"neutron_physnet_${old_physnet}/numa_nodes\": ensure \u003d\u003e absent;"},{"line_number":259,"context_line":"      }"},{"line_number":260,"context_line":"    }"},{"line_number":261,"context_line":"    nova_config {"},{"line_number":262,"context_line":"      \u0027neutron/physnets\u0027:          ensure \u003d\u003e absent;"},{"line_number":263,"context_line":"      \u0027neutron_tunnel/numa_nodes\u0027: ensure \u003d\u003e absent;"},{"line_number":264,"context_line":"    }"},{"line_number":265,"context_line":"  }"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"  if !empty($neutron_physnets){"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5f7c97a3_f8ba006f","line":264,"range":{"start_line":261,"start_character":0,"end_line":264,"end_character":5},"updated":"2018-07-17 11:08:48.000000000","message":"already doing this on line 281 (which will not have issue with duplicate resources)","commit_id":"801217d884617cb51c9b7ac5a1acfe339a58048d"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"82b17ae9049e7cab89c75af449411e6cabdbbf93","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    $neutron_physnets_real \u003d keys($neutron_physnets_numa_nodes_mapping)"},{"line_number":254,"context_line":"    nova_config {"},{"line_number":255,"context_line":"      \u0027neutron/physnets\u0027:          value \u003d\u003e join(any2array($neutron_physnets_real), \u0027,\u0027);"},{"line_number":256,"context_line":"      \u0027neutron_tunnel/numa_nodes\u0027: value \u003d\u003e join(any2array($neutron_tunnel_numa_nodes), \u0027,\u0027);"},{"line_number":257,"context_line":"    }"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    $neutron_physnets_numa_nodes_mapping.each |$physnet, $numa_nodes| {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"5f7c97a3_77201e4c","line":256,"range":{"start_line":256,"start_character":6,"end_line":256,"end_character":93},"updated":"2018-07-18 13:16:01.000000000","message":"need to move this out of the if !empty($neutron_physnets_numa_nodes_mapping) conditional","commit_id":"4067cc6966c657ce1b216ca3b3dd89f190987d34"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"ca2601315b4bb7ef6b2eeb92282f1645525b057f","unresolved":false,"context_lines":[{"line_number":255,"context_line":"      \u0027neutron/physnets\u0027: value \u003d\u003e join(any2array($neutron_physnets_real), \u0027,\u0027);"},{"line_number":256,"context_line":"    }"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    $neutron_physnets_numa_nodes_mapping.each |$physnet, $numa_nodes| {"},{"line_number":259,"context_line":"      nova_config {"},{"line_number":260,"context_line":"        \"neutron_physnet_${physnet}/numa_nodes\": value \u003d\u003e join(any2array($numa_nodes), \u0027,\u0027);"},{"line_number":261,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"5f7c97a3_955437c8","line":258,"updated":"2018-07-25 10:27:27.000000000","message":"This does not change the existing config during an update, for example, if changing from {\u0027foo\u0027: [1,2} to {\u0027bar\u0027:[1,2]} will not remove the older configuration of [neutron_physnet_foo] section. But since it is not present in the neutron/physnets, it will not be used at all. Is this is behavior we are expecting?","commit_id":"c268f629a7e051ac395ca220c8249fb6fd19377d"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"90ec94a3de27078ae5048143fd548ff705586480","unresolved":false,"context_lines":[{"line_number":255,"context_line":"      \u0027neutron/physnets\u0027: value \u003d\u003e join(any2array($neutron_physnets_real), \u0027,\u0027);"},{"line_number":256,"context_line":"    }"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    $neutron_physnets_numa_nodes_mapping.each |$physnet, $numa_nodes| {"},{"line_number":259,"context_line":"      nova_config {"},{"line_number":260,"context_line":"        \"neutron_physnet_${physnet}/numa_nodes\": value \u003d\u003e join(any2array($numa_nodes), \u0027,\u0027);"},{"line_number":261,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"5f7c97a3_b532935c","line":258,"in_reply_to":"5f7c97a3_955437c8","updated":"2018-07-25 11:01:15.000000000","message":"I have tried to implement that, but reverted after suggestion by Oliver.\nhttps://review.openstack.org/#/c/578743/7/manifests/compute.pp","commit_id":"c268f629a7e051ac395ca220c8249fb6fd19377d"}],"spec/classes/nova_compute_spec.rb":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"220938b3d27d1c049ce626eecef881391a507e98","unresolved":false,"context_lines":[{"line_number":236,"context_line":"      it { is_expected.to contain_nova_config(\u0027neutron_tunnel/numa_nodes\u0027).with_ensure(\u0027absent\u0027) }"},{"line_number":237,"context_line":"    end"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    context \u0027when neutron_physnets is set to valid hash\u0027 do"},{"line_number":240,"context_line":"      let :params do"},{"line_number":241,"context_line":"        { :neutron_physnets          \u003d\u003e {\u0027foo\u0027: [0,1], \u0027bar\u0027: [0]},"},{"line_number":242,"context_line":"          :neutron_tunnel_numa_nodes \u003d\u003e [0], }"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"5f7c97a3_4fca35a0","line":239,"updated":"2018-07-05 11:42:31.000000000","message":"I am not sure if it is possible but could you check if a test case could added to replace the existing configs or just deleting it?","commit_id":"78575fbd3de42f090c01e5cacafb0ede8600eb39"}]}