)]}'
{"manifests/compute/libvirt.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"0498d6c9d8b989cd81de136a032672aad1119959","unresolved":false,"context_lines":[{"line_number":152,"context_line":"#   Defaults to $::os_service_default"},{"line_number":153,"context_line":"#"},{"line_number":154,"context_line":"# [*volume_use_multipath*]"},{"line_number":155,"context_line":"#   (optional) Use multipath connection of the"},{"line_number":156,"context_line":"#    iSCSI or FC volume. Volumes can be connected in the"},{"line_number":157,"context_line":"#    LibVirt as multipath devices."},{"line_number":158,"context_line":"#    Defaults to False"},{"line_number":159,"context_line":"#"},{"line_number":160,"context_line":"class nova::compute::libvirt ("},{"line_number":161,"context_line":"  $ensure_package                             \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f79a3b5_847d52e7","line":158,"range":{"start_line":155,"start_character":1,"end_line":158,"end_character":22},"updated":"2018-10-03 15:52:22.000000000","message":"faulty alignment, default should be $::os_service_default","commit_id":"1a5090f196ba71f8b71e37351c57e13714eb210c"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"8ac81919732c618e1126471d21fc2a7e1204871a","unresolved":false,"context_lines":[{"line_number":152,"context_line":"#   Defaults to $::os_service_default"},{"line_number":153,"context_line":"#"},{"line_number":154,"context_line":"# [*volume_use_multipath*]"},{"line_number":155,"context_line":"#   (optional) Use multipath connection of the"},{"line_number":156,"context_line":"#    iSCSI or FC volume. Volumes can be connected in the"},{"line_number":157,"context_line":"#    LibVirt as multipath devices."},{"line_number":158,"context_line":"#    Defaults to False"},{"line_number":159,"context_line":"#"},{"line_number":160,"context_line":"class nova::compute::libvirt ("},{"line_number":161,"context_line":"  $ensure_package                             \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f79a3b5_9ac5a60c","line":158,"range":{"start_line":155,"start_character":1,"end_line":158,"end_character":22},"in_reply_to":"3f79a3b5_847d52e7","updated":"2018-10-03 19:16:03.000000000","message":"Done","commit_id":"1a5090f196ba71f8b71e37351c57e13714eb210c"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"0498d6c9d8b989cd81de136a032672aad1119959","unresolved":false,"context_lines":[{"line_number":186,"context_line":"  $rx_queue_size                              \u003d $::os_service_default,"},{"line_number":187,"context_line":"  $tx_queue_size                              \u003d $::os_service_default,"},{"line_number":188,"context_line":"  $file_backed_memory                         \u003d undef,"},{"line_number":189,"context_line":"  $volume_use_multipath                       \u003d false,"},{"line_number":190,"context_line":") inherits nova::params {"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"  include ::nova::deps"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f79a3b5_446bba1d","line":189,"range":{"start_line":189,"start_character":48,"end_line":189,"end_character":53},"updated":"2018-10-03 15:52:22.000000000","message":"please use $::os_service_default","commit_id":"1a5090f196ba71f8b71e37351c57e13714eb210c"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"8ac81919732c618e1126471d21fc2a7e1204871a","unresolved":false,"context_lines":[{"line_number":186,"context_line":"  $rx_queue_size                              \u003d $::os_service_default,"},{"line_number":187,"context_line":"  $tx_queue_size                              \u003d $::os_service_default,"},{"line_number":188,"context_line":"  $file_backed_memory                         \u003d undef,"},{"line_number":189,"context_line":"  $volume_use_multipath                       \u003d false,"},{"line_number":190,"context_line":") inherits nova::params {"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"  include ::nova::deps"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f79a3b5_3ad492ba","line":189,"range":{"start_line":189,"start_character":48,"end_line":189,"end_character":53},"in_reply_to":"3f79a3b5_446bba1d","updated":"2018-10-03 19:16:03.000000000","message":"Done","commit_id":"1a5090f196ba71f8b71e37351c57e13714eb210c"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"0498d6c9d8b989cd81de136a032672aad1119959","unresolved":false,"context_lines":[{"line_number":341,"context_line":"      \u0027DEFAULT/remove_unused_original_minimum_age_seconds\u0027: ensure \u003d\u003e absent;"},{"line_number":342,"context_line":"    }"},{"line_number":343,"context_line":"  }"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f79a3b5_246c7e31","line":344,"updated":"2018-10-03 15:52:22.000000000","message":"?","commit_id":"1a5090f196ba71f8b71e37351c57e13714eb210c"}],"spec/classes/nova_compute_libvirt_spec.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"2c55948a7537258f5da491e74eda52fd8fcd73bb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      it { is_expected.to contain_nova_config(\u0027libvirt/remove_unused_resized_minimum_age_seconds\u0027).with_ensure(\u0027absent\u0027)}"},{"line_number":65,"context_line":"      it { is_expected.to contain_nova_config(\u0027libvirt/rx_queue_size\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)}"},{"line_number":66,"context_line":"      it { is_expected.to contain_nova_config(\u0027libvirt/tx_queue_size\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)}"},{"line_number":67,"context_line":"      it { is_expected.to contain_nova_config(\u0027libvirt/volume_use_multipath\u0027).with_value(false)}"},{"line_number":68,"context_line":"    end"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    describe \u0027with params\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"3f79a3b5_75dc3045","line":67,"range":{"start_line":67,"start_character":89,"end_line":67,"end_character":94},"updated":"2018-10-05 11:34:21.000000000","message":"Hm, something must be wrong with the testing. Should this be catching the $::os_service_default default value.","commit_id":"9a32936099d05d62effe73232c8190c1a1ba27e7"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"ddbb96844d3376db498dfa78df0b709202df7ca5","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      it { is_expected.to contain_nova_config(\u0027libvirt/remove_unused_resized_minimum_age_seconds\u0027).with_ensure(\u0027absent\u0027)}"},{"line_number":65,"context_line":"      it { is_expected.to contain_nova_config(\u0027libvirt/rx_queue_size\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)}"},{"line_number":66,"context_line":"      it { is_expected.to contain_nova_config(\u0027libvirt/tx_queue_size\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)}"},{"line_number":67,"context_line":"      it { is_expected.to contain_nova_config(\u0027libvirt/volume_use_multipath\u0027).with_value(false)}"},{"line_number":68,"context_line":"    end"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    describe \u0027with params\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"3f79a3b5_7f125157","line":67,"range":{"start_line":67,"start_character":89,"end_line":67,"end_character":94},"in_reply_to":"3f79a3b5_75dc3045","updated":"2018-10-11 14:39:15.000000000","message":"Fixed","commit_id":"9a32936099d05d62effe73232c8190c1a1ba27e7"}]}