)]}'
{"manifests/api.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"732f0d6a8935bf529d3492cfc9b8005443c340a1","unresolved":false,"context_lines":[{"line_number":379,"context_line":"  if !$nova_metadata_wsgi_enabled {"},{"line_number":380,"context_line":"    warning(\u0027Vendordata parameters are deprecated in nova::api, nova::vendordata should be used instead.\u0027)"},{"line_number":381,"context_line":"    class { \u0027::nova::vendordata\u0027:"},{"line_number":382,"context_line":"      vendordata_jsonfile_path                    \u003d\u003e $vendordata_jsonfile_path,"},{"line_number":383,"context_line":"      vendordata_providers                        \u003d\u003e $vendordata_providers,"},{"line_number":384,"context_line":"      vendordata_dynamic_targets                  \u003d\u003e $vendordata_dynamic_targets,"},{"line_number":385,"context_line":"      vendordata_dynamic_connect_timeout          \u003d\u003e $vendordata_dynamic_connect_timeout,"},{"line_number":386,"context_line":"      vendordata_dynamic_read_timeout             \u003d\u003e $vendordata_dynamic_read_timeout,"},{"line_number":387,"context_line":"      vendordata_dynamic_failure_fatal            \u003d\u003e $vendordata_dynamic_failure_fatal,"},{"line_number":388,"context_line":"      vendordata_dynamic_auth_auth_type           \u003d\u003e $vendordata_dynamic_auth_auth_type,"},{"line_number":389,"context_line":"      vendordata_dynamic_auth_auth_url            \u003d\u003e $vendordata_dynamic_auth_auth_url,"},{"line_number":390,"context_line":"      vendordata_dynamic_auth_os_region_name      \u003d\u003e $vendordata_dynamic_auth_os_region_name,"},{"line_number":391,"context_line":"      vendordata_dynamic_auth_password            \u003d\u003e $vendordata_dynamic_auth_password,"},{"line_number":392,"context_line":"      vendordata_dynamic_auth_project_domain_name \u003d\u003e $vendordata_dynamic_auth_project_domain_name,"},{"line_number":393,"context_line":"      vendordata_dynamic_auth_project_name        \u003d\u003e $vendordata_dynamic_auth_project_name,"},{"line_number":394,"context_line":"      vendordata_dynamic_auth_user_domain_name    \u003d\u003e $vendordata_dynamic_auth_user_domain_name,"},{"line_number":395,"context_line":"      vendordata_dynamic_auth_username            \u003d\u003e $vendordata_dynamic_auth_username,"},{"line_number":396,"context_line":"    }"},{"line_number":397,"context_line":"    nova_config {"},{"line_number":398,"context_line":"      \u0027DEFAULT/enabled_apis\u0027:                        value \u003d\u003e join($enabled_apis_real, \u0027,\u0027);"},{"line_number":399,"context_line":"      \u0027DEFAULT/metadata_workers\u0027:                    value \u003d\u003e $metadata_workers;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_8acb6d71","line":396,"range":{"start_line":382,"start_character":0,"end_line":396,"end_character":5},"updated":"2018-10-24 09:55:43.000000000","message":"what if we don\u0027t pass all off these parameters and instead call:\n\ninclude ::nova::vendordata\n\nAnd assume that those parameters are passed via hieradata","commit_id":"923b618948c994f4f395ff373963a38b8449f2cb"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"5f97a809ddd591d504e09de7dcd21121bab9a2d3","unresolved":false,"context_lines":[{"line_number":379,"context_line":"  if !$nova_metadata_wsgi_enabled {"},{"line_number":380,"context_line":"    warning(\u0027Vendordata parameters are deprecated in nova::api, nova::vendordata should be used instead.\u0027)"},{"line_number":381,"context_line":"    class { \u0027::nova::vendordata\u0027:"},{"line_number":382,"context_line":"      vendordata_jsonfile_path                    \u003d\u003e $vendordata_jsonfile_path,"},{"line_number":383,"context_line":"      vendordata_providers                        \u003d\u003e $vendordata_providers,"},{"line_number":384,"context_line":"      vendordata_dynamic_targets                  \u003d\u003e $vendordata_dynamic_targets,"},{"line_number":385,"context_line":"      vendordata_dynamic_connect_timeout          \u003d\u003e $vendordata_dynamic_connect_timeout,"},{"line_number":386,"context_line":"      vendordata_dynamic_read_timeout             \u003d\u003e $vendordata_dynamic_read_timeout,"},{"line_number":387,"context_line":"      vendordata_dynamic_failure_fatal            \u003d\u003e $vendordata_dynamic_failure_fatal,"},{"line_number":388,"context_line":"      vendordata_dynamic_auth_auth_type           \u003d\u003e $vendordata_dynamic_auth_auth_type,"},{"line_number":389,"context_line":"      vendordata_dynamic_auth_auth_url            \u003d\u003e $vendordata_dynamic_auth_auth_url,"},{"line_number":390,"context_line":"      vendordata_dynamic_auth_os_region_name      \u003d\u003e $vendordata_dynamic_auth_os_region_name,"},{"line_number":391,"context_line":"      vendordata_dynamic_auth_password            \u003d\u003e $vendordata_dynamic_auth_password,"},{"line_number":392,"context_line":"      vendordata_dynamic_auth_project_domain_name \u003d\u003e $vendordata_dynamic_auth_project_domain_name,"},{"line_number":393,"context_line":"      vendordata_dynamic_auth_project_name        \u003d\u003e $vendordata_dynamic_auth_project_name,"},{"line_number":394,"context_line":"      vendordata_dynamic_auth_user_domain_name    \u003d\u003e $vendordata_dynamic_auth_user_domain_name,"},{"line_number":395,"context_line":"      vendordata_dynamic_auth_username            \u003d\u003e $vendordata_dynamic_auth_username,"},{"line_number":396,"context_line":"    }"},{"line_number":397,"context_line":"    nova_config {"},{"line_number":398,"context_line":"      \u0027DEFAULT/enabled_apis\u0027:                        value \u003d\u003e join($enabled_apis_real, \u0027,\u0027);"},{"line_number":399,"context_line":"      \u0027DEFAULT/metadata_workers\u0027:                    value \u003d\u003e $metadata_workers;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_ea80e1f8","line":396,"range":{"start_line":382,"start_character":0,"end_line":396,"end_character":5},"in_reply_to":"3f79a3b5_8acb6d71","updated":"2018-10-24 09:59:01.000000000","message":"we could do that, but I thought it would be nice for a user to have it for a release with deprecation note. But I am open for this.","commit_id":"923b618948c994f4f395ff373963a38b8449f2cb"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"434dd4496a00c41c66ddf184f0b039d4258294fa","unresolved":false,"context_lines":[{"line_number":379,"context_line":"  if !$nova_metadata_wsgi_enabled {"},{"line_number":380,"context_line":"    warning(\u0027Vendordata parameters are deprecated in nova::api, nova::vendordata should be used instead.\u0027)"},{"line_number":381,"context_line":"    class { \u0027::nova::vendordata\u0027:"},{"line_number":382,"context_line":"      vendordata_jsonfile_path                    \u003d\u003e $vendordata_jsonfile_path,"},{"line_number":383,"context_line":"      vendordata_providers                        \u003d\u003e $vendordata_providers,"},{"line_number":384,"context_line":"      vendordata_dynamic_targets                  \u003d\u003e $vendordata_dynamic_targets,"},{"line_number":385,"context_line":"      vendordata_dynamic_connect_timeout          \u003d\u003e $vendordata_dynamic_connect_timeout,"},{"line_number":386,"context_line":"      vendordata_dynamic_read_timeout             \u003d\u003e $vendordata_dynamic_read_timeout,"},{"line_number":387,"context_line":"      vendordata_dynamic_failure_fatal            \u003d\u003e $vendordata_dynamic_failure_fatal,"},{"line_number":388,"context_line":"      vendordata_dynamic_auth_auth_type           \u003d\u003e $vendordata_dynamic_auth_auth_type,"},{"line_number":389,"context_line":"      vendordata_dynamic_auth_auth_url            \u003d\u003e $vendordata_dynamic_auth_auth_url,"},{"line_number":390,"context_line":"      vendordata_dynamic_auth_os_region_name      \u003d\u003e $vendordata_dynamic_auth_os_region_name,"},{"line_number":391,"context_line":"      vendordata_dynamic_auth_password            \u003d\u003e $vendordata_dynamic_auth_password,"},{"line_number":392,"context_line":"      vendordata_dynamic_auth_project_domain_name \u003d\u003e $vendordata_dynamic_auth_project_domain_name,"},{"line_number":393,"context_line":"      vendordata_dynamic_auth_project_name        \u003d\u003e $vendordata_dynamic_auth_project_name,"},{"line_number":394,"context_line":"      vendordata_dynamic_auth_user_domain_name    \u003d\u003e $vendordata_dynamic_auth_user_domain_name,"},{"line_number":395,"context_line":"      vendordata_dynamic_auth_username            \u003d\u003e $vendordata_dynamic_auth_username,"},{"line_number":396,"context_line":"    }"},{"line_number":397,"context_line":"    nova_config {"},{"line_number":398,"context_line":"      \u0027DEFAULT/enabled_apis\u0027:                        value \u003d\u003e join($enabled_apis_real, \u0027,\u0027);"},{"line_number":399,"context_line":"      \u0027DEFAULT/metadata_workers\u0027:                    value \u003d\u003e $metadata_workers;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_6aba91ba","line":396,"range":{"start_line":382,"start_character":0,"end_line":396,"end_character":5},"in_reply_to":"3f79a3b5_ea80e1f8","updated":"2018-10-24 10:03:10.000000000","message":"Well, I think this can stay here... for legacy reasons.","commit_id":"923b618948c994f4f395ff373963a38b8449f2cb"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"080ed833ecf403ae7cda090bb78404f668ecca01","unresolved":false,"context_lines":[{"line_number":377,"context_line":"  }"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"  if !$nova_metadata_wsgi_enabled {"},{"line_number":380,"context_line":"    warning(\u0027Vendordata parameters are deprecated in nova::api, nova::vendordata should be used instead.\u0027)"},{"line_number":381,"context_line":"    include ::nova::vendordata"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    nova_config {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f79a3b5_427771a0","line":380,"range":{"start_line":380,"start_character":4,"end_line":380,"end_character":106},"updated":"2018-10-24 17:25:37.000000000","message":"here","commit_id":"2bb42072d9ebbf5e0563cff1ce6ee20015176d93"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2a930bf46263ec30d44e65bb574e6582fc1f4ed0","unresolved":false,"context_lines":[{"line_number":391,"context_line":"                      $vendordata_dynamic_auth_project_name,"},{"line_number":392,"context_line":"                      $vendordata_dynamic_auth_user_domain_name,"},{"line_number":393,"context_line":"                      $vendordata_dynamic_auth_username,"},{"line_number":394,"context_line":"                      undef))){"},{"line_number":395,"context_line":"      warning(\u0027Vendordata parameters are deprecated in nova::metadata, nova::vendordata should be used instead.\u0027)"},{"line_number":396,"context_line":"      class { \u0027::nova::vendordata\u0027:"},{"line_number":397,"context_line":"        vendordata_caller \u003d\u003e \u0027api\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3f79a3b5_6bb4ac81","line":394,"range":{"start_line":394,"start_character":22,"end_line":394,"end_character":27},"updated":"2018-10-25 20:35:05.000000000","message":"I thought pick didn\u0027t like undef as the final value.  You can do....\n\nif (length(delete_undef_values([$vendordata_jsonfile_path,\n                      $vendordata_providers,\n                      $vendordata_dynamic_targets,\n                      $vendordata_dynamic_connect_timeout,\n                      $vendordata_dynamic_read_timeout,\n                      $vendordata_dynamic_failure_fatal,\n                      $vendordata_dynamic_auth_auth_type,\n                      $vendordata_dynamic_auth_auth_url,\n                      $vendordata_dynamic_auth_os_region_name,\n                      $vendordata_dynamic_auth_password,\n                      $vendordata_dynamic_auth_project_domain_name,\n                      $vendordata_dynamic_auth_project_name,\n                      $vendordata_dynamic_auth_user_domain_name,\n                      $vendordata_dynamic_auth_username])) \u003e 0 {\n...\n\n}","commit_id":"7fdb34ce7112f2803a606a2e9f115505d65a9b28"}],"manifests/compute.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"080ed833ecf403ae7cda090bb78404f668ecca01","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"  include ::nova::pci"},{"line_number":232,"context_line":"  include ::nova::compute::vgpu"},{"line_number":233,"context_line":"  include ::nova::vendordata"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"  if ($vnc_enabled and $spice_enabled) {"},{"line_number":236,"context_line":"    fail(\u0027vnc_enabled and spice_enabled is mutually exclusive\u0027)"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f79a3b5_026df9c9","line":233,"updated":"2018-10-24 17:25:37.000000000","message":"could we add testing for this?","commit_id":"2bb42072d9ebbf5e0563cff1ce6ee20015176d93"}],"manifests/metadata.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"732f0d6a8935bf529d3492cfc9b8005443c340a1","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"  warning(\u0027Vendordata parameters are deprecated in nova::metadata, nova::vendordata should be used instead.\u0027)"},{"line_number":119,"context_line":"  class { \u0027::nova::vendordata\u0027:"},{"line_number":120,"context_line":"    vendordata_jsonfile_path                    \u003d\u003e $vendordata_jsonfile_path,"},{"line_number":121,"context_line":"    vendordata_providers                        \u003d\u003e $vendordata_providers,"},{"line_number":122,"context_line":"    vendordata_dynamic_targets                  \u003d\u003e $vendordata_dynamic_targets,"},{"line_number":123,"context_line":"    vendordata_dynamic_connect_timeout          \u003d\u003e $vendordata_dynamic_connect_timeout,"},{"line_number":124,"context_line":"    vendordata_dynamic_read_timeout             \u003d\u003e $vendordata_dynamic_read_timeout,"},{"line_number":125,"context_line":"    vendordata_dynamic_failure_fatal            \u003d\u003e $vendordata_dynamic_failure_fatal,"},{"line_number":126,"context_line":"    vendordata_dynamic_auth_auth_type           \u003d\u003e $vendordata_dynamic_auth_auth_type,"},{"line_number":127,"context_line":"    vendordata_dynamic_auth_auth_url            \u003d\u003e $vendordata_dynamic_auth_auth_url,"},{"line_number":128,"context_line":"    vendordata_dynamic_auth_os_region_name      \u003d\u003e $vendordata_dynamic_auth_os_region_name,"},{"line_number":129,"context_line":"    vendordata_dynamic_auth_password            \u003d\u003e $vendordata_dynamic_auth_password,"},{"line_number":130,"context_line":"    vendordata_dynamic_auth_project_domain_name \u003d\u003e $vendordata_dynamic_auth_project_domain_name,"},{"line_number":131,"context_line":"    vendordata_dynamic_auth_project_name        \u003d\u003e $vendordata_dynamic_auth_project_name,"},{"line_number":132,"context_line":"    vendordata_dynamic_auth_user_domain_name    \u003d\u003e $vendordata_dynamic_auth_user_domain_name,"},{"line_number":133,"context_line":"    vendordata_dynamic_auth_username            \u003d\u003e $vendordata_dynamic_auth_username,"},{"line_number":134,"context_line":"  }"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  nova_config {"},{"line_number":137,"context_line":"    \u0027DEFAULT/enabled_apis\u0027:                        value \u003d\u003e $enabled_apis;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_aac8a974","line":134,"range":{"start_line":120,"start_character":0,"end_line":134,"end_character":3},"updated":"2018-10-24 09:55:43.000000000","message":"same comment as in the api manifest.","commit_id":"923b618948c994f4f395ff373963a38b8449f2cb"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"a835b9fa1fc52753a216bcd4bcfa139abb480c31","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"  warning(\u0027Vendordata parameters are deprecated in nova::metadata, nova::vendordata should be used instead.\u0027)"},{"line_number":119,"context_line":"  class { \u0027::nova::vendordata\u0027:"},{"line_number":120,"context_line":"    vendordata_jsonfile_path                    \u003d\u003e $vendordata_jsonfile_path,"},{"line_number":121,"context_line":"    vendordata_providers                        \u003d\u003e $vendordata_providers,"},{"line_number":122,"context_line":"    vendordata_dynamic_targets                  \u003d\u003e $vendordata_dynamic_targets,"},{"line_number":123,"context_line":"    vendordata_dynamic_connect_timeout          \u003d\u003e $vendordata_dynamic_connect_timeout,"},{"line_number":124,"context_line":"    vendordata_dynamic_read_timeout             \u003d\u003e $vendordata_dynamic_read_timeout,"},{"line_number":125,"context_line":"    vendordata_dynamic_failure_fatal            \u003d\u003e $vendordata_dynamic_failure_fatal,"},{"line_number":126,"context_line":"    vendordata_dynamic_auth_auth_type           \u003d\u003e $vendordata_dynamic_auth_auth_type,"},{"line_number":127,"context_line":"    vendordata_dynamic_auth_auth_url            \u003d\u003e $vendordata_dynamic_auth_auth_url,"},{"line_number":128,"context_line":"    vendordata_dynamic_auth_os_region_name      \u003d\u003e $vendordata_dynamic_auth_os_region_name,"},{"line_number":129,"context_line":"    vendordata_dynamic_auth_password            \u003d\u003e $vendordata_dynamic_auth_password,"},{"line_number":130,"context_line":"    vendordata_dynamic_auth_project_domain_name \u003d\u003e $vendordata_dynamic_auth_project_domain_name,"},{"line_number":131,"context_line":"    vendordata_dynamic_auth_project_name        \u003d\u003e $vendordata_dynamic_auth_project_name,"},{"line_number":132,"context_line":"    vendordata_dynamic_auth_user_domain_name    \u003d\u003e $vendordata_dynamic_auth_user_domain_name,"},{"line_number":133,"context_line":"    vendordata_dynamic_auth_username            \u003d\u003e $vendordata_dynamic_auth_username,"},{"line_number":134,"context_line":"  }"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  nova_config {"},{"line_number":137,"context_line":"    \u0027DEFAULT/enabled_apis\u0027:                        value \u003d\u003e $enabled_apis;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_05498e64","line":134,"range":{"start_line":120,"start_character":0,"end_line":134,"end_character":3},"in_reply_to":"3f79a3b5_8ad60dc4","updated":"2018-10-24 10:26:18.000000000","message":"maybe its ok as we\u0027d also need to backport it to rocky where we introduced it.","commit_id":"923b618948c994f4f395ff373963a38b8449f2cb"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"434dd4496a00c41c66ddf184f0b039d4258294fa","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"  warning(\u0027Vendordata parameters are deprecated in nova::metadata, nova::vendordata should be used instead.\u0027)"},{"line_number":119,"context_line":"  class { \u0027::nova::vendordata\u0027:"},{"line_number":120,"context_line":"    vendordata_jsonfile_path                    \u003d\u003e $vendordata_jsonfile_path,"},{"line_number":121,"context_line":"    vendordata_providers                        \u003d\u003e $vendordata_providers,"},{"line_number":122,"context_line":"    vendordata_dynamic_targets                  \u003d\u003e $vendordata_dynamic_targets,"},{"line_number":123,"context_line":"    vendordata_dynamic_connect_timeout          \u003d\u003e $vendordata_dynamic_connect_timeout,"},{"line_number":124,"context_line":"    vendordata_dynamic_read_timeout             \u003d\u003e $vendordata_dynamic_read_timeout,"},{"line_number":125,"context_line":"    vendordata_dynamic_failure_fatal            \u003d\u003e $vendordata_dynamic_failure_fatal,"},{"line_number":126,"context_line":"    vendordata_dynamic_auth_auth_type           \u003d\u003e $vendordata_dynamic_auth_auth_type,"},{"line_number":127,"context_line":"    vendordata_dynamic_auth_auth_url            \u003d\u003e $vendordata_dynamic_auth_auth_url,"},{"line_number":128,"context_line":"    vendordata_dynamic_auth_os_region_name      \u003d\u003e $vendordata_dynamic_auth_os_region_name,"},{"line_number":129,"context_line":"    vendordata_dynamic_auth_password            \u003d\u003e $vendordata_dynamic_auth_password,"},{"line_number":130,"context_line":"    vendordata_dynamic_auth_project_domain_name \u003d\u003e $vendordata_dynamic_auth_project_domain_name,"},{"line_number":131,"context_line":"    vendordata_dynamic_auth_project_name        \u003d\u003e $vendordata_dynamic_auth_project_name,"},{"line_number":132,"context_line":"    vendordata_dynamic_auth_user_domain_name    \u003d\u003e $vendordata_dynamic_auth_user_domain_name,"},{"line_number":133,"context_line":"    vendordata_dynamic_auth_username            \u003d\u003e $vendordata_dynamic_auth_username,"},{"line_number":134,"context_line":"  }"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  nova_config {"},{"line_number":137,"context_line":"    \u0027DEFAULT/enabled_apis\u0027:                        value \u003d\u003e $enabled_apis;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_eafc6172","line":134,"range":{"start_line":120,"start_character":0,"end_line":134,"end_character":3},"in_reply_to":"3f79a3b5_aac8a974","updated":"2018-10-24 10:03:10.000000000","message":"Given this is fairly new, I would say we do switch to just using include ::nova::vendordata. And also add that to the nova::compute manifest.\n\nany thoughts?","commit_id":"923b618948c994f4f395ff373963a38b8449f2cb"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"6bf661e71a26f4e6fac05618f11d215b0f844361","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"  warning(\u0027Vendordata parameters are deprecated in nova::metadata, nova::vendordata should be used instead.\u0027)"},{"line_number":119,"context_line":"  class { \u0027::nova::vendordata\u0027:"},{"line_number":120,"context_line":"    vendordata_jsonfile_path                    \u003d\u003e $vendordata_jsonfile_path,"},{"line_number":121,"context_line":"    vendordata_providers                        \u003d\u003e $vendordata_providers,"},{"line_number":122,"context_line":"    vendordata_dynamic_targets                  \u003d\u003e $vendordata_dynamic_targets,"},{"line_number":123,"context_line":"    vendordata_dynamic_connect_timeout          \u003d\u003e $vendordata_dynamic_connect_timeout,"},{"line_number":124,"context_line":"    vendordata_dynamic_read_timeout             \u003d\u003e $vendordata_dynamic_read_timeout,"},{"line_number":125,"context_line":"    vendordata_dynamic_failure_fatal            \u003d\u003e $vendordata_dynamic_failure_fatal,"},{"line_number":126,"context_line":"    vendordata_dynamic_auth_auth_type           \u003d\u003e $vendordata_dynamic_auth_auth_type,"},{"line_number":127,"context_line":"    vendordata_dynamic_auth_auth_url            \u003d\u003e $vendordata_dynamic_auth_auth_url,"},{"line_number":128,"context_line":"    vendordata_dynamic_auth_os_region_name      \u003d\u003e $vendordata_dynamic_auth_os_region_name,"},{"line_number":129,"context_line":"    vendordata_dynamic_auth_password            \u003d\u003e $vendordata_dynamic_auth_password,"},{"line_number":130,"context_line":"    vendordata_dynamic_auth_project_domain_name \u003d\u003e $vendordata_dynamic_auth_project_domain_name,"},{"line_number":131,"context_line":"    vendordata_dynamic_auth_project_name        \u003d\u003e $vendordata_dynamic_auth_project_name,"},{"line_number":132,"context_line":"    vendordata_dynamic_auth_user_domain_name    \u003d\u003e $vendordata_dynamic_auth_user_domain_name,"},{"line_number":133,"context_line":"    vendordata_dynamic_auth_username            \u003d\u003e $vendordata_dynamic_auth_username,"},{"line_number":134,"context_line":"  }"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  nova_config {"},{"line_number":137,"context_line":"    \u0027DEFAULT/enabled_apis\u0027:                        value \u003d\u003e $enabled_apis;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_8ad60dc4","line":134,"range":{"start_line":120,"start_character":0,"end_line":134,"end_character":3},"in_reply_to":"3f79a3b5_eafc6172","updated":"2018-10-24 10:12:29.000000000","message":"I\u0027ve added it to nova::compute. Other thoughts to just include nova::vendordata instead of having it still for a release?","commit_id":"923b618948c994f4f395ff373963a38b8449f2cb"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"bc7d5fee1a7c71312425ce8366517d3ad3127054","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"  warning(\u0027Vendordata parameters are deprecated in nova::metadata, nova::vendordata should be used instead.\u0027)"},{"line_number":119,"context_line":"  class { \u0027::nova::vendordata\u0027:"},{"line_number":120,"context_line":"    vendordata_jsonfile_path                    \u003d\u003e $vendordata_jsonfile_path,"},{"line_number":121,"context_line":"    vendordata_providers                        \u003d\u003e $vendordata_providers,"},{"line_number":122,"context_line":"    vendordata_dynamic_targets                  \u003d\u003e $vendordata_dynamic_targets,"},{"line_number":123,"context_line":"    vendordata_dynamic_connect_timeout          \u003d\u003e $vendordata_dynamic_connect_timeout,"},{"line_number":124,"context_line":"    vendordata_dynamic_read_timeout             \u003d\u003e $vendordata_dynamic_read_timeout,"},{"line_number":125,"context_line":"    vendordata_dynamic_failure_fatal            \u003d\u003e $vendordata_dynamic_failure_fatal,"},{"line_number":126,"context_line":"    vendordata_dynamic_auth_auth_type           \u003d\u003e $vendordata_dynamic_auth_auth_type,"},{"line_number":127,"context_line":"    vendordata_dynamic_auth_auth_url            \u003d\u003e $vendordata_dynamic_auth_auth_url,"},{"line_number":128,"context_line":"    vendordata_dynamic_auth_os_region_name      \u003d\u003e $vendordata_dynamic_auth_os_region_name,"},{"line_number":129,"context_line":"    vendordata_dynamic_auth_password            \u003d\u003e $vendordata_dynamic_auth_password,"},{"line_number":130,"context_line":"    vendordata_dynamic_auth_project_domain_name \u003d\u003e $vendordata_dynamic_auth_project_domain_name,"},{"line_number":131,"context_line":"    vendordata_dynamic_auth_project_name        \u003d\u003e $vendordata_dynamic_auth_project_name,"},{"line_number":132,"context_line":"    vendordata_dynamic_auth_user_domain_name    \u003d\u003e $vendordata_dynamic_auth_user_domain_name,"},{"line_number":133,"context_line":"    vendordata_dynamic_auth_username            \u003d\u003e $vendordata_dynamic_auth_username,"},{"line_number":134,"context_line":"  }"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  nova_config {"},{"line_number":137,"context_line":"    \u0027DEFAULT/enabled_apis\u0027:                        value \u003d\u003e $enabled_apis;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_65588224","line":134,"range":{"start_line":120,"start_character":0,"end_line":134,"end_character":3},"updated":"2018-10-24 10:29:48.000000000","message":"we would like some feedback from other folks on this: should it be kept as it is? or should it be changed to:\n\ninclude ::metadata::vendodata\n\n?","commit_id":"dc515d6ad7c98029307d228ce50f0037b8e15e74"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"080ed833ecf403ae7cda090bb78404f668ecca01","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  include ::nova::db"},{"line_number":116,"context_line":"  include ::nova::keystone::authtoken"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"  warning(\u0027Vendordata parameters are deprecated in nova::metadata, nova::vendordata should be used instead.\u0027)"},{"line_number":119,"context_line":"  include ::nova::vendordata"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  nova_config {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f79a3b5_a26525e4","line":118,"range":{"start_line":118,"start_character":2,"end_line":118,"end_character":109},"updated":"2018-10-24 17:25:37.000000000","message":"and here","commit_id":"2bb42072d9ebbf5e0563cff1ce6ee20015176d93"}],"manifests/vendordata.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"080ed833ecf403ae7cda090bb78404f668ecca01","unresolved":false,"context_lines":[{"line_number":88,"context_line":") inherits nova::params {"},{"line_number":89,"context_line":"  include ::nova::deps"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  # NOTE(mschuppert): In order to keep backward compatibility we rely on the pick function"},{"line_number":92,"context_line":"  if defined(\u0027$::nova::api::nova_metadata_wsgi_enabled\u0027){"},{"line_number":93,"context_line":"    $nova_metadata_wsgi_enabled \u003d pick($::nova::api::nova_metadata_wsgi_enabled, false)"},{"line_number":94,"context_line":"    if $nova_metadata_wsgi_enabled {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f79a3b5_e29c7dbf","line":91,"updated":"2018-10-24 17:25:37.000000000","message":"Could we make this a TODO","commit_id":"2bb42072d9ebbf5e0563cff1ce6ee20015176d93"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"31b1abb9a1db4af2d8116cf09750ce74163de82e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  $vendordata_dynamic_auth_username            \u003d $::os_service_default,"},{"line_number":96,"context_line":"  # DEPRECATED"},{"line_number":97,"context_line":"  $vendordata_caller                           \u003d undef,"},{"line_number":98,"context_line":") inherits nova::params {"},{"line_number":99,"context_line":"  include ::nova::deps"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  # TODO(mschuppert): In order to keep backward compatibility we rely on the"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3f79a3b5_fab29a30","line":98,"range":{"start_line":98,"start_character":2,"end_line":98,"end_character":23},"updated":"2018-10-29 10:14:59.000000000","message":"Shouldn\u0027t need this since we dont use any params in this class.","commit_id":"6686406bce9e7fc9623dea130daa3f16c0f93905"}],"spec/classes/nova_api_spec.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"31b1abb9a1db4af2d8116cf09750ce74163de82e","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        is_expected.to contain_nova_config(\u0027neutron/metadata_proxy_shared_secret\u0027).with(:ensure \u003d\u003e \u0027absent\u0027)"},{"line_number":87,"context_line":"      end"},{"line_number":88,"context_line":"    end"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    context \u0027with overridden parameters\u0027 do"},{"line_number":91,"context_line":"      before do"},{"line_number":92,"context_line":"        params.merge!({"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"3f79a3b5_1a475620","side":"PARENT","line":89,"updated":"2018-10-29 10:14:59.000000000","message":"Since we just removed all testing for vendordata parameters in this class, we should add a context here that tests setting values from this class and make sure it configures the correct parameters when set in nova::vendordata.\n\nThis way we can ensure the pick()\u0027s are working correctly and should also safe us from any potential ways somebody could cause a \"resource already exists\" error.","commit_id":"12d59ac8748053ae73962769fe1ee1b07f79887d"}],"spec/classes/nova_metadata_spec.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"31b1abb9a1db4af2d8116cf09750ce74163de82e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        is_expected.to contain_nova_config(\u0027neutron/metadata_proxy_shared_secret\u0027).with(:ensure \u003d\u003e \u0027absent\u0027)"},{"line_number":48,"context_line":"      end"},{"line_number":49,"context_line":"    end"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    context \u0027with overridden parameters\u0027 do"},{"line_number":52,"context_line":"      before do"},{"line_number":53,"context_line":"        params.merge!({"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"3f79a3b5_da4c7e41","side":"PARENT","line":50,"updated":"2018-10-29 10:14:59.000000000","message":"Same here, we should add context check for setting these in nova::metadata.","commit_id":"12d59ac8748053ae73962769fe1ee1b07f79887d"}]}