)]}'
{"manifests/compute/libvirt/qemu.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4693df1a8d776fa2b75477bb1cb1feb1e0c3e57b","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    augeas { \u0027qemu-conf-limits\u0027:"},{"line_number":131,"context_line":"      context \u003d\u003e \u0027/files/etc/libvirt/qemu.conf\u0027,"},{"line_number":132,"context_line":"      changes \u003d\u003e $augues_changes,"},{"line_number":133,"context_line":"      tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"},{"line_number":134,"context_line":"    }"},{"line_number":135,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_35523839","line":132,"range":{"start_line":132,"start_character":18,"end_line":132,"end_character":24},"updated":"2018-12-12 15:02:37.000000000","message":"i just noticed the type in this var. oh well","commit_id":"80d0c00d54bc1c7cde03d205145c56a2f4e28519"}],"manifests/compute/libvirt/version.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8f4fc452181e7a8fd17a286021992392c47364f6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Try to detect the version by OS"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"class nova::compute::libvirt::version {"},{"line_number":6,"context_line":"  # This will be 7.5 or 7.6 on RedHat, 9 on Debian, 18.10 or cosmic on Ubuntu, etc."},{"line_number":7,"context_line":"  $osr_array \u003d split($::operatingsystemrelease,\u0027[\\/\\.]\u0027)"},{"line_number":8,"context_line":"  if length($osr_array) \u003e 1 {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_ea46567e","line":5,"updated":"2018-11-27 17:47:10.000000000","message":"I really don\u0027t like this but I know we can\u0027t really detect this prior to installation.","commit_id":"bdf50eee43c2e1020b0724ee325deecd697a20d8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8f4fc452181e7a8fd17a286021992392c47364f6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    fail(\"Class[\u0027nova::compute::libvirt::version\u0027]: Unparsable \\$::operatingsystemrelease: ${::operatingsystemrelease}\")"},{"line_number":16,"context_line":"  }"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  case $::osfamily {"},{"line_number":19,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":20,"context_line":"      if ($::operatingsystem \u003d\u003d \u0027Fedora\u0027 and versioncmp($distrelease, \u002729\u0027) \u003e\u003d 0) or ($::operatingsystem !\u003d \u0027Fedora\u0027 and versioncmp($distrelease, \u00277.6\u0027) \u003e\u003d 0) {"},{"line_number":21,"context_line":"        $default \u003d \u00274.5\u0027"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_0a4ab280","line":18,"updated":"2018-11-27 17:47:10.000000000","message":"You might want to use the new $::os facts instead of doing all this parsing. as much of this is already available\n\nFrom a facter -p:\nos \u003d\u003e {\"name\"\u003d\u003e\"RedHat\", \"family\"\u003d\u003e\"RedHat\", \"release\"\u003d\u003e{\"major\"\u003d\u003e\"7\", \"minor\"\u003d\u003e\"5\", \"full\"\u003d\u003e\"7.5\"}, \"lsb\"\u003d\u003e{\"distcodename\"\u003d\u003e\"Maipo\", \"distid\"\u003d\u003e\"RedHatEnterpriseWorkstation\", \"distdescription\"\u003d\u003e\"Red Hat Enterprise Linux Workstation release 7.5 (Maipo)\", \"release\"\u003d\u003e\":core-4.1-amd64:core-4.1-noarch:cxx-4.1-amd64:cxx-4.1-noarch:desktop-4.1-amd64:desktop-4.1-noarch:languages-4.1-amd64:languages-4.1-noarch:printing-4.1-amd64:printing-4.1-noarch\", \"distrelease\"\u003d\u003e\"7.5\", \"majdistrelease\"\u003d\u003e\"7\", \"minordistrelease\"\u003d\u003e\"5\"}}","commit_id":"bdf50eee43c2e1020b0724ee325deecd697a20d8"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"bad13964ac22a431c108e4760c5c65a9fd63f99c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":12,"context_line":"      case $facts[\u0027os\u0027][\u0027name\u0027] {"},{"line_number":13,"context_line":"        \u0027RedHat\u0027: {"},{"line_number":14,"context_line":"          if versioncmp($facts[\u0027os\u0027][\u0027release\u0027][\u0027full\u0027], \u00277.6\u0027) \u003e\u003d 0 {"},{"line_number":15,"context_line":"            $default \u003d \u00274.5\u0027"},{"line_number":16,"context_line":"          } else {"},{"line_number":17,"context_line":"            $default \u003d \u00273.9\u0027"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_2098b866","line":14,"range":{"start_line":14,"start_character":10,"end_line":14,"end_character":70},"updated":"2018-12-12 15:19:12.000000000","message":"IIUC this works for future versions, cool","commit_id":"80d0c00d54bc1c7cde03d205145c56a2f4e28519"}]}