)]}'
{"manifests/init.pp":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"f45045f36ec3b045169d70f570f8380deefe97d7","unresolved":false,"context_lines":[{"line_number":510,"context_line":"  $purge_config                           \u003d false,"},{"line_number":511,"context_line":"  $my_ip                                  \u003d $::os_service_default,"},{"line_number":512,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":513,"context_line":"  $placement_database_connection          \u003d undef,"},{"line_number":514,"context_line":"  $placement_slave_connection             \u003d undef,"},{"line_number":515,"context_line":"  $notify_api_faults                      \u003d undef,"},{"line_number":516,"context_line":"  $image_service                          \u003d undef,"},{"line_number":517,"context_line":"  $notify_on_api_faults                   \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"9fdfeff1_ecacb0ef","line":514,"range":{"start_line":513,"start_character":1,"end_line":514,"end_character":32},"updated":"2019-02-22 09:07:30.000000000","message":"we should print a warning when those are used, like the use_ipv6 bellow","commit_id":"9168299f0233b827c91c9d8496e62837f894d40b"}],"manifests/placement.pp":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"d833ac2d7b08b4b5fd7c115fb0a6d33e0fdb91ca","unresolved":false,"context_lines":[{"line_number":78,"context_line":"#   Defaults to \u0027present\u0027"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"class nova::placement("},{"line_number":81,"context_line":"  $enabled             \u003d true,"},{"line_number":82,"context_line":"  $manage_service      \u003d true,"},{"line_number":83,"context_line":"  $package_name        \u003d $::nova::params::placement_package_name,"},{"line_number":84,"context_line":"  $service_name        \u003d $::nova::params::placement_service_name,"},{"line_number":85,"context_line":"  $ensure_package      \u003d \u0027present\u0027,"},{"line_number":86,"context_line":"  $password            \u003d false,"},{"line_number":87,"context_line":"  $auth_type           \u003d \u0027password\u0027,"},{"line_number":88,"context_line":"  $auth_url            \u003d \u0027http://127.0.0.1:5000/v3\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9fdfeff1_67b891c7","line":85,"range":{"start_line":81,"start_character":0,"end_line":85,"end_character":35},"updated":"2019-02-13 14:24:55.000000000","message":"can you also move them here down","commit_id":"9ccb9573943cab66dacd244774de2588c62e97cd"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"1a7732f3bd679f329c845d9b05e4f3b614ad24a8","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  $username            \u003d \u0027placement\u0027,"},{"line_number":90,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":91,"context_line":"  $os_interface        \u003d undef,"},{"line_number":92,"context_line":"  $enabled             \u003d true,"},{"line_number":93,"context_line":"  $manage_service      \u003d true,"},{"line_number":94,"context_line":"  $package_name        \u003d $::nova::params::placement_package_name,"},{"line_number":95,"context_line":"  $service_name        \u003d $::nova::params::placement_service_name,"},{"line_number":96,"context_line":"  $ensure_package      \u003d \u0027present\u0027,"},{"line_number":97,"context_line":") inherits nova::params {"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  include ::nova::deps"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9fdfeff1_850a3b1d","line":96,"range":{"start_line":92,"start_character":0,"end_line":96,"end_character":35},"updated":"2019-02-14 08:31:59.000000000","message":"parameters that are deprecated get usually undefed out. this likely also needs a change to the specs","commit_id":"36a8cc5b7272c4af94d7cec3b6a634795f8eb337"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"44b28bd30c6993fc7eebc827767ba16f562e2864","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  $username            \u003d \u0027placement\u0027,"},{"line_number":90,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":91,"context_line":"  $os_interface        \u003d undef,"},{"line_number":92,"context_line":"  $enabled             \u003d true,"},{"line_number":93,"context_line":"  $manage_service      \u003d true,"},{"line_number":94,"context_line":"  $package_name        \u003d $::nova::params::placement_package_name,"},{"line_number":95,"context_line":"  $service_name        \u003d $::nova::params::placement_service_name,"},{"line_number":96,"context_line":"  $ensure_package      \u003d \u0027present\u0027,"},{"line_number":97,"context_line":") inherits nova::params {"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  include ::nova::deps"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9fdfeff1_cf01de06","line":96,"range":{"start_line":92,"start_character":0,"end_line":96,"end_character":35},"in_reply_to":"9fdfeff1_5a750931","updated":"2019-02-19 17:57:41.000000000","message":"I don\u0027t think we should change the use-case but just notify that they are deprecated, maybe it\u0027s messy to output warnings when it\u0027s still the default use-case, so maybe a more detailed release note is enough.","commit_id":"36a8cc5b7272c4af94d7cec3b6a634795f8eb337"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6bcf82e5eea6b5acaa528163320e57d5aa0d4b4c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  $username            \u003d \u0027placement\u0027,"},{"line_number":90,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":91,"context_line":"  $os_interface        \u003d undef,"},{"line_number":92,"context_line":"  $enabled             \u003d true,"},{"line_number":93,"context_line":"  $manage_service      \u003d true,"},{"line_number":94,"context_line":"  $package_name        \u003d $::nova::params::placement_package_name,"},{"line_number":95,"context_line":"  $service_name        \u003d $::nova::params::placement_service_name,"},{"line_number":96,"context_line":"  $ensure_package      \u003d \u0027present\u0027,"},{"line_number":97,"context_line":") inherits nova::params {"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  include ::nova::deps"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9fdfeff1_d759d48d","line":96,"range":{"start_line":92,"start_character":0,"end_line":96,"end_character":35},"in_reply_to":"9fdfeff1_850a3b1d","updated":"2019-02-14 11:11:37.000000000","message":"Wouldn\u0027t that break existing users?","commit_id":"36a8cc5b7272c4af94d7cec3b6a634795f8eb337"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"ab0bf33eca5a3ea06e45326deb69321bd443e849","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  $username            \u003d \u0027placement\u0027,"},{"line_number":90,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":91,"context_line":"  $os_interface        \u003d undef,"},{"line_number":92,"context_line":"  $enabled             \u003d true,"},{"line_number":93,"context_line":"  $manage_service      \u003d true,"},{"line_number":94,"context_line":"  $package_name        \u003d $::nova::params::placement_package_name,"},{"line_number":95,"context_line":"  $service_name        \u003d $::nova::params::placement_service_name,"},{"line_number":96,"context_line":"  $ensure_package      \u003d \u0027present\u0027,"},{"line_number":97,"context_line":") inherits nova::params {"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  include ::nova::deps"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9fdfeff1_5a750931","line":96,"range":{"start_line":92,"start_character":0,"end_line":96,"end_character":35},"in_reply_to":"9fdfeff1_d759d48d","updated":"2019-02-14 11:42:22.000000000","message":"yeah somehow. they\u0027d have to specify the parameters when call the class. tbh not sure what is the best approach here as it is a bit special case with the extract. lets see what others recommend","commit_id":"36a8cc5b7272c4af94d7cec3b6a634795f8eb337"}],"manifests/placement/service.pp":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"1a7732f3bd679f329c845d9b05e4f3b614ad24a8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"class nova::placement::service("},{"line_number":35,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":36,"context_line":"  $enabled             \u003d true,"},{"line_number":37,"context_line":"  $manage_service      \u003d true,"},{"line_number":38,"context_line":"  $package_name        \u003d $::nova::params::placement_package_name,"},{"line_number":39,"context_line":"  $service_name        \u003d $::nova::params::placement_service_name,"},{"line_number":40,"context_line":"  $ensure_package      \u003d \u0027present\u0027,"},{"line_number":41,"context_line":") inherits nova::params {"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  warning(\u0027nova::placement::service is deprecated and will be removed in a future release\u0027)"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9fdfeff1_85231ba7","line":40,"range":{"start_line":36,"start_character":0,"end_line":40,"end_character":35},"updated":"2019-02-14 08:31:59.000000000","message":"parameters that are deprecated get usually undefed out.","commit_id":"36a8cc5b7272c4af94d7cec3b6a634795f8eb337"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6bcf82e5eea6b5acaa528163320e57d5aa0d4b4c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"class nova::placement::service("},{"line_number":35,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":36,"context_line":"  $enabled             \u003d true,"},{"line_number":37,"context_line":"  $manage_service      \u003d true,"},{"line_number":38,"context_line":"  $package_name        \u003d $::nova::params::placement_package_name,"},{"line_number":39,"context_line":"  $service_name        \u003d $::nova::params::placement_service_name,"},{"line_number":40,"context_line":"  $ensure_package      \u003d \u0027present\u0027,"},{"line_number":41,"context_line":") inherits nova::params {"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  warning(\u0027nova::placement::service is deprecated and will be removed in a future release\u0027)"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9fdfeff1_f75c187e","line":40,"range":{"start_line":36,"start_character":0,"end_line":40,"end_character":35},"in_reply_to":"9fdfeff1_85231ba7","updated":"2019-02-14 11:11:37.000000000","message":"Yeah again wouldn\u0027t that break existing users?","commit_id":"36a8cc5b7272c4af94d7cec3b6a634795f8eb337"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"44b28bd30c6993fc7eebc827767ba16f562e2864","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"class nova::placement::service("},{"line_number":35,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":36,"context_line":"  $enabled             \u003d true,"},{"line_number":37,"context_line":"  $manage_service      \u003d true,"},{"line_number":38,"context_line":"  $package_name        \u003d $::nova::params::placement_package_name,"},{"line_number":39,"context_line":"  $service_name        \u003d $::nova::params::placement_service_name,"},{"line_number":40,"context_line":"  $ensure_package      \u003d \u0027present\u0027,"},{"line_number":41,"context_line":") inherits nova::params {"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  warning(\u0027nova::placement::service is deprecated and will be removed in a future release\u0027)"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9fdfeff1_f42b5792","line":40,"range":{"start_line":36,"start_character":0,"end_line":40,"end_character":35},"in_reply_to":"9fdfeff1_f75c187e","updated":"2019-02-19 17:57:41.000000000","message":"IMO this is fine since the whole class is deprecated, we dont want to change the use-case now, just notify that it will be completely gone in next cycle.","commit_id":"36a8cc5b7272c4af94d7cec3b6a634795f8eb337"}],"releasenotes/notes/deprecate_placement_deployment-2497e35aa7089a92.yaml":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"44b28bd30c6993fc7eebc827767ba16f562e2864","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Deployment of the Placement API service using puppet-nova is now deprecated"},{"line_number":5,"context_line":"    in favour of the puppet-placement module ahead of the extraction of the"},{"line_number":6,"context_line":"    service from the Nova project early in the T release."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_34223fbc","line":6,"range":{"start_line":6,"start_character":47,"end_line":6,"end_character":48},"updated":"2019-02-19 17:57:41.000000000","message":"Can probably say \"Train\" here as well since that named is already settled.","commit_id":"36a8cc5b7272c4af94d7cec3b6a634795f8eb337"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"205e69de1c88b3e3c0606f80916fa8286def8b48","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Deployment of the Placement API service using puppet-nova is now deprecated"},{"line_number":5,"context_line":"    in favour of the puppet-placement module ahead of the extraction of the"},{"line_number":6,"context_line":"    service from the Nova project early in the T release."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_07c03c2a","line":6,"range":{"start_line":6,"start_character":49,"end_line":6,"end_character":56},"updated":"2019-02-19 09:54:31.000000000","message":"development cycle? I\u0027ll change this if I respin.","commit_id":"36a8cc5b7272c4af94d7cec3b6a634795f8eb337"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"44b28bd30c6993fc7eebc827767ba16f562e2864","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9fdfeff1_0f17e647","line":7,"updated":"2019-02-19 17:57:41.000000000","message":"Could we more explicit there about exactly what params and class will be removed in the next release, since we cannot be super verbose on warnings for this change (or should we?) since it would output on all deployments anyway.","commit_id":"36a8cc5b7272c4af94d7cec3b6a634795f8eb337"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"06e7df4217cd625c289d7d05f1511bbf1bc799e9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    deprecated in favour of the placement class provided by the"},{"line_number":6,"context_line":"    puppet-placement project. This deprecation comes ahead of the extraction of"},{"line_number":7,"context_line":"    the Placement service from the Nova project early in the Train development"},{"line_number":8,"context_line":"    cycle. "},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    The following parameters are also deprecated for removal as part of this:"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fdfeff1_1cb0598b","line":8,"range":{"start_line":8,"start_character":10,"end_line":8,"end_character":11},"updated":"2019-02-21 11:33:40.000000000","message":"could you please remove extra space here.","commit_id":"e6a6f7ebe548ae8458c96fce729a8c3d274cd67e"}]}