)]}'
{"manifests/cinder.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"cae4947b2d61b1f38a995df540bcd60a72d5f899","unresolved":false,"context_lines":[{"line_number":48,"context_line":"#   Defaults to \u0027RegionOne\u0027"},{"line_number":49,"context_line":"#"},{"line_number":50,"context_line":"class nova::cinder ("},{"line_number":51,"context_line":"  $cinder_password            \u003d false,"},{"line_number":52,"context_line":"  $cinder_auth_type           \u003d \u0027v3password\u0027,"},{"line_number":53,"context_line":"  $cinder_project_name        \u003d \u0027services\u0027,"},{"line_number":54,"context_line":"  $cinder_project_domain_name \u003d \u0027Default\u0027,"},{"line_number":55,"context_line":"  $cinder_username            \u003d \u0027cinder\u0027,"},{"line_number":56,"context_line":"  $cinder_user_domain_name    \u003d \u0027Default\u0027,"},{"line_number":57,"context_line":"  $cinder_auth_url            \u003d \u0027http://127.0.0.1:5000/v3\u0027,"},{"line_number":58,"context_line":"  $cinder_timeout             \u003d \u002730\u0027,"},{"line_number":59,"context_line":"  $cinder_region_name         \u003d \u0027RegionOne\u0027,"},{"line_number":60,"context_line":") {"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  include ::nova::deps"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dfbec78f_ddd37437","line":59,"range":{"start_line":51,"start_character":2,"end_line":59,"end_character":43},"updated":"2019-05-10 10:05:25.000000000","message":"should skip all cinder_* prefixes","commit_id":"5ec5a8f1f68f4e8b75da61da7a7b3354c6365330"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"4f84f30a52c410b1977934c8f1bae5dea57866ec","unresolved":false,"context_lines":[{"line_number":48,"context_line":"#   Defaults to \u0027RegionOne\u0027"},{"line_number":49,"context_line":"#"},{"line_number":50,"context_line":"class nova::cinder ("},{"line_number":51,"context_line":"  $cinder_password            \u003d false,"},{"line_number":52,"context_line":"  $cinder_auth_type           \u003d \u0027v3password\u0027,"},{"line_number":53,"context_line":"  $cinder_project_name        \u003d \u0027services\u0027,"},{"line_number":54,"context_line":"  $cinder_project_domain_name \u003d \u0027Default\u0027,"},{"line_number":55,"context_line":"  $cinder_username            \u003d \u0027cinder\u0027,"},{"line_number":56,"context_line":"  $cinder_user_domain_name    \u003d \u0027Default\u0027,"},{"line_number":57,"context_line":"  $cinder_auth_url            \u003d \u0027http://127.0.0.1:5000/v3\u0027,"},{"line_number":58,"context_line":"  $cinder_timeout             \u003d \u002730\u0027,"},{"line_number":59,"context_line":"  $cinder_region_name         \u003d \u0027RegionOne\u0027,"},{"line_number":60,"context_line":") {"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  include ::nova::deps"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dfbec78f_1381e1c3","line":59,"range":{"start_line":51,"start_character":2,"end_line":59,"end_character":43},"in_reply_to":"dfbec78f_ddd37437","updated":"2019-05-13 08:12:27.000000000","message":"Done","commit_id":"5ec5a8f1f68f4e8b75da61da7a7b3354c6365330"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"5c98a531549691b095ca0ff5007b474d55fd90c4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  $auth_url            \u003d $::os_service_default,"},{"line_number":55,"context_line":"  $timeout             \u003d $::os_service_default,"},{"line_number":56,"context_line":"  $region_name         \u003d $::os_service_default,"},{"line_number":57,"context_line":"  $project_name        \u003d \u0027service\u0027,"},{"line_number":58,"context_line":"  $project_domain_name \u003d \u0027Default\u0027,"},{"line_number":59,"context_line":"  $username            \u003d \u0027cinder\u0027,"},{"line_number":60,"context_line":"  $user_domain_name    \u003d \u0027Default\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dfbec78f_3b311c5b","line":57,"updated":"2019-05-16 10:20:20.000000000","message":"Based on puppet-keystone default this should be \u0027services\u0027.\n\nThis might be an overall inconsistency when checking now, looks like it\u0027s \u0027service\u0027 in multiple modules that\u0027s probably wrong. I\u0027ll add that to my TODO list.","commit_id":"7ef7457b06a5059256a2994521c291fc94c86a88"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a5405eab2e44e2c1cc68c1a1394597fd14ecaa4d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  $auth_url            \u003d $::os_service_default,"},{"line_number":55,"context_line":"  $timeout             \u003d $::os_service_default,"},{"line_number":56,"context_line":"  $region_name         \u003d $::os_service_default,"},{"line_number":57,"context_line":"  $project_name        \u003d \u0027service\u0027,"},{"line_number":58,"context_line":"  $project_domain_name \u003d \u0027Default\u0027,"},{"line_number":59,"context_line":"  $username            \u003d \u0027cinder\u0027,"},{"line_number":60,"context_line":"  $user_domain_name    \u003d \u0027Default\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dfbec78f_f10f2585","line":57,"in_reply_to":"dfbec78f_3b311c5b","updated":"2019-05-16 12:06:07.000000000","message":"Agree, but clearly existing deployments have something in place to deal with the inconsistency. For example, tripleo overrides keystone\u0027s default so that \u0027service\u0027 is used everywhere. It makes sense that puppet modules should start with a common default, but I don\u0027t think we can change those modules that chose the \"wrong\" default value. How do we proceed? In the short term, I\u0027m hoping we can move this patch forward.","commit_id":"7ef7457b06a5059256a2994521c291fc94c86a88"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0ce5590f7d9e2421156e6b0b64d511806e85f4a2","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  $auth_url            \u003d $::os_service_default,"},{"line_number":55,"context_line":"  $timeout             \u003d $::os_service_default,"},{"line_number":56,"context_line":"  $region_name         \u003d $::os_service_default,"},{"line_number":57,"context_line":"  $project_name        \u003d \u0027service\u0027,"},{"line_number":58,"context_line":"  $project_domain_name \u003d \u0027Default\u0027,"},{"line_number":59,"context_line":"  $username            \u003d \u0027cinder\u0027,"},{"line_number":60,"context_line":"  $user_domain_name    \u003d \u0027Default\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dfbec78f_6267e1b8","line":57,"in_reply_to":"dfbec78f_f10f2585","updated":"2019-05-16 14:18:56.000000000","message":"services vs service is a tripleo specific thing. For puppet-nova, it should be services and it should be set to service in tripleo","commit_id":"7ef7457b06a5059256a2994521c291fc94c86a88"}],"manifests/compute.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"cae4947b2d61b1f38a995df540bcd60a72d5f899","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"  include ::nova::deps"},{"line_number":229,"context_line":"  include ::nova::params"},{"line_number":230,"context_line":"  include ::nova::cinder"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"  $vcpu_pin_set_real \u003d pick(join(any2array($vcpu_pin_set), \u0027,\u0027), $::os_service_default)"},{"line_number":233,"context_line":"  $cpu_shared_set_real \u003d pick(join(any2array($cpu_shared_set), \u0027,\u0027), $::os_service_default)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dfbec78f_1df10cce","line":230,"updated":"2019-05-10 10:05:25.000000000","message":"please add this in spec testing as well","commit_id":"5ec5a8f1f68f4e8b75da61da7a7b3354c6365330"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"4f84f30a52c410b1977934c8f1bae5dea57866ec","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"  include ::nova::deps"},{"line_number":229,"context_line":"  include ::nova::params"},{"line_number":230,"context_line":"  include ::nova::cinder"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"  $vcpu_pin_set_real \u003d pick(join(any2array($vcpu_pin_set), \u0027,\u0027), $::os_service_default)"},{"line_number":233,"context_line":"  $cpu_shared_set_real \u003d pick(join(any2array($cpu_shared_set), \u0027,\u0027), $::os_service_default)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dfbec78f_d36ee92d","line":230,"in_reply_to":"dfbec78f_1df10cce","updated":"2019-05-13 08:12:27.000000000","message":"Done","commit_id":"5ec5a8f1f68f4e8b75da61da7a7b3354c6365330"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"6af5997844adc21f28bc6a64cdb56a2d168ad0f1","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"  include ::nova::deps"},{"line_number":229,"context_line":"  include ::nova::params"},{"line_number":230,"context_line":"  include ::nova::cinder"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"  $vcpu_pin_set_real \u003d pick(join(any2array($vcpu_pin_set), \u0027,\u0027), $::os_service_default)"},{"line_number":233,"context_line":"  $cpu_shared_set_real \u003d pick(join(any2array($cpu_shared_set), \u0027,\u0027), $::os_service_default)"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"dfbec78f_1bb8ebe2","line":230,"updated":"2019-05-15 12:12:56.000000000","message":"Also to reiterate what I mentioned in patch [1] I don\u0027t like this dependency nightmare we are doing here either, see my comment in [1].\n\n[1] https://review.opendev.org/#/c/659260/","commit_id":"717910de19bd201232ff600eabcbb3458f3d38a2"}],"releasenotes/notes/add-cinder-creds-91a50b74c8bdb541.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"457879ab3203213bbb57e76757a0e05a2ac069f3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add cinder credentials in cinder section of nova conf to fix issue"},{"line_number":5,"context_line":"    when reclaim_instance_interval \u003e 0 and delete instance which booted"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bfb3d3c7_1ef65291","line":2,"updated":"2019-05-17 12:46:57.000000000","message":"Erm, style wise, I think the scope of the puppet-cinder release note should be confined to stating this patch adds a feature (nova::cinder) that supports configuring cinder credentials.\n\nAs written, the note focuses on the motivation for why you are adding the feature, but the feature itself doesn\u0027t actually fix the bug. Technically speaking, it\u0027s the puppet-tripleo change (which adds this new resource to the deployment) that fixes the bug.\n\nI\u0027ll let the cores decide which way to go with this.","commit_id":"db2280e2d022384f0e10ea828a1ab4606fbd0ff4"}],"spec/classes/nova_compute_spec.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"36a3261afe9a498f32e158f0b23de920fa971078","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  let :pre_condition do"},{"line_number":6,"context_line":"    \u0027include nova\u0027"},{"line_number":7,"context_line":"    \u0027include nova::cinder\u0027"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  shared_examples \u0027nova-compute\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"dfbec78f_648091c1","line":7,"updated":"2019-05-13 11:58:51.000000000","message":"not needed","commit_id":"2822b2f3892ebb6b458b469353c05823ab7c7155"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"36a3261afe9a498f32e158f0b23de920fa971078","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  shared_examples \u0027nova-compute\u0027 do"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    context \u0027with default parameters\u0027 do"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"      it \u0027installs nova-compute package and service\u0027 do"},{"line_number":15,"context_line":"        is_expected.to contain_service(\u0027nova-compute\u0027).with({"},{"line_number":16,"context_line":"          :name      \u003d\u003e platform_params[:nova_compute_service],"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"dfbec78f_841fc5b5","line":13,"updated":"2019-05-13 11:58:51.000000000","message":"meant more like this:\nit { is_expected.to contain_class(\u0027nova::cinder\u0027) }","commit_id":"2822b2f3892ebb6b458b469353c05823ab7c7155"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"36a3261afe9a498f32e158f0b23de920fa971078","unresolved":false,"context_lines":[{"line_number":109,"context_line":"          :consecutive_build_service_disable_threshold \u003d\u003e \u00279\u0027,"},{"line_number":110,"context_line":"        }"},{"line_number":111,"context_line":"      end"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"      it \u0027installs nova-compute package and service\u0027 do"},{"line_number":114,"context_line":"        is_expected.to contain_service(\u0027nova-compute\u0027).with({"},{"line_number":115,"context_line":"          :name      \u003d\u003e platform_params[:nova_compute_service],"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"dfbec78f_048195c3","line":112,"updated":"2019-05-13 11:58:51.000000000","message":"it { is_expected.to contain_class(\u0027nova::cinder\u0027) }","commit_id":"2822b2f3892ebb6b458b469353c05823ab7c7155"}]}