)]}'
{"id":"openstack%2Fpuppet-nova~659260","triplet_id":"openstack%2Fpuppet-nova~stable%2Fstein~Ia94a5d7baf1dd2efc8339475176a1e1c24ad99d0","project":"openstack/puppet-nova","branch":"stable/stein","topic":"bug/1824273-stable/stein","hashtags":[],"change_id":"Ia94a5d7baf1dd2efc8339475176a1e1c24ad99d0","subject":"Include nova::availability_zone in scheduler.pp","status":"MERGED","created":"2019-05-15 10:04:08.000000000","updated":"2019-05-22 11:32:56.000000000","submitted":"2019-05-22 11:32:56.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"659260-1558524776625-54bd5aa7","meta_rev_id":"4670ab820b51bf6882656cb0c96a97b24b022a22","_number":659260,"virtual_id_number":659260,"owner":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":2,"date":"2019-05-22 11:32:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25613,"name":"Keigo Noha","email":"knoha@redhat.com","username":"knoha"},{"value":0,"date":"2019-05-22 05:19:52.000000000","_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},{"value":0,"_account_id":27679,"name":"gaoruyue","email":"gaory@awcloud.com","username":"gaoruyue"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":2,"date":"2019-05-21 12:45:44.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},{"value":2,"date":"2019-05-22 00:49:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"date":"2019-05-16 11:06:42.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25613,"name":"Keigo Noha","email":"knoha@redhat.com","username":"knoha"},{"value":0,"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},{"value":1,"date":"2019-05-22 08:28:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27679,"name":"gaoruyue","email":"gaory@awcloud.com","username":"gaoruyue"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"all":[{"value":0,"date":"2019-05-15 12:53:18.000000000","_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"date":"2019-05-15 10:04:21.000000000","_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},{"value":1,"date":"2019-05-22 00:49:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"date":"2019-05-15 10:04:28.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-05-15 10:04:08.000000000","_account_id":25613,"name":"Keigo Noha","email":"knoha@redhat.com","username":"knoha"},{"value":0,"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},{"value":0,"_account_id":27679,"name":"gaoruyue","email":"gaory@awcloud.com","username":"gaoruyue"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25613,"name":"Keigo Noha","email":"knoha@redhat.com","username":"knoha"},{"_account_id":27679,"name":"gaoruyue","email":"gaory@awcloud.com","username":"gaoruyue"},{"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-15 10:04:08.000000000","updated_by":{"_account_id":25613,"name":"Keigo Noha","email":"knoha@redhat.com","username":"knoha"},"reviewer":{"_account_id":25613,"name":"Keigo Noha","email":"knoha@redhat.com","username":"knoha"},"state":"REVIEWER"},{"updated":"2019-05-15 10:04:21.000000000","updated_by":{"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},"reviewer":{"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},"state":"REVIEWER"},{"updated":"2019-05-15 10:04:28.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-05-15 12:53:18.000000000","updated_by":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"reviewer":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"state":"REVIEWER"},{"updated":"2019-05-16 11:06:42.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2019-05-21 12:45:44.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-05-22 00:49:56.000000000","updated_by":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"reviewer":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"state":"REVIEWER"},{"updated":"2019-05-22 08:28:42.000000000","updated_by":{"_account_id":27679,"name":"gaoruyue","email":"gaory@awcloud.com","username":"gaoruyue"},"reviewer":{"_account_id":27679,"name":"gaoruyue","email":"gaory@awcloud.com","username":"gaoruyue"},"state":"REVIEWER"},{"updated":"2019-05-22 11:32:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6f68375a16b14a3e7d0a4817176a34e36f50e4ab","author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"date":"2019-05-15 10:04:08.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"fb37e86a79f06ae1c64f2688a8d1d2c34c199ddc","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2019-05-15 12:11:15.000000000","message":"Patch Set 1: Code-Review-1\n\nI don\u0027t like these include nightmare we have right now, if a deployment requires the availability zone config options to be set they should use the nova::availability_zone class, it should not be assumed that we should include it.\n\nThe alternative is moving those options to ::nova class which also is not ideal since other components might not need it.\n\nThe problem here is if a deployment defines nova::availability_zone after nova::scheduler themselves it will throw a redeclaration error, I\u0027ve tried to decrease those to make sure it\u0027s impossible to throw those without the deployer doing something wrong (moved out \u003cmodule\u003e::logging in Stein and maybe \u003cmodule\u003e::db later or in Train).\n\nI tried to make this clearer in the contributor guide [1] under \"Class structure and dependencies\" to make sure we do not implement any more of these dependency nightmares so that we can work away from them.\n\n[1] https://docs.openstack.org/puppet-openstack-guide/latest/contributor/coding-style.html","accounts_in_message":[],"_revision_number":1},{"id":"62deaf00520a11015454ac4640db633da4069a77","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-15 12:45:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic http://logs.openstack.org/60/659260/1/check/puppet-openstack-lint-ubuntu-bionic/486fd1c/ : SUCCESS in 5m 09s\n- puppet-openstack-syntax-4-ubuntu-bionic http://logs.openstack.org/60/659260/1/check/puppet-openstack-syntax-4-ubuntu-bionic/bbabd98/ : SUCCESS in 4m 31s\n- puppet-openstack-syntax-5-ubuntu-bionic http://logs.openstack.org/60/659260/1/check/puppet-openstack-syntax-5-ubuntu-bionic/7ec32e3/ : SUCCESS in 4m 30s\n- puppet-openstack-syntax-6-ubuntu-bionic http://logs.openstack.org/60/659260/1/check/puppet-openstack-syntax-6-ubuntu-bionic/462db3f/ : SUCCESS in 3m 39s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/60/659260/1/check/puppet-openstack-unit-4.8-centos-7/9e032b0/ : SUCCESS in 38m 00s\n- puppet-openstack-unit-5.5-centos-7 http://logs.openstack.org/60/659260/1/check/puppet-openstack-unit-5.5-centos-7/3a87877/ : SUCCESS in 25m 36s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous http://logs.openstack.org/60/659260/1/check/puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous/27a564b/ : SUCCESS in 52m 42s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 http://logs.openstack.org/60/659260/1/check/puppet-openstack-integration-5-scenario002-tempest-centos-7/9f950a4/ : SUCCESS in 1h 01m 59s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 http://logs.openstack.org/60/659260/1/check/puppet-openstack-integration-5-scenario003-tempest-centos-7/d58c98f/ : SUCCESS in 1h 01m 51s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus http://logs.openstack.org/60/659260/1/check/puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus/b614cf1/ : SUCCESS in 46m 52s\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic http://logs.openstack.org/60/659260/1/check/puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic/97e95f8/ : FAILURE in 20m 19s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic http://logs.openstack.org/60/659260/1/check/puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic/71de4f2/ : FAILURE in 19m 16s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic http://logs.openstack.org/60/659260/1/check/puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic/8465896/ : FAILURE in 30m 23s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic http://logs.openstack.org/60/659260/1/check/puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic/787c068/ : FAILURE in 23m 09s (non-voting)\n- puppet-openstack-beaker-centos-7 http://logs.openstack.org/60/659260/1/check/puppet-openstack-beaker-centos-7/b2396f7/ : SUCCESS in 37m 07s\n- puppet-openstack-beaker-ubuntu-bionic http://logs.openstack.org/60/659260/1/check/puppet-openstack-beaker-ubuntu-bionic/5077611/ : FAILURE in 7m 20s (non-voting)\n- puppet-nova-tripleo-standalone http://logs.openstack.org/60/659260/1/check/puppet-nova-tripleo-standalone/2f984f0/ : SUCCESS in 2h 35m 57s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"cbf6d2afdd232bab50886db90248eabd912930f3","author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"date":"2019-05-15 12:53:18.000000000","message":"Patch Set 1:\n\n\u003e I don\u0027t like these include nightmare we have right now, if a\n \u003e deployment requires the availability zone config options to be set\n \u003e they should use the nova::availability_zone class, it should not be\n \u003e assumed that we should include it.\n \u003e \n \u003e The alternative is moving those options to ::nova class which also\n \u003e is not ideal since other components might not need it.\n \u003e \n \u003e The problem here is if a deployment defines nova::availability_zone\n \u003e after nova::scheduler themselves it will throw a redeclaration\n \u003e error, I\u0027ve tried to decrease those to make sure it\u0027s impossible to\n \u003e throw those without the deployer doing something wrong (moved out\n \u003e \u003cmodule\u003e::logging in Stein and maybe \u003cmodule\u003e::db later or in\n \u003e Train).\n \u003e \n \u003e I tried to make this clearer in the contributor guide [1] under\n \u003e \"Class structure and dependencies\" to make sure we do not implement\n \u003e any more of these dependency nightmares so that we can work away\n \u003e from them.\n \u003e \n \u003e [1] https://docs.openstack.org/puppet-openstack-guide/latest/contributor/coding-style.html\n\n@Tobias: The thing is, we already have this patch in master, rocky and queens [1].\nShould we revert all of them, or merge this one and do a follow up cleanup?\n\nIn general for tripleo this should then get included in puppet-tripleo in [2].\n\n[1] https://review.opendev.org/#/q/Ia94a5d7baf1dd2efc8339475176a1e1c24ad99d0\n[2] https://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/base/nova/scheduler.pp#L33","accounts_in_message":[],"_revision_number":1},{"id":"eac92c3c21c5aafff8f3afdedb42f4bc05fd078c","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2019-05-16 11:06:42.000000000","message":"Patch Set 1: -Code-Review\n\nDidn\u0027t see it was a backport, but yeah. My hope is that we can move away from this, introducing a behavior change in backport isn\u0027t optimal either but I\u0027m not gonna block because of that.\n\nMy point is that we need some more broader effort for clean that up afterwards, maybe just live with doing that sometime in a single cycle.","accounts_in_message":[],"_revision_number":1},{"id":"d7216a118292d4cdf2f2cedaa3de6f0ce3a03722","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-05-21 12:45:44.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b1192ce398ffd4c6ac130dfc5c4600541617a3f9","author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"date":"2019-05-22 00:49:56.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"b333ff901ae68612d21ea364f48819daf36b0cdd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-22 00:50:09.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"c389af921c253aa0383eda15b3281ed210fe5471","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-22 03:41:58.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- puppet-openstack-lint-ubuntu-bionic http://logs.openstack.org/60/659260/1/gate/puppet-openstack-lint-ubuntu-bionic/9455fed/ : SUCCESS in 3m 44s\n- puppet-openstack-syntax-4-ubuntu-bionic http://logs.openstack.org/60/659260/1/gate/puppet-openstack-syntax-4-ubuntu-bionic/d21d431/ : SUCCESS in 4m 07s\n- puppet-openstack-syntax-5-ubuntu-bionic http://logs.openstack.org/60/659260/1/gate/puppet-openstack-syntax-5-ubuntu-bionic/7f96d34/ : SUCCESS in 5m 36s\n- puppet-openstack-syntax-6-ubuntu-bionic http://logs.openstack.org/60/659260/1/gate/puppet-openstack-syntax-6-ubuntu-bionic/26e5baa/ : SUCCESS in 5m 15s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/60/659260/1/gate/puppet-openstack-unit-4.8-centos-7/d36540a/ : SUCCESS in 33m 04s\n- puppet-openstack-unit-5.5-centos-7 http://logs.openstack.org/60/659260/1/gate/puppet-openstack-unit-5.5-centos-7/ca222c8/ : SUCCESS in 28m 11s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous http://logs.openstack.org/60/659260/1/gate/puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous/2d5b115/ : FAILURE in 1h 13m 09s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 http://logs.openstack.org/60/659260/1/gate/puppet-openstack-integration-5-scenario002-tempest-centos-7/d9382c4/ : SUCCESS in 1h 16m 55s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 http://logs.openstack.org/60/659260/1/gate/puppet-openstack-integration-5-scenario003-tempest-centos-7/967d752/ : SUCCESS in 59m 34s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus http://logs.openstack.org/60/659260/1/gate/puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus/2640a73/ : SUCCESS in 51m 35s\n- puppet-openstack-beaker-centos-7 http://logs.openstack.org/60/659260/1/gate/puppet-openstack-beaker-centos-7/fac2ef7/ : SUCCESS in 34m 31s\n- puppet-openstack-beaker-ubuntu-bionic http://logs.openstack.org/60/659260/1/gate/puppet-openstack-beaker-ubuntu-bionic/f526320/ : FAILURE in 8m 40s (non-voting)\n- puppet-nova-tripleo-standalone http://logs.openstack.org/60/659260/1/gate/puppet-nova-tripleo-standalone/6e166f2/ : SUCCESS in 2h 45m 15s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a66d1deea810bbae59e3c1b0294d356b8a79c83e","author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"date":"2019-05-22 05:19:52.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"3f51807d746608d956733b4a1ee58265a1bfd6c2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-22 08:20:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic http://logs.openstack.org/60/659260/1/check/puppet-openstack-lint-ubuntu-bionic/2f0c56e/ : SUCCESS in 5m 08s\n- puppet-openstack-syntax-4-ubuntu-bionic http://logs.openstack.org/60/659260/1/check/puppet-openstack-syntax-4-ubuntu-bionic/45392bc/ : SUCCESS in 4m 36s\n- puppet-openstack-syntax-5-ubuntu-bionic http://logs.openstack.org/60/659260/1/check/puppet-openstack-syntax-5-ubuntu-bionic/2a7eb91/ : SUCCESS in 5m 04s\n- puppet-openstack-syntax-6-ubuntu-bionic http://logs.openstack.org/60/659260/1/check/puppet-openstack-syntax-6-ubuntu-bionic/e474a0a/ : SUCCESS in 3m 40s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/60/659260/1/check/puppet-openstack-unit-4.8-centos-7/74c5cb6/ : SUCCESS in 26m 57s\n- puppet-openstack-unit-5.5-centos-7 http://logs.openstack.org/60/659260/1/check/puppet-openstack-unit-5.5-centos-7/c64d1e6/ : SUCCESS in 27m 59s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous http://logs.openstack.org/60/659260/1/check/puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous/8b0387f/ : SUCCESS in 58m 30s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 http://logs.openstack.org/60/659260/1/check/puppet-openstack-integration-5-scenario002-tempest-centos-7/e7f69f7/ : SUCCESS in 1h 10m 30s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 http://logs.openstack.org/60/659260/1/check/puppet-openstack-integration-5-scenario003-tempest-centos-7/72e540b/ : SUCCESS in 1h 05m 36s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus http://logs.openstack.org/60/659260/1/check/puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus/390530c/ : SUCCESS in 49m 53s\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic http://logs.openstack.org/60/659260/1/check/puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic/ac0b245/ : FAILURE in 17m 56s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic http://logs.openstack.org/60/659260/1/check/puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic/9651f60/ : FAILURE in 25m 10s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic http://logs.openstack.org/60/659260/1/check/puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic/7e8dc2b/ : FAILURE in 27m 09s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic http://logs.openstack.org/60/659260/1/check/puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic/7e36147/ : FAILURE in 22m 03s (non-voting)\n- puppet-openstack-beaker-centos-7 http://logs.openstack.org/60/659260/1/check/puppet-openstack-beaker-centos-7/e7d23de/ : SUCCESS in 22m 25s\n- puppet-openstack-beaker-ubuntu-bionic http://logs.openstack.org/60/659260/1/check/puppet-openstack-beaker-ubuntu-bionic/648a862/ : FAILURE in 13m 30s (non-voting)\n- puppet-nova-tripleo-standalone http://logs.openstack.org/60/659260/1/check/puppet-nova-tripleo-standalone/16d89af/ : SUCCESS in 2h 52m 22s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"1e89bb2618c3699a7a227d95f2d362ae6d4ba3fe","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-22 08:20:43.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"07adce06fe08954893983bc4fbdf95339cfae1c1","author":{"_account_id":27679,"name":"gaoruyue","email":"gaory@awcloud.com","username":"gaoruyue"},"date":"2019-05-22 08:28:42.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"7e8c48f9836fad1ef6285eaaa1c37a7e006e5b7f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-22 11:32:56.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic http://logs.openstack.org/60/659260/1/gate/puppet-openstack-lint-ubuntu-bionic/8275bad/ : SUCCESS in 5m 49s\n- puppet-openstack-syntax-4-ubuntu-bionic http://logs.openstack.org/60/659260/1/gate/puppet-openstack-syntax-4-ubuntu-bionic/9b8e6be/ : SUCCESS in 4m 56s\n- puppet-openstack-syntax-5-ubuntu-bionic http://logs.openstack.org/60/659260/1/gate/puppet-openstack-syntax-5-ubuntu-bionic/56ced49/ : SUCCESS in 4m 24s\n- puppet-openstack-syntax-6-ubuntu-bionic http://logs.openstack.org/60/659260/1/gate/puppet-openstack-syntax-6-ubuntu-bionic/46ac14c/ : SUCCESS in 3m 44s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/60/659260/1/gate/puppet-openstack-unit-4.8-centos-7/368d44d/ : SUCCESS in 33m 52s\n- puppet-openstack-unit-5.5-centos-7 http://logs.openstack.org/60/659260/1/gate/puppet-openstack-unit-5.5-centos-7/2f7a595/ : SUCCESS in 30m 07s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous http://logs.openstack.org/60/659260/1/gate/puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous/4d2c67b/ : SUCCESS in 57m 27s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 http://logs.openstack.org/60/659260/1/gate/puppet-openstack-integration-5-scenario002-tempest-centos-7/18906d3/ : SUCCESS in 1h 00m 10s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 http://logs.openstack.org/60/659260/1/gate/puppet-openstack-integration-5-scenario003-tempest-centos-7/629650b/ : SUCCESS in 1h 08m 59s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus http://logs.openstack.org/60/659260/1/gate/puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus/4c0f8fa/ : SUCCESS in 44m 28s\n- puppet-openstack-beaker-centos-7 http://logs.openstack.org/60/659260/1/gate/puppet-openstack-beaker-centos-7/3b95f55/ : SUCCESS in 21m 47s\n- puppet-openstack-beaker-ubuntu-bionic http://logs.openstack.org/60/659260/1/gate/puppet-openstack-beaker-ubuntu-bionic/6b1381b/ : FAILURE in 7m 16s (non-voting)\n- puppet-nova-tripleo-standalone http://logs.openstack.org/60/659260/1/gate/puppet-nova-tripleo-standalone/f67b640/ : SUCCESS in 3h 04m 52s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"08c7effcd32061655580a097d58cdc3e8cbc425a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-22 11:32:56.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"74c69381395b3f3489adc4db608722c537171148","revisions":{"74c69381395b3f3489adc4db608722c537171148":{"kind":"REWORK","_number":1,"created":"2019-05-15 10:04:08.000000000","uploader":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"ref":"refs/changes/60/659260/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/60/659260/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/60/659260/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/60/659260/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/60/659260/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/60/659260/1"}}},"commit":{"parents":[{"commit":"2f2508638a42a4f7d9ebaf6d8657e6ef2c1df934","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/2f2508638a42a4f7d9ebaf6d8657e6ef2c1df934"}]}],"author":{"name":"Keigo Noha","email":"knoha@redhat.com","date":"2019-04-11 04:17:18.000000000","tz":540},"committer":{"name":"Rajesh Tailor","email":"ratailor@redhat.com","date":"2019-05-15 10:04:08.000000000","tz":0},"subject":"Include nova::availability_zone in scheduler.pp","message":"Include nova::availability_zone in scheduler.pp\n\nnova-scheduler uses CONF.default_availabiliy_zone.\nHowever, the required class was not included in scheduler.pp\nThis patch includes nova::availability_zone class in scheduler.pp.\n\nSigned-off-by: Keigo Noha \u003cknoha@redhat.com\u003e\nCloses-Bug: #1824273\nChange-Id: Ia94a5d7baf1dd2efc8339475176a1e1c24ad99d0\n(cherry picked from commit fd7587d71fd6dd6af6a95104e538d8f04ae9dd5e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/74c69381395b3f3489adc4db608722c537171148"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/74c69381395b3f3489adc4db608722c537171148"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}