)]}'
{"id":"openstack%2Fpuppet-nova~660329","triplet_id":"openstack%2Fpuppet-nova~stable%2Fstein~Ib58c2ca04dfe6d1e1ff849f600a9a24724205078","project":"openstack/puppet-nova","branch":"stable/stein","topic":"bug/1734025-stable/stein","hashtags":[],"change_id":"Ib58c2ca04dfe6d1e1ff849f600a9a24724205078","subject":"Add cinder credentials in nova conf","status":"MERGED","created":"2019-05-21 09:55:13.000000000","updated":"2019-05-21 18:31:26.000000000","submitted":"2019-05-21 18:31:26.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"660329-1558463486780-db3b04f4","meta_rev_id":"7d33389ff07554e9c2552d46d76bb033ff0fdf04","_number":660329,"virtual_id_number":660329,"owner":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},{"value":0,"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":2,"date":"2019-05-21 18:31:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":2,"date":"2019-05-21 15:45:55.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},{"value":0,"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":2,"date":"2019-05-21 15:03:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"date":"2019-05-21 13:10:47.000000000","_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":1,"date":"2019-05-21 15:45:55.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"date":"2019-05-21 13:10:51.000000000","_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},{"value":0,"date":"2019-05-21 13:11:02.000000000","_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"value":0,"date":"2019-05-21 13:11:12.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-21 13:10:47.000000000","updated_by":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"reviewer":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"state":"REVIEWER"},{"updated":"2019-05-21 13:10:51.000000000","updated_by":{"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},"reviewer":{"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},"state":"REVIEWER"},{"updated":"2019-05-21 13:11:02.000000000","updated_by":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"reviewer":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"state":"REVIEWER"},{"updated":"2019-05-21 13:11:12.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2019-05-21 15:03:16.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-05-21 15:45:55.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-05-21 18:31:26.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"dfb476edd183e616ce9eb73ff98b1c698ec79dc1","author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"date":"2019-05-21 09:55:13.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"85d5cfa4f9ab90628f7df13e5d6ff84a9e6260bc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-21 12:50:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic http://logs.openstack.org/29/660329/1/check/puppet-openstack-lint-ubuntu-bionic/0e2f7ed/ : SUCCESS in 4m 02s\n- puppet-openstack-syntax-4-ubuntu-bionic http://logs.openstack.org/29/660329/1/check/puppet-openstack-syntax-4-ubuntu-bionic/0b61b7a/ : SUCCESS in 7m 08s\n- puppet-openstack-syntax-5-ubuntu-bionic http://logs.openstack.org/29/660329/1/check/puppet-openstack-syntax-5-ubuntu-bionic/e35d2d6/ : SUCCESS in 3m 57s\n- puppet-openstack-syntax-6-ubuntu-bionic http://logs.openstack.org/29/660329/1/check/puppet-openstack-syntax-6-ubuntu-bionic/61e59dc/ : SUCCESS in 3m 50s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/29/660329/1/check/puppet-openstack-unit-4.8-centos-7/5550f57/ : SUCCESS in 38m 08s\n- puppet-openstack-unit-5.5-centos-7 http://logs.openstack.org/29/660329/1/check/puppet-openstack-unit-5.5-centos-7/d311067/ : SUCCESS in 30m 14s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous http://logs.openstack.org/29/660329/1/check/puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous/641c61a/ : SUCCESS in 1h 02m 21s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 http://logs.openstack.org/29/660329/1/check/puppet-openstack-integration-5-scenario002-tempest-centos-7/06070d8/ : SUCCESS in 1h 02m 25s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 http://logs.openstack.org/29/660329/1/check/puppet-openstack-integration-5-scenario003-tempest-centos-7/07e4e37/ : SUCCESS in 59m 14s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus http://logs.openstack.org/29/660329/1/check/puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus/0f1317b/ : SUCCESS in 51m 02s\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic http://logs.openstack.org/29/660329/1/check/puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic/55c3839/ : FAILURE in 22m 50s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic http://logs.openstack.org/29/660329/1/check/puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic/d9941d3/ : FAILURE in 20m 32s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic http://logs.openstack.org/29/660329/1/check/puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic/2adb8eb/ : FAILURE in 27m 37s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic http://logs.openstack.org/29/660329/1/check/puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic/a865a30/ : FAILURE in 26m 38s (non-voting)\n- puppet-openstack-beaker-centos-7 http://logs.openstack.org/29/660329/1/check/puppet-openstack-beaker-centos-7/07f562d/ : SUCCESS in 23m 21s\n- puppet-openstack-beaker-ubuntu-bionic http://logs.openstack.org/29/660329/1/check/puppet-openstack-beaker-ubuntu-bionic/9512acc/ : FAILURE in 8m 04s (non-voting)\n- build-openstack-releasenotes http://logs.openstack.org/29/660329/1/check/build-openstack-releasenotes/70feed2/html/ : SUCCESS in 2m 23s\n- puppet-nova-tripleo-standalone http://logs.openstack.org/29/660329/1/check/puppet-nova-tripleo-standalone/a3d7ded/ : SUCCESS in 2h 50m 50s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3ae74935b41d9df0aa60870cbaf8184164a00cba","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-05-21 15:03:16.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3cac5e2e90fcf607ebcf5f8164432d7a0da10520","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-05-21 15:45:55.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"d0463aca771e9f4272b0bb3776255ae3c9fca171","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-21 15:46:06.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"26b98f0b8ba0f8d5641c1ddce8b9938e4538261a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-21 18:31:26.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"587efa5e5f7635dee5005c0d7e4d8347e80c02ff","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-21 18:31:26.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic http://logs.openstack.org/29/660329/1/gate/puppet-openstack-lint-ubuntu-bionic/02e2275/ : SUCCESS in 4m 31s\n- puppet-openstack-syntax-4-ubuntu-bionic http://logs.openstack.org/29/660329/1/gate/puppet-openstack-syntax-4-ubuntu-bionic/fdf5603/ : SUCCESS in 3m 58s\n- puppet-openstack-syntax-5-ubuntu-bionic http://logs.openstack.org/29/660329/1/gate/puppet-openstack-syntax-5-ubuntu-bionic/eb3b756/ : SUCCESS in 4m 09s\n- puppet-openstack-syntax-6-ubuntu-bionic http://logs.openstack.org/29/660329/1/gate/puppet-openstack-syntax-6-ubuntu-bionic/c83623f/ : SUCCESS in 3m 54s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/29/660329/1/gate/puppet-openstack-unit-4.8-centos-7/34e2621/ : SUCCESS in 33m 47s\n- puppet-openstack-unit-5.5-centos-7 http://logs.openstack.org/29/660329/1/gate/puppet-openstack-unit-5.5-centos-7/1129ea4/ : SUCCESS in 27m 35s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous http://logs.openstack.org/29/660329/1/gate/puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous/0ba14d5/ : SUCCESS in 59m 56s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 http://logs.openstack.org/29/660329/1/gate/puppet-openstack-integration-5-scenario002-tempest-centos-7/7b863b9/ : SUCCESS in 1h 06m 07s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 http://logs.openstack.org/29/660329/1/gate/puppet-openstack-integration-5-scenario003-tempest-centos-7/49b2223/ : SUCCESS in 59m 47s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus http://logs.openstack.org/29/660329/1/gate/puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus/3302f9e/ : SUCCESS in 44m 14s\n- puppet-openstack-beaker-centos-7 http://logs.openstack.org/29/660329/1/gate/puppet-openstack-beaker-centos-7/afcb21e/ : SUCCESS in 21m 08s\n- puppet-openstack-beaker-ubuntu-bionic http://logs.openstack.org/29/660329/1/gate/puppet-openstack-beaker-ubuntu-bionic/f2bb9f4/ : FAILURE in 12m 53s (non-voting)\n- build-openstack-releasenotes http://logs.openstack.org/29/660329/1/gate/build-openstack-releasenotes/3a28c2a/html/ : SUCCESS in 3m 54s\n- puppet-nova-tripleo-standalone http://logs.openstack.org/29/660329/1/gate/puppet-nova-tripleo-standalone/963a41f/ : FAILURE in 2h 27m 27s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a82d06399b4abdfe654eb83beff2c70ef17e52fd","revisions":{"a82d06399b4abdfe654eb83beff2c70ef17e52fd":{"kind":"REWORK","_number":1,"created":"2019-05-21 09:55:13.000000000","uploader":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"ref":"refs/changes/29/660329/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/29/660329/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/29/660329/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/29/660329/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/29/660329/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/29/660329/1"}}},"commit":{"parents":[{"commit":"2f2508638a42a4f7d9ebaf6d8657e6ef2c1df934","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/2f2508638a42a4f7d9ebaf6d8657e6ef2c1df934"}]}],"author":{"name":"Rajesh Tailor","email":"ratailor@redhat.com","date":"2019-04-30 06:17:12.000000000","tz":330},"committer":{"name":"Rajesh Tailor","email":"ratailor@redhat.com","date":"2019-05-21 09:55:13.000000000","tz":0},"subject":"Add cinder credentials in nova conf","message":"Add cinder credentials in nova conf\n\nAdded user/project CONF with admin role at cinder group,\nand when determine context is_admin and without token, do\nauthenticaion with user/project info to call cinder api.\n\nWhen set reclaim_instance_interval \u003e 0, and then delete an\ninstance which booted from volume with `delete_on_termination`\nset as true. After reclaim_instance_interval time pass,\nall volumes boot instance with state: attached and in-use,\neven when attached instances was deleted.\n\nThis happens because as admin context from\n`nova.compute.manager._reclaim_queued_deletes` did not have\nany token info, then call cinder api would be failed.\n\nThe corresponding nova changes merged in change\nhttps://review.opendev.org/#/c/522112/\n\nRelated-Bug: #1734025\nChange-Id: Ib58c2ca04dfe6d1e1ff849f600a9a24724205078\n(cherry picked from commit 848ac0b5e101850e7c3ad5140ac87e5476603f1b)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/a82d06399b4abdfe654eb83beff2c70ef17e52fd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/a82d06399b4abdfe654eb83beff2c70ef17e52fd"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}