)]}'
{"manifests/cinder.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7543bc4b9cdb0dcb813711b8ed2a84b3c5c599d0","unresolved":false,"context_lines":[{"line_number":62,"context_line":") {"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  include ::nova::deps"},{"line_number":65,"context_line":"  include ::nova::keystone::service_user"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  nova_config {"},{"line_number":68,"context_line":"    \u0027cinder/password\u0027:            value \u003d\u003e $password, secret \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7faddb67_64c6a96a","line":65,"updated":"2019-07-08 19:24:24.000000000","message":"As mentioned in puppet-cider, I don\u0027t think we should include this by default.","commit_id":"c365a470c657c6ea7cb77b2e10bc16de20a6889f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c7a0f9e178aaaba2cb7a835e92e5abb0cf19510d","unresolved":false,"context_lines":[{"line_number":62,"context_line":") {"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  include ::nova::deps"},{"line_number":65,"context_line":"  include ::nova::keystone::service_user"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  nova_config {"},{"line_number":68,"context_line":"    \u0027cinder/password\u0027:            value \u003d\u003e $password, secret \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7faddb67_808fae21","line":65,"updated":"2019-07-31 20:08:37.000000000","message":"please remove this part from here. I don\u0027t think we should be including this by default","commit_id":"ab4397c476cf29a81311b2c355acfb8b7202af97"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5e48663cd88dfa8386d6c15086606e522fd2381b","unresolved":false,"context_lines":[{"line_number":62,"context_line":") {"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  include ::nova::deps"},{"line_number":65,"context_line":"  include ::nova::keystone::service_user"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  nova_config {"},{"line_number":68,"context_line":"    \u0027cinder/password\u0027:            value \u003d\u003e $password, secret \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7faddb67_8f31190e","line":65,"in_reply_to":"7faddb67_808fae21","updated":"2019-08-01 03:53:37.000000000","message":"Done.\n\nThanks for the catch. I missed to remove this when I updated my patch according to the given suggestion.","commit_id":"ab4397c476cf29a81311b2c355acfb8b7202af97"}],"manifests/keystone/service_token.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"472f9486ac7257cf89b14cb666748fecd7e88082","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  $project_name             \u003d \u0027services\u0027,"},{"line_number":71,"context_line":"  $user_domain_name         \u003d \u0027Default\u0027,"},{"line_number":72,"context_line":"  $project_domain_name      \u003d \u0027Default\u0027,"},{"line_number":73,"context_line":"  $send_service_user_token  \u003d false,"},{"line_number":74,"context_line":"  $insecure                 \u003d $::os_service_default,"},{"line_number":75,"context_line":"  $auth_type                \u003d \u0027password\u0027,"},{"line_number":76,"context_line":"  $auth_version             \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9fb8cfa7_d81654a8","line":73,"range":{"start_line":73,"start_character":27,"end_line":73,"end_character":28},"updated":"2019-06-20 07:39:25.000000000","message":"align \u003d","commit_id":"2e083986d1f3893d31d59ea130d52d66f58a3b89"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"257559f89c187c4f9bec7406b25fd14f83432616","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  $project_name             \u003d \u0027services\u0027,"},{"line_number":71,"context_line":"  $user_domain_name         \u003d \u0027Default\u0027,"},{"line_number":72,"context_line":"  $project_domain_name      \u003d \u0027Default\u0027,"},{"line_number":73,"context_line":"  $send_service_user_token  \u003d false,"},{"line_number":74,"context_line":"  $insecure                 \u003d $::os_service_default,"},{"line_number":75,"context_line":"  $auth_type                \u003d \u0027password\u0027,"},{"line_number":76,"context_line":"  $auth_version             \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9fb8cfa7_387690da","line":73,"range":{"start_line":73,"start_character":27,"end_line":73,"end_character":28},"in_reply_to":"9fb8cfa7_d81654a8","updated":"2019-06-20 07:52:41.000000000","message":"Done","commit_id":"2e083986d1f3893d31d59ea130d52d66f58a3b89"}],"spec/classes/nova_keystone_sevice_token_spec.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"472f9486ac7257cf89b14cb666748fecd7e88082","unresolved":false,"context_lines":[{"line_number":42,"context_line":"          :auth_type                            \u003d\u003e \u0027password\u0027,"},{"line_number":43,"context_line":"          :auth_version                         \u003d\u003e \u0027v3\u0027,"},{"line_number":44,"context_line":"          :cafile                               \u003d\u003e"},{"line_number":45,"context_line":"\u0027/opt/stack/data/cafile.pem\u0027,"},{"line_number":46,"context_line":"          :certfile                             \u003d\u003e \u0027certfile.crt\u0027,"},{"line_number":47,"context_line":"          :keyfile                              \u003d\u003e \u0027keyfile\u0027,"},{"line_number":48,"context_line":"          :region_name                          \u003d\u003e \u0027region2\u0027,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9fb8cfa7_9810dcaa","line":45,"updated":"2019-06-20 07:39:25.000000000","message":"remove newline","commit_id":"2e083986d1f3893d31d59ea130d52d66f58a3b89"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"257559f89c187c4f9bec7406b25fd14f83432616","unresolved":false,"context_lines":[{"line_number":42,"context_line":"          :auth_type                            \u003d\u003e \u0027password\u0027,"},{"line_number":43,"context_line":"          :auth_version                         \u003d\u003e \u0027v3\u0027,"},{"line_number":44,"context_line":"          :cafile                               \u003d\u003e"},{"line_number":45,"context_line":"\u0027/opt/stack/data/cafile.pem\u0027,"},{"line_number":46,"context_line":"          :certfile                             \u003d\u003e \u0027certfile.crt\u0027,"},{"line_number":47,"context_line":"          :keyfile                              \u003d\u003e \u0027keyfile\u0027,"},{"line_number":48,"context_line":"          :region_name                          \u003d\u003e \u0027region2\u0027,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9fb8cfa7_b84b6085","line":45,"in_reply_to":"9fb8cfa7_9810dcaa","updated":"2019-06-20 07:52:41.000000000","message":"Done\n\nAlso fixed spec file for auth_token as this comes from it.","commit_id":"2e083986d1f3893d31d59ea130d52d66f58a3b89"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"472f9486ac7257cf89b14cb666748fecd7e88082","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        facts.merge!(OSDefaults.get_facts())"},{"line_number":77,"context_line":"      end"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"      it_configures \u0027nova service_token\u0027"},{"line_number":80,"context_line":"    end"},{"line_number":81,"context_line":"  end"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9fb8cfa7_f820f8f9","line":79,"range":{"start_line":79,"start_character":6,"end_line":79,"end_character":19},"updated":"2019-06-20 07:39:25.000000000","message":"nit: it_behaves_like","commit_id":"2e083986d1f3893d31d59ea130d52d66f58a3b89"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"257559f89c187c4f9bec7406b25fd14f83432616","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        facts.merge!(OSDefaults.get_facts())"},{"line_number":77,"context_line":"      end"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"      it_configures \u0027nova service_token\u0027"},{"line_number":80,"context_line":"    end"},{"line_number":81,"context_line":"  end"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9fb8cfa7_585a6450","line":79,"range":{"start_line":79,"start_character":6,"end_line":79,"end_character":19},"in_reply_to":"9fb8cfa7_f820f8f9","updated":"2019-06-20 07:52:41.000000000","message":"Done","commit_id":"2e083986d1f3893d31d59ea130d52d66f58a3b89"}]}
