)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"c2f8a93a7c8519722b6062bb99fccb293019cfa7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to enforce for incoming client connections to the console proxy"},{"line_number":12,"context_line":"services (VNC, SPICE, etc)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: 679502"},{"line_number":15,"context_line":"Change-Id: I3a1262f70f6a801db276701a39ebb01f40025192"},{"line_number":16,"context_line":"Related-Bug: 1842149"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5faad753_6bb53aee","line":14,"range":{"start_line":14,"start_character":12,"end_line":14,"end_character":18},"updated":"2019-09-07 07:19:12.000000000","message":"should be https://review.opendev.org/#/c/679502","commit_id":"3f97e4469a61cd5004f2dfe5f4fb2b35c212f5bd"}],"manifests/init.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7724c6b18727121d2cf1b2c69bb9cee0d2cce6f0","unresolved":false,"context_lines":[{"line_number":502,"context_line":"  $nova_private_key                       \u003d undef,"},{"line_number":503,"context_line":"  $ssl_only                               \u003d false,"},{"line_number":504,"context_line":"  $ssl_ciphers                            \u003d undef,"},{"line_number":505,"context_line":"  $ssl_minimum_version                    \u003d undef,"},{"line_number":506,"context_line":"  $cert                                   \u003d $::os_service_default,"},{"line_number":507,"context_line":"  $key                                    \u003d $::os_service_default,"},{"line_number":508,"context_line":"  $notification_transport_url             \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3fa7e38b_b37e0617","line":505,"updated":"2019-09-20 18:54:27.000000000","message":"These should be $::os_service_default","commit_id":"c91d1d9992d6173a7508961543228762f20f0e58"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"7e6e8004504e2f76227a9d550f79f37cbfb3984b","unresolved":false,"context_lines":[{"line_number":502,"context_line":"  $nova_private_key                       \u003d undef,"},{"line_number":503,"context_line":"  $ssl_only                               \u003d false,"},{"line_number":504,"context_line":"  $ssl_ciphers                            \u003d undef,"},{"line_number":505,"context_line":"  $ssl_minimum_version                    \u003d undef,"},{"line_number":506,"context_line":"  $cert                                   \u003d $::os_service_default,"},{"line_number":507,"context_line":"  $key                                    \u003d $::os_service_default,"},{"line_number":508,"context_line":"  $notification_transport_url             \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3fa7e38b_9957195a","line":505,"in_reply_to":"3fa7e38b_b37e0617","updated":"2020-02-11 21:52:56.000000000","message":"Done","commit_id":"c91d1d9992d6173a7508961543228762f20f0e58"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7724c6b18727121d2cf1b2c69bb9cee0d2cce6f0","unresolved":false,"context_lines":[{"line_number":667,"context_line":""},{"line_number":668,"context_line":"  if $ssl_minimum_version {"},{"line_number":669,"context_line":"    nova_config { \u0027DEFAULT/ssl_minimum_version\u0027: value \u003d\u003e $ssl_minimum_version }"},{"line_number":670,"context_line":"  }"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"  oslo::messaging::rabbit {\u0027nova_config\u0027:"},{"line_number":673,"context_line":"    rabbit_use_ssl              \u003d\u003e $rabbit_use_ssl,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3fa7e38b_d379422f","line":670,"updated":"2019-09-20 18:54:27.000000000","message":"we don\u0027t need the if statements around these.","commit_id":"c91d1d9992d6173a7508961543228762f20f0e58"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"7e6e8004504e2f76227a9d550f79f37cbfb3984b","unresolved":false,"context_lines":[{"line_number":667,"context_line":""},{"line_number":668,"context_line":"  if $ssl_minimum_version {"},{"line_number":669,"context_line":"    nova_config { \u0027DEFAULT/ssl_minimum_version\u0027: value \u003d\u003e $ssl_minimum_version }"},{"line_number":670,"context_line":"  }"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"  oslo::messaging::rabbit {\u0027nova_config\u0027:"},{"line_number":673,"context_line":"    rabbit_use_ssl              \u003d\u003e $rabbit_use_ssl,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3fa7e38b_34670755","line":670,"in_reply_to":"3fa7e38b_d379422f","updated":"2020-02-11 21:52:56.000000000","message":"Moved these inside the same block that has the cert and key.","commit_id":"c91d1d9992d6173a7508961543228762f20f0e58"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"336462c3559086a399f98ca8034679bf99398f96","unresolved":false,"context_lines":[{"line_number":282,"context_line":"#   allow for TLS connections from clients.  See the man page for the OpenSSL"},{"line_number":283,"context_line":"#   \u0027ciphers\u0027 command for details of the cipher preference string format and"},{"line_number":284,"context_line":"#   allowed values."},{"line_number":285,"context_line":"#   Defaults to undef"},{"line_number":286,"context_line":"#"},{"line_number":287,"context_line":"# [*console_ssl_minimum_version*]"},{"line_number":288,"context_line":"#   (optional) Minimum allowed SSL/TLS protocol version.  Valid values are"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3fa7e38b_25edf7b8","line":285,"range":{"start_line":285,"start_character":16,"end_line":285,"end_character":21},"updated":"2020-02-21 15:02:33.000000000","message":"... and updated this as we\u0027ve changed replace this undef by $::os_service_default","commit_id":"68a9be913df509f659f0b0a915b353de6c69cde6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"336462c3559086a399f98ca8034679bf99398f96","unresolved":false,"context_lines":[{"line_number":288,"context_line":"#   (optional) Minimum allowed SSL/TLS protocol version.  Valid values are"},{"line_number":289,"context_line":"#   \u0027default\u0027, \u0027tlsv1_1\u0027, \u0027tlsv1_2\u0027, and \u0027tlsv1_3\u0027.  A value of \u0027default\u0027 will"},{"line_number":290,"context_line":"#   use the underlying system OpenSSL defaults."},{"line_number":291,"context_line":"#   Defaults to undef"},{"line_number":292,"context_line":"#"},{"line_number":293,"context_line":"# [*cert*]"},{"line_number":294,"context_line":"#   (optional) Path to SSL certificate file."}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3fa7e38b_c5ebc3a2","line":291,"range":{"start_line":291,"start_character":16,"end_line":291,"end_character":21},"updated":"2020-02-21 15:02:33.000000000","message":"ditto","commit_id":"68a9be913df509f659f0b0a915b353de6c69cde6"}],"spec/classes/nova_init_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"57a1b0c60b06c86bc294d67aca94a5f8169b7e80","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/ssl_only\u0027).with_value(false)"},{"line_number":63,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/cert\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":64,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/key\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":65,"context_line":"        is_expected.to_not contain_nova_config(\u0027console/ssl_ciphers\u0027)"},{"line_number":66,"context_line":"        is_expected.to_not contain_nova_config(\u0027console/ssl_minimum_version\u0027)"},{"line_number":67,"context_line":"      end"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":8,"id":"3fa7e38b_f88a2764","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":69},"updated":"2020-02-21 12:37:36.000000000","message":"this should be\n\n  is_expected.to contain_nova_config(\u0027console/ssl_ciphers\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)\n\nas you pass $::os_service_default by default","commit_id":"156ae98a4049c54685722a25d4e6debf3b4c7cc7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a32f4bad8ea31346ee44f346f4b25d4f0a77b84a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/ssl_only\u0027).with_value(false)"},{"line_number":63,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/cert\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":64,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/key\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":65,"context_line":"        is_expected.to_not contain_nova_config(\u0027console/ssl_ciphers\u0027)"},{"line_number":66,"context_line":"        is_expected.to_not contain_nova_config(\u0027console/ssl_minimum_version\u0027)"},{"line_number":67,"context_line":"      end"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":8,"id":"3fa7e38b_98b77323","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":69},"in_reply_to":"3fa7e38b_f88a2764","updated":"2020-02-21 12:42:20.000000000","message":"Done","commit_id":"156ae98a4049c54685722a25d4e6debf3b4c7cc7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"57a1b0c60b06c86bc294d67aca94a5f8169b7e80","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/cert\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":64,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/key\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":65,"context_line":"        is_expected.to_not contain_nova_config(\u0027console/ssl_ciphers\u0027)"},{"line_number":66,"context_line":"        is_expected.to_not contain_nova_config(\u0027console/ssl_minimum_version\u0027)"},{"line_number":67,"context_line":"      end"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"      it \u0027configures block_device_allocate params\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"3fa7e38b_9889b371","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":77},"updated":"2020-02-21 12:37:36.000000000","message":"ditto","commit_id":"156ae98a4049c54685722a25d4e6debf3b4c7cc7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a2568326b380633162cba077a4d74dd2c1820a7a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/cert\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":64,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/key\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":65,"context_line":"        is_expected.to_not contain_nova_config(\u0027console/ssl_ciphers\u0027)"},{"line_number":66,"context_line":"        is_expected.to_not contain_nova_config(\u0027console/ssl_minimum_version\u0027)"},{"line_number":67,"context_line":"      end"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"      it \u0027configures block_device_allocate params\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"3fa7e38b_85f70b29","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":77},"in_reply_to":"3fa7e38b_33b3009c","updated":"2020-02-21 14:27:07.000000000","message":"sorry. it was my mistake to add the duplicated ssl.(see patch 9)\n\nanyway it should be fixed now.","commit_id":"156ae98a4049c54685722a25d4e6debf3b4c7cc7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a32f4bad8ea31346ee44f346f4b25d4f0a77b84a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/cert\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":64,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/key\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":65,"context_line":"        is_expected.to_not contain_nova_config(\u0027console/ssl_ciphers\u0027)"},{"line_number":66,"context_line":"        is_expected.to_not contain_nova_config(\u0027console/ssl_minimum_version\u0027)"},{"line_number":67,"context_line":"      end"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"      it \u0027configures block_device_allocate params\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"3fa7e38b_b8b26f30","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":77},"in_reply_to":"3fa7e38b_9889b371","updated":"2020-02-21 12:42:20.000000000","message":"Done.\n\nAnd ssl_ssl_minimum_version should be replaced by ssl_minimum_version, IMO.","commit_id":"156ae98a4049c54685722a25d4e6debf3b4c7cc7"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"38535b28c2dc78986b4cda40222bf16d9a887c47","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/cert\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":64,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/key\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":65,"context_line":"        is_expected.to_not contain_nova_config(\u0027console/ssl_ciphers\u0027)"},{"line_number":66,"context_line":"        is_expected.to_not contain_nova_config(\u0027console/ssl_minimum_version\u0027)"},{"line_number":67,"context_line":"      end"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"      it \u0027configures block_device_allocate params\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"3fa7e38b_33b3009c","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":77},"in_reply_to":"3fa7e38b_b8b26f30","updated":"2020-02-21 14:19:29.000000000","message":"Thanks for the help with the patch, Takashi.  I\u0027m not sure I understand where you\u0027re seeing ssl_ssl_minimum_version with two ssl?","commit_id":"156ae98a4049c54685722a25d4e6debf3b4c7cc7"}]}