)]}'
{"manifests/compute.pp":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"7ed4296dd6c328d4bb762d19392878329691922a","unresolved":false,"context_lines":[{"line_number":284,"context_line":"  }"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"  # if cpu_dedicated_set is not set, vcpu_pin_set is set."},{"line_number":287,"context_line":"  if empty($cpu_dedicated_set) and !empty($vcpu_pin_set) {"},{"line_number":288,"context_line":"    nova_config {"},{"line_number":289,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assignes service default"},{"line_number":290,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"3fa7e38b_2426b2b9","line":287,"range":{"start_line":287,"start_character":0,"end_line":287,"end_character":58},"updated":"2019-09-16 14:36:21.000000000","message":"you\u0027d need to modify all conditions that you run only one of them or you get the duplicate declaration errors like in \nhttps://zuul.opendev.org/t/openstack/build/724ab80374c249d2ba3594125936f1c9/console","commit_id":"e2a23ea983e39838cbe16c82d8bfe1ec46e9fdc2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"af9ac985d050725097deee2e8e47468e2ea1605c","unresolved":false,"context_lines":[{"line_number":267,"context_line":"  }"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"  if $vcpu_pin_set {"},{"line_number":270,"context_line":"    warning(\u0027vcpu_pin_set is deprecated, instead use cpu_dedicated_set.\u0027)"},{"line_number":271,"context_line":"  }"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"  if $vcpu_pin_set !\u003d $::os_service_default and $cpu_dedicated_set !\u003d $::os_service_default {"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"3fa7e38b_b9bcf9bb","line":270,"range":{"start_line":270,"start_character":41,"end_line":270,"end_character":70},"updated":"2019-09-17 10:58:03.000000000","message":"instead use cpu_dedicated_set or cpu_shared_set\n\nvcpu_pin_set is used for both pinned and unpinned instances so you can\u0027t say migrate to one or the other. Instead, the decision must be made based on whether the host is intended for pinned instances or not (typically determined via host aggregate metadata)","commit_id":"8e4e24ed0a284615919154394f4c4b51964d3edb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"af9ac985d050725097deee2e8e47468e2ea1605c","unresolved":false,"context_lines":[{"line_number":271,"context_line":"  }"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"  if $vcpu_pin_set !\u003d $::os_service_default and $cpu_dedicated_set !\u003d $::os_service_default {"},{"line_number":274,"context_line":"    fail(\u0027vcpu_pin_set is deprecated. vcpu_pin_set and cpu_dedicated_set is mutually exclusive.\u0027)"},{"line_number":275,"context_line":"  }"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"  # if cpu_shared_set and cpu_dedicated_set both are set, use these and ignore vcpu_pin_set."}],"source_content_type":"text/x-puppet","patch_set":20,"id":"3fa7e38b_59b145e1","line":274,"range":{"start_line":274,"start_character":73,"end_line":274,"end_character":75},"updated":"2019-09-17 10:58:03.000000000","message":"are","commit_id":"8e4e24ed0a284615919154394f4c4b51964d3edb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"af9ac985d050725097deee2e8e47468e2ea1605c","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    nova_config {"},{"line_number":280,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real;"},{"line_number":281,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real;"},{"line_number":282,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real; # assignes service default"},{"line_number":283,"context_line":"    }"},{"line_number":284,"context_line":"  }"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":20,"id":"3fa7e38b_79b681dc","line":282,"range":{"start_line":282,"start_character":66,"end_line":282,"end_character":74},"updated":"2019-09-17 10:58:03.000000000","message":"assigns ?","commit_id":"8e4e24ed0a284615919154394f4c4b51964d3edb"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"8f4bb2078e2cbf203e3ba1d4cd55cbdcc55e8569","unresolved":false,"context_lines":[{"line_number":284,"context_line":"  }"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"  # if vcpu_pin_set is set, but cpu_dedicated_set not."},{"line_number":287,"context_line":"  if !empty($vcpu_pin_set) and empty($cpu_dedicated_set) {"},{"line_number":288,"context_line":"    nova_config {"},{"line_number":289,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assignes service default"},{"line_number":290,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"3fa7e38b_90f4715d","line":287,"range":{"start_line":287,"start_character":0,"end_line":287,"end_character":58},"updated":"2019-09-17 08:52:42.000000000","message":"maybe use a nested condition and combine line 287 and 296 and use a nested if/else where they differ.","commit_id":"8e4e24ed0a284615919154394f4c4b51964d3edb"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"8f4bb2078e2cbf203e3ba1d4cd55cbdcc55e8569","unresolved":false,"context_lines":[{"line_number":302,"context_line":"  }"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"  # if cpu_shared_set is set, but vcpu_pin_set not set"},{"line_number":305,"context_line":"  if !empty($cpu_shared_set) and empty($vcpu_pin_set) {"},{"line_number":306,"context_line":"    nova_config {"},{"line_number":307,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real;"},{"line_number":308,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;      # assignes service default"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"3fa7e38b_10008134","line":305,"range":{"start_line":305,"start_character":0,"end_line":305,"end_character":55},"updated":"2019-09-17 08:52:42.000000000","message":"same here for 278 and 305","commit_id":"8e4e24ed0a284615919154394f4c4b51964d3edb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"81d0c90ce0fe18d3a30da351d4641aa79f321752","unresolved":false,"context_lines":[{"line_number":293,"context_line":"    nova_config {"},{"line_number":294,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":295,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;"},{"line_number":296,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $vcpu_pin_set_real; # vcpu_pin_set override cpu_shared_set"},{"line_number":297,"context_line":"    }"},{"line_number":298,"context_line":"  }"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3fa7e38b_b20cf93b","line":296,"range":{"start_line":296,"start_character":6,"end_line":296,"end_character":7},"updated":"2019-10-03 12:35:45.000000000","message":"As noted in the test, this is wrong. You don\u0027t need to special case cpu_shared_set like this.","commit_id":"1919702009476eeb2458c53b60d530d36e2c0efb"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"c113311686f98eaccaf37c1403803dab4f560a23","unresolved":false,"context_lines":[{"line_number":293,"context_line":"    nova_config {"},{"line_number":294,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":295,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;"},{"line_number":296,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $vcpu_pin_set_real; # vcpu_pin_set override cpu_shared_set"},{"line_number":297,"context_line":"    }"},{"line_number":298,"context_line":"  }"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":34,"id":"3fa7e38b_af3d672d","line":296,"range":{"start_line":296,"start_character":6,"end_line":296,"end_character":7},"in_reply_to":"3fa7e38b_b20cf93b","updated":"2019-10-04 07:56:38.000000000","message":"Done","commit_id":"1919702009476eeb2458c53b60d530d36e2c0efb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"da6cc7cfd18b541961fc1947fb1b2656b065aa6d","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    $vcpu_pin_set_real \u003d undef"},{"line_number":278,"context_line":"  }"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"  if $vcpu_pin_set_real !\u003d undef and $cpu_dedicated_set_real !\u003d $::os_service_default {"},{"line_number":281,"context_line":"    fail(\u0027vcpu_pin_set is deprecated. vcpu_pin_set and cpu_dedicated_set are mutually exclusive.\u0027)"},{"line_number":282,"context_line":"  }"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":38,"id":"3fa7e38b_8cfe6f03","line":280,"range":{"start_line":280,"start_character":64,"end_line":280,"end_character":85},"updated":"2019-10-04 15:38:56.000000000","message":"I don\u0027t know Puppet that well, but what\u0027s this equal to and why aren\u0027t we simply checking for \u0027undef\u0027?","commit_id":"fc5df9ff624c3f67538b9f0d186659b3c7e83163"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"62c0f2579458d2585c66eb94c7ef612d35bbddca","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    $vcpu_pin_set_real \u003d undef"},{"line_number":278,"context_line":"  }"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"  if $vcpu_pin_set_real !\u003d undef and $cpu_dedicated_set_real !\u003d $::os_service_default {"},{"line_number":281,"context_line":"    fail(\u0027vcpu_pin_set is deprecated. vcpu_pin_set and cpu_dedicated_set are mutually exclusive.\u0027)"},{"line_number":282,"context_line":"  }"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":38,"id":"3fa7e38b_acc9eb25","line":280,"range":{"start_line":280,"start_character":4,"end_line":280,"end_character":85},"updated":"2019-10-04 16:08:38.000000000","message":"We have some special puppet openstackism.  Basically this is checking vcpu_pin_set is configured but cpu_dedicated_set is the default.  This should be:\n\n  if $vcpu_pin_set_real and is_service_default($cpu_dedicated_set_real) { ... }\n\nAlso historically if we have renamed a var, we\u0027ll usually do something like...\n\nif $vcpu_pin_set {\n   warning(\u0027vcpu_pin_set is deprecated, use cpu_dedicated_set\u0027)\n}\n\n$cpu_dedicated_set_real \u003d pick($vcp_pin_set, join(any2array($vcpu_pin_set, \u0027,\u0027))), $::os_service_default)\n\n\nthen we just set cpu_dedicated_set in the config with whatever the value is. Since we appear to be splitting shared/dedicated, perhaps it makes sense to just take the legacy value and throw it in the dedicated set? I\u0027m not sure what the impact would be.  If not I would just throw warnings/failures for the incompatible logic sets and call it good.","commit_id":"fc5df9ff624c3f67538b9f0d186659b3c7e83163"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"aad1a4e6a55cf12b38d1d115ccb075116b53baaa","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    $vcpu_pin_set_real \u003d undef"},{"line_number":278,"context_line":"  }"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"  if $vcpu_pin_set_real !\u003d undef and $cpu_dedicated_set_real !\u003d $::os_service_default {"},{"line_number":281,"context_line":"    fail(\u0027vcpu_pin_set is deprecated. vcpu_pin_set and cpu_dedicated_set are mutually exclusive.\u0027)"},{"line_number":282,"context_line":"  }"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":38,"id":"3fa7e38b_01ca366d","line":280,"range":{"start_line":280,"start_character":64,"end_line":280,"end_character":85},"in_reply_to":"3fa7e38b_8cfe6f03","updated":"2019-10-07 06:18:07.000000000","message":"we want to check if this is not undef, which means it is configured. And if cpu_dedicated_set is also configured then we should fail, which is what expected.","commit_id":"fc5df9ff624c3f67538b9f0d186659b3c7e83163"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"da6cc7cfd18b541961fc1947fb1b2656b065aa6d","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    }"},{"line_number":291,"context_line":"  }"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"  # if vcpu_pin_set is set, but cpu_shared_set not."},{"line_number":294,"context_line":"  if $vcpu_pin_set_real !\u003d undef and $cpu_shared_set_real \u003d\u003d $::os_service_default {"},{"line_number":295,"context_line":"    nova_config {"},{"line_number":296,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;"},{"line_number":297,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":298,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real; # assigns service default"},{"line_number":299,"context_line":"    }"},{"line_number":300,"context_line":"  }"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"  # if cpu_shared_set and vcpu_pin_set are set, but cpu_dedicated_set not set."},{"line_number":303,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $vcpu_pin_set_real !\u003d undef {"},{"line_number":304,"context_line":"    nova_config {"},{"line_number":305,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real;"},{"line_number":306,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;"},{"line_number":307,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":308,"context_line":"    }"},{"line_number":309,"context_line":"  }"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"  # if cpu_shared_set is set, but vcpu_pin_set and cpu_dedicated_set are not set."},{"line_number":312,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $vcpu_pin_set_real \u003d\u003d undef and $cpu_dedicated_set_real \u003d\u003d $::os_service_default {"}],"source_content_type":"text/x-puppet","patch_set":38,"id":"3fa7e38b_2c0dfb34","line":309,"range":{"start_line":293,"start_character":0,"end_line":309,"end_character":3},"updated":"2019-10-04 15:38:56.000000000","message":"comments aside, couldn\u0027t you combine these?\n\n  if $vcpu_pin_set_real !\u003d undef {\n    nova_config {\n      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;\n      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real;\n      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real;\n    }\n  }\n\nSince they\u0027re effectively doing the same thing, no?\n\nIn fact, what\u0027s the difference between:\n\n  \u0027compute/vcpu_pin_set\u0027:      ensure \u003d\u003e absent;\n\nand\n\n  \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;\n\nif\n\n  $vcpu_pin_set_real \u003d undef\n\n? Is the \u0027ensure\u0027 just a safety check?","commit_id":"fc5df9ff624c3f67538b9f0d186659b3c7e83163"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"15df1cf1aa3649668bb8a8b1253fb7c34b608ce7","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    }"},{"line_number":291,"context_line":"  }"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"  # if vcpu_pin_set is set, but cpu_shared_set not."},{"line_number":294,"context_line":"  if $vcpu_pin_set_real !\u003d undef and $cpu_shared_set_real \u003d\u003d $::os_service_default {"},{"line_number":295,"context_line":"    nova_config {"},{"line_number":296,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;"},{"line_number":297,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":298,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real; # assigns service default"},{"line_number":299,"context_line":"    }"},{"line_number":300,"context_line":"  }"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"  # if cpu_shared_set and vcpu_pin_set are set, but cpu_dedicated_set not set."},{"line_number":303,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $vcpu_pin_set_real !\u003d undef {"},{"line_number":304,"context_line":"    nova_config {"},{"line_number":305,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real;"},{"line_number":306,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;"},{"line_number":307,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":308,"context_line":"    }"},{"line_number":309,"context_line":"  }"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"  # if cpu_shared_set is set, but vcpu_pin_set and cpu_dedicated_set are not set."},{"line_number":312,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $vcpu_pin_set_real \u003d\u003d undef and $cpu_dedicated_set_real \u003d\u003d $::os_service_default {"}],"source_content_type":"text/x-puppet","patch_set":38,"id":"3fa7e38b_c7fc2eb7","line":309,"range":{"start_line":293,"start_character":0,"end_line":309,"end_character":3},"in_reply_to":"3fa7e38b_27f2e207","updated":"2019-10-07 09:47:53.000000000","message":"Compare [1] and [2]\n\n[1] http://paste.openstack.org/show/781747/\n[2] http://paste.openstack.org/show/781750/","commit_id":"fc5df9ff624c3f67538b9f0d186659b3c7e83163"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"aad1a4e6a55cf12b38d1d115ccb075116b53baaa","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    }"},{"line_number":291,"context_line":"  }"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"  # if vcpu_pin_set is set, but cpu_shared_set not."},{"line_number":294,"context_line":"  if $vcpu_pin_set_real !\u003d undef and $cpu_shared_set_real \u003d\u003d $::os_service_default {"},{"line_number":295,"context_line":"    nova_config {"},{"line_number":296,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;"},{"line_number":297,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":298,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real; # assigns service default"},{"line_number":299,"context_line":"    }"},{"line_number":300,"context_line":"  }"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"  # if cpu_shared_set and vcpu_pin_set are set, but cpu_dedicated_set not set."},{"line_number":303,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $vcpu_pin_set_real !\u003d undef {"},{"line_number":304,"context_line":"    nova_config {"},{"line_number":305,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real;"},{"line_number":306,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;"},{"line_number":307,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":308,"context_line":"    }"},{"line_number":309,"context_line":"  }"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"  # if cpu_shared_set is set, but vcpu_pin_set and cpu_dedicated_set are not set."},{"line_number":312,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $vcpu_pin_set_real \u003d\u003d undef and $cpu_dedicated_set_real \u003d\u003d $::os_service_default {"}],"source_content_type":"text/x-puppet","patch_set":38,"id":"3fa7e38b_41ad8e99","line":309,"range":{"start_line":293,"start_character":0,"end_line":309,"end_character":3},"in_reply_to":"3fa7e38b_2c0dfb34","updated":"2019-10-07 06:18:07.000000000","message":"No, both are doing different things. That\u0027s why I have added comments to make is clear for myself as well. \n\n\nHere we are checking for condition, when vcpu_pin_set is set,\n but cpu_shared_set is not set. (and since vcpu_pin_set is set, \nwe don\u0027t need to check for cpu_dedicated_set as both are mutually exclusive.)\nso here vcpu_pin_set will take \n  # if vcpu_pin_set is set, but cpu_shared_set not.\n  if $vcpu_pin_set_real !\u003d undef and $cpu_shared_set_real \u003d\u003d $::os_service_default {\n    nova_config {\n      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;\n      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assigns service default\n      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real; # assigns service default\n    }\n  }\n\n\nHere we are checking if cpu_shared_set and vcpu_pin_set both are set,\nand obviously cpu_dedicated_set would not be set and is default.\n\n\n  # if cpu_shared_set and vcpu_pin_set are set, but cpu_dedicated_set not set.\n  if $cpu_shared_set_real !\u003d $::os_service_default and $vcpu_pin_set_real !\u003d undef {\n    nova_config {\n      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real;\n      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;\n      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assigns service default\n    }\n  }\n\n\nAnd regarding difference between both:\n1) \u0027compute/vcpu_pin_set\u0027:      ensure \u003d\u003e absent;\nhere we are making sure that it is absent from nova.conf file, since it is deprecated and generally deprecated parameters are default to undef and absent from conf.\nBut since we have special case, I make sure to add it to conf it it is defined otherwise not.\n\u0027compute/vcpu_pin_set\u0027:      ensure \u003d\u003e absent;\n\n2) \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;\nAnd it set the parameter value in nova.conf to whatever is the value of vcpu_pin_set_real parameter.","commit_id":"fc5df9ff624c3f67538b9f0d186659b3c7e83163"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2e7ff63c93a9c828f9b72af218084fdf3ee9e84a","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    }"},{"line_number":291,"context_line":"  }"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"  # if vcpu_pin_set is set, but cpu_shared_set not."},{"line_number":294,"context_line":"  if $vcpu_pin_set_real !\u003d undef and $cpu_shared_set_real \u003d\u003d $::os_service_default {"},{"line_number":295,"context_line":"    nova_config {"},{"line_number":296,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;"},{"line_number":297,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":298,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real; # assigns service default"},{"line_number":299,"context_line":"    }"},{"line_number":300,"context_line":"  }"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"  # if cpu_shared_set and vcpu_pin_set are set, but cpu_dedicated_set not set."},{"line_number":303,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $vcpu_pin_set_real !\u003d undef {"},{"line_number":304,"context_line":"    nova_config {"},{"line_number":305,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real;"},{"line_number":306,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;"},{"line_number":307,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":308,"context_line":"    }"},{"line_number":309,"context_line":"  }"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"  # if cpu_shared_set is set, but vcpu_pin_set and cpu_dedicated_set are not set."},{"line_number":312,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $vcpu_pin_set_real \u003d\u003d undef and $cpu_dedicated_set_real \u003d\u003d $::os_service_default {"}],"source_content_type":"text/x-puppet","patch_set":38,"id":"3fa7e38b_27f2e207","line":309,"range":{"start_line":293,"start_character":0,"end_line":309,"end_character":3},"in_reply_to":"3fa7e38b_41ad8e99","updated":"2019-10-07 09:41:02.000000000","message":"\u003e No, both are doing different things. That\u0027s why I have added\n \u003e comments to make is clear for myself as well.\n \u003e \n \u003e \n \u003e Here we are checking for condition, when vcpu_pin_set is set,\n \u003e but cpu_shared_set is not set. (and since vcpu_pin_set is set,\n \u003e we don\u0027t need to check for cpu_dedicated_set as both are mutually\n \u003e exclusive.)\n \u003e so here vcpu_pin_set will take\n \u003e # if vcpu_pin_set is set, but cpu_shared_set not.\n \u003e if $vcpu_pin_set_real !\u003d undef and $cpu_shared_set_real \u003d\u003d $::os_service_default {\n\nSo this is the first conditional.\n\n \u003e nova_config {\n \u003e \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;\n \u003e \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; #\n \u003e assigns service default\n \u003e \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real; #\n \u003e assigns service default\n \u003e }\n \u003e }\n\nThis is the first block.\n\n \u003e \n \u003e Here we are checking if cpu_shared_set and vcpu_pin_set both are\n \u003e set,\n \u003e and obviously cpu_dedicated_set would not be set and is default.\n \u003e \n \u003e \n \u003e # if cpu_shared_set and vcpu_pin_set are set, but cpu_dedicated_set not set.\n \u003e if $cpu_shared_set_real !\u003d $::os_service_default and $vcpu_pin_set_real !\u003d undef {\n\nThis is the second conditional\n\n \u003e nova_config {\n \u003e \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real;\n \u003e \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;\n \u003e \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; #\n \u003e assigns service default\n \u003e }\n \u003e }\n\nAnd this is the second block. The conditionals are different but the blocks are the same, so couldn\u0027t we just combine this conditionals and have one block?\n\n \u003e And regarding difference between both:\n \u003e 1) \u0027compute/vcpu_pin_set\u0027:      ensure \u003d\u003e absent;\n \u003e here we are making sure that it is absent from nova.conf file,\n \u003e since it is deprecated and generally deprecated parameters are\n \u003e default to undef and absent from conf.\n \u003e But since we have special case, I make sure to add it to conf it it\n \u003e is defined otherwise not.\n \u003e \u0027compute/vcpu_pin_set\u0027:      ensure \u003d\u003e absent;\n \u003e \n \u003e 2) \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;\n \u003e And it set the parameter value in nova.conf to whatever is the\n \u003e value of vcpu_pin_set_real parameter.\n\nAck, thanks","commit_id":"fc5df9ff624c3f67538b9f0d186659b3c7e83163"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"1818f7054fe22be32be9c08995f9ab88058ec4d1","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    }"},{"line_number":291,"context_line":"  }"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"  # if vcpu_pin_set is set, but cpu_shared_set not."},{"line_number":294,"context_line":"  if $vcpu_pin_set_real !\u003d undef and $cpu_shared_set_real \u003d\u003d $::os_service_default {"},{"line_number":295,"context_line":"    nova_config {"},{"line_number":296,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;"},{"line_number":297,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":298,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real; # assigns service default"},{"line_number":299,"context_line":"    }"},{"line_number":300,"context_line":"  }"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"  # if cpu_shared_set and vcpu_pin_set are set, but cpu_dedicated_set not set."},{"line_number":303,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $vcpu_pin_set_real !\u003d undef {"},{"line_number":304,"context_line":"    nova_config {"},{"line_number":305,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real;"},{"line_number":306,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;"},{"line_number":307,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":308,"context_line":"    }"},{"line_number":309,"context_line":"  }"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"  # if cpu_shared_set is set, but vcpu_pin_set and cpu_dedicated_set are not set."},{"line_number":312,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $vcpu_pin_set_real \u003d\u003d undef and $cpu_dedicated_set_real \u003d\u003d $::os_service_default {"}],"source_content_type":"text/x-puppet","patch_set":38,"id":"3fa7e38b_e7ca8a4d","line":309,"range":{"start_line":293,"start_character":0,"end_line":309,"end_character":3},"in_reply_to":"3fa7e38b_c7fc2eb7","updated":"2019-10-07 10:10:16.000000000","message":"Thanks a lot, I think this makes sense, I will make the required changes and if puppet doesn\u0027t complain about it, then we are good with this.","commit_id":"fc5df9ff624c3f67538b9f0d186659b3c7e83163"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"da6cc7cfd18b541961fc1947fb1b2656b065aa6d","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    }"},{"line_number":309,"context_line":"  }"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"  # if cpu_shared_set is set, but vcpu_pin_set and cpu_dedicated_set are not set."},{"line_number":312,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $vcpu_pin_set_real \u003d\u003d undef and $cpu_dedicated_set_real \u003d\u003d $::os_service_default {"},{"line_number":313,"context_line":"    nova_config {"},{"line_number":314,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value  \u003d\u003e $cpu_shared_set_real;"},{"line_number":315,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value  \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":316,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      ensure \u003d\u003e absent;  # when undef, don\u0027t include in conf"},{"line_number":317,"context_line":"    }"},{"line_number":318,"context_line":"  }"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"  # if cpu_dedicated_set is set but cpu_shared_set is not set."},{"line_number":321,"context_line":"  if $cpu_dedicated_set_real !\u003d $::os_service_default and $cpu_shared_set_real \u003d\u003d $::os_service_default {"},{"line_number":322,"context_line":"    nova_config {"},{"line_number":323,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value  \u003d\u003e $cpu_dedicated_set_real;"},{"line_number":324,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value  \u003d\u003e $cpu_shared_set_real; # assigns service default"},{"line_number":325,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      ensure \u003d\u003e absent;   # when undef, don\u0027t include in conf"},{"line_number":326,"context_line":"    }"},{"line_number":327,"context_line":"  }"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"  # cryptsetup is required when Barbican is encrypting volumes"}],"source_content_type":"text/x-puppet","patch_set":38,"id":"3fa7e38b_8c274fb7","line":326,"range":{"start_line":311,"start_character":0,"end_line":326,"end_character":5},"updated":"2019-10-04 15:38:56.000000000","message":"ditto","commit_id":"fc5df9ff624c3f67538b9f0d186659b3c7e83163"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"62c0f2579458d2585c66eb94c7ef612d35bbddca","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    fail(\u0027vcpu_pin_set is deprecated. vcpu_pin_set and cpu_dedicated_set are mutually exclusive.\u0027)"},{"line_number":282,"context_line":"  }"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"  # if cpu_shared_set and cpu_dedicated_set both are set, use these and ignore vcpu_pin_set."},{"line_number":285,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $cpu_dedicated_set_real !\u003d $::os_service_default {"},{"line_number":286,"context_line":"    nova_config {"},{"line_number":287,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value  \u003d\u003e $cpu_shared_set_real;"},{"line_number":288,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value  \u003d\u003e $cpu_dedicated_set_real;"},{"line_number":289,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      ensure \u003d\u003e absent;  # when undef, don\u0027t include in conf."},{"line_number":290,"context_line":"    }"},{"line_number":291,"context_line":"  }"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"  # if vcpu_pin_set is set, but cpu_shared_set not."},{"line_number":294,"context_line":"  if $vcpu_pin_set_real !\u003d undef and $cpu_shared_set_real \u003d\u003d $::os_service_default {"},{"line_number":295,"context_line":"    nova_config {"},{"line_number":296,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;"},{"line_number":297,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":298,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real; # assigns service default"},{"line_number":299,"context_line":"    }"},{"line_number":300,"context_line":"  }"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"  # if cpu_shared_set and vcpu_pin_set are set, but cpu_dedicated_set not set."},{"line_number":303,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $vcpu_pin_set_real !\u003d undef {"},{"line_number":304,"context_line":"    nova_config {"},{"line_number":305,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real;"},{"line_number":306,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;"},{"line_number":307,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":308,"context_line":"    }"},{"line_number":309,"context_line":"  }"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"  # if cpu_shared_set is set, but vcpu_pin_set and cpu_dedicated_set are not set."},{"line_number":312,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $vcpu_pin_set_real \u003d\u003d undef and $cpu_dedicated_set_real \u003d\u003d $::os_service_default {"},{"line_number":313,"context_line":"    nova_config {"},{"line_number":314,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value  \u003d\u003e $cpu_shared_set_real;"},{"line_number":315,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value  \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":316,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      ensure \u003d\u003e absent;  # when undef, don\u0027t include in conf"},{"line_number":317,"context_line":"    }"},{"line_number":318,"context_line":"  }"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"  # if cpu_dedicated_set is set but cpu_shared_set is not set."},{"line_number":321,"context_line":"  if $cpu_dedicated_set_real !\u003d $::os_service_default and $cpu_shared_set_real \u003d\u003d $::os_service_default {"},{"line_number":322,"context_line":"    nova_config {"},{"line_number":323,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value  \u003d\u003e $cpu_dedicated_set_real;"},{"line_number":324,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value  \u003d\u003e $cpu_shared_set_real; # assigns service default"},{"line_number":325,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      ensure \u003d\u003e absent;   # when undef, don\u0027t include in conf"},{"line_number":326,"context_line":"    }"},{"line_number":327,"context_line":"  }"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"  # cryptsetup is required when Barbican is encrypting volumes"}],"source_content_type":"text/x-puppet","patch_set":38,"id":"3fa7e38b_ccfc6740","line":326,"range":{"start_line":284,"start_character":1,"end_line":326,"end_character":5},"updated":"2019-10-04 16:08:38.000000000","message":"this can be simplified a bit if you just set the cpu_dedicated_set/cpu_shared_set vars up front then you can just do the nova config once. The only weird logic would need to be for vcp_pin_set, though you could key off if vcp_pin_set \u003d undef then set it absent, otherwise use the var.","commit_id":"fc5df9ff624c3f67538b9f0d186659b3c7e83163"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2e7ff63c93a9c828f9b72af218084fdf3ee9e84a","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    fail(\u0027vcpu_pin_set is deprecated. vcpu_pin_set and cpu_dedicated_set are mutually exclusive.\u0027)"},{"line_number":282,"context_line":"  }"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"  # if cpu_shared_set and cpu_dedicated_set both are set, use these and ignore vcpu_pin_set."},{"line_number":285,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $cpu_dedicated_set_real !\u003d $::os_service_default {"},{"line_number":286,"context_line":"    nova_config {"},{"line_number":287,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value  \u003d\u003e $cpu_shared_set_real;"},{"line_number":288,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value  \u003d\u003e $cpu_dedicated_set_real;"},{"line_number":289,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      ensure \u003d\u003e absent;  # when undef, don\u0027t include in conf."},{"line_number":290,"context_line":"    }"},{"line_number":291,"context_line":"  }"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"  # if vcpu_pin_set is set, but cpu_shared_set not."},{"line_number":294,"context_line":"  if $vcpu_pin_set_real !\u003d undef and $cpu_shared_set_real \u003d\u003d $::os_service_default {"},{"line_number":295,"context_line":"    nova_config {"},{"line_number":296,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;"},{"line_number":297,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":298,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real; # assigns service default"},{"line_number":299,"context_line":"    }"},{"line_number":300,"context_line":"  }"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"  # if cpu_shared_set and vcpu_pin_set are set, but cpu_dedicated_set not set."},{"line_number":303,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $vcpu_pin_set_real !\u003d undef {"},{"line_number":304,"context_line":"    nova_config {"},{"line_number":305,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real;"},{"line_number":306,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;"},{"line_number":307,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":308,"context_line":"    }"},{"line_number":309,"context_line":"  }"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"  # if cpu_shared_set is set, but vcpu_pin_set and cpu_dedicated_set are not set."},{"line_number":312,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $vcpu_pin_set_real \u003d\u003d undef and $cpu_dedicated_set_real \u003d\u003d $::os_service_default {"},{"line_number":313,"context_line":"    nova_config {"},{"line_number":314,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value  \u003d\u003e $cpu_shared_set_real;"},{"line_number":315,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value  \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":316,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      ensure \u003d\u003e absent;  # when undef, don\u0027t include in conf"},{"line_number":317,"context_line":"    }"},{"line_number":318,"context_line":"  }"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"  # if cpu_dedicated_set is set but cpu_shared_set is not set."},{"line_number":321,"context_line":"  if $cpu_dedicated_set_real !\u003d $::os_service_default and $cpu_shared_set_real \u003d\u003d $::os_service_default {"},{"line_number":322,"context_line":"    nova_config {"},{"line_number":323,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value  \u003d\u003e $cpu_dedicated_set_real;"},{"line_number":324,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value  \u003d\u003e $cpu_shared_set_real; # assigns service default"},{"line_number":325,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      ensure \u003d\u003e absent;   # when undef, don\u0027t include in conf"},{"line_number":326,"context_line":"    }"},{"line_number":327,"context_line":"  }"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"  # cryptsetup is required when Barbican is encrypting volumes"}],"source_content_type":"text/x-puppet","patch_set":38,"id":"3fa7e38b_87d4f648","line":326,"range":{"start_line":284,"start_character":1,"end_line":326,"end_character":5},"in_reply_to":"3fa7e38b_21989268","updated":"2019-10-07 09:41:02.000000000","message":"\u003e I had earlier thought about that, but it is not easy, as we might\n \u003e have below valid conditions and that\u0027s why I had to add these many\n \u003e conditions.\n \u003e 1) cpu_shared_set and cpu_dedicated_set both are defined.\n \u003e 2) only cpu_shared_set is defined, and others default.\n \u003e 3) only cpu_dedicated_set is defined and others default.\n \u003e 4) only vcpu_pin_set is defined and others default.\n \u003e 5) vcpu_pin_set and cpu_shared_set is defined and remaining\n \u003e defaults.\n \u003e \n \u003e And as a special case, defining vcpu_pin_set and cpu_dedicated_set\n \u003e both is an error.\n \u003e \n \u003e Stephen, could you please confirm that we can have all these valid\n \u003e cases ?\n\nThis is correct, yes, though I\u0027m not sure it matter in the context of this comment :)","commit_id":"fc5df9ff624c3f67538b9f0d186659b3c7e83163"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"aad1a4e6a55cf12b38d1d115ccb075116b53baaa","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    }"},{"line_number":309,"context_line":"  }"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"  # if cpu_shared_set is set, but vcpu_pin_set and cpu_dedicated_set are not set."},{"line_number":312,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $vcpu_pin_set_real \u003d\u003d undef and $cpu_dedicated_set_real \u003d\u003d $::os_service_default {"},{"line_number":313,"context_line":"    nova_config {"},{"line_number":314,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value  \u003d\u003e $cpu_shared_set_real;"},{"line_number":315,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value  \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":316,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      ensure \u003d\u003e absent;  # when undef, don\u0027t include in conf"},{"line_number":317,"context_line":"    }"},{"line_number":318,"context_line":"  }"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"  # if cpu_dedicated_set is set but cpu_shared_set is not set."},{"line_number":321,"context_line":"  if $cpu_dedicated_set_real !\u003d $::os_service_default and $cpu_shared_set_real \u003d\u003d $::os_service_default {"},{"line_number":322,"context_line":"    nova_config {"},{"line_number":323,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value  \u003d\u003e $cpu_dedicated_set_real;"},{"line_number":324,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value  \u003d\u003e $cpu_shared_set_real; # assigns service default"},{"line_number":325,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      ensure \u003d\u003e absent;   # when undef, don\u0027t include in conf"},{"line_number":326,"context_line":"    }"},{"line_number":327,"context_line":"  }"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"  # cryptsetup is required when Barbican is encrypting volumes"}],"source_content_type":"text/x-puppet","patch_set":38,"id":"3fa7e38b_a1f24299","line":326,"range":{"start_line":311,"start_character":0,"end_line":326,"end_character":5},"in_reply_to":"3fa7e38b_8c274fb7","updated":"2019-10-07 06:18:07.000000000","message":"ditto as explained above.","commit_id":"fc5df9ff624c3f67538b9f0d186659b3c7e83163"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"aad1a4e6a55cf12b38d1d115ccb075116b53baaa","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    fail(\u0027vcpu_pin_set is deprecated. vcpu_pin_set and cpu_dedicated_set are mutually exclusive.\u0027)"},{"line_number":282,"context_line":"  }"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"  # if cpu_shared_set and cpu_dedicated_set both are set, use these and ignore vcpu_pin_set."},{"line_number":285,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $cpu_dedicated_set_real !\u003d $::os_service_default {"},{"line_number":286,"context_line":"    nova_config {"},{"line_number":287,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value  \u003d\u003e $cpu_shared_set_real;"},{"line_number":288,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value  \u003d\u003e $cpu_dedicated_set_real;"},{"line_number":289,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      ensure \u003d\u003e absent;  # when undef, don\u0027t include in conf."},{"line_number":290,"context_line":"    }"},{"line_number":291,"context_line":"  }"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"  # if vcpu_pin_set is set, but cpu_shared_set not."},{"line_number":294,"context_line":"  if $vcpu_pin_set_real !\u003d undef and $cpu_shared_set_real \u003d\u003d $::os_service_default {"},{"line_number":295,"context_line":"    nova_config {"},{"line_number":296,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;"},{"line_number":297,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":298,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real; # assigns service default"},{"line_number":299,"context_line":"    }"},{"line_number":300,"context_line":"  }"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"  # if cpu_shared_set and vcpu_pin_set are set, but cpu_dedicated_set not set."},{"line_number":303,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $vcpu_pin_set_real !\u003d undef {"},{"line_number":304,"context_line":"    nova_config {"},{"line_number":305,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value \u003d\u003e $cpu_shared_set_real;"},{"line_number":306,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      value \u003d\u003e $vcpu_pin_set_real;"},{"line_number":307,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":308,"context_line":"    }"},{"line_number":309,"context_line":"  }"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"  # if cpu_shared_set is set, but vcpu_pin_set and cpu_dedicated_set are not set."},{"line_number":312,"context_line":"  if $cpu_shared_set_real !\u003d $::os_service_default and $vcpu_pin_set_real \u003d\u003d undef and $cpu_dedicated_set_real \u003d\u003d $::os_service_default {"},{"line_number":313,"context_line":"    nova_config {"},{"line_number":314,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value  \u003d\u003e $cpu_shared_set_real;"},{"line_number":315,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value  \u003d\u003e $cpu_dedicated_set_real; # assigns service default"},{"line_number":316,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      ensure \u003d\u003e absent;  # when undef, don\u0027t include in conf"},{"line_number":317,"context_line":"    }"},{"line_number":318,"context_line":"  }"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"  # if cpu_dedicated_set is set but cpu_shared_set is not set."},{"line_number":321,"context_line":"  if $cpu_dedicated_set_real !\u003d $::os_service_default and $cpu_shared_set_real \u003d\u003d $::os_service_default {"},{"line_number":322,"context_line":"    nova_config {"},{"line_number":323,"context_line":"      \u0027compute/cpu_dedicated_set\u0027: value  \u003d\u003e $cpu_dedicated_set_real;"},{"line_number":324,"context_line":"      \u0027compute/cpu_shared_set\u0027:    value  \u003d\u003e $cpu_shared_set_real; # assigns service default"},{"line_number":325,"context_line":"      \u0027compute/vcpu_pin_set\u0027:      ensure \u003d\u003e absent;   # when undef, don\u0027t include in conf"},{"line_number":326,"context_line":"    }"},{"line_number":327,"context_line":"  }"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"  # cryptsetup is required when Barbican is encrypting volumes"}],"source_content_type":"text/x-puppet","patch_set":38,"id":"3fa7e38b_21989268","line":326,"range":{"start_line":284,"start_character":1,"end_line":326,"end_character":5},"in_reply_to":"3fa7e38b_ccfc6740","updated":"2019-10-07 06:18:07.000000000","message":"I had earlier thought about that, but it is not easy, as we might have below valid conditions and that\u0027s why I had to add these many conditions.\n1) cpu_shared_set and cpu_dedicated_set both are defined.\n2) only cpu_shared_set is defined, and others default.\n3) only cpu_dedicated_set is defined and others default.\n4) only vcpu_pin_set is defined and others default.\n5) vcpu_pin_set and cpu_shared_set is defined and remaining defaults.\n\nAnd as a special case, defining vcpu_pin_set and cpu_dedicated_set both is an error.\n\nStephen, could you please confirm that we can have all these valid cases ?","commit_id":"fc5df9ff624c3f67538b9f0d186659b3c7e83163"}],"manifests/scheduler.pp":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"29353c0a599120e99a1fe64c0af26ec059256aab","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  $discover_hosts_in_cells_interval       \u003d $::os_service_default,"},{"line_number":59,"context_line":"  $query_placement_for_image_type_support \u003d $::os_service_default,"},{"line_number":60,"context_line":"  $limit_tenants_to_placement_aggregate   \u003d $::os_service_default,"},{"line_number":61,"context_line":"  $enable_pinning_policy_translation      \u003d $::os_service_default,"},{"line_number":62,"context_line":") {"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  include ::nova::deps"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"5faad753_40645d4a","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":66},"updated":"2019-09-13 10:30:06.000000000","message":"We figured out a way to get rid of the need to set this on the scheduler so this is no longer a thing and can be dropped. Selection of hosts with and without PCPUs will happen automagically","commit_id":"14ed178d6f78c97032f14dad978ab83fa1e60f02"}],"releasenotes/notes/cpu-resources-39ce2f92ae6395ae.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"29353c0a599120e99a1fe64c0af26ec059256aab","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add new parameter `cpu_dedicated_set` in compute section to specify"},{"line_number":5,"context_line":"    list or range of physical CPU cores to reserve to be used for allocating"},{"line_number":6,"context_line":"    PCPU resources to virtual machine processes."},{"line_number":7,"context_line":"    Defaults to $::os_service_default."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5faad753_009d0509","line":4,"range":{"start_line":4,"start_character":21,"end_line":4,"end_character":41},"updated":"2019-09-13 10:30:06.000000000","message":"``code``. Also, we usually write this as\n\n  ``[compute] cpu_dedicated_set``\n\nrather than saying \"in the foo section\"","commit_id":"14ed178d6f78c97032f14dad978ab83fa1e60f02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"29353c0a599120e99a1fe64c0af26ec059256aab","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Add new parameter `cpu_dedicated_set` in compute section to specify"},{"line_number":5,"context_line":"    list or range of physical CPU cores to reserve to be used for allocating"},{"line_number":6,"context_line":"    PCPU resources to virtual machine processes."},{"line_number":7,"context_line":"    Defaults to $::os_service_default."},{"line_number":8,"context_line":"    Add new parameter `enable_pinning_policy_translation` in scheduler"},{"line_number":9,"context_line":"    section to specify whether to enable/disable this feature."},{"line_number":10,"context_line":"    Defaults to $::os_service_default."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5faad753_609cf90e","line":7,"range":{"start_line":7,"start_character":16,"end_line":7,"end_character":37},"updated":"2019-09-13 10:30:06.000000000","message":"``code``","commit_id":"14ed178d6f78c97032f14dad978ab83fa1e60f02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"29353c0a599120e99a1fe64c0af26ec059256aab","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    list or range of physical CPU cores to reserve to be used for allocating"},{"line_number":6,"context_line":"    PCPU resources to virtual machine processes."},{"line_number":7,"context_line":"    Defaults to $::os_service_default."},{"line_number":8,"context_line":"    Add new parameter `enable_pinning_policy_translation` in scheduler"},{"line_number":9,"context_line":"    section to specify whether to enable/disable this feature."},{"line_number":10,"context_line":"    Defaults to $::os_service_default."},{"line_number":11,"context_line":"deprecations:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    The `vcpu_pin_set` parameter is deprecated and superseded by cpu_shared_set"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5faad753_6069591f","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":38},"updated":"2019-09-13 10:30:06.000000000","message":"So you can also drop this","commit_id":"14ed178d6f78c97032f14dad978ab83fa1e60f02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"29353c0a599120e99a1fe64c0af26ec059256aab","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    Defaults to $::os_service_default."},{"line_number":11,"context_line":"deprecations:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    The `vcpu_pin_set` parameter is deprecated and superseded by cpu_shared_set"},{"line_number":14,"context_line":"    and cpu_dedicated_set parameters, where cpu_shared_set and cpu_dedicated_set"},{"line_number":15,"context_line":"    is used to define list or range of VCPU and PCPU resources for virtual machine"},{"line_number":16,"context_line":"    instances respectively."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5faad753_e0546955","line":13,"range":{"start_line":13,"start_character":65,"end_line":13,"end_character":79},"updated":"2019-09-13 10:30:06.000000000","message":"``code``","commit_id":"14ed178d6f78c97032f14dad978ab83fa1e60f02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"29353c0a599120e99a1fe64c0af26ec059256aab","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    Defaults to $::os_service_default."},{"line_number":11,"context_line":"deprecations:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    The `vcpu_pin_set` parameter is deprecated and superseded by cpu_shared_set"},{"line_number":14,"context_line":"    and cpu_dedicated_set parameters, where cpu_shared_set and cpu_dedicated_set"},{"line_number":15,"context_line":"    is used to define list or range of VCPU and PCPU resources for virtual machine"},{"line_number":16,"context_line":"    instances respectively."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5faad753_205fe172","line":13,"range":{"start_line":13,"start_character":9,"end_line":13,"end_character":21},"updated":"2019-09-13 10:30:06.000000000","message":"``vcpu_pin_set`` (double backticks so it\u0027ll render as a literal, here and elsewhere)","commit_id":"14ed178d6f78c97032f14dad978ab83fa1e60f02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"29353c0a599120e99a1fe64c0af26ec059256aab","unresolved":false,"context_lines":[{"line_number":11,"context_line":"deprecations:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    The `vcpu_pin_set` parameter is deprecated and superseded by cpu_shared_set"},{"line_number":14,"context_line":"    and cpu_dedicated_set parameters, where cpu_shared_set and cpu_dedicated_set"},{"line_number":15,"context_line":"    is used to define list or range of VCPU and PCPU resources for virtual machine"},{"line_number":16,"context_line":"    instances respectively."},{"line_number":17,"context_line":"    When used vcpu_pin_set should not be defined with cpu_dedicated_set parameter."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5faad753_40c9bd23","line":14,"range":{"start_line":14,"start_character":44,"end_line":14,"end_character":58},"updated":"2019-09-13 10:30:06.000000000","message":"``code``","commit_id":"14ed178d6f78c97032f14dad978ab83fa1e60f02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"29353c0a599120e99a1fe64c0af26ec059256aab","unresolved":false,"context_lines":[{"line_number":11,"context_line":"deprecations:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    The `vcpu_pin_set` parameter is deprecated and superseded by cpu_shared_set"},{"line_number":14,"context_line":"    and cpu_dedicated_set parameters, where cpu_shared_set and cpu_dedicated_set"},{"line_number":15,"context_line":"    is used to define list or range of VCPU and PCPU resources for virtual machine"},{"line_number":16,"context_line":"    instances respectively."},{"line_number":17,"context_line":"    When used vcpu_pin_set should not be defined with cpu_dedicated_set parameter."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5faad753_804d75c5","line":14,"range":{"start_line":14,"start_character":8,"end_line":14,"end_character":25},"updated":"2019-09-13 10:30:06.000000000","message":"``code``","commit_id":"14ed178d6f78c97032f14dad978ab83fa1e60f02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"29353c0a599120e99a1fe64c0af26ec059256aab","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    and cpu_dedicated_set parameters, where cpu_shared_set and cpu_dedicated_set"},{"line_number":15,"context_line":"    is used to define list or range of VCPU and PCPU resources for virtual machine"},{"line_number":16,"context_line":"    instances respectively."},{"line_number":17,"context_line":"    When used vcpu_pin_set should not be defined with cpu_dedicated_set parameter."},{"line_number":18,"context_line":"    It is also removed from nova config options in change"},{"line_number":19,"context_line":"    ``https://review.opendev.org/#/c/671793``"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5faad753_40f21d72","line":17,"range":{"start_line":17,"start_character":14,"end_line":17,"end_character":26},"updated":"2019-09-13 10:30:06.000000000","message":"``code``","commit_id":"14ed178d6f78c97032f14dad978ab83fa1e60f02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"29353c0a599120e99a1fe64c0af26ec059256aab","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    and cpu_dedicated_set parameters, where cpu_shared_set and cpu_dedicated_set"},{"line_number":15,"context_line":"    is used to define list or range of VCPU and PCPU resources for virtual machine"},{"line_number":16,"context_line":"    instances respectively."},{"line_number":17,"context_line":"    When used vcpu_pin_set should not be defined with cpu_dedicated_set parameter."},{"line_number":18,"context_line":"    It is also removed from nova config options in change"},{"line_number":19,"context_line":"    ``https://review.opendev.org/#/c/671793``"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5faad753_60f71961","line":17,"range":{"start_line":17,"start_character":54,"end_line":17,"end_character":71},"updated":"2019-09-13 10:30:06.000000000","message":"``code``","commit_id":"14ed178d6f78c97032f14dad978ab83fa1e60f02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"29353c0a599120e99a1fe64c0af26ec059256aab","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    and cpu_dedicated_set parameters, where cpu_shared_set and cpu_dedicated_set"},{"line_number":15,"context_line":"    is used to define list or range of VCPU and PCPU resources for virtual machine"},{"line_number":16,"context_line":"    instances respectively."},{"line_number":17,"context_line":"    When used vcpu_pin_set should not be defined with cpu_dedicated_set parameter."},{"line_number":18,"context_line":"    It is also removed from nova config options in change"},{"line_number":19,"context_line":"    ``https://review.opendev.org/#/c/671793``"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5faad753_00e8a579","line":17,"range":{"start_line":17,"start_character":27,"end_line":17,"end_character":37},"updated":"2019-09-13 10:30:06.000000000","message":"can not? nova will enforce this so maybe should not is the correct term from the TripleO perspective though","commit_id":"14ed178d6f78c97032f14dad978ab83fa1e60f02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"29353c0a599120e99a1fe64c0af26ec059256aab","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    is used to define list or range of VCPU and PCPU resources for virtual machine"},{"line_number":16,"context_line":"    instances respectively."},{"line_number":17,"context_line":"    When used vcpu_pin_set should not be defined with cpu_dedicated_set parameter."},{"line_number":18,"context_line":"    It is also removed from nova config options in change"},{"line_number":19,"context_line":"    ``https://review.opendev.org/#/c/671793``"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5faad753_80fb3545","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":45},"updated":"2019-09-13 10:30:06.000000000","message":"I don\u0027t know what you mean here. Nothing is removed. I\u0027d probably drop this.","commit_id":"14ed178d6f78c97032f14dad978ab83fa1e60f02"}],"spec/classes/nova_compute_spec.rb":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"81d0c90ce0fe18d3a30da351d4641aa79f321752","unresolved":false,"context_lines":[{"line_number":256,"context_line":"      end"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"      it { is_expected.to contain_nova_config(\u0027compute/vcpu_pin_set\u0027).with(:value \u003d\u003e \u00274-12,^8,15\u0027) }"},{"line_number":259,"context_line":"      it { is_expected.to contain_nova_config(\u0027compute/cpu_shared_set\u0027).with(:value \u003d\u003e \u00274-12,^8,15\u0027) }"},{"line_number":260,"context_line":"      it { is_expected.to contain_nova_config(\u0027compute/cpu_dedicated_set\u0027).with(:value \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027) }"},{"line_number":261,"context_line":"    end"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":34,"id":"3fa7e38b_4f0c0242","line":259,"range":{"start_line":259,"start_character":0,"end_line":259,"end_character":102},"updated":"2019-10-03 12:35:45.000000000","message":"This isn\u0027t correct. If \u0027vcpu_pin_set\u0027 is set, \u0027cpu_shared_set\u0027 will be only be used for emulator threads if it\u0027s set by the user. If the user hasn\u0027t set it, it should be null","commit_id":"1919702009476eeb2458c53b60d530d36e2c0efb"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"c113311686f98eaccaf37c1403803dab4f560a23","unresolved":false,"context_lines":[{"line_number":256,"context_line":"      end"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"      it { is_expected.to contain_nova_config(\u0027compute/vcpu_pin_set\u0027).with(:value \u003d\u003e \u00274-12,^8,15\u0027) }"},{"line_number":259,"context_line":"      it { is_expected.to contain_nova_config(\u0027compute/cpu_shared_set\u0027).with(:value \u003d\u003e \u00274-12,^8,15\u0027) }"},{"line_number":260,"context_line":"      it { is_expected.to contain_nova_config(\u0027compute/cpu_dedicated_set\u0027).with(:value \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027) }"},{"line_number":261,"context_line":"    end"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":34,"id":"3fa7e38b_cf3a2333","line":259,"range":{"start_line":259,"start_character":0,"end_line":259,"end_character":102},"in_reply_to":"3fa7e38b_4f0c0242","updated":"2019-10-04 07:56:38.000000000","message":"Done","commit_id":"1919702009476eeb2458c53b60d530d36e2c0efb"}],"spec/classes/nova_scheduler_spec.rb":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"29353c0a599120e99a1fe64c0af26ec059256aab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"5faad753_c0b36d97","updated":"2019-09-13 10:30:06.000000000","message":"and naturally all of this can go","commit_id":"14ed178d6f78c97032f14dad978ab83fa1e60f02"}]}