)]}'
{"manifests/compute/libvirt/virtlogd.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"b077994267a354337a148a3c269610214c98d760","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    virtlogd_config {"},{"line_number":54,"context_line":"      \u0027log_level\u0027: value \u003d\u003e $log_level;"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":"  }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  if $log_filters {"},{"line_number":59,"context_line":"    virtlogd_config {"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"3fa7e38b_e145e117","line":56,"updated":"2019-11-26 18:05:52.000000000","message":"else {\n  virtlogd_config {\n    \u0027log_level\u0027: ensure \u003d\u003e \u0027absent\u0027;\n  }\n}","commit_id":"4ec8a9e0b984dd30d5a2d583e4dbdb60361717c5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1cc10db7442046c31a98999f1385a0587d781cad","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    virtlogd_config {"},{"line_number":54,"context_line":"      \u0027log_level\u0027: value \u003d\u003e $log_level;"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":"  }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  if $log_filters {"},{"line_number":59,"context_line":"    virtlogd_config {"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"3fa7e38b_f07125e1","line":56,"in_reply_to":"3fa7e38b_e145e117","updated":"2019-11-27 00:52:55.000000000","message":"Done","commit_id":"4ec8a9e0b984dd30d5a2d583e4dbdb60361717c5"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"88b8af3473f2f010ea9168f93aca0c9bfa20b946","unresolved":false,"context_lines":[{"line_number":47,"context_line":") {"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  include ::nova::deps"},{"line_number":50,"context_line":"  require ::nova::compute::libvirt"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  if $log_level {"},{"line_number":53,"context_line":"    virtlogd_config {"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"3fa7e38b_ea62f5ac","line":50,"updated":"2019-12-09 15:48:27.000000000","message":"I think these need to be relative inclusions now","commit_id":"02d019275330635e4b655caf4b8665acf4e1775b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1130eb6bea0766251633986ed5c278d3d75c9aac","unresolved":false,"context_lines":[{"line_number":47,"context_line":") {"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  include ::nova::deps"},{"line_number":50,"context_line":"  require ::nova::compute::libvirt"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  if $log_level {"},{"line_number":53,"context_line":"    virtlogd_config {"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"3fa7e38b_76825f01","line":50,"in_reply_to":"3fa7e38b_ea62f5ac","updated":"2019-12-10 12:32:05.000000000","message":"Done","commit_id":"02d019275330635e4b655caf4b8665acf4e1775b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0ba60189610eaf579f4b65728a15b5a153259966","unresolved":false,"context_lines":[{"line_number":47,"context_line":") {"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  include nova::deps"},{"line_number":50,"context_line":"  require ::nova::compute::libvirt"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  if $log_level {"},{"line_number":53,"context_line":"    virtlogd_config {"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"3fa7e38b_43a18e39","line":50,"updated":"2019-12-11 16:52:06.000000000","message":"This one should also be relative","commit_id":"9e07a3f69a8f905b36db0b981885e25b0b3707fe"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1cf5e93c16a14554abac3ee29496102359395afc","unresolved":false,"context_lines":[{"line_number":47,"context_line":") {"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  include nova::deps"},{"line_number":50,"context_line":"  require ::nova::compute::libvirt"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  if $log_level {"},{"line_number":53,"context_line":"    virtlogd_config {"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"3fa7e38b_20455e9b","line":50,"in_reply_to":"3fa7e38b_43a18e39","updated":"2019-12-12 06:32:47.000000000","message":"I let this as absolute one because I see that we still use absolute path for require[1][2] atm.\n\n[1] https://github.com/openstack/puppet-nova/blob/master/manifests/compute/libvirt/qemu.pp#L58\n[2] https://github.com/openstack/puppet-nova/blob/master/manifests/compute/ironic.pp#L21\n\nI\u0027ll submit another follow-up patch to convert all of them.","commit_id":"9e07a3f69a8f905b36db0b981885e25b0b3707fe"}],"spec/classes/nova_compute_libvirt_virtlogd_spec.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"b077994267a354337a148a3c269610214c98d760","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      it { is_expected.to contain_class(\u0027nova::deps\u0027)}"},{"line_number":23,"context_line":"      it { is_expected.to contain_class(\u0027nova::compute::libvirt::virtlogd\u0027)}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"      it { is_expected.to contain_virtlogd_config(\u0027log_level\u0027).with_ensure(\u0027absent\u0027)}"},{"line_number":26,"context_line":"      it { is_expected.to contain_virtlogd_config(\u0027log_outputs\u0027).with_ensure(\u0027absent\u0027)}"},{"line_number":27,"context_line":"      it { is_expected.to contain_virtlogd_config(\u0027log_filters\u0027).with_ensure(\u0027absent\u0027)}"},{"line_number":28,"context_line":"      it { is_expected.to contain_virtlogd_config(\u0027max_clients\u0027).with_ensure(\u0027absent\u0027)}"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"3fa7e38b_213c5991","line":25,"updated":"2019-11-26 18:05:52.000000000","message":"Your testing says these resources are suppose to be declared with ensure set to absent, but in your code you never declare the resources when the default value is undef.","commit_id":"4ec8a9e0b984dd30d5a2d583e4dbdb60361717c5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1cc10db7442046c31a98999f1385a0587d781cad","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      it { is_expected.to contain_class(\u0027nova::deps\u0027)}"},{"line_number":23,"context_line":"      it { is_expected.to contain_class(\u0027nova::compute::libvirt::virtlogd\u0027)}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"      it { is_expected.to contain_virtlogd_config(\u0027log_level\u0027).with_ensure(\u0027absent\u0027)}"},{"line_number":26,"context_line":"      it { is_expected.to contain_virtlogd_config(\u0027log_outputs\u0027).with_ensure(\u0027absent\u0027)}"},{"line_number":27,"context_line":"      it { is_expected.to contain_virtlogd_config(\u0027log_filters\u0027).with_ensure(\u0027absent\u0027)}"},{"line_number":28,"context_line":"      it { is_expected.to contain_virtlogd_config(\u0027max_clients\u0027).with_ensure(\u0027absent\u0027)}"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"3fa7e38b_9063111a","line":25,"in_reply_to":"3fa7e38b_213c5991","updated":"2019-11-27 00:52:55.000000000","message":"Thank you for your great help here! It makes much sense to me.","commit_id":"4ec8a9e0b984dd30d5a2d583e4dbdb60361717c5"}]}