)]}'
{"id":"openstack%2Fpuppet-nova~687993","triplet_id":"openstack%2Fpuppet-nova~stable%2Ftrain~Iae595796559cc6551d8ae27e2573122a8a2da15d","project":"openstack/puppet-nova","branch":"stable/train","topic":"fix_libvirt_lines-stable/train","hashtags":[],"change_id":"Iae595796559cc6551d8ae27e2573122a8a2da15d","subject":"Fix \"More than one line in file \u0027/etc/sysconfig/libvirtd\u0027 matches pattern\" errors","status":"MERGED","created":"2019-10-10 22:10:55.000000000","updated":"2019-10-11 18:31:43.000000000","submitted":"2019-10-11 18:31:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"687993-1570818703477-01385176","meta_rev_id":"0bc27355909ed93d1ea0bd4b922b77b0745b2b86","_number":687993,"virtual_id_number":687993,"owner":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-11 18:31:43.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"recommended":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"all":[{"value":1,"date":"2019-10-11 07:46:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2019-10-11 08:00:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":1,"date":"2019-10-11 08:18:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":1,"date":"2019-10-11 13:46:20.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"date":"2019-10-10 22:10:55.000000000","_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-10 22:10:55.000000000","updated_by":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"reviewer":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"state":"REVIEWER"},{"updated":"2019-10-11 07:46:52.000000000","updated_by":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"reviewer":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"state":"REVIEWER"},{"updated":"2019-10-11 08:00:45.000000000","updated_by":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"reviewer":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"state":"REVIEWER"},{"updated":"2019-10-11 08:18:02.000000000","updated_by":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"reviewer":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"state":"REVIEWER"},{"updated":"2019-10-11 13:46:20.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-10-11 18:31:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2367a047bc09c3f0bc6985314e5f35ce4efff6ef","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-10-10 22:10:55.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"b80c01a839d4c976ea92a02133c6ad2a45bffd7b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-11 00:31:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/11dfb8f99bdc475db0b7c771972c35f7 : SUCCESS in 4m 14s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/2376109efbec45c28fc066b3b6c27480 : SUCCESS in 4m 20s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/583777f9eda24c039263c39be41af807 : SUCCESS in 20m 34s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/73eda2a3194642e2992389df8adcf79b : SUCCESS in 47m 11s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/ee13ac9a246e45eab257fdc853679ac3 : SUCCESS in 57m 02s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/f7d40de2609046b2b724ff0f4cbecd1c : SUCCESS in 1h 15m 20s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/107bbcaf7dd043b9bd3edd9e5ba339a2 : SUCCESS in 46m 02s\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/81373c6d1c9d495a9038d44a64185b77 : FAILURE in 44m 07s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/5d235260d575468d8b7a6b5b9092f01c : FAILURE in 44m 43s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/acc61d91cbff42d8be1f4415a3a10d07 : FAILURE in 23m 26s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/74ee977905d04585af014bc52d8e2f50 : FAILURE in 20m 18s (non-voting)\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/79684cb536584e58a2e45c3e7a1ac9ce : SUCCESS in 23m 43s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f05813eb17a34fcf8ea4647d17c2b258 : FAILURE in 6m 52s (non-voting)\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/4fa7ebae427744b2b4fe76d06acafd93 : SUCCESS in 2h 16m 06s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a7a0f5599c657875e55b01431d5236e804d59142","author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"date":"2019-10-11 07:46:52.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"22ce0d88925567d7a59548446a75895b2d37dbcb","author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"date":"2019-10-11 08:00:45.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e1ee7f5d5b5867f68fbb9ca2c0757a6ad326cf75","author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"date":"2019-10-11 08:18:02.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"96a71d73c79d0f484e2f2e62bec1484ad7085a78","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-10-11 13:46:20.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"784490fa6794d1f427fcf8bba7c374996c4f3739","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-11 13:46:32.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"1cc566a4b40c380f4b9d425c11b3b14ec3f72c05","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-11 18:31:43.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"95c671122681a92602b309232128f63c828519e1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-11 18:31:43.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/332bb05d964242b1a6fd9bc23f1a9352 : SUCCESS in 4m 13s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/79d3fa0de8624011a7f1220dc1a6aa1c : SUCCESS in 4m 39s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/98d898b16003463c8b036e0090f858c6 : SUCCESS in 33m 13s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/d692c98679694afba419d159f287bf95 : SUCCESS in 55m 13s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/89595fc55f454feb9667e0302eaca8d2 : SUCCESS in 58m 22s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/d625879f33e34b02b63f6748aa56dda8 : SUCCESS in 1h 20m 15s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/d8313ec13da748a886d2d6bfe00206b9 : SUCCESS in 48m 53s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/d4f57390132e479e87b146314c2c5999 : SUCCESS in 24m 11s\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/ca8047a945ef4bae819d6a528552e36e : SUCCESS in 2h 26m 45s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"14651dbf98194ff5d91a5bad672312cc2e3fce15","revisions":{"14651dbf98194ff5d91a5bad672312cc2e3fce15":{"kind":"REWORK","_number":1,"created":"2019-10-10 22:10:55.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/93/687993/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/93/687993/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/93/687993/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/93/687993/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/93/687993/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/93/687993/1"}}},"commit":{"parents":[{"commit":"6c868f26e1e2feb827d5cd5a5db39aa99e2379cf","subject":"Update TOX/UPPER_CONSTRAINTS_FILE for stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/6c868f26e1e2feb827d5cd5a5db39aa99e2379cf"}]}],"author":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-10-08 15:28:28.000000000","tz":120},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-10-10 22:10:55.000000000","tz":0},"subject":"Fix \"More than one line in file \u0027/etc/sysconfig/libvirtd\u0027 matches pattern\" errors","message":"Fix \"More than one line in file \u0027/etc/sysconfig/libvirtd\u0027 matches pattern\" errors\n\nThe current code that matches the LIBVIRTD_ARGS\u003d lines can have multiple\nmatches if said line shows up multiple times in a comment and we can end\nup with the following error:\n\n  Error: /Stage[main]/Nova::Migration::Libvirt/File_line[/etc/sysconfig/libvirtd libvirtd args]/\n    ensure: change from \u0027absent\u0027 to \u0027present\u0027 failed: More than one line in file \u0027/etc/sysconfig/libvirtd\u0027 matches pattern\n      \u0027LIBVIRTD_ARGS\u003d\u0027\n\nFor the record the sysconfig file that triggered this error had the\nfollowing lines:\n\n  # connects.\n  LIBVIRTD_ARGS\u003d\"--timeout 120\"\n\n  # If systemd socket activation is disabled, then the following\n  # can be used to listen on TCP/TLS sockets\n  #LIBVIRTD_ARGS\u003d\"--listen\"\n\nTested this change and I correctly did not fail the deployment anymore.\n\nChange-Id: Iae595796559cc6551d8ae27e2573122a8a2da15d\nCloses-Bug: #1847288\n(cherry picked from commit 8377b33bd1e96eda6342d009f85301c5f9acfc03)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/14651dbf98194ff5d91a5bad672312cc2e3fce15"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/14651dbf98194ff5d91a5bad672312cc2e3fce15"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}