)]}'
{"id":"openstack%2Fpuppet-nova~687994","triplet_id":"openstack%2Fpuppet-nova~stable%2Fstein~Iae595796559cc6551d8ae27e2573122a8a2da15d","project":"openstack/puppet-nova","branch":"stable/stein","topic":"fix_libvirt_lines-stable/stein","hashtags":[],"change_id":"Iae595796559cc6551d8ae27e2573122a8a2da15d","subject":"Fix \"More than one line in file \u0027/etc/sysconfig/libvirtd\u0027 matches pattern\" errors","status":"MERGED","created":"2019-10-10 22:11:33.000000000","updated":"2019-10-11 19:08:53.000000000","submitted":"2019-10-11 19:08:53.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"687994-1570820933885-9bbf562d","meta_rev_id":"3cf0f36a43766c17b0f394446f88b21d2a88ad7c","_number":687994,"virtual_id_number":687994,"owner":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-11 19:08:53.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"recommended":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"all":[{"value":1,"date":"2019-10-11 07:54:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2019-10-11 08:01:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":1,"date":"2019-10-11 08:17:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":1,"date":"2019-10-11 13:46:29.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"date":"2019-10-10 22:11:33.000000000","_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-10 22:11:33.000000000","updated_by":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"reviewer":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"state":"REVIEWER"},{"updated":"2019-10-11 07:54:35.000000000","updated_by":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"reviewer":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"state":"REVIEWER"},{"updated":"2019-10-11 08:01:05.000000000","updated_by":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"reviewer":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"state":"REVIEWER"},{"updated":"2019-10-11 08:17:38.000000000","updated_by":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"reviewer":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"state":"REVIEWER"},{"updated":"2019-10-11 13:46:29.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-10-11 19:08:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"af9be60dac701e031df224060cffea4e966efdf2","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-10-10 22:11:33.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"bfcdfbad631058f9eb60371c91063a853cc642d0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-11 00:58:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/19669bd71d2c4c79993d6436716d61bb : SUCCESS in 4m 27s\n- puppet-openstack-syntax-4-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/578adeee954a456c940c7da2806a1000 : SUCCESS in 4m 16s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/1bdc194ea0a543d7a9f71494ffb05abb : SUCCESS in 4m 13s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/1619d5eb19294685af1be69d356a6910 : SUCCESS in 4m 22s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/b042a1e475b84555a5272197ccd94a15 : SUCCESS in 29m 01s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/ce6737a6dd7a4ce3962e6eb46d74ecc6 : SUCCESS in 29m 27s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/415f3d13c7744d2da6903985abe7048c : SUCCESS in 1h 02m 26s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/a7e2d22427dc4b4db0b9512245a9b40b : SUCCESS in 56m 39s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/5e1f6240a63c49d6870a9debf58c85bd : SUCCESS in 53m 14s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/7b6ae39b91ba4550b93ce8bd29e663c1 : SUCCESS in 41m 33s (non-voting)\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/5531ca65cae84b8da33c137964caaaf8 : FAILURE in 24m 56s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/924f874adc4845858248eda0cd244fcd : FAILURE in 21m 43s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/6e38592994a84d06a8a00421ce1b8ca5 : FAILURE in 24m 57s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/b032304d4ccc49bdb526ebeac77331ba : FAILURE in 27m 11s (non-voting)\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/6a986696fbef4c1a8aedc789163e88f8 : SUCCESS in 21m 58s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/867e2da8bf59418782ebbf90f8d9da80 : FAILURE in 8m 15s (non-voting)\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/84c28c7d75b346c8a7513eca4c917ae4 : SUCCESS in 2h 45m 02s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6e291d2e1d9ce3feb51cf450bd8b1d025552dcc9","author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"date":"2019-10-11 07:54:35.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"8387f09650d5401ccfe05515f264644f89f47a0d","author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"date":"2019-10-11 08:01:05.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"73a08b567074419ed9c97c2d725d7aa042dd6321","author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"date":"2019-10-11 08:17:38.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"ac5bf91347967288752972244cdccd1d7a0eaad3","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-10-11 13:46:29.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"79447eb746afb07f2f8bd4c459ed2a0d378ae670","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-11 13:46:42.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"93beb8890fd6c85b2cb0f002768096b80be2b43b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-11 19:08:53.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"1ad66c3708c645c4028a49d3f89b353d2bf908f9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-11 19:08:53.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/0d605e2c1954451b9eebee63501ed974 : SUCCESS in 4m 19s\n- puppet-openstack-syntax-4-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/20fcb9acc3fe44c5b097e5c3348c7ef4 : SUCCESS in 4m 40s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/25fc978f158c474189f8587b2f890c74 : SUCCESS in 4m 49s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/a7b4aef44b274a7b84275e66a905706c : SUCCESS in 3m 56s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/84ec7b1b7a7842f780ae5d38b8a14d60 : SUCCESS in 35m 29s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/e20d946a498b44c4bcc8e0a1fb541696 : SUCCESS in 36m 00s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/438f075d1c284d229c4a00c6d826f5eb : SUCCESS in 59m 26s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/d8fc34a7d5ff4657822e734c2d98d806 : SUCCESS in 1h 00m 17s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/c8a9964322e04f6db68525a3e44a4ce6 : SUCCESS in 1h 03m 30s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/5f1451de4a254e28936244288242aa87 : SUCCESS in 25m 55s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/4da78f507728434380a7bedb0f0da1b7 : FAILURE in 8m 53s (non-voting)\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/3dfd51b130674bb3b32af84c6a1d7461 : SUCCESS in 3h 05m 11s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fd55aae79f2a1c472d852a796d386b7c0c1952e7","revisions":{"fd55aae79f2a1c472d852a796d386b7c0c1952e7":{"kind":"REWORK","_number":1,"created":"2019-10-10 22:11:33.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/94/687994/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/94/687994/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/94/687994/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/94/687994/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/94/687994/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/94/687994/1"}}},"commit":{"parents":[{"commit":"b28b01a01f940af2356d348cf66d2dcdfa8ef25a","subject":"Adds tls_priority parameter to nova::compute::libvirt","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/b28b01a01f940af2356d348cf66d2dcdfa8ef25a"}]}],"author":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-10-08 15:28:28.000000000","tz":120},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-10-10 22:11:33.000000000","tz":0},"subject":"Fix \"More than one line in file \u0027/etc/sysconfig/libvirtd\u0027 matches pattern\" errors","message":"Fix \"More than one line in file \u0027/etc/sysconfig/libvirtd\u0027 matches pattern\" errors\n\nThe current code that matches the LIBVIRTD_ARGS\u003d lines can have multiple\nmatches if said line shows up multiple times in a comment and we can end\nup with the following error:\n\n  Error: /Stage[main]/Nova::Migration::Libvirt/File_line[/etc/sysconfig/libvirtd libvirtd args]/\n    ensure: change from \u0027absent\u0027 to \u0027present\u0027 failed: More than one line in file \u0027/etc/sysconfig/libvirtd\u0027 matches pattern\n      \u0027LIBVIRTD_ARGS\u003d\u0027\n\nFor the record the sysconfig file that triggered this error had the\nfollowing lines:\n\n  # connects.\n  LIBVIRTD_ARGS\u003d\"--timeout 120\"\n\n  # If systemd socket activation is disabled, then the following\n  # can be used to listen on TCP/TLS sockets\n  #LIBVIRTD_ARGS\u003d\"--listen\"\n\nTested this change and I correctly did not fail the deployment anymore.\n\nChange-Id: Iae595796559cc6551d8ae27e2573122a8a2da15d\nCloses-Bug: #1847288\n(cherry picked from commit 8377b33bd1e96eda6342d009f85301c5f9acfc03)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/fd55aae79f2a1c472d852a796d386b7c0c1952e7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/fd55aae79f2a1c472d852a796d386b7c0c1952e7"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}