)]}'
{"id":"openstack%2Fpuppet-nova~687996","triplet_id":"openstack%2Fpuppet-nova~stable%2Fqueens~Iae595796559cc6551d8ae27e2573122a8a2da15d","project":"openstack/puppet-nova","branch":"stable/queens","topic":"fix_libvirt_lines-stable/queens","hashtags":[],"change_id":"Iae595796559cc6551d8ae27e2573122a8a2da15d","subject":"Fix \"More than one line in file \u0027/etc/sysconfig/libvirtd\u0027 matches pattern\" errors","status":"MERGED","created":"2019-10-10 22:12:04.000000000","updated":"2019-10-11 15:08:33.000000000","submitted":"2019-10-11 15:08:33.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"687996-1570806513182-9bbf562d","meta_rev_id":"832d182c6ff21ac60fd97e34294d60351b79996a","_number":687996,"virtual_id_number":687996,"owner":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-11 15:08:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"recommended":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"all":[{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-10-11 08:18:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":2,"date":"2019-10-11 08:00:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":1,"date":"2019-10-11 07:55:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"date":"2019-10-10 22:12:04.000000000","_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":1,"date":"2019-10-11 13:46:15.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-10 22:12:04.000000000","updated_by":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"reviewer":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"state":"REVIEWER"},{"updated":"2019-10-11 07:55:21.000000000","updated_by":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"reviewer":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"state":"REVIEWER"},{"updated":"2019-10-11 08:00:59.000000000","updated_by":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"reviewer":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"state":"REVIEWER"},{"updated":"2019-10-11 08:18:31.000000000","updated_by":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"reviewer":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"state":"REVIEWER"},{"updated":"2019-10-11 13:46:15.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-10-11 15:08:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fde1d2eb3810e85789eb1f0e059c4d9c497ba28b","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-10-10 22:12:04.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"d5d9ae309ed7b668555c319782598d6f2442c544","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-10 23:46:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint https://zuul.opendev.org/t/openstack/build/25fad65b15fd4dd69e7ccffc15a65de8 : SUCCESS in 4m 22s\n- puppet-openstack-syntax-4 https://zuul.opendev.org/t/openstack/build/39ca99bfa72e4e4aa72a4f2341a79600 : SUCCESS in 4m 06s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/bc8e836f5e624ff48a1c433fe02a989d : SUCCESS in 28m 01s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/17635ce50d5340efab1a3fb953998e6f : SUCCESS in 21m 55s\n- puppet-openstack-integration-4-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/cd3b552af6e64455843c63e44e172791 : SUCCESS in 1h 20m 10s\n- puppet-openstack-integration-4-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/b12e709c4a094d8485b4f907ed180148 : SUCCESS in 1h 06m 24s\n- puppet-openstack-integration-4-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/4da2c6dd4e924e58921cb234f8f2c1d2 : SUCCESS in 1h 24m 05s\n- puppet-openstack-integration-4-scenario004-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/ba1b1e8f5b974476bd6be093aaca2128 : SUCCESS in 50m 33s\n- puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial-luminous https://zuul.opendev.org/t/openstack/build/e4c9beda1ccc4b109178dc4a92887b0c : TIMED_OUT in 1h 31m 07s (non-voting)\n- puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/6f00796657d54ec9b9f94cc47141dd64 : TIMED_OUT in 1h 30m 57s (non-voting)\n- puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/36c6ff0149e8499ba496cdc9cf3ef7b6 : TIMED_OUT in 1h 31m 03s (non-voting)\n- puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial-luminous https://zuul.opendev.org/t/openstack/build/feeb862a1adc4ae2a98df88ffe4f0f9b : TIMED_OUT in 1h 30m 59s (non-voting)\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/51cbc7c8fe324bb4ace6d8a2e456cb69 : SUCCESS in 32m 54s\n- puppet-openstack-beaker-xenial https://zuul.opendev.org/t/openstack/build/9f4064d5140e45eaad29bc2140a4d2a5 : SUCCESS in 18m 42s","accounts_in_message":[],"_revision_number":1},{"id":"c2889db29b371eb50f6bc3aafda73e512b53cac7","author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"date":"2019-10-11 07:55:21.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"6aae6f655bfdadf88b5909618859b1e6bc9cea97","author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"date":"2019-10-11 08:00:59.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d79d669d73cb1da36d26ad168b117730135bc850","author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"date":"2019-10-11 08:18:31.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"e5bfc208e1eb10104f79fa77ad6e727a73be9c11","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-10-11 13:46:15.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"eb3fac05d9b973cb961895dc7914bae3759298a6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-11 13:46:27.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"1a91c88670c54c29363d315df69f80a135445605","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-11 15:08:32.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint https://zuul.opendev.org/t/openstack/build/d35b9b77ce8a40a9a041fc129b29e2f9 : SUCCESS in 6m 04s\n- puppet-openstack-syntax-4 https://zuul.opendev.org/t/openstack/build/874c7b11cb0e4ae386f64e2542a3c130 : SUCCESS in 6m 01s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/80c4ecfedbcc45728119aa4d42102dc1 : SUCCESS in 23m 29s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/cd9dd140c71e4cbba74b1c56fcdad683 : SUCCESS in 19m 08s\n- puppet-openstack-integration-4-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/c2a8cff3b1a04aaaae9ca8f27b5be698 : SUCCESS in 53m 18s\n- puppet-openstack-integration-4-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/bdee71c06d9d40c4b17bb2263539b091 : SUCCESS in 55m 31s\n- puppet-openstack-integration-4-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/33c77c3caf0e4ddbba3ab6fe717ca518 : SUCCESS in 1h 06m 16s\n- puppet-openstack-integration-4-scenario004-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/70995699819d4e9f91372be62b856179 : SUCCESS in 46m 55s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/0f05855464554d9c880282f86a087ba0 : SUCCESS in 20m 48s\n- puppet-openstack-beaker-xenial https://zuul.opendev.org/t/openstack/build/fb2b5f8944044980814ea3464eb6f0b4 : SUCCESS in 17m 57s","accounts_in_message":[],"_revision_number":1},{"id":"cc6b4cfae7f6f37e15caee604d36b76ebaf51c5f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-11 15:08:33.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b876ace5fa102a1a5e9d205282a6e35f1d0fc82f","revisions":{"b876ace5fa102a1a5e9d205282a6e35f1d0fc82f":{"kind":"REWORK","_number":1,"created":"2019-10-10 22:12:04.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/96/687996/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/96/687996/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/96/687996/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/96/687996/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/96/687996/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/96/687996/1"}}},"commit":{"parents":[{"commit":"f1b23d074e52e5c785fd07fbfeededbde3ca2c49","subject":"Prepare 12.5.0 (queens)","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/f1b23d074e52e5c785fd07fbfeededbde3ca2c49"}]}],"author":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-10-08 15:28:28.000000000","tz":120},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-10-10 22:12:04.000000000","tz":0},"subject":"Fix \"More than one line in file \u0027/etc/sysconfig/libvirtd\u0027 matches pattern\" errors","message":"Fix \"More than one line in file \u0027/etc/sysconfig/libvirtd\u0027 matches pattern\" errors\n\nThe current code that matches the LIBVIRTD_ARGS\u003d lines can have multiple\nmatches if said line shows up multiple times in a comment and we can end\nup with the following error:\n\n  Error: /Stage[main]/Nova::Migration::Libvirt/File_line[/etc/sysconfig/libvirtd libvirtd args]/\n    ensure: change from \u0027absent\u0027 to \u0027present\u0027 failed: More than one line in file \u0027/etc/sysconfig/libvirtd\u0027 matches pattern\n      \u0027LIBVIRTD_ARGS\u003d\u0027\n\nFor the record the sysconfig file that triggered this error had the\nfollowing lines:\n\n  # connects.\n  LIBVIRTD_ARGS\u003d\"--timeout 120\"\n\n  # If systemd socket activation is disabled, then the following\n  # can be used to listen on TCP/TLS sockets\n  #LIBVIRTD_ARGS\u003d\"--listen\"\n\nTested this change and I correctly did not fail the deployment anymore.\n\nChange-Id: Iae595796559cc6551d8ae27e2573122a8a2da15d\nCloses-Bug: #1847288\n(cherry picked from commit 8377b33bd1e96eda6342d009f85301c5f9acfc03)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/b876ace5fa102a1a5e9d205282a6e35f1d0fc82f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/b876ace5fa102a1a5e9d205282a6e35f1d0fc82f"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}