)]}'
{"id":"openstack%2Fpuppet-nova~689074","triplet_id":"openstack%2Fpuppet-nova~stable%2Ftrain~I40e0ed0bba93bfcdc4cf157195c3e9fbcfce0776","project":"openstack/puppet-nova","branch":"stable/train","topic":"bp/cpu-resources-stable/train","hashtags":[],"change_id":"I40e0ed0bba93bfcdc4cf157195c3e9fbcfce0776","subject":"Add ability to collocate pinned and unpinned instance on same host","status":"MERGED","created":"2019-10-17 05:32:36.000000000","updated":"2019-11-01 03:10:01.000000000","submitted":"2019-11-01 03:08:30.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"689074-1572577710639-dfbf8c2d","meta_rev_id":"23c299a5b2a50c4f82c128607322ebdbf5304d27","_number":689074,"virtual_id_number":689074,"owner":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-11-01 03:08:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"recommended":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"all":[{"value":1,"date":"2019-10-31 10:51:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":2,"date":"2019-10-31 10:48:42.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":-1,"date":"2019-10-17 11:19:34.000000000","permitted_voting_range":{"min":-1,"max":2},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":2,"date":"2019-10-31 13:37:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"all":[{"value":0,"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"date":"2019-10-17 09:07:30.000000000","_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},{"value":1,"date":"2019-11-01 00:31:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-17 09:07:30.000000000","updated_by":{"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},"reviewer":{"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},"state":"REVIEWER"},{"updated":"2019-10-17 11:19:34.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2019-10-31 10:48:42.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-10-31 10:51:50.000000000","updated_by":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"reviewer":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"state":"REVIEWER"},{"updated":"2019-10-31 13:37:05.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-11-01 00:31:59.000000000","updated_by":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"reviewer":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"state":"REVIEWER"},{"updated":"2019-11-01 03:08:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7414574782cbd2736d1e8c41fc76991f6bbbf7da","author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"date":"2019-10-17 05:32:36.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"c9756d1f50d75f0a0ddf6de474caffd3de6e209b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-17 07:32:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f518624d241d409bb4160786a15134c7 : SUCCESS in 3m 52s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/7f117b1e2b0e4166980535353d14a171 : SUCCESS in 3m 54s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/5028c5155944472dbcb2676ba216433a : SUCCESS in 24m 38s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/adb7a8960a4b461882cbabaec965fcc6 : SUCCESS in 1h 06m 17s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/7b3afa4ba7d246aebbafb68350e352e3 : SUCCESS in 1h 00m 01s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/8984b3f1e4ab42f4819b1d19e5b064ad : SUCCESS in 1h 22m 43s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/ddad9a610626476ba5d64d48ac79e64a : SUCCESS in 48m 09s\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/5ad6cc48ca11432bb5978d9f33e616fd : FAILURE in 35m 11s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/bcd2565e96914a9fbd3557f7bf8094df : FAILURE in 31m 06s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9b1240cd1b7d4f3da6b919adb435d6ce : FAILURE in 22m 01s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/53ca6a64800a4f3d8785d2a1d92437d1 : FAILURE in 23m 59s (non-voting)\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/2776ff969773443aba357b8776c9d909 : SUCCESS in 23m 36s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/7b5581490d8d49fea5187955d9d09e72 : FAILURE in 8m 23s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/69d7a3d178524c8ebecc102d04f7d4e8 : SUCCESS in 3m 27s\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/2bec600cf9b04ab193233b6fbb894ec9 : SUCCESS in 1h 58m 19s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"019150c6981b680eef51f853aed4c88a91bb2c34","author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"date":"2019-10-17 09:20:33.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"6fcd07346e84479751db20cab9c2dadaecfe0b92","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2019-10-17 11:19:34.000000000","message":"Patch Set 1: Code-Review-1\n\nDoes the old way for in Train? I understand that we might have missed the deadline on this but this is a feature (that alters existing behaviour) and deprecations being backported which pretty much breaks the backporting policy on most points [1].\n\n[1] https://docs.openstack.org/puppet-openstack-guide/latest/contributor/backporting.html","accounts_in_message":[],"_revision_number":1},{"id":"8a35aa901d2c5253c052dd325aea55b7a53d7114","author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"date":"2019-10-17 12:23:55.000000000","message":"Patch Set 1: -Code-Review\n\n\u003e Does the old way for in Train? I understand that we might have\n \u003e missed the deadline on this but this is a feature (that alters\n \u003e existing behaviour) and deprecations being backported which pretty\n \u003e much breaks the backporting policy on most points [1].\n \u003e \n \u003e [1] https://docs.openstack.org/puppet-openstack-guide/latest/contributor/backporting.html\n\nyes, I was thinking the same but vcpu_pin_set got deprecated in\nnova in train with [2]. How should we handle it when it gets\nremoved in nova in u? Wouldn\u0027t it make sense to have nova and\npuppet-nova in sync with deprecation of config settings or we\nneed to make them aware of the delay in puppet-nova?\nIn general I think we could keep vcpu_pin_set as not deprecated\nwith the downside mentioned above.\n\n[2] https://review.opendev.org/671793","accounts_in_message":[],"_revision_number":1},{"id":"e2d49f88185c1481f608b5a5a25498c44ae28e98","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-10-31 10:48:42.000000000","message":"Patch Set 1: Code-Review+2\n\nI agree Nova \u0026 puppet-nova should be in sync and the parameter is well deprecated, the deployment won\u0027t fail and the right configuration will be applied; just a warning will be shown; which is imho ok at this point.\nLet\u0027s just not make it an habit.","accounts_in_message":[],"_revision_number":1},{"id":"a18035d40aea9932fb8adb5c6c0b487aa069b504","author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"date":"2019-10-31 10:51:50.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"304ae116f157ac48596d41903e525b20dafa8c75","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-10-31 13:37:05.000000000","message":"Patch Set 1: Code-Review+2\n\nSo this doesn\u0027t go against our stable policy because it continues to have the old configuration. The fail configuration is if someone tries to use the new one with the old one still set. Unfortunately we have to mirror the upstream service configurations so IMHO this change mirrors the changes in nova which would make sense to have in Train.","accounts_in_message":[],"_revision_number":1},{"id":"94086191a29eb164021573d14fdf4f73e275df73","author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"date":"2019-11-01 00:31:59.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"52dfc6d71eff9567df087428b8e1b9e3d31b3720","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-01 00:32:11.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"9764ccb95e40fb2f74eee15de46cfc5711bd43f0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-01 03:08:30.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9babf5194db7466db814191523bc35c1 : SUCCESS in 5m 01s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/c0f354e286d94bb2b912f1305c4f7098 : SUCCESS in 4m 06s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/55ed819b0e8f4892bfb6d1eca67545dc : SUCCESS in 42m 24s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/e2934f68565d4a808d1e512a52a2b041 : SUCCESS in 59m 30s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/82ba4bbdd352448a9a84d27e4e85af4b : SUCCESS in 1h 05m 56s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/e01b757d8aef435f8e35e7e022a08f40 : SUCCESS in 1h 34m 29s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/4b29ba1cd20f4cc0b0deb09bd0d12bc3 : SUCCESS in 1h 04m 28s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/a2e1d1fd65c14c9dac7eced2dd32b231 : SUCCESS in 22m 33s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f54e9e35565f4e43b177738207c5a602 : SUCCESS in 3m 19s\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/b630367e02ec4a7cad26bfe31e76452e : SUCCESS in 2h 29m 47s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"821a70ca33f6c017a265bc17267b77c18891a991","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-01 03:08:30.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"2c55d00463840ac355d1432875f02e38c3f5c159","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-01 03:10:01.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/4403e7d4934d4aad8371a89496f0210b : SUCCESS in 1m 12s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"cfb8f7173a8619530072a9d5b5be5d33e310f115","revisions":{"cfb8f7173a8619530072a9d5b5be5d33e310f115":{"kind":"REWORK","_number":1,"created":"2019-10-17 05:32:36.000000000","uploader":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"ref":"refs/changes/74/689074/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/74/689074/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/74/689074/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/74/689074/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/74/689074/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/74/689074/1"}}},"commit":{"parents":[{"commit":"e6628d679dd30f481fac5faaa04315468c2b20ca","subject":"Merge \"Switch to Train\" into stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/e6628d679dd30f481fac5faaa04315468c2b20ca"}]}],"author":{"name":"Rajesh Tailor","email":"ratailor@redhat.com","date":"2019-09-06 10:20:01.000000000","tz":330},"committer":{"name":"Rajesh Tailor","email":"ratailor@redhat.com","date":"2019-10-17 05:32:36.000000000","tz":0},"subject":"Add ability to collocate pinned and unpinned instance on same host","message":"Add ability to collocate pinned and unpinned instance on same host\n\nAdd support for configuring `cpu_dedicated_set` parameter\nand modify logic for `vcpu_pin_set` and `cpu_shared_set` parameters\nto add ability to collocate pinned and unpinned instances on same host.\n\nDeprecate `vcpu_pin_set` option as it is deprecated from config\noptions in nova [1] as well.\n\n[1] https://review.opendev.org/#/c/671793\n\nChange-Id: I40e0ed0bba93bfcdc4cf157195c3e9fbcfce0776\n(cherry picked from commit cf666bd557d2d5b94774cace4b09d91ea5822c2c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/cfb8f7173a8619530072a9d5b5be5d33e310f115"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/cfb8f7173a8619530072a9d5b5be5d33e310f115"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}