)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"bcb47ebf1b3a024c2f3d85731daf84130deb6b68","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t restart libvirt-guests on config change"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When there is a config change the service gets notfied to be"},{"line_number":10,"context_line":"restarted, which is not required as /usr/libexec/libvirt-guests.sh"},{"line_number":11,"context_line":"sources /etc/syscontig/libvirt-guests on each run. As a side"},{"line_number":12,"context_line":"effect of the service restart, instances get stopped which bad."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_50332bf7","line":9,"updated":"2019-10-22 12:36:30.000000000","message":"nit","commit_id":"08a8918868f1fea56302e505e500a6e15e47d872"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"bcb47ebf1b3a024c2f3d85731daf84130deb6b68","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When there is a config change the service gets notfied to be"},{"line_number":10,"context_line":"restarted, which is not required as /usr/libexec/libvirt-guests.sh"},{"line_number":11,"context_line":"sources /etc/syscontig/libvirt-guests on each run. As a side"},{"line_number":12,"context_line":"effect of the service restart, instances get stopped which bad."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In addition manage_service was bound to the enabled parameter."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_3050ef0a","line":11,"range":{"start_line":11,"start_character":19,"end_line":11,"end_character":20},"updated":"2019-10-22 12:36:30.000000000","message":"nit","commit_id":"08a8918868f1fea56302e505e500a6e15e47d872"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"bcb47ebf1b3a024c2f3d85731daf84130deb6b68","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When there is a config change the service gets notfied to be"},{"line_number":10,"context_line":"restarted, which is not required as /usr/libexec/libvirt-guests.sh"},{"line_number":11,"context_line":"sources /etc/syscontig/libvirt-guests on each run. As a side"},{"line_number":12,"context_line":"effect of the service restart, instances get stopped which bad."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In addition manage_service was bound to the enabled parameter."},{"line_number":15,"context_line":"This introduce manage_service to be able to manage start/stop"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_50480b5b","line":12,"updated":"2019-10-22 12:36:30.000000000","message":"nit: is","commit_id":"08a8918868f1fea56302e505e500a6e15e47d872"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"bcb47ebf1b3a024c2f3d85731daf84130deb6b68","unresolved":false,"context_lines":[{"line_number":12,"context_line":"effect of the service restart, instances get stopped which bad."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In addition manage_service was bound to the enabled parameter."},{"line_number":15,"context_line":"This introduce manage_service to be able to manage start/stop"},{"line_number":16,"context_line":"independent from enabled parameter."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Icf52a2272601401c423ae07f7b10474bdc190574"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_70450743","line":15,"updated":"2019-10-22 12:36:30.000000000","message":"nit: introduces","commit_id":"08a8918868f1fea56302e505e500a6e15e47d872"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"1b291de568c86ddba3d2165f09ee9f2526181137","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t restart libvirt-guests on config change"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When there is a config change the service gets notfied to be"},{"line_number":10,"context_line":"restarted, which is not required as /usr/libexec/libvirt-guests.sh"},{"line_number":11,"context_line":"sources /etc/sysconfig/libvirt-guests on each run. As a side"},{"line_number":12,"context_line":"effect of the service restart, instances get stopped which is bad."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_a6cb4948","line":9,"range":{"start_line":9,"start_character":47,"end_line":9,"end_character":54},"updated":"2019-10-22 14:33:32.000000000","message":"nit (only if uploading a new patch)","commit_id":"0e1da12265d3cb2a9bdc4fe4b8a50fa7928bfb69"}],"manifests/compute/libvirt_guests.pp":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"bcb47ebf1b3a024c2f3d85731daf84130deb6b68","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  include ::nova::params"},{"line_number":53,"context_line":"  include ::nova::deps"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  Anchor[\u0027nova::config::begin\u0027]"},{"line_number":56,"context_line":"  -\u003e File_line\u003c| tag \u003d\u003d \u0027libvirt-guests-file_line\u0027|\u003e"},{"line_number":57,"context_line":"  -\u003e Anchor[\u0027nova::config::end\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  File_line\u003c| tag \u003d\u003d \u0027libvirt-guests-file_line\u0027 |\u003e"},{"line_number":60,"context_line":"  ~\u003e Service[\u0027libvirt-guests\u0027]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3fa7e38b_5061ebd2","side":"PARENT","line":57,"range":{"start_line":55,"start_character":0,"end_line":57,"end_character":32},"updated":"2019-10-22 12:36:30.000000000","message":"Why is this removed? Does nova::config::end notify the libvirt-guests service?","commit_id":"954f5a1cea6ebffd83255b08938b9238e3a84b86"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"bb0bac319d6bfe83afc026a6687f56d24f5401ae","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  include ::nova::params"},{"line_number":53,"context_line":"  include ::nova::deps"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  Anchor[\u0027nova::config::begin\u0027]"},{"line_number":56,"context_line":"  -\u003e File_line\u003c| tag \u003d\u003d \u0027libvirt-guests-file_line\u0027|\u003e"},{"line_number":57,"context_line":"  -\u003e Anchor[\u0027nova::config::end\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  File_line\u003c| tag \u003d\u003d \u0027libvirt-guests-file_line\u0027 |\u003e"},{"line_number":60,"context_line":"  ~\u003e Service[\u0027libvirt-guests\u0027]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3fa7e38b_d09cfb0f","side":"PARENT","line":57,"range":{"start_line":55,"start_character":0,"end_line":57,"end_character":32},"in_reply_to":"3fa7e38b_5061ebd2","updated":"2019-10-22 13:18:47.000000000","message":"\u003e Why is this removed? Does nova::config::end notify the\n \u003e libvirt-guests service?\n\nNo, but right now I don\u0027t see any value to keep. But maybe\nlets keep it and just remove to notify the service","commit_id":"954f5a1cea6ebffd83255b08938b9238e3a84b86"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"647953ab07170ea7ad5773ab6f11c73bffc74b57","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  include ::nova::params"},{"line_number":53,"context_line":"  include ::nova::deps"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  Anchor[\u0027nova::config::begin\u0027]"},{"line_number":56,"context_line":"  -\u003e File_line\u003c| tag \u003d\u003d \u0027libvirt-guests-file_line\u0027|\u003e"},{"line_number":57,"context_line":"  -\u003e Anchor[\u0027nova::config::end\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  File_line\u003c| tag \u003d\u003d \u0027libvirt-guests-file_line\u0027 |\u003e"},{"line_number":60,"context_line":"  ~\u003e Service[\u0027libvirt-guests\u0027]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3fa7e38b_a69d8958","side":"PARENT","line":57,"range":{"start_line":55,"start_character":0,"end_line":57,"end_character":32},"in_reply_to":"3fa7e38b_d09cfb0f","updated":"2019-10-22 14:31:17.000000000","message":"+1 keeping the tags might be useful e.g tripleo uses this to just generate conf files for containers","commit_id":"954f5a1cea6ebffd83255b08938b9238e3a84b86"}]}