)]}'
{"id":"openstack%2Fpuppet-nova~690621","triplet_id":"openstack%2Fpuppet-nova~stable%2Ftrain~Icf52a2272601401c423ae07f7b10474bdc190574","project":"openstack/puppet-nova","branch":"stable/train","topic":"1849264","hashtags":[],"change_id":"Icf52a2272601401c423ae07f7b10474bdc190574","subject":"Don\u0027t restart libvirt-guests on config change","status":"MERGED","created":"2019-10-23 16:07:44.000000000","updated":"2019-10-24 18:20:40.000000000","submitted":"2019-10-24 18:20:40.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"690621-1571941240452-256045c0","meta_rev_id":"1172def76034a59ec260e97e71437f64f3c6f407","_number":690621,"virtual_id_number":690621,"owner":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-24 18:20:40.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":2,"date":"2019-10-24 14:16:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":2,"date":"2019-10-24 13:46:23.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-10-23 20:10:22.000000000","_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},{"value":0,"date":"2019-10-23 20:10:44.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":1,"date":"2019-10-24 14:16:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"date":"2019-10-23 20:10:29.000000000","_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},{"value":0,"date":"2019-10-23 20:10:57.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"date":"2019-10-24 13:15:09.000000000","_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"date":"2019-10-23 20:10:38.000000000","_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},{"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-23 20:10:22.000000000","updated_by":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"reviewer":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"state":"REVIEWER"},{"updated":"2019-10-23 20:10:29.000000000","updated_by":{"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},"reviewer":{"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},"state":"REVIEWER"},{"updated":"2019-10-23 20:10:38.000000000","updated_by":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"reviewer":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"state":"REVIEWER"},{"updated":"2019-10-23 20:10:44.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2019-10-23 20:10:57.000000000","updated_by":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"reviewer":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"state":"REVIEWER"},{"updated":"2019-10-24 13:46:23.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-10-24 14:16:39.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-10-24 18:20:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c28524afc66a4b249c6d2dfab3250d6e9585c28b","author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"date":"2019-10-23 16:07:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"41a46798435e46fa714038d33d5ab4be0a8fdb82","author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"date":"2019-10-23 16:12:25.000000000","message":"Patch Set 1: Workflow-1\n\nwait until landed in master","accounts_in_message":[],"_revision_number":1},{"id":"178a2339176025654a8c57dae07dfdfe1f77079c","author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"date":"2019-10-23 16:12:33.000000000","message":"Topic changed from 1849264-train to 1849264","accounts_in_message":[],"_revision_number":1},{"id":"e01bed37506789b0135ed94bc92ded5c9d7ec77a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-23 17:43:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/798af14568f749f5acdb445caa4119a5 : SUCCESS in 4m 34s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/6bdae3c567714066a9363f8bf40465fe : SUCCESS in 4m 14s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/d4b59423da6244909ef5266a982051fa : SUCCESS in 27m 30s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/01cc22164174449eb6d8c2b0022afef1 : SUCCESS in 54m 56s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/4a0c3b08927b41ec8d35fe62828b2893 : SUCCESS in 57m 28s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/de62e8cacfdd4dd69d6830d2031398f2 : SUCCESS in 1h 03m 41s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/cf277ed1cd1d4ec4910dce44fa82dc88 : SUCCESS in 43m 37s\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/786e8dca13b049d180334c4925be92ff : SUCCESS in 54m 05s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/42707867890b4d1bb6a21f71e9307ca9 : SUCCESS in 43m 03s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/55794e4babab49738db86b198811b94a : SUCCESS in 34m 50s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/0726b2f16e7d49648016da253d75acfd : SUCCESS in 34m 06s (non-voting)\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/ae5cf2020f014c639666bbb0a18fd1e8 : SUCCESS in 27m 34s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/8b35a87c95804d4c981d205cb48ac8e0 : FAILURE in 7m 45s (non-voting)\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/add55235b2cf4f22851a01531a41d167 : SUCCESS in 1h 30m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a1e557ec06f9c03917790ccf104b98fafd8de3fd","author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"date":"2019-10-24 13:15:09.000000000","message":"Patch Set 1: -Workflow\n\nmerged in master","accounts_in_message":[],"_revision_number":1},{"id":"1a6d501653fc006c3b1e514e4a51932d73b7c60d","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-10-24 13:46:23.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"02f04edfc637ae453adb6f03042cbebd0337f9c7","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-10-24 14:16:39.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"d44086a0fed0da66eb9347ae0dc99c5f19e2f5a0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-24 14:16:51.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"08fd9c35b0a17590b69aab3b29d5e4d55da44e4f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-24 16:16:05.000000000","message":"Patch Set 1:\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"6548cd1383ff5e6c291f1391fa808f16cbe0f769","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-24 18:20:40.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/d5228fe157114c3a9db56483ba3d38c4 : SUCCESS in 5m 34s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/630ee847c49245d5bc80b21d5f98efea : SUCCESS in 5m 56s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/e9ad4459f39c4e518ffd23a3ad9438f1 : SUCCESS in 22m 20s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/25c906bb5dc94d27a970a3e08d772246 : SUCCESS in 56m 44s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/2970c0fdc23540a9ba093a576d7b5b91 : SUCCESS in 1h 05m 58s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/9ee0f2ea551d443dbfcfda984b976f0a : SUCCESS in 1h 08m 25s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/1c58acd14bef4bfe8fa4d51fa2c8b8f2 : SUCCESS in 56m 15s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/af89fcca47464cea839078777b970321 : SUCCESS in 25m 46s\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/4f9d007a0b5b47af8e16bbca4e84bea0 : SUCCESS in 1h 53m 38s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ce8f3bcdf731ec72844c25dc53dcf693bc3392a1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-24 18:20:40.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6a0a609d57d5ff82b417ad823511154372095ef9","revisions":{"6a0a609d57d5ff82b417ad823511154372095ef9":{"kind":"REWORK","_number":1,"created":"2019-10-23 16:07:44.000000000","uploader":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"ref":"refs/changes/21/690621/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/21/690621/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/21/690621/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/21/690621/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/21/690621/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/21/690621/1"}}},"commit":{"parents":[{"commit":"e6628d679dd30f481fac5faaa04315468c2b20ca","subject":"Merge \"Switch to Train\" into stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/e6628d679dd30f481fac5faaa04315468c2b20ca"}]}],"author":{"name":"Martin Schuppert","email":"mschuppert@redhat.com","date":"2019-10-22 08:57:05.000000000","tz":120},"committer":{"name":"Martin Schuppert","email":"mschuppert@redhat.com","date":"2019-10-23 16:01:09.000000000","tz":120},"subject":"Don\u0027t restart libvirt-guests on config change","message":"Don\u0027t restart libvirt-guests on config change\n\nWhen there is a config change the service gets notfied to be\nrestarted, which is not required as /usr/libexec/libvirt-guests.sh\nsources /etc/sysconfig/libvirt-guests on each run. As a side\neffect of the service restart, instances get stopped which is bad.\n\nIn addition manage_service was bound to the enabled parameter.\nThis introduces manage_service to be able to manage start/stop\nindependent from enabled parameter.\n\nChange-Id: Icf52a2272601401c423ae07f7b10474bdc190574\nCloses-Bug: #1849264\n(cherry picked from commit 0e1da12265d3cb2a9bdc4fe4b8a50fa7928bfb69)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/6a0a609d57d5ff82b417ad823511154372095ef9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/6a0a609d57d5ff82b417ad823511154372095ef9"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}