)]}'
{"id":"openstack%2Fpuppet-nova~690626","triplet_id":"openstack%2Fpuppet-nova~stable%2Fqueens~Icf52a2272601401c423ae07f7b10474bdc190574","project":"openstack/puppet-nova","branch":"stable/queens","topic":"1849264","hashtags":[],"change_id":"Icf52a2272601401c423ae07f7b10474bdc190574","subject":"Don\u0027t restart libvirt-guests on config change","status":"MERGED","created":"2019-10-23 16:11:02.000000000","updated":"2019-10-24 19:49:13.000000000","submitted":"2019-10-24 19:49:13.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"690626-1571946553815-5cb63f8a","meta_rev_id":"5ab587fa19da7affa43fe5baedb7ccb5fba876d9","_number":690626,"virtual_id_number":690626,"owner":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-24 19:49:13.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":2,"date":"2019-10-24 14:17:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-10-23 20:13:29.000000000","_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},{"value":0,"date":"2019-10-23 20:13:57.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"date":"2019-10-23 20:13:35.000000000","_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},{"value":0,"date":"2019-10-23 20:14:10.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"date":"2019-10-24 13:16:10.000000000","_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"value":1,"date":"2019-10-24 14:24:41.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"date":"2019-10-23 20:13:47.000000000","_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},{"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-23 20:13:29.000000000","updated_by":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"reviewer":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"state":"REVIEWER"},{"updated":"2019-10-23 20:13:35.000000000","updated_by":{"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},"reviewer":{"_account_id":30133,"name":"Piotr Kopec","email":"pkopec17@gmail.com","username":"pkopec"},"state":"REVIEWER"},{"updated":"2019-10-23 20:13:47.000000000","updated_by":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"reviewer":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"state":"REVIEWER"},{"updated":"2019-10-23 20:13:57.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2019-10-23 20:14:10.000000000","updated_by":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"reviewer":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"state":"REVIEWER"},{"updated":"2019-10-24 14:17:09.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-10-24 14:24:41.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-10-24 19:49:13.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ef59571b7451f2620a8d43804f29a9dd83b3848f","author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"date":"2019-10-23 16:11:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c4b6d89de30be6aa33ed2adf5c239946787beaa5","author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"date":"2019-10-23 16:14:00.000000000","message":"Patch Set 1: Workflow-1\n\nwait until landed in master","accounts_in_message":[],"_revision_number":1},{"id":"01a643492d89931da74c3ed4b78a87c92c938f07","author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"date":"2019-10-23 16:14:10.000000000","message":"Topic set to 1849264","accounts_in_message":[],"_revision_number":1},{"id":"9525ebc243efae4d334508bfd1aaa9d74537de34","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-23 17:48:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint https://zuul.opendev.org/t/openstack/build/582e38932a1449c79cc6530edd519a01 : SUCCESS in 4m 15s\n- puppet-openstack-syntax-4 https://zuul.opendev.org/t/openstack/build/ecbc09a304194103b433f6141e7452a2 : SUCCESS in 5m 09s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/5ceadc63e1c74580a0aa0a53d6d3773a : SUCCESS in 29m 45s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/a7202e8b37584a3cb25df2a7f8cee786 : SUCCESS in 22m 30s\n- puppet-openstack-integration-4-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/c15990b67d654224a94321ecd6fa24d1 : SUCCESS in 59m 49s\n- puppet-openstack-integration-4-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/a8662a33de464f4d92f2497254634558 : SUCCESS in 1h 07m 55s\n- puppet-openstack-integration-4-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/aa30989b18314d85848e418db4615bac : SUCCESS in 1h 05m 03s\n- puppet-openstack-integration-4-scenario004-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/26bfc775bd9946c2bfaf8b0acbb3c611 : SUCCESS in 41m 55s\n- puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial-luminous https://zuul.opendev.org/t/openstack/build/2944ed35daf74ec69d2db86fc23e747f : TIMED_OUT in 1h 31m 02s (non-voting)\n- puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/b56c1b113de440aba0e9615bdd552b8a : TIMED_OUT in 1h 31m 05s (non-voting)\n- puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/dea580eb098a47d19883bc75c8415a9c : TIMED_OUT in 1h 30m 56s (non-voting)\n- puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial-luminous https://zuul.opendev.org/t/openstack/build/8e96012685954c9d9ede2d3fa654ae3e : TIMED_OUT in 1h 30m 47s (non-voting)\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/bfa206b1b3334e18858984e3c5c18858 : SUCCESS in 26m 14s\n- puppet-openstack-beaker-xenial https://zuul.opendev.org/t/openstack/build/61b70996dfdd498992907b5c9e3c787d : SUCCESS in 16m 17s","accounts_in_message":[],"_revision_number":1},{"id":"c9a7ab9d2a75fc968e62b0042b36b0853e2317f2","author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"date":"2019-10-24 13:16:10.000000000","message":"Patch Set 1: -Workflow\n\nmerged in master","accounts_in_message":[],"_revision_number":1},{"id":"f6ce4930e3207026f7f377bd3e5da0eaa0db4cec","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-10-24 14:17:09.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"1f1b532c01df1d891a9ca99f059388733e5916d3","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-10-24 14:24:41.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"d521ff411024e41606b64b703523b88780413792","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-24 14:24:54.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e74a5694a27bc90133f9e3407fca4f73c41ab5ed","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-24 16:16:12.000000000","message":"Patch Set 1:\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"30a4491effc00bdd96ba476b3b067898db0fbc38","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-24 19:49:13.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"5ab587fa19da7affa43fe5baedb7ccb5fba876d9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-24 19:49:13.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint https://zuul.opendev.org/t/openstack/build/7174e937f0ab471eb300eedee2f0e7f1 : SUCCESS in 5m 29s\n- puppet-openstack-syntax-4 https://zuul.opendev.org/t/openstack/build/1a41b910d2b14d88a26fff0ba6f4493e : SUCCESS in 5m 07s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/46d08613c75b40d2b0a52e5089c7a953 : SUCCESS in 23m 49s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/38485b47000941bba79ed93cb7aa7f96 : SUCCESS in 20m 01s\n- puppet-openstack-integration-4-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/a643a9c7c36a4111aa61c44f63f2dac6 : SUCCESS in 1h 08m 57s\n- puppet-openstack-integration-4-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/46491195ceaf4750b3919cf78282e4d5 : SUCCESS in 52m 21s\n- puppet-openstack-integration-4-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/f813105d475b4ce0b304feec8c355e0e : SUCCESS in 56m 37s\n- puppet-openstack-integration-4-scenario004-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/3ab7728bf0604360a49c76a9e17e63b4 : SUCCESS in 42m 55s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/458aa713c48f4ff1931d7abfa8c2cabd : SUCCESS in 24m 10s\n- puppet-openstack-beaker-xenial https://zuul.opendev.org/t/openstack/build/60aa58a0d3ac44749e8cf89cb42bcf0a : SUCCESS in 20m 03s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9f8fa5147e215c1cdaab95a16535c566a61c3f35","revisions":{"9f8fa5147e215c1cdaab95a16535c566a61c3f35":{"kind":"REWORK","_number":1,"created":"2019-10-23 16:11:02.000000000","uploader":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"ref":"refs/changes/26/690626/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/26/690626/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/26/690626/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/26/690626/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/26/690626/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/26/690626/1"}}},"commit":{"parents":[{"commit":"b876ace5fa102a1a5e9d205282a6e35f1d0fc82f","subject":"Fix \"More than one line in file \u0027/etc/sysconfig/libvirtd\u0027 matches pattern\" errors","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/b876ace5fa102a1a5e9d205282a6e35f1d0fc82f"}]}],"author":{"name":"Martin Schuppert","email":"mschuppert@redhat.com","date":"2019-10-22 08:57:05.000000000","tz":120},"committer":{"name":"Martin Schuppert","email":"mschuppert@redhat.com","date":"2019-10-23 16:10:40.000000000","tz":120},"subject":"Don\u0027t restart libvirt-guests on config change","message":"Don\u0027t restart libvirt-guests on config change\n\nWhen there is a config change the service gets notfied to be\nrestarted, which is not required as /usr/libexec/libvirt-guests.sh\nsources /etc/sysconfig/libvirt-guests on each run. As a side\neffect of the service restart, instances get stopped which is bad.\n\nIn addition manage_service was bound to the enabled parameter.\nThis introduces manage_service to be able to manage start/stop\nindependent from enabled parameter.\n\nChange-Id: Icf52a2272601401c423ae07f7b10474bdc190574\nCloses-Bug: #1849264\n(cherry picked from commit 0e1da12265d3cb2a9bdc4fe4b8a50fa7928bfb69)\n(cherry picked from commit 6a0a609d57d5ff82b417ad823511154372095ef9)\n(cherry picked from commit a555962745bc275414537007d4a59d2364b9a87d)\n(cherry picked from commit 9079de85fc9fccf1fdb35682ca080b1a5e7e92f4)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/9f8fa5147e215c1cdaab95a16535c566a61c3f35"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/9f8fa5147e215c1cdaab95a16535c566a61c3f35"}]},"parents_data":[{"branch_name":"refs/heads/stable/queens","commit_id":"b876ace5fa102a1a5e9d205282a6e35f1d0fc82f","is_merged_in_target_branch":false,"change_id":"Iae595796559cc6551d8ae27e2573122a8a2da15d","change_number":687996,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}