)]}'
{"id":"openstack%2Fpuppet-nova~691471","triplet_id":"openstack%2Fpuppet-nova~stable%2Fstein~If4d6a4a8f4cc1e7066cacb00da67d5433acd6ac5","project":"openstack/puppet-nova","branch":"stable/stein","topic":"bug/1529065-stable/train-stable/stein","hashtags":[],"change_id":"If4d6a4a8f4cc1e7066cacb00da67d5433acd6ac5","subject":"Include nova::availability_zone in nova::api and nova::conductor","status":"MERGED","created":"2019-10-26 08:49:34.000000000","updated":"2019-10-28 13:53:58.000000000","submitted":"2019-10-28 13:50:51.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"691471-1572270651040-c8ddf85e","meta_rev_id":"8cdf59232c849a3a34500b9f233949b69e533f46","_number":691471,"virtual_id_number":691471,"owner":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-28 13:50:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-10-28 11:00:12.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-10-28 11:00:12.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"date":"2019-10-26 08:49:34.000000000","_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-26 08:49:34.000000000","updated_by":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"reviewer":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"state":"REVIEWER"},{"updated":"2019-10-28 11:00:12.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-10-28 13:50:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2fb96910eaea593d0d9caa23493fa3670ec8404f","author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"date":"2019-10-26 08:49:34.000000000","message":"Patch Set 1: Cherry Picked from branch stable/train.","accounts_in_message":[],"_revision_number":1},{"id":"e718a1bf96ddf7e4debfd4759c432e958c3af200","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-26 11:24:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/38d447964dcb47488a96ac98034a181f : SUCCESS in 3m 45s\n- puppet-openstack-syntax-4-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/b56deccc3dbe46f2ba1d0f059f61ee5f : SUCCESS in 3m 27s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/38aeba4b91534962b501963d5f754482 : SUCCESS in 3m 41s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/dcac120467974cd89898557d0e603396 : SUCCESS in 3m 29s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/88ae2979fb7a4e278cb72e3392d816f4 : SUCCESS in 33m 29s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/5e2a1262a6fe4f9b8e9bfbdf5eff8546 : SUCCESS in 29m 59s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/1b3ce88df79b487bbef852932c09e6c7 : SUCCESS in 57m 06s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/a838c45dea0045dca8b379f2eafe7868 : SUCCESS in 55m 07s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/212c528ec2d64b4f9df10722838fa0eb : SUCCESS in 56m 48s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/1c05ccd8bc774901ac500af0d990c79c : SUCCESS in 44m 07s (non-voting)\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/8e8a6ba37c0d4520a97c5efae848d141 : FAILURE in 20m 11s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f06e7ca76bcd4b04935838d9f3e8c0c9 : FAILURE in 20m 57s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/6bc1947e4ad4419387fc78724f76b031 : FAILURE in 20m 28s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/0bb178558a70450fbc97ceb665efceb7 : FAILURE in 19m 57s (non-voting)\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/29449faceb794622bb9e9af7a7363c03 : SUCCESS in 23m 23s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f74e9f5b8de8414c88f2febaf61afd67 : FAILURE in 15m 04s (non-voting)\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/c8407a60310f44e19c14624acb28bebc : SUCCESS in 2h 30m 33s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7caff4d4367eaa995fe9bc2c12eec82d68b89da9","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-10-28 11:00:12.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"4c7e8c2cb516b00a1494f51f9708d991f65dbbf5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-28 11:00:23.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e3762cf9a3e0e04a9c396dacea04c25b9c6f49e3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-28 13:50:50.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/b98cdbbf74a74313b8eed606c04647fd : SUCCESS in 4m 41s\n- puppet-openstack-syntax-4-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f7ee851497f6485e85b588cbf91f95bc : SUCCESS in 4m 08s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/8859038c87554e91995c5707709985eb : SUCCESS in 4m 03s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/4cbef651fa1649b4a09bed43606a62fc : SUCCESS in 4m 33s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/1229e6c2598d4fb6a77300870a347414 : SUCCESS in 30m 09s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/58a8603d2a814c5083a137f249a542ba : SUCCESS in 33m 53s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/d151793d80f649959a6eb3bdbaca9c08 : SUCCESS in 54m 25s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/7b2777eb3d56489a8d0b67a4e07508d1 : SUCCESS in 1h 00m 02s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/458aa6663a2c4131aa8616e56da8bbe8 : SUCCESS in 57m 28s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/8744fb9f8708428c83dd341131166b2d : SUCCESS in 23m 31s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/01340ea136dd46b88718f4d293ef2c73 : FAILURE in 16m 12s (non-voting)\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/a82c0621cefd44dca65a1b5cfe28a889 : SUCCESS in 2h 45m 34s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3472f9e7f415817795ffc4bcf2a59fdec93aea20","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-28 13:50:51.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"657e537833e4a495d0a1c8f6df405eecc7f034a3","author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"date":"2019-10-28 13:53:58.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/rocky as commit effda25202c9270b843e113c12edef5b80130559","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"75d67bd6c8ff0fd147e1ac7516ede2bc60d960b2","revisions":{"75d67bd6c8ff0fd147e1ac7516ede2bc60d960b2":{"kind":"REWORK","_number":1,"created":"2019-10-26 08:49:34.000000000","uploader":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"ref":"refs/changes/71/691471/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/71/691471/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/71/691471/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/71/691471/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/71/691471/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/71/691471/1"}}},"commit":{"parents":[{"commit":"a555962745bc275414537007d4a59d2364b9a87d","subject":"Don\u0027t restart libvirt-guests on config change","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/a555962745bc275414537007d4a59d2364b9a87d"}]}],"author":{"name":"Oliver Walsh","email":"owalsh@redhat.com","date":"2019-10-17 20:43:43.000000000","tz":60},"committer":{"name":"Martin Schuppert","email":"mschuppert@redhat.com","date":"2019-10-26 08:49:34.000000000","tz":0},"subject":"Include nova::availability_zone in nova::api and nova::conductor","message":"Include nova::availability_zone in nova::api and nova::conductor\n\nFor some reason this was included in nova::compute and nova::scheduler\nbut never included in nova::api eventhough bug #1529065 specifically\ncalls out the fact that it is missing.\n\nLooking at the code - nova-api definitely requires it.\nE.g the server create request handler sets the target AZ to\nCONF.default_schedule_zone if none\nhttps://github.com/openstack/nova/blob/stable/queens/nova/api/openstack/compute/servers.py#L486\n\nand the az request handler skips the internal_service_availabily_zone\nwhen listing AZs\nhttps://github.com/openstack/nova/blob/stable/queens/nova/api/openstack/compute/availability_zone.py#L38\n\nnova-conductor also requires it as it calls\navailability_zones.get_host_availability_zone which defaults to\nCONF.default_availability_zone\n\nChange-Id: If4d6a4a8f4cc1e7066cacb00da67d5433acd6ac5\nCloses-bug: #1529065\n(cherry picked from commit d7eb253e4de03c05eb6597db0959e4137831ad91)\n(cherry picked from commit 57ff2a154c0e50da4a833ffabfef27a8d0db4fb6)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/75d67bd6c8ff0fd147e1ac7516ede2bc60d960b2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/75d67bd6c8ff0fd147e1ac7516ede2bc60d960b2"}]},"parents_data":[{"branch_name":"refs/heads/stable/stein","commit_id":"a555962745bc275414537007d4a59d2364b9a87d","is_merged_in_target_branch":false,"change_id":"Icf52a2272601401c423ae07f7b10474bdc190574","change_number":690624,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}