)]}'
{"manifests/init.pp":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"d256c020c48d71d83d1ba07bbf5061efdb0e814d","unresolved":false,"context_lines":[{"line_number":438,"context_line":"  $control_exchange                       \u003d $::os_service_default,"},{"line_number":439,"context_line":"  # these glance params should be optional"},{"line_number":440,"context_line":"  # this should probably just be configured as a glance client"},{"line_number":441,"context_line":"  $glance_api_servers                     \u003d \u0027http://localhost:9292\u0027,"},{"line_number":442,"context_line":"  $rabbit_use_ssl                         \u003d $::os_service_default,"},{"line_number":443,"context_line":"  $rabbit_heartbeat_timeout_threshold     \u003d $::os_service_default,"},{"line_number":444,"context_line":"  $rabbit_heartbeat_rate                  \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3fa7e38b_326042d0","side":"PARENT","line":441,"range":{"start_line":441,"start_character":44,"end_line":441,"end_character":67},"updated":"2020-02-14 15:52:16.000000000","message":"not sure if removing this default will break anything... but I don\u0027t see an alternative","commit_id":"d2a9f480176b717c234a233c8b466ab32440838d"}],"releasenotes/notes/deprecate_glance_api_servers-ae08e65b7ebac688.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f49bdb980ea32eac1e85f0cd10d46b3cb0a0cb67","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    nova::glance_api_servers has been deprecated as the nova config option is"},{"line_number":5,"context_line":"    now deprecated."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_38d103cb","line":2,"updated":"2020-02-14 18:49:37.000000000","message":"Recommend adding features section that describes the new nova::glance_api_endpoint parameter. For many use cases, the new parameter essentially replaces the one being deprecated (the limitation being you cannot specify a list values).","commit_id":"9c727e95e4976ed9a4f9858e36ed95dd40433ed1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dc72c3e90a7abb053c2dd31dd5506b211b466ff6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    nova::glance_api_servers has been deprecated as the nova config option is"},{"line_number":5,"context_line":"    now deprecated."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_c7a32a9b","line":2,"in_reply_to":"3fa7e38b_38d103cb","updated":"2020-02-15 12:17:57.000000000","message":"+1","commit_id":"9c727e95e4976ed9a4f9858e36ed95dd40433ed1"}],"spec/classes/nova_init_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dc72c3e90a7abb053c2dd31dd5506b211b466ff6","unresolved":false,"context_lines":[{"line_number":124,"context_line":"      end"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"      it \u0027configures glance endpoint_override\u0027 do"},{"line_number":127,"context_line":"        is_expected.to contain_nova_config(\u0027glance/endpoint_override\u0027)"},{"line_number":128,"context_line":"      end"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"      it \u0027does not configure glance api servers\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"3fa7e38b_079e2254","line":127,"range":{"start_line":127,"start_character":8,"end_line":127,"end_character":70},"updated":"2020-02-15 12:17:57.000000000","message":"Can we make sure that the parameter has the expected value, like ;\n\n    is_expected.to contain_nova_config(\u0027glance/endpoint_override\u0027).with_value(\u0027http://localhost:9292\u0027)","commit_id":"9c727e95e4976ed9a4f9858e36ed95dd40433ed1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dc72c3e90a7abb053c2dd31dd5506b211b466ff6","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        is_expected.to contain_nova_config(\u0027glance/endpoint_override\u0027)"},{"line_number":128,"context_line":"      end"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"      it \u0027does not configure glance api servers\u0027 do"},{"line_number":131,"context_line":"        is_expected.to_not contain_nova_config(\u0027glance/api_servers\u0027)"},{"line_number":132,"context_line":"      end"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"3fa7e38b_2799de69","line":130,"range":{"start_line":130,"start_character":6,"end_line":130,"end_character":51},"updated":"2020-02-15 12:17:57.000000000","message":"Because the parameter is still available though deprecated, I would prefer to keep existing tests to set api_servers in this deprecation patch.","commit_id":"9c727e95e4976ed9a4f9858e36ed95dd40433ed1"}]}