)]}'
{"manifests/metadata/novajoin/api.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"caa7fd8550638f3de50820828d4a11c436f7a633","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  $configure_kerberos        \u003d false,"},{"line_number":128,"context_line":"  $ipa_realm                 \u003d undef,"},{"line_number":129,"context_line":") {"},{"line_number":130,"context_line":"  include nova::params"},{"line_number":131,"context_line":"  include nova::metadata::novajoin::authtoken"},{"line_number":132,"context_line":"  include nova::metadata::novajoin::policy"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":13,"id":"df33271e_38c4b43f","line":130,"range":{"start_line":130,"start_character":2,"end_line":130,"end_character":22},"updated":"2020-04-02 17:50:37.000000000","message":"migt want to inherit this in the class instead and leave this blank line","commit_id":"0aac4291bda4b4d46f2a03a3beac730cfb78cd9e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7c4c51c849a7b86cabd7fb875b89f34f0b1e1c5c","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  $configure_kerberos        \u003d false,"},{"line_number":128,"context_line":"  $ipa_realm                 \u003d undef,"},{"line_number":129,"context_line":") {"},{"line_number":130,"context_line":"  include nova::params"},{"line_number":131,"context_line":"  include nova::metadata::novajoin::authtoken"},{"line_number":132,"context_line":"  include nova::metadata::novajoin::policy"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":13,"id":"df33271e_b36e27c6","line":130,"range":{"start_line":130,"start_character":2,"end_line":130,"end_character":22},"in_reply_to":"df33271e_38c4b43f","updated":"2020-04-02 18:18:31.000000000","message":"We only need to inherit if it was using as a class param.  Since this isn\u0027t used there I think this is fine","commit_id":"0aac4291bda4b4d46f2a03a3beac730cfb78cd9e"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"caa7fd8550638f3de50820828d4a11c436f7a633","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    fail(\u0027service_password is missing\u0027)"},{"line_number":140,"context_line":"  }"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"  if ! $nova::params::novajoin_package_name {"},{"line_number":143,"context_line":"    fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"},{"line_number":144,"context_line":"  }"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":13,"id":"df33271e_18bf30aa","line":142,"range":{"start_line":142,"start_character":2,"end_line":142,"end_character":45},"updated":"2020-04-02 17:50:37.000000000","message":"can we explictly test for undef since that matches a false statement as well","commit_id":"0aac4291bda4b4d46f2a03a3beac730cfb78cd9e"}]}