)]}'
{"id":"openstack%2Fpuppet-nova~717156","triplet_id":"openstack%2Fpuppet-nova~master~Ic3cebbaf73adbfb30b88a93c0bc4dbc516ba3664","project":"openstack/puppet-nova","branch":"master","topic":"centos8-novajoin","hashtags":[],"change_id":"Ic3cebbaf73adbfb30b88a93c0bc4dbc516ba3664","subject":"Strictly test nova::params::novajoin_package_name","status":"MERGED","created":"2020-04-03 00:19:36.000000000","updated":"2020-04-03 16:51:29.000000000","submitted":"2020-04-03 16:51:28.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"717156-1585932689105-cde04409","meta_rev_id":"13b97ecb7428f2ccf09832bfd74b8660a2a389b3","_number":717156,"virtual_id_number":717156,"owner":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-04-03 16:51:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2020-04-03 14:14:05.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2020-04-03 08:52:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":1,"date":"2020-04-03 14:14:05.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-04-03 08:52:36.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2020-04-03 14:14:05.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2020-04-03 16:51:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"43113675803b18d70395506044ca4ebd955315bc","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-04-03 00:19:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"962825c80dc9ad1d0d3993945a388f5c1b60d02a","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-04-03 00:20:13.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"e403d807ef08d31c3dd9c617beca0c5616d3acf3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-03 03:09:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f7e961e00cc7451caec0bd2b35a31424 : SUCCESS in 5m 23s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/56c34a68e3d8490abd750edeb3febbc2 : SUCCESS in 7m 11s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/754dc047601444e48d3a6285d4b9b648 : SUCCESS in 5m 25s\n- puppet-openstack-unit-5.5-centos-8 https://zuul.opendev.org/t/openstack/build/3f6b387a922f4583b5f5a89314d7458d : SUCCESS in 22m 04s (non-voting)\n- puppet-openstack-unit-6.11-centos-8 https://zuul.opendev.org/t/openstack/build/a2bf11c00af14646b0766a59741c001a : SUCCESS in 21m 44s\n- puppet-openstack-unit-6.11-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/1800d7d136434ebdabcba55528ce0377 : SUCCESS in 20m 07s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/645084bec76449c0adc7f837c294d8d0 : FAILURE in 20m 01s (non-voting)\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/b2abda1934114af680fa8f160a508326 : SUCCESS in 51m 07s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/704cab4b8abd493ba8ecc1c444b00b37 : SUCCESS in 51m 59s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e1f2ea466f564f84a1d0e3f97eba5f17 : SUCCESS in 40m 01s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/eb7f00cd0e7f452c88fcdab730fad368 : SUCCESS in 36m 37s (non-voting)\n- puppet-openstack-integration-5-scenario001-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/df3251a0927c4827a1d8baa2d5d0eb5a : SUCCESS in 55m 07s\n- puppet-openstack-integration-5-scenario002-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/e46cf942e0b84d99b43a430907e985d3 : SUCCESS in 1h 04m 12s\n- puppet-openstack-integration-5-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/dddb2acfa04c4fb3999a74d2e96a907e : SUCCESS in 1h 07m 41s\n- puppet-openstack-integration-5-scenario004-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/7e2452b3b7d44011a8e1d87b90d4a865 : SUCCESS in 46m 27s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/09f90f2287e3497291b408b3b08e2525 : SUCCESS in 27m 00s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/24b0346b2a094458895735e29567b56b : FAILURE in 7m 15s (non-voting)\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/4a8cd9c670a84d6daf376a831118a24f : SUCCESS in 2h 42m 58s","accounts_in_message":[],"_revision_number":2},{"id":"ad7e11d385cde68e56a4ddef8a0f42914de020fb","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2020-04-03 08:52:36.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"0bfd0c113880c85ecb1f6f6ddf09b021b186fec0","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2020-04-03 14:14:05.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"617d25e58fa45e132e366dbf64c4a14a6fac3ae4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-03 14:14:17.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"06544e475960148326d777c787b6302745505bb5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-03 16:51:28.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e124ab999fa64f52814fbf4801812656 : SUCCESS in 7m 36s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/64c738d4c6e34bb6bd4b7f29c9a9e068 : SUCCESS in 7m 30s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/26c7e857f0bd4b10950265e2988759f7 : SUCCESS in 7m 44s\n- puppet-openstack-unit-5.5-centos-8 https://zuul.opendev.org/t/openstack/build/eed6100f5aac4ae48066460e2de8e383 : SUCCESS in 23m 49s (non-voting)\n- puppet-openstack-unit-6.11-centos-8 https://zuul.opendev.org/t/openstack/build/7872c34f43d44e4c9a916d1eac6fc642 : SUCCESS in 23m 46s\n- puppet-openstack-unit-6.11-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/db2fa3d6efca40aba01090c05e30b825 : SUCCESS in 17m 04s\n- puppet-openstack-integration-5-scenario001-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/f9d2323b84654ec9a4df15a000e4e26a : SUCCESS in 1h 03m 08s\n- puppet-openstack-integration-5-scenario002-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/0148384293064d6bafbca61e2b8a856a : SUCCESS in 1h 11m 57s\n- puppet-openstack-integration-5-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/578881539a7c4807a3d0a95ffc6b0ed3 : SUCCESS in 1h 08m 47s\n- puppet-openstack-integration-5-scenario004-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/016c441f929a4c439627216dacf07aac : SUCCESS in 45m 59s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/b33f86f952ae480b994bed1c10931737 : SUCCESS in 32m 15s\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/10bc66b3a63c476aae845528e50119ca : SUCCESS in 2h 29m 30s","accounts_in_message":[],"_revision_number":2},{"id":"96d18209030925dac2b7debb56f2d60edf4c2e92","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-03 16:51:29.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5a01b0b4dceeb86807db466270c9888dcb8d5fb2","revisions":{"2d57a0eff28576c18060b59a2b7184f12f168b9a":{"kind":"REWORK","_number":1,"created":"2020-04-03 00:19:36.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/56/717156/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/56/717156/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/56/717156/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/56/717156/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/56/717156/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/56/717156/1"}}},"commit":{"parents":[{"commit":"0aac4291bda4b4d46f2a03a3beac730cfb78cd9e","subject":"Select correct novajoin package in CentOS8/Fedora","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/0aac4291bda4b4d46f2a03a3beac730cfb78cd9e"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2020-04-03 00:17:00.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2020-04-03 00:17:00.000000000","tz":540},"subject":"Strictly check nova::params::novajoin_package_name","message":"Strictly check nova::params::novajoin_package_name\n\nThis is a follow-up of 0aac4291bda4b4d46f2a03a3beac730cfb78cd9e, and\nmake sure we test whether nova::params::nova_join_package_name is\nundef, to avoid unexpected matching with false for example.\n\nChange-Id: Ic3cebbaf73adbfb30b88a93c0bc4dbc516ba3664\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/2d57a0eff28576c18060b59a2b7184f12f168b9a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/2d57a0eff28576c18060b59a2b7184f12f168b9a"}]},"branch":"refs/heads/master"},"5a01b0b4dceeb86807db466270c9888dcb8d5fb2":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-04-03 00:20:13.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/56/717156/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/56/717156/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/56/717156/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/56/717156/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/56/717156/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/56/717156/2"}}},"commit":{"parents":[{"commit":"0aac4291bda4b4d46f2a03a3beac730cfb78cd9e","subject":"Select correct novajoin package in CentOS8/Fedora","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/0aac4291bda4b4d46f2a03a3beac730cfb78cd9e"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2020-04-03 00:17:00.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2020-04-03 00:19:51.000000000","tz":540},"subject":"Strictly test nova::params::novajoin_package_name","message":"Strictly test nova::params::novajoin_package_name\n\nThis is a follow-up of 0aac4291bda4b4d46f2a03a3beac730cfb78cd9e, and\nmake sure we test whether nova::params::nova_join_package_name is\nundef, to avoid unexpected matching with false for example.\n\nChange-Id: Ic3cebbaf73adbfb30b88a93c0bc4dbc516ba3664\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/5a01b0b4dceeb86807db466270c9888dcb8d5fb2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/5a01b0b4dceeb86807db466270c9888dcb8d5fb2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}