)]}'
{"id":"openstack%2Fpuppet-nova~723738","triplet_id":"openstack%2Fpuppet-nova~master~I2e07e29740cf0398b4f34457b53d54890b4aa843","project":"openstack/puppet-nova","branch":"master","topic":"cross_az_attach","hashtags":[],"change_id":"I2e07e29740cf0398b4f34457b53d54890b4aa843","subject":"Migrate back cross_az_attach","status":"MERGED","created":"2020-04-27 22:33:19.000000000","updated":"2020-04-28 15:45:37.000000000","submitted":"2020-04-28 15:41:23.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"723738-1588088483377-a73711ca","meta_rev_id":"53e833590252f2595570e491fd0f9d926918573f","_number":723738,"virtual_id_number":723738,"owner":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-04-28 15:41:23.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":2,"date":"2020-04-28 13:17:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":2,"date":"2020-04-28 07:52:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":1,"date":"2020-04-28 13:17:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-04-27 22:39:44.000000000","updated_by":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"reviewer":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"state":"REVIEWER"},{"updated":"2020-04-28 07:52:47.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2020-04-28 13:17:11.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2020-04-28 15:41:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"108567e1e7114f9514a585b93ad67caa484e188f","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-04-27 22:33:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d71c78163bcb8ba36cd9a772c4f6bdb4290f2489","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-04-27 22:41:16.000000000","message":"Patch Set 1:\n\nSorry that I missed this while implementing the initial patch...\n\nAdding Shengping as a reviewer because I think it\u0027s better to include this change before we cut off Usurri release.","accounts_in_message":[],"_revision_number":1},{"id":"0a14fd278ba6cb307a2929c18096af304b6f7b53","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-04-27 23:00:42.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"81b7eabba241b9dcb746aa81eb365805c2bd9c66","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-28 02:36:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/3a5428537b6f44bfa87b57f83823c3d4 : SUCCESS in 4m 46s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/94664e7fd74c45e5a9e11fc21572f33f : SUCCESS in 4m 30s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f649490586764906a2df458c396106ff : SUCCESS in 4m 40s\n- puppet-openstack-unit-5.5-centos-8 https://zuul.opendev.org/t/openstack/build/ba74274ca4464c30a057cd170532ac65 : SUCCESS in 18m 00s\n- puppet-openstack-unit-6.14-centos-8 https://zuul.opendev.org/t/openstack/build/47758722246f47548ac0da7bf041141c : SUCCESS in 22m 25s\n- puppet-openstack-unit-6.14-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e53b81e294d04509a4ab7f2a8515599f : SUCCESS in 18m 04s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9642705ac3424bf0af8d78acc2699208 : FAILURE in 17m 47s (non-voting)\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/e62346fca3754ad8b9d938a270c36e71 : SUCCESS in 54m 06s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f40c93e11050428facb100abb910fead : FAILURE in 50m 39s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/02dd04dd3f6f4785ba506daf7e8a17e6 : SUCCESS in 39m 23s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/af89125947a74f9cbee901b666e21aa5 : SUCCESS in 36m 05s (non-voting)\n- puppet-openstack-integration-5-scenario001-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/fa448aa0467347279117f9a131e05d20 : SUCCESS in 50m 42s\n- puppet-openstack-integration-5-scenario002-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/b4f46f2dfb9048dbbac34b249fe5b8b5 : SUCCESS in 1h 03m 32s\n- puppet-openstack-integration-5-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/5e94b78f37bf4268aa84066e6e4cb89e : SUCCESS in 1h 00m 46s\n- puppet-openstack-integration-5-scenario004-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/f3d0953e4eac489b8f449e5decf846c2 : SUCCESS in 44m 52s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/5d7e8bb3fa844d0a99ac4fac07dd2e82 : SUCCESS in 24m 16s\n- puppet-openstack-beaker-centos-8 https://zuul.opendev.org/t/openstack/build/7717084510c04b229ada9129a47ca46b : FAILURE in 7m 50s (non-voting)\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/16b50a7f45bf4c31b34b836bd87e3794 : FAILURE in 7m 39s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9803cd1e132f4c0b8e13ef27e0afdba8 : SUCCESS in 3m 51s\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/95a286465b1f4b7b8fec4c6165148f12 : SUCCESS in 3h 33m 54s","accounts_in_message":[],"_revision_number":2},{"id":"613f91ffdc2f3e7379e89c44b5d08440dbc2b0b9","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2020-04-28 07:52:47.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"0dde3a834b15caa0e97205a19153b6b29311a32b","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2020-04-28 13:17:11.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"935727262a69759861a99bbb79ae8ae01080a711","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-28 13:17:23.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"8d0e8ace04c65c0eed04463a92e762c96f3dc7a7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-28 15:41:23.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"3f1b335f34478366974ba57cacc3dd9a00b82f56","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-28 15:41:23.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/a6dc28ab2f65459fa8cfb104135c4cd6 : SUCCESS in 5m 46s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/b100dae01f324b158075c08429e0f811 : SUCCESS in 5m 01s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/7d5a8cacb96e405fb12bcc00ee176b6d : SUCCESS in 5m 31s\n- puppet-openstack-unit-5.5-centos-8 https://zuul.opendev.org/t/openstack/build/2fdfeaf57e1a4fc6b0645571557da9ae : SUCCESS in 19m 36s\n- puppet-openstack-unit-6.14-centos-8 https://zuul.opendev.org/t/openstack/build/14a185475933419698e1bf932b604195 : SUCCESS in 21m 05s\n- puppet-openstack-unit-6.14-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/de0f6d8cdb76432e8f0374b9b8ecf9c0 : SUCCESS in 16m 54s\n- puppet-openstack-integration-5-scenario001-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/350eac1fad554033a9109da06eecde02 : SUCCESS in 53m 36s\n- puppet-openstack-integration-5-scenario002-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/529613fc2cd94d04a34b1dc5a6f334ff : SUCCESS in 1h 02m 53s\n- puppet-openstack-integration-5-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/7a51747cd8a042a5ab5d39cd297c3ae6 : SUCCESS in 1h 01m 59s\n- puppet-openstack-integration-5-scenario004-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/53070faaacf74d31b9f845a68c152f44 : SUCCESS in 46m 22s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/695a2d01b108491abf7b760981f48c83 : SUCCESS in 28m 27s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ff676d2739714ebb857d6ecd64a13dfb : SUCCESS in 4m 37s\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/7b210547628741e281e3cfcf41c7178a : SUCCESS in 2h 22m 50s","accounts_in_message":[],"_revision_number":2},{"id":"c2351ecbb9967f5c56bc231d8c308c9ede803996","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-28 15:45:37.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a9abef7af7164d0c8870ced38dcb1fea : SUCCESS in 3m 41s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d0aee23dae6b5fc81e4203497c94d0318fc8d2f9","revisions":{"f33cd176b9657c6741495c4189bde60175c34ebf":{"kind":"REWORK","_number":1,"created":"2020-04-27 22:33:19.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/38/723738/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/38/723738/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/38/723738/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/38/723738/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/38/723738/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/38/723738/1"}}},"commit":{"parents":[{"commit":"293f1b5e8e0ff80a9fc7118b86b19668de5352df","subject":"Merge \"Migrate parameters for cinder from nova to nova::cinder\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/293f1b5e8e0ff80a9fc7118b86b19668de5352df"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2020-04-27 22:26:12.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2020-04-27 22:26:12.000000000","tz":540},"subject":"Migrate back cross_az_attach","message":"Migrate back cross_az_attach\n\nThe previous change[1] migrated some parameters related cinder\nfrom nova to nova::cinder, but cross_az_attach shouldn\u0027t be migrate\nbecause the parameter is used in nova-api and nova-compute and in some\ncases nova::cinder class is not actually loaded in api side.\n(We actually don\u0027t include nova::cinder for controllers in TripleO)\n\nThis patch partially reverts the change by [1], so that we keep\ncross_az_attach in more common place, which is surely loaded in\nboth control plane and hypervisor.\n\n[1] 72103db985d00b3289b8b936956166f20ef8f3d0\n\nChange-Id: I2e07e29740cf0398b4f34457b53d54890b4aa843\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/f33cd176b9657c6741495c4189bde60175c34ebf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/f33cd176b9657c6741495c4189bde60175c34ebf"}]},"branch":"refs/heads/master"},"d0aee23dae6b5fc81e4203497c94d0318fc8d2f9":{"kind":"REWORK","_number":2,"created":"2020-04-27 23:00:42.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/38/723738/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/38/723738/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/38/723738/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/38/723738/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/38/723738/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/38/723738/2"}}},"commit":{"parents":[{"commit":"293f1b5e8e0ff80a9fc7118b86b19668de5352df","subject":"Merge \"Migrate parameters for cinder from nova to nova::cinder\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/293f1b5e8e0ff80a9fc7118b86b19668de5352df"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2020-04-27 22:26:12.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2020-04-27 23:00:39.000000000","tz":0},"subject":"Migrate back cross_az_attach","message":"Migrate back cross_az_attach\n\nThe previous change[1] migrated some parameters related cinder\nfrom nova to nova::cinder, but cross_az_attach shouldn\u0027t be migrate\nbecause the parameter is used in nova-api and nova-compute and in some\ncases nova::cinder class is not actually loaded in api side.\n(We actually don\u0027t include nova::cinder for controllers in TripleO)\n\nThis patch partially reverts the change by [1], so that we keep\ncross_az_attach in more common place, which is surely loaded in\nboth control plane and hypervisor.\n\n[1] 72103db985d00b3289b8b936956166f20ef8f3d0\n\nChange-Id: I2e07e29740cf0398b4f34457b53d54890b4aa843\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/d0aee23dae6b5fc81e4203497c94d0318fc8d2f9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/d0aee23dae6b5fc81e4203497c94d0318fc8d2f9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}