)]}'
{"id":"openstack%2Fpuppet-nova~728899","triplet_id":"openstack%2Fpuppet-nova~master~I5371e8ef3d04c26aba1518f7c212d62311b773f1","project":"openstack/puppet-nova","branch":"master","topic":"vendordata","hashtags":[],"change_id":"I5371e8ef3d04c26aba1518f7c212d62311b773f1","subject":"Include vendordata in metadata api","status":"ABANDONED","created":"2020-05-18 14:01:42.000000000","updated":"2020-05-18 14:18:16.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1392c345f00ec3839fe8591d8e3b3e357de6c4ff","_number":728899,"virtual_id_number":728899,"owner":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"actions":{},"labels":{"Verified":{"all":[{"date":"2020-05-18 14:18:12.000000000","_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":-1,"date":"2020-05-18 14:13:42.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-05-18 14:13:42.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"}],"messages":[{"id":"860740d89e85d2146c45e3a076f42cd9cf67b91a","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-05-18 14:01:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dd3df30e0d44d855dcf02ddde8bea848944b298d","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2020-05-18 14:13:42.000000000","message":"Patch Set 1: Code-Review-1\n\nI disagree even thought its theoretically correct, we want to get rid of the include patterns","accounts_in_message":[],"_revision_number":1},{"id":"9a5ab04b1a7243fe762855e79e36949663d7b798","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-05-18 14:18:12.000000000","message":"Patch Set 1:\n\nI think the problem was that tripleo didn\u0027t follow parameter deprecation thus missed to add vendordata class,\nthough deprecation warning was shown in one cycle.\nI\u0027ll fix the problem in tripleo side.\n\nIn addition, seems like vendordata parameters are not used in compute, and it can be removed.\nI\u0027ll submit a follow-up change about that.\n\nhttps://github.com/openstack/puppet-nova/commit/296b10691680dd364ba8eaa0e938f9691c3744bb","accounts_in_message":[],"_revision_number":1},{"id":"9a8721afece00d93087480e7648e4052faf5858a","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-05-18 14:18:16.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1a5d13c12154f8fb91be87aec8aef9a8eb8b315f","revisions":{"1a5d13c12154f8fb91be87aec8aef9a8eb8b315f":{"kind":"REWORK","_number":1,"created":"2020-05-18 14:01:42.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/99/728899/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/99/728899/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/99/728899/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/99/728899/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/99/728899/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/99/728899/1"}}},"commit":{"parents":[{"commit":"2c32631e90396299d94e571334793e4882067073","subject":"Bump version for the start of Victoria","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/2c32631e90396299d94e571334793e4882067073"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2020-05-18 14:00:59.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2020-05-18 14:00:59.000000000","tz":540},"subject":"Include vendordata in metadata api","message":"Include vendordata in metadata api\n\nThe vendordata configuration is used not only in compute but also\nin metadata, thus the module shuold be included in metadata class.\n\nChange-Id: I5371e8ef3d04c26aba1518f7c212d62311b773f1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/1a5d13c12154f8fb91be87aec8aef9a8eb8b315f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/1a5d13c12154f8fb91be87aec8aef9a8eb8b315f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
