)]}'
{"manifests/compute/libvirt/version.pp":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"992bac89f7d948ad3f9b473039ed06c68d717faa","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        \u0027RedHat\u0027, \u0027CentOS\u0027: {"},{"line_number":14,"context_line":"          if versioncmp($facts[\u0027os\u0027][\u0027release\u0027][\u0027full\u0027], \u00278.2\u0027) \u003e\u003d 0 {"},{"line_number":15,"context_line":"            $default \u003d \u00276.0\u0027"},{"line_number":16,"context_line":"          } elsif versioncmp($facts[\u0027os\u0027][\u0027release\u0027][\u0027full\u0027], \u00277.6\u0027) \u003e\u003d 0 {"},{"line_number":17,"context_line":"            $default \u003d \u00274.5\u0027"},{"line_number":18,"context_line":"          } else {"},{"line_number":19,"context_line":"            $default \u003d \u00273.9\u0027"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"ff570b3c_a43a24ca","line":16,"range":{"start_line":16,"start_character":10,"end_line":16,"end_character":75},"updated":"2020-05-26 07:52:22.000000000","message":"AFAIK CentOS 7 is not longer supported in puppet-nova since ussuri so i think we can skip this","commit_id":"feec21bdbf87ff523f05de6527c543fe70646815"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"de59dd2dd8d7b71a42d04cce3eeb466df52a55ec","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        \u0027RedHat\u0027, \u0027CentOS\u0027: {"},{"line_number":14,"context_line":"          if versioncmp($facts[\u0027os\u0027][\u0027release\u0027][\u0027full\u0027], \u00278.2\u0027) \u003e\u003d 0 {"},{"line_number":15,"context_line":"            $default \u003d \u00276.0\u0027"},{"line_number":16,"context_line":"          } elsif versioncmp($facts[\u0027os\u0027][\u0027release\u0027][\u0027full\u0027], \u00277.6\u0027) \u003e\u003d 0 {"},{"line_number":17,"context_line":"            $default \u003d \u00274.5\u0027"},{"line_number":18,"context_line":"          } else {"},{"line_number":19,"context_line":"            $default \u003d \u00273.9\u0027"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"ff570b3c_6db10fe2","line":16,"range":{"start_line":16,"start_character":10,"end_line":16,"end_character":75},"in_reply_to":"ff570b3c_a43a24ca","updated":"2020-05-26 11:46:14.000000000","message":"The problem is that we still have beaker test running on CentOS7, and we need compatibility for CentOS7 to avoid failure in that voting job.\n\nFYI. That job can be removed once we migrate to CentOS8 for beaker jobs, but I\u0027m currently stuck with refactored repository structure at the moment...","commit_id":"feec21bdbf87ff523f05de6527c543fe70646815"}],"manifests/migration/libvirt.pp":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"992bac89f7d948ad3f9b473039ed06c68d717faa","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    case $::osfamily {"},{"line_number":241,"context_line":"      \u0027RedHat\u0027: {"},{"line_number":242,"context_line":"        if versioncmp($libvirt_version, \u00275.7\u0027) \u003e\u003d 0 {"},{"line_number":243,"context_line":"          if $transport_real \u003d\u003d \u0027tls\u0027 {"},{"line_number":244,"context_line":"            service { \u0027libvirtd-tls\u0027:"},{"line_number":245,"context_line":"              ensure  \u003d\u003e \u0027running\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"ff570b3c_a43fc4b3","line":242,"range":{"start_line":242,"start_character":8,"end_line":242,"end_character":52},"updated":"2020-05-26 07:52:22.000000000","message":"IIUC libvirt 5.6, included in 8.1 includes support for activation sockets although is not the default option (at least i could test it), so I\u0027d move to use it unconditionally for RedHat osfamily.","commit_id":"feec21bdbf87ff523f05de6527c543fe70646815"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"de59dd2dd8d7b71a42d04cce3eeb466df52a55ec","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    case $::osfamily {"},{"line_number":241,"context_line":"      \u0027RedHat\u0027: {"},{"line_number":242,"context_line":"        if versioncmp($libvirt_version, \u00275.7\u0027) \u003e\u003d 0 {"},{"line_number":243,"context_line":"          if $transport_real \u003d\u003d \u0027tls\u0027 {"},{"line_number":244,"context_line":"            service { \u0027libvirtd-tls\u0027:"},{"line_number":245,"context_line":"              ensure  \u003d\u003e \u0027running\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"ff570b3c_0dbcd3b9","line":242,"range":{"start_line":242,"start_character":8,"end_line":242,"end_character":52},"in_reply_to":"ff570b3c_a43fc4b3","updated":"2020-05-26 11:46:14.000000000","message":"Done","commit_id":"feec21bdbf87ff523f05de6527c543fe70646815"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"afbe720901b486f97d3ffe858a54d72ef954f4f5","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    case $::osfamily {"},{"line_number":241,"context_line":"      \u0027RedHat\u0027: {"},{"line_number":242,"context_line":"        if versioncmp($libvirt_version, \u00275.6\u0027) \u003e\u003d 0 {"},{"line_number":243,"context_line":"          $manage_service \u003d pick($::nova::compute::libvirt::manage_libvirt_services)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"          if $manage_service {"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ff570b3c_6d458f70","line":242,"range":{"start_line":242,"start_character":8,"end_line":242,"end_character":51},"updated":"2020-05-26 12:10:33.000000000","message":"IMO involving libvirt_version new param is overcomplicating this. I\u0027d just check \"if facts[:operatingsystemmajrelease] \u003e \u00277\u0027\" using services, else, setting --listen option. I think making libvirt_version configurable is not needed.","commit_id":"e6a1428c08447969ddc3a8bd64ab465d7fc61556"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"990cee05b74d9303a5d3ba586dfc942b759d4a97","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    case $::osfamily {"},{"line_number":241,"context_line":"      \u0027RedHat\u0027: {"},{"line_number":242,"context_line":"        if versioncmp($libvirt_version, \u00275.6\u0027) \u003e\u003d 0 {"},{"line_number":243,"context_line":"          $manage_service \u003d pick($::nova::compute::libvirt::manage_libvirt_services)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"          if $manage_service {"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ff570b3c_1ebd1b68","line":242,"range":{"start_line":242,"start_character":8,"end_line":242,"end_character":51},"in_reply_to":"ff570b3c_6d458f70","updated":"2020-05-26 13:37:11.000000000","message":"This follow the way how we have implemented a logic which depends on libvirt versions[1], and I think it\u0027s better than adding another logic to detect libvirt version here.\n\n [1] https://github.com/openstack/puppet-nova/blob/master/manifests/compute/libvirt/qemu.pp#L99","commit_id":"e6a1428c08447969ddc3a8bd64ab465d7fc61556"}]}