)]}'
{"id":"openstack%2Fpuppet-nova~733955","triplet_id":"openstack%2Fpuppet-nova~stable%2Ftrain~Iab96968de75d7064b3aecf266d0f24b7b98dc809","project":"openstack/puppet-nova","branch":"stable/train","hashtags":[],"change_id":"Iab96968de75d7064b3aecf266d0f24b7b98dc809","subject":"Fix dependency cycle","status":"MERGED","created":"2020-06-06 09:28:00.000000000","updated":"2020-06-08 17:06:32.000000000","submitted":"2020-06-08 17:06:32.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"733955-1591635992663-61bf20c8","meta_rev_id":"20cc6cbd21cc043d9a7ede7f77de1126de19902a","_number":733955,"virtual_id_number":733955,"owner":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-06-08 17:06:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"all":[{"value":2,"date":"2020-06-08 01:39:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":2,"date":"2020-06-08 14:40:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"all":[{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":1,"date":"2020-06-08 14:40:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-08 01:39:23.000000000","updated_by":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"reviewer":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"state":"REVIEWER"},{"updated":"2020-06-08 14:40:04.000000000","updated_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"REVIEWER"},{"updated":"2020-06-08 17:06:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"947c29a7429ef64e4a5c42296433e06a9ee25d1f","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2020-06-06 09:28:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dfa2dda8e1b66668638812c6a10218100d61bc06","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-06 12:00:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/5dde31a31ea04f0a8cfc55726bdcdd73 : SUCCESS in 5m 18s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/0d3e7422e2f140a9b32d276a4666ceca : SUCCESS in 4m 44s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/05247c5f40a3402aa9f1994423d698fe : SUCCESS in 4m 37s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/4005c5597bf74904abcfe598e335bfb8 : SUCCESS in 21m 57s\n- puppet-openstack-unit-5.5-centos-8 https://zuul.opendev.org/t/openstack/build/42cc8cb4c51b444494b5dfe2dca6199d : SUCCESS in 19m 16s\n- puppet-openstack-unit-6.4-centos-8 https://zuul.opendev.org/t/openstack/build/03301570a4c34807baeb7c59f27a0e72 : SUCCESS in 19m 11s\n- puppet-openstack-unit-6.4-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/7c85b16af5dc439abd183c128577f2d4 : SUCCESS in 17m 11s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/32451e6b04f4490f8fe9739543cc6ddf : FAILURE in 16m 55s (non-voting)\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/988702d180e94ce1909d8632bf1f1824 : SUCCESS in 1h 03m 15s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/cbc7f12371654220bc7faef6d3055b63 : SUCCESS in 1h 03m 31s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/11c78877b0364b9ab5370d0baede53c9 : SUCCESS in 1h 07m 40s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/a90ceca0c6f040a9bb2392b7ed52d929 : SUCCESS in 44m 41s\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/32b8474597c74c6683120416ccf5ca35 : SUCCESS in 49m 38s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/692d00106d0d4e27afb68c6ea7d21eb9 : SUCCESS in 1h 04m 40s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/299e8ec6edd24f7ba6696c9e568a6bfc : SUCCESS in 45m 48s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/c2e662f2abcc49b7bbd1a8bd92471607 : SUCCESS in 39m 18s (non-voting)\n- puppet-openstack-integration-5-scenario001-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/28d4a11bee294f40a607072011b0356c : SUCCESS in 55m 54s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/1ebf25c821144be78f31dd1c4e811112 : SUCCESS in 54m 14s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/c50391ae3e6d44ff990f1bc8f2a9e37c : SUCCESS in 1h 04m 33s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/11bece3188b44026ab482cf97e5b7c44 : SUCCESS in 51m 28s (non-voting)\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/235625c2e4e049d4b59bd97912d631d2 : SUCCESS in 22m 40s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/cb045ca35a8a42c7bf3a4a6b1cbed3c8 : FAILURE in 20m 34s (non-voting)\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/dcb487106859418983724673f76ead71 : SUCCESS in 2h 27m 36s","accounts_in_message":[],"_revision_number":1},{"id":"32cbd56563345aa5ad0d461c9f62c58c56e3ef01","author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"date":"2020-06-08 01:39:23.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"445ef3e12c3cc97513b96b7328ddb785e4e9c5d2","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-06-08 14:40:04.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"b330e9f85836b777c2d91d2e4b184fea56c19fed","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-08 14:40:15.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"d8a16ba10abe9064889e194a62f162eb70b4f728","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-08 17:06:32.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"20cc6cbd21cc043d9a7ede7f77de1126de19902a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-08 17:06:32.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/59adf0c9345949628eb83c904ad5ea95 : SUCCESS in 5m 34s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/b712be2ef8cb477c9c67d53ff746a743 : SUCCESS in 5m 37s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/4ec9bf13aae94180b8b3d9b1d4ca4c2f : SUCCESS in 5m 09s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/fd77be33ba86407cb52528fd30c340b6 : SUCCESS in 24m 53s\n- puppet-openstack-unit-6.4-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/690cee64e4474319af308cdc4b1e666b : SUCCESS in 16m 04s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/16013f3f093d451a9a51783a8bffbfef : SUCCESS in 1h 02m 37s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/a92ba61efbaa45df9f4db7c6d77b17f0 : SUCCESS in 54m 54s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/165e624e3b29412f8898275582972960 : SUCCESS in 1h 01m 30s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/350773bf445542d9bc4f3835c9cfe42e : SUCCESS in 58m 56s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/5a3c30f977214174b3fff8215c5740f9 : SUCCESS in 24m 30s\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/396f4eecf1fa4a268f30f4c4f1577ed1 : SUCCESS in 2h 24m 37s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c15e37c4246a7f8922e3a172419490c134c258d9","revisions":{"c15e37c4246a7f8922e3a172419490c134c258d9":{"kind":"REWORK","_number":1,"created":"2020-06-06 09:28:00.000000000","uploader":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"ref":"refs/changes/55/733955/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/55/733955/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/55/733955/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/55/733955/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/55/733955/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/55/733955/1"}}},"commit":{"parents":[{"commit":"9d933a3e31003a8e250625c8d97da6a346b15571","subject":"Use systemd units to enable tcp/tls in libvirt","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/9d933a3e31003a8e250625c8d97da6a346b15571"}]}],"author":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2020-06-05 08:41:30.000000000","tz":120},"committer":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2020-06-06 09:27:50.000000000","tz":120},"subject":"Fix dependency cycle","message":"Fix dependency cycle\n\nThere is a dependency cycle when using the nova::compute::libvirt\nclass and the nova::compute::rbd class in the same manifest.\n\nThe \u0027set-secret-value virsh\u0027 resource says before the\nnova::config::end resource but up it\u0027s dependency path the\nnew libvirtd-tcp sources introduced in [1] depends requires\nthe nova::config::end anchor.\n\nThis removes the before nova::config::end on the set-secret-value\nresources and only makes it depend on the get-or-set resource.\n\n2020-06-05 08:26:58.966645 | centos-8 | (Anchor[nova::config::end] \u003d\u003e\nService[libvirtd-tcp] \u003d\u003e Service[libvirt] \u003d\u003e Exec[get-or-set virsh\nsecret] \u003d\u003e Exec[set-secret-value virsh] \u003d\u003e\nAnchor[nova::config::end])\\nTry the \u0027--graph\u0027 option and opening the\nresulting \u0027.dot\u0027 file in OmniGraffle or GraphViz\n\n[1] https://review.opendev.org/#/c/730689/\n\nChange-Id: Iab96968de75d7064b3aecf266d0f24b7b98dc809\n(cherry picked from commit 345fac687a01075350fc057473dc042734024b04)\n(cherry picked from commit e9931d92c90b94611e76c90bdf70bffb29fba68c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/c15e37c4246a7f8922e3a172419490c134c258d9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/c15e37c4246a7f8922e3a172419490c134c258d9"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}