)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"621b9d45e37aec1fa9322e9bada88ac3df65aca5","unresolved":false,"context_lines":[{"line_number":15,"context_line":"This change adds a params parameter which is a hash of options to"},{"line_number":16,"context_line":"pass through to the authtoken resource. The individual params are"},{"line_number":17,"context_line":"still used as defaults, but any keys set in the params hash override"},{"line_number":18,"context_line":"them. I propose deprecating these individual parameters in a future"},{"line_number":19,"context_line":"commit."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Depends-On: https://review.opendev.org/#/c/743858/"},{"line_number":22,"context_line":"Change-Id: I695834ac03a52d8569e50db600676a89e165491d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_561c4ac0","line":19,"range":{"start_line":18,"start_character":6,"end_line":19,"end_character":6},"updated":"2020-08-02 23:31:42.000000000","message":"One thing we should be careful about when we deprecate existing parameters is that each puppet modules define their own default values for some parameters like username.\n\nI think this default overriding is useful because users don\u0027t need to define all of the parameters by themselves, and should be kept while we can deprecate the other parameters.","commit_id":"5c38281e1b698f157f03bf1815733277c541c30b"}],"manifests/api.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"d666fa5511a4926ea1713ee775f49a02b3ee4737","unresolved":false,"context_lines":[{"line_number":352,"context_line":"  }"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"  if $validate {"},{"line_number":355,"context_line":"    $authtoken_values \u003d {"},{"line_number":356,"context_line":"      \u0027username\u0027 \u003d\u003e $::nova::keystone::authtoken::username,"},{"line_number":357,"context_line":"      \u0027password\u0027 \u003d\u003e $::nova::keystone::authtoken::password,"},{"line_number":358,"context_line":"      \u0027project_name\u0027 \u003d\u003e $::nova::keystone::authtoken::project_name,"},{"line_number":359,"context_line":"      \u0027www_authenticate_uri\u0027 \u003d\u003e $::nova::keystone::authtoken::www_authenticate_uri,"},{"line_number":360,"context_line":"    }"},{"line_number":361,"context_line":"    $authtoken \u003d merge($authtoken_values, $::nova::keystone::authtoken::params)"},{"line_number":362,"context_line":"    $defaults \u003d {"},{"line_number":363,"context_line":"      \u0027nova-api\u0027 \u003d\u003e {"},{"line_number":364,"context_line":"        \u0027command\u0027  \u003d\u003e @(\"CMD\"/L)"},{"line_number":365,"context_line":"          nova --os-auth-url ${authtoken[\u0027www_authenticate_uri\u0027]} \\"},{"line_number":366,"context_line":"          --os-project-name ${authtoken[\u0027project_name\u0027]} \\"},{"line_number":367,"context_line":"          --os-username ${authtoken[\u0027username\u0027]} \\"},{"line_number":368,"context_line":"          --os-password ${authtoken[\u0027password\u0027]} \\"},{"line_number":369,"context_line":"          flavor-list"},{"line_number":370,"context_line":"          |- CMD"},{"line_number":371,"context_line":"      }"},{"line_number":372,"context_line":"    }"},{"line_number":373,"context_line":"    $validation_options_hash \u003d merge ($defaults, $validation_options)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f560f44_7d37d8b1","line":370,"range":{"start_line":355,"start_character":1,"end_line":370,"end_character":16},"updated":"2020-07-30 14:02:18.000000000","message":"This is somewhat unrelated to the change though, I\u0027m for just deprecating and removing any validation commands, like we\u0027ve done with puppet-keystone and some parts of puppet-neutron.","commit_id":"5c38281e1b698f157f03bf1815733277c541c30b"}],"spec/classes/nova_api_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"621b9d45e37aec1fa9322e9bada88ac3df65aca5","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    \"include nova"},{"line_number":7,"context_line":"     class { \u0027nova::keystone::authtoken\u0027:"},{"line_number":8,"context_line":"       password \u003d\u003e \u0027passw0rd\u0027,"},{"line_number":9,"context_line":"       params \u003d\u003e { \u0027username\u0027 \u003d\u003e \u0027novae\u0027 },"},{"line_number":10,"context_line":"     }\""},{"line_number":11,"context_line":"  end"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9f560f44_764d0ec3","line":9,"range":{"start_line":9,"start_character":14,"end_line":9,"end_character":16},"updated":"2020-08-02 23:31:42.000000000","message":"(nit) align \u003d\u003e","commit_id":"5c38281e1b698f157f03bf1815733277c541c30b"}],"spec/classes/nova_keystone_authtoken_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"621b9d45e37aec1fa9322e9bada88ac3df65aca5","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    context \u0027when overriding parameters via params hash\u0027 do"},{"line_number":137,"context_line":"      before do"},{"line_number":138,"context_line":"        params.merge!({"},{"line_number":139,"context_line":"          :username                             \u003d\u003e \u0027myuser\u0027,"},{"line_number":140,"context_line":"          :params                               \u003d\u003e { \u0027username\u0027 \u003d\u003e \"myotheruser\" },"},{"line_number":141,"context_line":"        })"},{"line_number":142,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9f560f44_b6c84622","line":139,"range":{"start_line":139,"start_character":20,"end_line":139,"end_character":48},"updated":"2020-08-02 23:31:42.000000000","message":"(nit) redundant spaces","commit_id":"5c38281e1b698f157f03bf1815733277c541c30b"}]}