)]}'
{"id":"openstack%2Fpuppet-nova~743861","triplet_id":"openstack%2Fpuppet-nova~master~I695834ac03a52d8569e50db600676a89e165491d","project":"openstack/puppet-nova","branch":"master","topic":"authtoken-params","hashtags":[],"change_id":"I695834ac03a52d8569e50db600676a89e165491d","subject":"Use a \u0027params\u0027 hash for authtoken parameters","status":"MERGED","created":"2020-07-30 01:35:07.000000000","updated":"2020-08-10 20:48:46.000000000","submitted":"2020-08-10 20:48:46.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"743861-1597092526331-5080a3ed","meta_rev_id":"398aa375b39519f0c5ac066a330e262205a1a556","_number":743861,"virtual_id_number":743861,"owner":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"date":"2020-08-02 23:31:42.000000000","_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"date":"2020-07-30 14:02:18.000000000","_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-10 20:48:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2020-08-10 17:52:18.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":2,"date":"2020-07-31 13:48:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":1,"date":"2020-08-10 17:52:18.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-30 14:02:18.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2020-07-31 13:48:43.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2020-08-02 23:31:42.000000000","updated_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"REVIEWER"},{"updated":"2020-08-10 17:52:18.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2020-08-10 20:48:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"87f949fc3284981ff60e0459c76eeafa78f0092b","author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"date":"2020-07-30 01:35:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"50c49247eb6839442026c13a9b78c4f040170731","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-30 04:10:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/619ee5b2fa064691ba3be7d97ee9aa98 : SUCCESS in 6m 09s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/ae90f973e51140f68c9ba957faf708dd : SUCCESS in 4m 55s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/ddd5405fe56e4c3ea90a95aed6b1820c : SUCCESS in 4m 49s\n- puppet-openstack-unit-5.5-centos-8 https://zuul.opendev.org/t/openstack/build/29ea808b0e3c4e81b6b6acc4d29b6cad : SUCCESS in 18m 01s\n- puppet-openstack-unit-6.14-centos-8 https://zuul.opendev.org/t/openstack/build/7cd03ab868ce4abf8baf5cac67be43bd : SUCCESS in 19m 36s\n- puppet-openstack-unit-6.14-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e27f29ee49084eac9128347d0961faf3 : SUCCESS in 13m 41s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/469ab94249c34b57b6e31e281037ea53 : FAILURE in 6m 22s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/ddcfcb8e80954db0bf2bd434f1016fc9 : SUCCESS in 47m 34s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/bf4547cea5ab4fd392ada785c8e58b3b : FAILURE in 49m 43s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/18e7700b0bfb47d998c561bb5e966146 : SUCCESS in 44m 56s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/2d3def6153b5422587e86500f97dc8d1 : SUCCESS in 49m 20s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/469b11d418164734b8bad413992b028a : SUCCESS in 1h 19m 41s\n- puppet-openstack-integration-6-scenario002-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/904bd30b626b40f28055629c5054971e : SUCCESS in 1h 33m 13s\n- puppet-openstack-integration-6-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/40edddd692944143a61787a2e97f6576 : SUCCESS in 1h 28m 28s\n- puppet-openstack-integration-6-scenario004-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/002bf090fa594498b56af635a86fc152 : SUCCESS in 59m 16s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/ecd3ac23dbc14d1ebf84d73ea635742e : SUCCESS in 39m 08s\n- puppet-openstack-beaker-centos-8 https://zuul.opendev.org/t/openstack/build/3c917bc830df47d892af81453071e4fc : FAILURE in 8m 38s (non-voting)\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/058da812103a48d38a203eefbaa90285 : FAILURE in 8m 46s (non-voting)\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/af44014061f14eb3b2d93a6923162cee : SUCCESS in 2h 29m 00s","accounts_in_message":[],"_revision_number":1},{"id":"d666fa5511a4926ea1713ee775f49a02b3ee4737","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2020-07-30 14:02:18.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nThis \"params\" approach is interesting and I think it adds some value that users doesn\u0027t have to send patches for parameters that doesn\u0027t exist. However I also think it\u0027s somewhat annoying working with hashes so not sure if I\u0027m for deprecating/removing the parameters even though it makes sense for modules such as puppet-nova etc that use oslo/openstacklib/keystone modules to configure some resources.","accounts_in_message":[],"_revision_number":1},{"id":"87a61e347de7b230f6a503164fb8b190e55d4a90","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2020-07-31 13:48:43.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"621b9d45e37aec1fa9322e9bada88ac3df65aca5","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-08-02 23:31:42.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"39dc9b1f8c1c92aab9791916210569ccef88244a","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2020-08-10 17:52:18.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"5b61eb5a36a7657f6d0c73807b5ad821015cb664","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-10 17:52:30.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"700f6dbb2d8a332c3684af9cccf46a9bffa25aea","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-10 20:48:45.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/8810da67bcc04ceaa3f9e81e7706ecdc : SUCCESS in 4m 15s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/0cd7e4dfdf3b49b2bb2a4d42e226a5bf : SUCCESS in 6m 13s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/0464666e813f4f2ca051905e3b6b4c27 : SUCCESS in 5m 09s\n- puppet-openstack-unit-5.5-centos-8 https://zuul.opendev.org/t/openstack/build/f100f42175574ceaaa1446c82f6d5e5e : SUCCESS in 18m 27s\n- puppet-openstack-unit-6.14-centos-8 https://zuul.opendev.org/t/openstack/build/eb42e1d4dee949d1886422f248c68749 : SUCCESS in 24m 28s\n- puppet-openstack-unit-6.14-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/88dd1541352d40aa94ffdb23bf049668 : SUCCESS in 19m 18s\n- puppet-openstack-integration-6-scenario001-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/41b107443ea84ee1964151152ccd8256 : SUCCESS in 1h 12m 50s\n- puppet-openstack-integration-6-scenario002-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/a4efb77c3acc49cf8ccc49dbea99eefd : SUCCESS in 1h 35m 53s\n- puppet-openstack-integration-6-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/0fc7747006944119a98008e8ed114c70 : SUCCESS in 1h 32m 32s\n- puppet-openstack-integration-6-scenario004-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/b24d5196ce5c4ab5bde4fa9441a9c70b : SUCCESS in 1h 01m 31s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/bf3459b2b6f8497898fdf778088b694a : SUCCESS in 29m 37s\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/4174b3b125e547579011da147979cc57 : SUCCESS in 2h 47m 58s","accounts_in_message":[],"_revision_number":1},{"id":"e2e0941d81ba629238fbee5bca8b75066fbb96f4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-10 20:48:46.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5c38281e1b698f157f03bf1815733277c541c30b","revisions":{"5c38281e1b698f157f03bf1815733277c541c30b":{"kind":"REWORK","_number":1,"created":"2020-07-30 01:35:07.000000000","uploader":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"ref":"refs/changes/61/743861/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/61/743861/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/61/743861/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/61/743861/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/61/743861/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/61/743861/1"}}},"commit":{"parents":[{"commit":"c1d92c4c74da9d7fff64e7bbb17b3cd89579da3a","subject":"Merge \"Remove deprecated parameters for baremetal scheduling\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/c1d92c4c74da9d7fff64e7bbb17b3cd89579da3a"}]}],"author":{"name":"Kieran Spear","email":"kispear@gmail.com","date":"2020-07-30 01:29:36.000000000","tz":600},"committer":{"name":"Kieran Spear","email":"kispear@gmail.com","date":"2020-07-30 01:35:06.000000000","tz":600},"subject":"Use a \u0027params\u0027 hash for authtoken parameters","message":"Use a \u0027params\u0027 hash for authtoken parameters\n\nCurrently adding a new authtoken parameter requires changes\nin nearly 30 different puppet projects. For options without defaults,\ndefining these individually in each puppet-* project doesn\u0027t\nappear to add any value since validation is already happening\nin the keystone::resource::authtoken class.\n\nThis change adds a params parameter which is a hash of options to\npass through to the authtoken resource. The individual params are\nstill used as defaults, but any keys set in the params hash override\nthem. I propose deprecating these individual parameters in a future\ncommit.\n\nDepends-On: https://review.opendev.org/#/c/743858/\nChange-Id: I695834ac03a52d8569e50db600676a89e165491d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/5c38281e1b698f157f03bf1815733277c541c30b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/5c38281e1b698f157f03bf1815733277c541c30b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}