)]}'
{"id":"openstack%2Fpuppet-nova~749412","triplet_id":"openstack%2Fpuppet-nova~master~Id41e597ef4339cbe39ef3056fc6ed665afc7819d","project":"openstack/puppet-nova","branch":"master","hashtags":[],"change_id":"Id41e597ef4339cbe39ef3056fc6ed665afc7819d","subject":"Add remove_unused_original_minimum_age_seconds option","status":"ABANDONED","created":"2020-09-02 00:10:37.000000000","updated":"2021-05-08 08:01:09.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7ee21d2e5c94781d8d383fc6e4be05e94c2388af","_number":749412,"virtual_id_number":749412,"owner":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-09-02 01:06:16.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},{"value":-1,"date":"2020-09-02 04:14:52.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"all":[{"value":-1,"date":"2020-09-02 16:39:53.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-02 01:06:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-09-02 04:14:52.000000000","updated_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"REVIEWER"}],"messages":[{"id":"7ef5981d8656c902650aa18fe7c2f4820cbcb9fa","author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"date":"2020-09-02 00:10:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e9e7a6993a56acb459075f2c05a6fd8c1a0b5a4a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-02 01:06:16.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/6a4f18927e224a43b7cfacbd6ed089bc : SUCCESS in 3m 54s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/639d55cfc247464588a3f6b59a3167a8 : SUCCESS in 2m 33s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/84e9bca5d2f94ad4abcc2430a2492639 : SUCCESS in 2m 59s\n- puppet-openstack-unit-5.5-centos-8 https://zuul.opendev.org/t/openstack/build/37ce3cd94d0944f09bca442cdc36761f : FAILURE in 10m 39s\n- puppet-openstack-unit-6.14-centos-8 https://zuul.opendev.org/t/openstack/build/947e0e551ee64f78bb6aaf579eb94db0 : FAILURE in 10m 33s\n- puppet-openstack-unit-6.14-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f4a4e28830a840a8b436c6a4f67cffcf : FAILURE in 8m 40s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e20de76c52c249a6bc3af5c5c996bcb3 : FAILURE in 8m 36s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/74b76022698e4e73a4af8ce490d70148 : FAILURE in 9m 36s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e755794d65bd4eae8c5a12400eb1f3e7 : FAILURE in 8m 57s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/bc4867eaef144ed4951b1839700dea4d : FAILURE in 7m 47s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/0178c5ef3b274c9c883ea0161da6f752 : FAILURE in 6m 41s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/51f22f0ebdee4c3095b65402fd9a1ef4 : FAILURE in 8m 25s\n- puppet-openstack-integration-6-scenario002-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/b5b7df2d454546a794d90671bac1f20f : FAILURE in 12m 02s\n- puppet-openstack-integration-6-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/41d1f54dcfb04ceb85b7831f900abb1f : FAILURE in 8m 21s\n- puppet-openstack-integration-6-scenario004-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/e1426560b0584e4ba89ba96ddec19f4c : FAILURE in 9m 56s\n- puppet-openstack-beaker-centos-8 https://zuul.opendev.org/t/openstack/build/91b75277f09c4c3ab39c7bc6faf9c924 : FAILURE in 8m 41s (non-voting)\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/0fe03661f7aa4f5985bd250ffdc79c65 : FAILURE in 6m 56s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/24e33d876d614b4d9fa7ad1077930ac0 : SUCCESS in 3m 28s\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/f0f6a6b37b4c448fbe4022cfd479b1f9 : FAILURE in 53m 57s","accounts_in_message":[],"_revision_number":1},{"id":"b04d53e9bcfef529d32054eb903a15cea9794c44","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-09-02 04:14:52.000000000","message":"Patch Set 1: Code-Review-1\n\nI\u0027m afraid that this parameter is already implemented in libvirt.pp[1]\n [1] https://github.com/openstack/puppet-nova/blob/master/manifests/compute/libvirt.pp#L408-L416","accounts_in_message":[],"_revision_number":1},{"id":"269ef9ae856cad871004a7d836adf0ea15dfc215","author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"date":"2020-09-02 16:39:53.000000000","message":"Patch Set 1: Workflow-1\n\nhow did I miss that...\n\n-W until I deprecate the existing params (they are deprecated in nova)","accounts_in_message":[],"_revision_number":1},{"id":"7ee21d2e5c94781d8d383fc6e4be05e94c2388af","tag":"autogenerated:gerrit:abandon","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-05-08 08:01:09.000000000","message":"Abandoned\n\nI\u0027ll abandon this because the parameter is now implemented in nova::compute::image_cache. Please feel free to restore this if anything is still missing.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"df243fc8b5791fd4d0e9f7ae40c54bae12edaf3e","revisions":{"df243fc8b5791fd4d0e9f7ae40c54bae12edaf3e":{"kind":"REWORK","_number":1,"created":"2020-09-02 00:10:37.000000000","uploader":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"ref":"refs/changes/12/749412/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/12/749412/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/12/749412/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/12/749412/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/12/749412/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/12/749412/1"}}},"commit":{"parents":[{"commit":"77ed82926562c4dc90e6be5d72fe0cbedba73d82","subject":"Do not validate database_connection format","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/77ed82926562c4dc90e6be5d72fe0cbedba73d82"}]}],"author":{"name":"Oliver Walsh","email":"owalsh@redhat.com","date":"2020-09-02 00:07:21.000000000","tz":60},"committer":{"name":"Oliver Walsh","email":"owalsh@redhat.com","date":"2020-09-02 00:10:35.000000000","tz":60},"subject":"Add remove_unused_original_minimum_age_seconds option","message":"Add remove_unused_original_minimum_age_seconds option\n\nThis is useful for controlling how long pre-cached[1] images remain on a compute\nhost.\n\n[1] https://docs.openstack.org/nova/ussuri/admin/image-caching.html#image-pre-caching\n\nChange-Id: Id41e597ef4339cbe39ef3056fc6ed665afc7819d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/df243fc8b5791fd4d0e9f7ae40c54bae12edaf3e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/df243fc8b5791fd4d0e9f7ae40c54bae12edaf3e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}