)]}'
{"manifests/compute/vgpu.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4e94951e05d6ab05a92743e7850207ec160b25ca","unresolved":false,"context_lines":[{"line_number":23,"context_line":") {"},{"line_number":24,"context_line":"  include nova::deps"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  if $enabled_vgpu_types {"},{"line_number":27,"context_line":"    warning(\u0027enabled_vcpu_types is deprecated, instead use enabled_vgpu_types_mapping parameter.\u0027)"},{"line_number":28,"context_line":"  }"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  if !empty($enabled_vgpu_types_mapping) {"},{"line_number":31,"context_line":"    validate_legacy(Hash, \u0027validate_hash\u0027, $enabled_vgpu_types_mapping)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9f560f44_8e1a39c3","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":3},"updated":"2020-09-08 05:49:16.000000000","message":"Can we take care of this parameter during it\u0027s left in deprecated status, instead of making this ignored ?\nPlease refer another patch in which I implement the similar migration.\n\nhttps://review.opendev.org/#/c/750163/6/manifests/compute/libvirt.pp","commit_id":"4d45ee5cc5fe9f009c8e5a49f455ed6a983ec40d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9e57caa2b9ec7f1a806e3b142676bc907e3d567a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        nova_config {"},{"line_number":44,"context_line":"          \"vgpu_${vgpu_type}/device_addresses\": value \u003d\u003e join(any2array($device_addresses), \u0027,\u0027);"},{"line_number":45,"context_line":"        }"},{"line_number":46,"context_line":"      }"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"  } else {"},{"line_number":49,"context_line":"    nova_config {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9f560f44_bcb7eef5","line":46,"updated":"2020-09-15 13:21:20.000000000","message":"Does it make sense to ensure device_addresses parameter is absent when device_addresses is empty ?","commit_id":"fbf77c0776f2aac341dc7a54a6a82243681d6354"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1dd54a190dfd0d48c6f2dd923a91c0530ea4bf71","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        nova_config {"},{"line_number":44,"context_line":"          \"vgpu_${vgpu_type}/device_addresses\": value \u003d\u003e join(any2array($device_addresses), \u0027,\u0027);"},{"line_number":45,"context_line":"        }"},{"line_number":46,"context_line":"      }"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"  } else {"},{"line_number":49,"context_line":"    nova_config {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9f560f44_149cc068","line":46,"in_reply_to":"9f560f44_bcb7eef5","updated":"2020-09-17 14:41:32.000000000","message":"I implemented this in my follow-up commit. I think we can move this forward now and change this behavior in another commit.","commit_id":"fbf77c0776f2aac341dc7a54a6a82243681d6354"}]}