)]}'
{"manifests/compute/vgpu.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5740e3e96b80419ffe715a7d7b32f32562c5ec64","unresolved":false,"context_lines":[{"line_number":23,"context_line":") {"},{"line_number":24,"context_line":"  include nova::deps"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  if $enabled_vgpu_types {"},{"line_number":27,"context_line":"    warning(\u0027enabled_vgpu_types is deprecated, instead use vgpu_types_device_addresses_mapping parameter.\u0027)"},{"line_number":28,"context_line":"  }"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  if $enabled_vgpu_types !\u003d undef and !empty($enabled_vgpu_types) {"},{"line_number":31,"context_line":"    nova_config {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f560f44_efe1bcff","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":3},"updated":"2020-09-29 06:50:42.000000000","message":"IMO we should avoid deprecating parameters in stable branches.\n\nI would suggest you update the logic to show warning saying mapping is ignored when both vgpu_types_device_ddresses_mapping and enabled_vgpu_types are set.","commit_id":"5e3f11251483baa786835fcc3a59082dd4d9a5c6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8a1a5e1bf1342440cd2f11bcf56b690cee1b27b1","unresolved":false,"context_lines":[{"line_number":23,"context_line":") {"},{"line_number":24,"context_line":"  include nova::deps"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  if $enabled_vgpu_types {"},{"line_number":27,"context_line":"    warning(\u0027enabled_vgpu_types is deprecated, instead use vgpu_types_device_addresses_mapping parameter.\u0027)"},{"line_number":28,"context_line":"  }"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  if $enabled_vgpu_types !\u003d undef and !empty($enabled_vgpu_types) {"},{"line_number":31,"context_line":"    nova_config {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f560f44_96d274fc","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":3},"in_reply_to":"9f560f44_6f264c25","updated":"2020-10-06 12:58:23.000000000","message":"it\u0027s not great to deprecate it, but it\u0027s still being configured for backwards compatibility so I think it\u0027s ok to deprecate. We should just not remove it in V and let it continue until W.  The problem with things like the puppet modules is we end up being late to the party for decisions made by the upstream services so sometimes we need to correct the state in the puppet modules after a release.","commit_id":"5e3f11251483baa786835fcc3a59082dd4d9a5c6"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d1febe7bd8ad26178a79d91094bcaf6dcfc45823","unresolved":false,"context_lines":[{"line_number":23,"context_line":") {"},{"line_number":24,"context_line":"  include nova::deps"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  if $enabled_vgpu_types {"},{"line_number":27,"context_line":"    warning(\u0027enabled_vgpu_types is deprecated, instead use vgpu_types_device_addresses_mapping parameter.\u0027)"},{"line_number":28,"context_line":"  }"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  if $enabled_vgpu_types !\u003d undef and !empty($enabled_vgpu_types) {"},{"line_number":31,"context_line":"    nova_config {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f560f44_6f264c25","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":3},"in_reply_to":"9f560f44_efe1bcff","updated":"2020-09-29 07:41:30.000000000","message":"I had backported the original change because the nova dependency is originally merged against ussuri [1], so the parameter to support multiple-gpus is there in nova stable/ussuri. That\u0027s why I wanted to deprecated it in this change.\n\n[1] https://review.opendev.org/#/q/status:merged+topic:bp/vgpu-multiple-types+project:openstack/nova\n\nPlease let me know, if that\u0027s fine, otherwise I will modify the change as per your suggestion.","commit_id":"5e3f11251483baa786835fcc3a59082dd4d9a5c6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ec845fdae0bdad92bc9068f032ce6097f4cabd15","unresolved":false,"context_lines":[{"line_number":23,"context_line":") {"},{"line_number":24,"context_line":"  include nova::deps"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  if $enabled_vgpu_types {"},{"line_number":27,"context_line":"    warning(\u0027enabled_vgpu_types is deprecated, instead use vgpu_types_device_addresses_mapping parameter.\u0027)"},{"line_number":28,"context_line":"  }"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  if $enabled_vgpu_types !\u003d undef and !empty($vgpu_types_device_addresses_mapping) {"},{"line_number":31,"context_line":"    warning(\u0027vgpu_types_device_addresses_mapping is ignored, when both \u0027"},{"line_number":32,"context_line":"    \u0027enabled_vgpu_types and vgpu_types_device_addresses_mapping are defined.\u0027)"},{"line_number":33,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9f560f44_b3de86d8","line":30,"range":{"start_line":26,"start_character":0,"end_line":30,"end_character":84},"updated":"2020-10-08 09:49:18.000000000","message":"For me these 2 messages look conflicting with each other.","commit_id":"7cf6df227a4a81e595260cbaf432495a16ef27ae"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ec845fdae0bdad92bc9068f032ce6097f4cabd15","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  }"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  if $enabled_vgpu_types !\u003d undef and !empty($vgpu_types_device_addresses_mapping) {"},{"line_number":31,"context_line":"    warning(\u0027vgpu_types_device_addresses_mapping is ignored, when both \u0027"},{"line_number":32,"context_line":"    \u0027enabled_vgpu_types and vgpu_types_device_addresses_mapping are defined.\u0027)"},{"line_number":33,"context_line":"  }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  if $enabled_vgpu_types !\u003d undef and !empty($enabled_vgpu_types) {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9f560f44_3399d61d","line":32,"range":{"start_line":31,"start_character":4,"end_line":32,"end_character":77},"updated":"2020-10-08 09:49:18.000000000","message":"Unfortunately you can do this kind of line-split in puppet, and should make this look like;\n\n\n    warning(\u0027vgpu_types_device_addresses_mapping is ignored, when both \\\nenabled_vgpu_types and vgpu_types_device_addresses_mapping are defined.\u0027)","commit_id":"7cf6df227a4a81e595260cbaf432495a16ef27ae"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f1f67b467737cd3aec2cb6993e576acc3ca15807","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  }"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  if $enabled_vgpu_types !\u003d undef and !empty($vgpu_types_device_addresses_mapping) {"},{"line_number":31,"context_line":"    warning(\u0027vgpu_types_device_addresses_mapping is ignored, when both \u0027"},{"line_number":32,"context_line":"    \u0027enabled_vgpu_types and vgpu_types_device_addresses_mapping are defined.\u0027)"},{"line_number":33,"context_line":"  }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  if $enabled_vgpu_types !\u003d undef and !empty($enabled_vgpu_types) {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9f560f44_4eaca134","line":32,"range":{"start_line":31,"start_character":4,"end_line":32,"end_character":77},"in_reply_to":"9f560f44_3399d61d","updated":"2020-10-08 11:14:59.000000000","message":"I meant to say \"you can NOT do this kind of lin-split\" ... sorry :-P","commit_id":"7cf6df227a4a81e595260cbaf432495a16ef27ae"}]}