)]}'
{"manifests/compute.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dc9a00d8ae5cb2102253889e01a8aff0e7886394","unresolved":false,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"  include nova::deps"},{"line_number":330,"context_line":"  include nova::params"},{"line_number":331,"context_line":"  include nova::workarounds"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"  $cpu_shared_set_real \u003d pick(join(any2array($cpu_shared_set), \u0027,\u0027), $::os_service_default)"},{"line_number":334,"context_line":"  $cpu_dedicated_set_real \u003d pick(join(any2array($cpu_dedicated_set), \u0027,\u0027), $::os_service_default)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f65232a_8cef6d86","line":331,"range":{"start_line":331,"start_character":2,"end_line":331,"end_character":27},"updated":"2020-10-21 23:43:33.000000000","message":"Because the workaround section is something general, I think it\u0027s better to add this to more common place like manifests/init.pp ?","commit_id":"df84b89693abd82f730bd38447588ce36a1ccf18"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2bccdf4b0cc1ebff5ecd975369d0841f75667c4c","unresolved":false,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"  include nova::deps"},{"line_number":330,"context_line":"  include nova::params"},{"line_number":331,"context_line":"  include nova::workarounds"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"  $cpu_shared_set_real \u003d pick(join(any2array($cpu_shared_set), \u0027,\u0027), $::os_service_default)"},{"line_number":334,"context_line":"  $cpu_dedicated_set_real \u003d pick(join(any2array($cpu_dedicated_set), \u0027,\u0027), $::os_service_default)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f65232a_be67dd25","line":331,"range":{"start_line":331,"start_character":2,"end_line":331,"end_character":27},"in_reply_to":"3f65232a_1b0f03e2","updated":"2020-10-22 23:09:27.000000000","message":"That sounds good. Thanks.","commit_id":"df84b89693abd82f730bd38447588ce36a1ccf18"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"2c3c7fa7dd2f84821a6c94e67c3f3e9191ca7748","unresolved":false,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"  include nova::deps"},{"line_number":330,"context_line":"  include nova::params"},{"line_number":331,"context_line":"  include nova::workarounds"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"  $cpu_shared_set_real \u003d pick(join(any2array($cpu_shared_set), \u0027,\u0027), $::os_service_default)"},{"line_number":334,"context_line":"  $cpu_dedicated_set_real \u003d pick(join(any2array($cpu_dedicated_set), \u0027,\u0027), $::os_service_default)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f65232a_1b0f03e2","line":331,"range":{"start_line":331,"start_character":2,"end_line":331,"end_character":27},"in_reply_to":"3f65232a_1ba54305","updated":"2020-10-22 20:34:57.000000000","message":"https://review.opendev.org/759321","commit_id":"df84b89693abd82f730bd38447588ce36a1ccf18"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"ec6988b2929b79e982850359ea3673ec6e83bfff","unresolved":false,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"  include nova::deps"},{"line_number":330,"context_line":"  include nova::params"},{"line_number":331,"context_line":"  include nova::workarounds"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"  $cpu_shared_set_real \u003d pick(join(any2array($cpu_shared_set), \u0027,\u0027), $::os_service_default)"},{"line_number":334,"context_line":"  $cpu_dedicated_set_real \u003d pick(join(any2array($cpu_dedicated_set), \u0027,\u0027), $::os_service_default)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f65232a_1ba54305","line":331,"range":{"start_line":331,"start_character":2,"end_line":331,"end_character":27},"in_reply_to":"3f65232a_8cef6d86","updated":"2020-10-22 20:19:41.000000000","message":"agreed, but I think that belongs in a follow-up patch.","commit_id":"df84b89693abd82f730bd38447588ce36a1ccf18"}],"manifests/workarounds.pp":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"96f1885f34d744163407585ec9e4788982801ec4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"class nova::workarounds ("},{"line_number":19,"context_line":"  $never_download_image_if_on_rbd \u003d $::os_service_default,"},{"line_number":20,"context_line":"  # DEPRECATED PARAMETER"},{"line_number":21,"context_line":"  $enable_numa_live_migration     \u003d undef,"},{"line_number":22,"context_line":") {"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  if $enable_numa_live_migration !\u003d undef {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f65232a_13287f32","line":21,"range":{"start_line":21,"start_character":30,"end_line":21,"end_character":33},"updated":"2020-10-23 14:00:12.000000000","message":"seems unrelated","commit_id":"9f260451977b850ba3b4375434512c227b2749f0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a7c854d3016131455604d1e0943f2c54bd1327d3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"class nova::workarounds ("},{"line_number":19,"context_line":"  $never_download_image_if_on_rbd \u003d $::os_service_default,"},{"line_number":20,"context_line":"  # DEPRECATED PARAMETER"},{"line_number":21,"context_line":"  $enable_numa_live_migration     \u003d undef,"},{"line_number":22,"context_line":") {"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  if $enable_numa_live_migration !\u003d undef {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f65232a_2e1ef40b","line":21,"range":{"start_line":21,"start_character":30,"end_line":21,"end_character":33},"in_reply_to":"3f65232a_13287f32","updated":"2020-10-23 14:59:02.000000000","message":"FYI. We usually prefer to insert/remove spaces for existing parameters to align \u003d or \u003d\u003e in puppet manifests.","commit_id":"9f260451977b850ba3b4375434512c227b2749f0"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"74ba500587a4c460a3625991a80ef216b4b1a244","unresolved":false,"context_lines":[{"line_number":18,"context_line":"class nova::workarounds ("},{"line_number":19,"context_line":"  $never_download_image_if_on_rbd \u003d $::os_service_default,"},{"line_number":20,"context_line":"  # DEPRECATED PARAMETER"},{"line_number":21,"context_line":"  $enable_numa_live_migration     \u003d undef,"},{"line_number":22,"context_line":") {"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  if $enable_numa_live_migration !\u003d undef {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f65232a_64d76bef","line":21,"range":{"start_line":21,"start_character":30,"end_line":21,"end_character":33},"in_reply_to":"3f65232a_2e1ef40b","updated":"2020-10-23 16:35:52.000000000","message":"although backports are horrendous because of this","commit_id":"9f260451977b850ba3b4375434512c227b2749f0"}],"spec/classes/nova_workarounds_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dc9a00d8ae5cb2102253889e01a8aff0e7886394","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    context \u0027with default parameters\u0027 do"},{"line_number":12,"context_line":"      it { is_expected.not_to contain_nova_config(\u0027workarounds/enable_numa_live_migration\u0027) }"},{"line_number":13,"context_line":"      it {"},{"line_number":14,"context_line":"        is_expected.to contain_nova_config("},{"line_number":15,"context_line":"          \u0027workarounds/never_download_image_if_on_rbd\u0027"},{"line_number":16,"context_line":"        ).with_value("},{"line_number":17,"context_line":"          \u0027\u003cSERVICE DEFAULT\u003e\u0027"},{"line_number":18,"context_line":"        )"},{"line_number":19,"context_line":"      }"},{"line_number":20,"context_line":"    end"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    context \u0027with overridden parameters\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3f65232a_0c551d51","line":19,"range":{"start_line":13,"start_character":0,"end_line":19,"end_character":7},"updated":"2020-10-21 23:43:33.000000000","message":"Please pack this into one line as we do for most of the test cases.","commit_id":"df84b89693abd82f730bd38447588ce36a1ccf18"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"ec6988b2929b79e982850359ea3673ec6e83bfff","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    context \u0027with default parameters\u0027 do"},{"line_number":12,"context_line":"      it { is_expected.not_to contain_nova_config(\u0027workarounds/enable_numa_live_migration\u0027) }"},{"line_number":13,"context_line":"      it {"},{"line_number":14,"context_line":"        is_expected.to contain_nova_config("},{"line_number":15,"context_line":"          \u0027workarounds/never_download_image_if_on_rbd\u0027"},{"line_number":16,"context_line":"        ).with_value("},{"line_number":17,"context_line":"          \u0027\u003cSERVICE DEFAULT\u003e\u0027"},{"line_number":18,"context_line":"        )"},{"line_number":19,"context_line":"      }"},{"line_number":20,"context_line":"    end"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    context \u0027with overridden parameters\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3f65232a_bb888f71","line":19,"range":{"start_line":13,"start_character":0,"end_line":19,"end_character":7},"in_reply_to":"3f65232a_0c551d51","updated":"2020-10-22 20:19:41.000000000","message":"I\u0027ve been writing a lot of python I guess :-)","commit_id":"df84b89693abd82f730bd38447588ce36a1ccf18"}]}