)]}'
{"manifests/db.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5f078523f98cf904a96d5f107c9e1139f25d9ed2","unresolved":false,"context_lines":[{"line_number":134,"context_line":"      config_group            \u003d\u003e \u0027api_database\u0027,"},{"line_number":135,"context_line":"      connection              \u003d\u003e $api_database_connection_real,"},{"line_number":136,"context_line":"      slave_connection        \u003d\u003e $api_slave_connection_real,"},{"line_number":137,"context_line":"      connection_recycle_time \u003d\u003e $database_connection_recycle_time_real,"},{"line_number":138,"context_line":"      # Package management should be disabled here to avoid conflict."},{"line_number":139,"context_line":"      manage_backend_package  \u003d\u003e false"},{"line_number":140,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1f621f24_6bbc77bb","line":137,"range":{"start_line":137,"start_character":34,"end_line":137,"end_character":71},"updated":"2020-10-29 06:04:38.000000000","message":"Since the parmaters for db and api db are separated, I think it\u0027s better to use the seprated parameter.\n\nAlso, could you implement some more missing parameters like\n max_pool_size\n max_retries\n retry_interval\n max_overflow\n pool_timeout\nin this patch at the same time ?","commit_id":"d6bafcfc456999e688f742c2568c98b127465d24"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3ae22742d30e7844c71e93c2f9962a65c25ebc71","unresolved":false,"context_lines":[{"line_number":87,"context_line":"#   (Optional) If set, use this value for pool_timeout with SQLAlchemy."},{"line_number":88,"context_line":"#   Defaults to $::os_service_default"},{"line_number":89,"context_line":"#"},{"line_number":90,"context_line":"# [*database_db_max_retries*]"},{"line_number":91,"context_line":"#   (optional) Maximum retries in case of connection error or deadlock error"},{"line_number":92,"context_line":"#   before error is raised. Set to -1 to specify an infinite retry count."},{"line_number":93,"context_line":"#   Defaults to $::os_service_default"},{"line_number":94,"context_line":"#"},{"line_number":95,"context_line":"# [*mysql_enable_ndb*]"},{"line_number":96,"context_line":"#   (Optional) If True, transparently enables support for handling MySQL"},{"line_number":97,"context_line":"#   Cluster (NDB)."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f621f24_1919d978","line":94,"range":{"start_line":90,"start_character":0,"end_line":94,"end_character":1},"updated":"2020-10-29 09:15:58.000000000","message":"Please move this to upper part since this is for database section, not for api_database section.","commit_id":"2716a0dee51fc9bdb6e9b36db03dcda2097c26a4"}],"spec/classes/nova_api_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3ae22742d30e7844c71e93c2f9962a65c25ebc71","unresolved":false,"context_lines":[{"line_number":198,"context_line":"           api_database_connection              \u003d\u003e \u0027mysql://user:pass@db/db2\u0027,"},{"line_number":199,"context_line":"           api_slave_connection                 \u003d\u003e \u0027mysql://user:pass@slave/db2\u0027,"},{"line_number":200,"context_line":"           database_connection_recycle_time     \u003d\u003e \u002730\u0027,"},{"line_number":201,"context_line":"           api_database_connection_recycle_time \u003d\u003e \u002760\u0027,"},{"line_number":202,"context_line":"         }"},{"line_number":203,"context_line":"         class { \u0027nova::keystone::authtoken\u0027:"},{"line_number":204,"context_line":"           password \u003d\u003e \u0027passw0rd\u0027,"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1f621f24_995b292d","line":201,"range":{"start_line":201,"start_character":11,"end_line":201,"end_character":56},"updated":"2020-10-29 09:15:58.000000000","message":"IMO this (nova_api_spec.rb) is not the right place to test the behavior of nova::db class in detail. So I prefer not adding this test case to this file.","commit_id":"2716a0dee51fc9bdb6e9b36db03dcda2097c26a4"}],"spec/classes/nova_db_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5f078523f98cf904a96d5f107c9e1139f25d9ed2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        :connection              \u003d\u003e \u0027mysql+pymysql://user:pass@db/db1\u0027,"},{"line_number":38,"context_line":"        :slave_connection        \u003d\u003e \u0027mysql+pymysql://user:pass@slave/db1\u0027,"},{"line_number":39,"context_line":"        :db_max_retries          \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":40,"context_line":"        :connection_recycle_time \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":41,"context_line":"        :max_pool_size           \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":42,"context_line":"        :max_retries             \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":43,"context_line":"        :retry_interval          \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1f621f24_abb68fd8","line":40,"range":{"start_line":40,"start_character":37,"end_line":40,"end_character":54},"updated":"2020-10-29 06:04:38.000000000","message":"This needs to be updated to fix the current failure in unit tests.","commit_id":"d6bafcfc456999e688f742c2568c98b127465d24"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3ae22742d30e7844c71e93c2f9962a65c25ebc71","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  shared_examples \u0027nova::db\u0027 do"},{"line_number":9,"context_line":"    context \u0027with default parameters\u0027 do"},{"line_number":10,"context_line":"      it { should_not contain_nova_config(\u0027database/connection\u0027) }"},{"line_number":11,"context_line":"      it { should_not contain_nova_config(\u0027database/slave_connection\u0027) }"},{"line_number":12,"context_line":"      it { should_not contain_nova_config(\u0027database/connection_recycle_time\u0027) }"},{"line_number":13,"context_line":"      it { should_not contain_nova_config(\u0027database/max_pool_size\u0027) }"},{"line_number":14,"context_line":"      it { should_not contain_nova_config(\u0027database/max_retries\u0027) }"},{"line_number":15,"context_line":"      it { should_not contain_nova_config(\u0027database/retry_interval\u0027) }"},{"line_number":16,"context_line":"      it { should_not contain_nova_config(\u0027database/max_overflow\u0027) }"},{"line_number":17,"context_line":"      it { should_not contain_nova_config(\u0027database/pool_timeout\u0027) }"},{"line_number":18,"context_line":"      it { should_not contain_nova_config(\u0027api_database/connection\u0027) }"},{"line_number":19,"context_line":"      it { should_not contain_nova_config(\u0027api_database/slave_connection\u0027) }"},{"line_number":20,"context_line":"      it { should_not contain_nova_config(\u0027api_database/connection_recycle_time\u0027) }"},{"line_number":21,"context_line":"      it { should_not contain_nova_config(\u0027api_database/max_pool_size\u0027) }"},{"line_number":22,"context_line":"      it { should_not contain_nova_config(\u0027api_database/max_retries\u0027) }"},{"line_number":23,"context_line":"      it { should_not contain_nova_config(\u0027api_database/retry_interval\u0027) }"},{"line_number":24,"context_line":"      it { should_not contain_nova_config(\u0027api_database/max_overflow\u0027) }"},{"line_number":25,"context_line":"      it { should_not contain_nova_config(\u0027api_database/pool_timeout\u0027) }"},{"line_number":26,"context_line":"      it { should_not contain_nova_config(\u0027database/db_max_retries\u0027) }"},{"line_number":27,"context_line":"      it { should_not contain_nova_config(\u0027database/mysql_enable_ndb\u0027) }"},{"line_number":28,"context_line":"    end"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    context \u0027with overridden parameters\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1f621f24_f9adfdea","line":27,"range":{"start_line":10,"start_character":0,"end_line":27,"end_character":72},"updated":"2020-10-29 09:15:58.000000000","message":"I think we can just simplify these test cases like the following example.\n\n~~~\n    it { should_not contain_oslo__db(\u0027nova_config\u0027) }\n    it { should_not contain_oslo__db(\u0027api_database\u0027) }\n~~~\n\nIt\u0027s better to test the implementation of oslo::db here since it makes it difficult to update oslo::db (because the change in oslo::db can break unit tests for puppet-nova).","commit_id":"2716a0dee51fc9bdb6e9b36db03dcda2097c26a4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3ae22742d30e7844c71e93c2f9962a65c25ebc71","unresolved":false,"context_lines":[{"line_number":46,"context_line":"      it { should contain_oslo__db(\u0027nova_config\u0027).with("},{"line_number":47,"context_line":"        :connection              \u003d\u003e \u0027mysql+pymysql://user:pass@db/db1\u0027,"},{"line_number":48,"context_line":"        :slave_connection        \u003d\u003e \u0027mysql+pymysql://user:pass@slave/db1\u0027,"},{"line_number":49,"context_line":"        :db_max_retries          \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":50,"context_line":"        :connection_recycle_time \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":51,"context_line":"        :max_pool_size           \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":52,"context_line":"        :max_retries             \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":53,"context_line":"        :retry_interval          \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":54,"context_line":"        :max_overflow            \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":55,"context_line":"        :pool_timeout            \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":56,"context_line":"        :mysql_enable_ndb        \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":57,"context_line":"      )}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"      it { should contain_oslo__db(\u0027api_database\u0027).with("}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1f621f24_b908a528","line":56,"range":{"start_line":49,"start_character":0,"end_line":56,"end_character":56},"updated":"2020-10-29 09:15:58.000000000","message":"I know this is not scope of this change but could you please set overridden parameters for these items ?","commit_id":"2716a0dee51fc9bdb6e9b36db03dcda2097c26a4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"15de2a192911013967697197bfb2e4be649a9037","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  shared_examples \u0027nova::db\u0027 do"},{"line_number":9,"context_line":"    context \u0027with default parameters\u0027 do"},{"line_number":10,"context_line":"      it { should_not contain_oslo__db(\u0027nova_config\u0027).with("},{"line_number":11,"context_line":"        :connection              \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":12,"context_line":"        :slave_connection        \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":13,"context_line":"        :db_max_retries          \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":14,"context_line":"        :connection_recycle_time \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":15,"context_line":"        :max_pool_size           \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":16,"context_line":"        :max_retries             \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":17,"context_line":"        :retry_interval          \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":18,"context_line":"        :max_overflow            \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":19,"context_line":"        :pool_timeout            \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":20,"context_line":"        :mysql_enable_ndb        \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":21,"context_line":"      )}"},{"line_number":22,"context_line":"      it { should_not contain_oslo__db(\u0027api_database\u0027).with("},{"line_number":23,"context_line":"        :connection              \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":24,"context_line":"        :slave_connection        \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1f621f24_51c20535","line":21,"range":{"start_line":10,"start_character":54,"end_line":21,"end_character":8},"updated":"2020-10-29 14:02:13.000000000","message":"We don\u0027t need this part and it\u0027s enough(and better) to assert that the resource is not contained.","commit_id":"5dbddba0171e76b01e5ad965a11f222cac80aec9"}],"spec/classes/nova_metadata_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3ae22742d30e7844c71e93c2f9962a65c25ebc71","unresolved":false,"context_lines":[{"line_number":74,"context_line":"           api_database_connection              \u003d\u003e \u0027mysql://user:pass@db/db2\u0027,"},{"line_number":75,"context_line":"           api_slave_connection                 \u003d\u003e \u0027mysql://user:pass@slave/db2\u0027,"},{"line_number":76,"context_line":"           database_connection_recycle_time     \u003d\u003e \u002730\u0027,"},{"line_number":77,"context_line":"           api_database_connection_recycle_time \u003d\u003e \u002760\u0027,"},{"line_number":78,"context_line":"         }"},{"line_number":79,"context_line":"         class { \u0027nova::keystone::authtoken\u0027:"},{"line_number":80,"context_line":"           password \u003d\u003e \u0027passw0rd\u0027,"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1f621f24_39b81529","line":77,"range":{"start_line":77,"start_character":11,"end_line":77,"end_character":56},"updated":"2020-10-29 09:15:58.000000000","message":"ditto. please do not add parameter assertion here.","commit_id":"2716a0dee51fc9bdb6e9b36db03dcda2097c26a4"}]}