)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c141bfefe8a2f5e41c173f5320635215933472cd","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This should never have been merged."},{"line_number":10,"context_line":"It removed more than the deprecated param, breaking the pci config on"},{"line_number":11,"context_line":"computes."},{"line_number":12,"context_line":"Also should have warned for at least 1 cycle before removal."},{"line_number":13,"context_line":"It also wasn\u0027t removed correctly as the pick remained in nova::compute::pci"},{"line_number":14,"context_line":"so (IIUC) the deprecated param still works today if set in hieradata."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7c028252_b4be2633","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":60},"updated":"2020-11-27 02:24:51.000000000","message":"I\u0027m confused with this.\n\nThe parameter was deprecated by https://github.com/openstack/puppet-nova/commit/c1a4ab211dd2322572349719379cd13c6f2abb9a and we had more than one cycle until we remove it.","commit_id":"e7f323a1f4fb37c5a8a70a123f08fc5e1e5a7843"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"e6b0c57ecd6510d85d7c02b20c7daf414cbd303a","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This should never have been merged."},{"line_number":10,"context_line":"It removed more than the deprecated param, breaking the pci config on"},{"line_number":11,"context_line":"computes."},{"line_number":12,"context_line":"Also should have warned for at least 1 cycle before removal."},{"line_number":13,"context_line":"It also wasn\u0027t removed correctly as the pick remained in nova::compute::pci"},{"line_number":14,"context_line":"so (IIUC) the deprecated param still works today if set in hieradata."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba56c716_f3652953","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":60},"in_reply_to":"7c028252_b4be2633","updated":"2020-12-01 16:43:45.000000000","message":"Both patches landed in queens:\nDeprecated on Sept 6 2017 https://review.opendev.org/c/openstack/puppet-nova/+/476327\nRemoved on Oct 9 2017  https://review.opendev.org/c/openstack/puppet-nova/+/510151","commit_id":"e7f323a1f4fb37c5a8a70a123f08fc5e1e5a7843"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6884aba7574c6829a9b4c174575c3bd9fa7cfd90","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This should never have been merged."},{"line_number":10,"context_line":"It removed more than the deprecated param, breaking the pci config on"},{"line_number":11,"context_line":"computes."},{"line_number":12,"context_line":"Also should have warned for at least 1 cycle before removal."},{"line_number":13,"context_line":"It also wasn\u0027t removed correctly as the pick remained in nova::compute::pci"},{"line_number":14,"context_line":"so (IIUC) the deprecated param still works today if set in hieradata."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c85ef8cb_c5beb04a","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":60},"in_reply_to":"ba56c716_f3652953","updated":"2020-12-01 23:08:14.000000000","message":"I now understand that we backported this patch to stable/pike [1], and this is why the deprecation steps \"look\" correct to me.\n\n\n[1] https://github.com/openstack/puppet-nova/commit/16e88fcf02adc9a4de3631c96cdc02ec4e80d6c7","commit_id":"e7f323a1f4fb37c5a8a70a123f08fc5e1e5a7843"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"5e1156dec09456dce4d2ec69cd34ff8d3c88dbbc","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This should never have been merged."},{"line_number":10,"context_line":"It removed more than the deprecated param, breaking the pci config on"},{"line_number":11,"context_line":"computes."},{"line_number":12,"context_line":"Also should have warned for at least 1 cycle before removal."},{"line_number":13,"context_line":"It also wasn\u0027t removed correctly as the pick remained in nova::compute::pci"},{"line_number":14,"context_line":"so (IIUC) the deprecated param still works today if set in hieradata."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"8c9f21fc_8aea6d79","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":60},"in_reply_to":"c85ef8cb_c5beb04a","updated":"2020-12-02 11:44:08.000000000","message":"ack, confused me too at first","commit_id":"e7f323a1f4fb37c5a8a70a123f08fc5e1e5a7843"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"e6b0c57ecd6510d85d7c02b20c7daf414cbd303a","unresolved":true,"context_lines":[{"line_number":11,"context_line":"computes."},{"line_number":12,"context_line":"Also should have warned for at least 1 cycle before removal."},{"line_number":13,"context_line":"It also wasn\u0027t removed correctly as the pick remained in nova::compute::pci"},{"line_number":14,"context_line":"so (IIUC) the deprecated param still works today if set in hieradata."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This reverts commit d845b6f0aefaaab0b65b32cd22ccda8c2c8ee6ae."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4d5a469c_3f8425eb","line":14,"range":{"start_line":14,"start_character":10,"end_line":14,"end_character":68},"updated":"2020-12-01 16:43:45.000000000","message":"i.e on current master: https://opendev.org/openstack/puppet-nova/src/commit/18be6c394e073d3bd90d2a58defb51ae9812e305/manifests/compute/pci.pp#L19","commit_id":"e7f323a1f4fb37c5a8a70a123f08fc5e1e5a7843"}],"manifests/compute.pp":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"f4e6e1253192f060a9a7958cff60a8113329dddc","unresolved":true,"context_lines":[{"line_number":373,"context_line":"    # Note: also remove the pick from nova::compute::pci"},{"line_number":374,"context_line":"    warning(\u0027The pci_passthrough parameter is deprecated and will be removed in X. Please use nova::compute::pci::passthrough instead.\u0027)"},{"line_number":375,"context_line":"  }"},{"line_number":376,"context_line":"  include ::nova::compute::pci"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"  include nova::compute::vgpu"},{"line_number":379,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"c8260b22_afc0e030","line":376,"range":{"start_line":376,"start_character":10,"end_line":376,"end_character":12},"updated":"2020-11-26 16:35:52.000000000","message":"linter doesn\u0027t like this nowadays","commit_id":"9d8ece6ce668c972ec46e2858970b4fb1624aecc"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c141bfefe8a2f5e41c173f5320635215933472cd","unresolved":true,"context_lines":[{"line_number":373,"context_line":"    # Note: also remove the pick from nova::compute::pci"},{"line_number":374,"context_line":"    warning(\u0027The pci_passthrough parameter is deprecated and will be removed in X. Please use nova::compute::pci::passthrough instead.\u0027)"},{"line_number":375,"context_line":"  }"},{"line_number":376,"context_line":"  include nova::compute::pci"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"  include nova::compute::vgpu"},{"line_number":379,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"60c08156_64c40034","line":376,"range":{"start_line":376,"start_character":2,"end_line":376,"end_character":28},"updated":"2020-11-27 02:24:51.000000000","message":"Historically this include was added to keep compatibility even if nova::compute::pci is not included, so I guess we removed this when we remove the deprecated parameter because we expect users added explicit class definition in their manifests at that time.\n\nHowever regarding the fact the we already have include nova::pci I\u0027d agree to keep this.","commit_id":"e7f323a1f4fb37c5a8a70a123f08fc5e1e5a7843"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"e6b0c57ecd6510d85d7c02b20c7daf414cbd303a","unresolved":true,"context_lines":[{"line_number":373,"context_line":"    # Note: also remove the pick from nova::compute::pci"},{"line_number":374,"context_line":"    warning(\u0027The pci_passthrough parameter is deprecated and will be removed in X. Please use nova::compute::pci::passthrough instead.\u0027)"},{"line_number":375,"context_line":"  }"},{"line_number":376,"context_line":"  include nova::compute::pci"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"  include nova::compute::vgpu"},{"line_number":379,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"de20cc52_85d5a57b","line":376,"range":{"start_line":376,"start_character":2,"end_line":376,"end_character":28},"in_reply_to":"60c08156_64c40034","updated":"2020-12-01 16:43:45.000000000","message":"I added this include. The intention was to namespace the compute specific pci params.","commit_id":"e7f323a1f4fb37c5a8a70a123f08fc5e1e5a7843"}],"spec/classes/nova_compute_spec.rb":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"f4e6e1253192f060a9a7958cff60a8113329dddc","unresolved":true,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    context \u0027when vcpu_pin_set and pci params are empty\u0027 do"},{"line_number":260,"context_line":"      let :params do"},{"line_number":261,"context_line":"        { :pci_passthrough \u003d\u003e \"\"}"},{"line_number":262,"context_line":"      it \u0027clears pci_passthrough configuration\u0027 do"},{"line_number":263,"context_line":"        is_expected.to contain_class(\u0027nova::compute::pci\u0027)"},{"line_number":264,"context_line":"        is_expected.to contain_nova_config(\u0027pci/passthrough_whitelist\u0027).with(:value \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3b59395e_1aca5a02","line":261,"updated":"2020-11-26 16:35:52.000000000","message":"missing end","commit_id":"9d8ece6ce668c972ec46e2858970b4fb1624aecc"}]}