)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bfef6f2574f7168e50a845802d65d5632e61784c","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The puppet pick function returns the first value that is not undefined or an"},{"line_number":10,"context_line":"empty string."},{"line_number":11,"context_line":"An empty string is a valid value for dhcp_domain so we cannot use pick() to"},{"line_number":12,"context_line":" choose between the current/deprecated param."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-bug: #1905418"},{"line_number":15,"context_line":"Change-Id: I98fe83e0c245388944529cd19b5e2bbed134e855"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7987b677_7b4d7511","line":12,"range":{"start_line":11,"start_character":1,"end_line":12,"end_character":45},"updated":"2020-12-02 15:28:42.000000000","message":"sorry i misread this\ni tought you said its not a valid value.","commit_id":"b8f5f1fcacd147a029a7e5fc0882927b5d5517b9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0d3ff3b92fe8b44914de73a73282dcb83795bf15","unresolved":true,"context_lines":[{"line_number":11,"context_line":"An empty string is a valid value for dhcp_domain so we cannot use pick() to"},{"line_number":12,"context_line":" choose between the current/deprecated param."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-bug: #1905418"},{"line_number":15,"context_line":"Change-Id: I98fe83e0c245388944529cd19b5e2bbed134e855"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b89554e3_dc380673","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":20},"updated":"2020-12-02 14:30:49.000000000","message":"the behavior of this bug imples when pick selected \"\"\npuppet-nova did not render it as \u0027 dhcp_domain\u003d\"\" \u0027 but instead rendered it as \u0027 dhcp_domain\u003d \u0027\nthose are not equivelent and will have different behaviors.\n\n\u0027 dhcp_domain\u003d \u0027 is the same as unset which means the options default of novalocal takes effect.\n\n\u0027 dhcp_domain\u003d\"\" \u0027 sets the domain in nova code to \"\" so when we append it to the hostname its unchanged.\n\nsince we are seing overcloud-novacompute-0.novalocal  not overcloud-novacompute-0 in the bug error output\nit means that puppet nova is not correctly rendering the empty string.\n\nthe empty string is a valid value for dhcp_domain and shoudl be supprted by puppet-nova.\nits used when you want to disable nova adding a suffix to the hostnames","commit_id":"b8f5f1fcacd147a029a7e5fc0882927b5d5517b9"}]}