)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ed0b03db76dba19959e5f3c97e3d7b100db8bf2e","unresolved":true,"context_lines":[{"line_number":10,"context_line":"consistency, we need to change this here as well. Another change in THT"},{"line_number":11,"context_line":"will follow this one."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I0e425e247be1e3ad7004a5667a0887949a2a031c"},{"line_number":14,"context_line":"Change-Id: I110f612f1b78899e8969da607e6b400e2e64c8a1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1c828e34_9d27d58a","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":53},"updated":"2020-12-03 14:54:23.000000000","message":"You are creating circular dependencies which doesn\u0027t work.\nIf we keep the old parameter but deprecate it, you don\u0027t need to make this depend on tht patch.","commit_id":"2691883b71c7aad91100474e3e33a1835e51ecde"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"2b4714cffdaf2687921eb7c38440963e08e99437","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     David Vallee Delisle \u003cdvd@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-12-03 22:04:16 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removing scheduler_default_filters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This setting was renamed enabled_filters a while back. For the sake of"},{"line_number":10,"context_line":"consistency, we need to change this here as well. Another change in THT"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3bd28618_ed88095f","line":7,"updated":"2020-12-04 09:08:25.000000000","message":"Maybe rename it to \u0027Deprecate\u0027 instead of remove","commit_id":"5d3b113dab65b84998af1bc60babec37e6db4d3b"}],"manifests/scheduler/filter.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ed0b03db76dba19959e5f3c97e3d7b100db8bf2e","unresolved":true,"context_lines":[{"line_number":29,"context_line":"#   Example: [\u0027first.filter.class\u0027, \u0027second.filter.class\u0027]"},{"line_number":30,"context_line":"#   Defaults to [\u0027nova.scheduler.filters.all_filters\u0027]"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*scheduler_enabled_filters*]"},{"line_number":33,"context_line":"#   (optional) An array of filters to be used by default"},{"line_number":34,"context_line":"#   Defaults to $::os_service_default"},{"line_number":35,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1fe446f5_6ef296ad","line":32,"range":{"start_line":32,"start_character":4,"end_line":32,"end_character":29},"updated":"2020-12-03 14:54:23.000000000","message":"I agree to rename the parameter, but we should keep the compatibility about the old parameter.\nPlease deprecate the old parameter name and add logic to pick the deprecated one when it is used.","commit_id":"2691883b71c7aad91100474e3e33a1835e51ecde"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9b17dc50410cee1e2410e56482196b838e5d54bb","unresolved":true,"context_lines":[{"line_number":164,"context_line":"  # - if set, we\u0027ll validate it\u0027s an array that is not empty and configure the parameter."},{"line_number":165,"context_line":"  # - Otherwise, fallback to default."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"  $scheduler_enabled_filters_new \u003d pick($::nova::scheduler::filter::scheduler_default_filters, $scheduler_enabled_filters)"},{"line_number":168,"context_line":"  if !is_service_default($scheduler_enabled_filters_new) and !empty($scheduler_enabled_filters_new){"},{"line_number":169,"context_line":"    validate_legacy(Array, \u0027validate_array\u0027, $scheduler_enabled_filters_new)"},{"line_number":170,"context_line":"    $scheduler_enabled_filters_real \u003d join($scheduler_enabled_filters_new, \u0027,\u0027)"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5bd4a791_d8f64286","line":167,"range":{"start_line":167,"start_character":3,"end_line":167,"end_character":32},"updated":"2020-12-04 09:09:29.000000000","message":"How about scheduler_enabled_filters_raw ?","commit_id":"5d3b113dab65b84998af1bc60babec37e6db4d3b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9b17dc50410cee1e2410e56482196b838e5d54bb","unresolved":true,"context_lines":[{"line_number":164,"context_line":"  # - if set, we\u0027ll validate it\u0027s an array that is not empty and configure the parameter."},{"line_number":165,"context_line":"  # - Otherwise, fallback to default."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"  $scheduler_enabled_filters_new \u003d pick($::nova::scheduler::filter::scheduler_default_filters, $scheduler_enabled_filters)"},{"line_number":168,"context_line":"  if !is_service_default($scheduler_enabled_filters_new) and !empty($scheduler_enabled_filters_new){"},{"line_number":169,"context_line":"    validate_legacy(Array, \u0027validate_array\u0027, $scheduler_enabled_filters_new)"},{"line_number":170,"context_line":"    $scheduler_enabled_filters_real \u003d join($scheduler_enabled_filters_new, \u0027,\u0027)"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"c5ae8669_f976a442","line":167,"range":{"start_line":167,"start_character":40,"end_line":167,"end_character":93},"updated":"2020-12-04 09:09:29.000000000","message":"You can use $scheduler_default_filters because the parameter is defined in this class.","commit_id":"5d3b113dab65b84998af1bc60babec37e6db4d3b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fff33c67c8612ab58064cdd5f49cec1ea116233d","unresolved":true,"context_lines":[{"line_number":112,"context_line":"#   (optional) An array of filters to be used by default"},{"line_number":113,"context_line":"#   Defaults to $::os_service_default"},{"line_number":114,"context_line":"#"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"class nova::scheduler::filter ("},{"line_number":117,"context_line":"  $scheduler_host_subset_size                     \u003d \u00271\u0027,"},{"line_number":118,"context_line":"  $max_io_ops_per_host                            \u003d \u00278\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"18e4139d_58325df3","line":115,"updated":"2020-12-08 23:54:46.000000000","message":"(nit) This blank line can be removed.","commit_id":"490a34a7b2b2ef3038123b3e88672846ed64c7da"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fff33c67c8612ab58064cdd5f49cec1ea116233d","unresolved":true,"context_lines":[{"line_number":158,"context_line":"will be removed in a future release. Use the nova::scheduler::schedumer_enabled_filters parameter instead.\u0027)"},{"line_number":159,"context_line":"  }"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"  # The following values are following this rule:"},{"line_number":163,"context_line":"  # - default is $::os_service_default so Puppet won\u0027t try to configure it."},{"line_number":164,"context_line":"  # - if set, we\u0027ll validate it\u0027s an array that is not empty and configure the parameter."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"eecc35c9_1513b499","line":161,"updated":"2020-12-08 23:54:46.000000000","message":"ditto","commit_id":"490a34a7b2b2ef3038123b3e88672846ed64c7da"}]}