)]}'
{"manifests/logging.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ed7669dd8bd03e92e711f586d264df52ce165ffb","unresolved":true,"context_lines":[{"line_number":121,"context_line":"  $instance_format               \u003d $::os_service_default,"},{"line_number":122,"context_line":"  $instance_uuid_format          \u003d $::os_service_default,"},{"line_number":123,"context_line":"  $log_date_format               \u003d $::os_service_default,"},{"line_number":124,"context_line":"  $os_brick_log_level            \u003d \u0027DEBUG\u0027,"},{"line_number":125,"context_line":") {"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  include nova::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"a6d285d6_508b4f86","line":124,"range":{"start_line":124,"start_character":36,"end_line":124,"end_character":41},"updated":"2020-12-14 10:48:02.000000000","message":"I agree that DEBUG log of os-brick is useful to troubleshooting as per my experience, I still have some doubt about enabling debug by default. If this is really required in any deployments then we should change the default in nova/cinder/os-brick, IMHO.","commit_id":"576bf9115249c7870217f4ab9ee56c8e3916e765"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ed7669dd8bd03e92e711f586d264df52ce165ffb","unresolved":true,"context_lines":[{"line_number":137,"context_line":"    }"},{"line_number":138,"context_line":"  }"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  if $log_config_append {"},{"line_number":141,"context_line":"    file { $log_config_append:"},{"line_number":142,"context_line":"      content \u003d\u003e template(\u0027nova/logging.conf.erb\u0027),"},{"line_number":143,"context_line":"      owner   \u003d\u003e $::nova::params::nova_user,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9d8db2a7_cde340a0","line":140,"range":{"start_line":140,"start_character":6,"end_line":140,"end_character":23},"updated":"2020-12-14 10:48:02.000000000","message":"This is always true because the default value is $::os_service_default. Also, I think we should not manage the log_config_append file by default since it might break the deployment where log_config_append is used with the static file.","commit_id":"576bf9115249c7870217f4ab9ee56c8e3916e765"}],"templates/logging.conf.erb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ed7669dd8bd03e92e711f586d264df52ce165ffb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0eb3c9cb_35a231ca","line":40,"updated":"2020-12-14 10:48:02.000000000","message":"IMO it\u0027s better to use not template but ini_config resource to allow flexible configurations. For example this template doesn\u0027t allow us to use syslog or any additional formatting.","commit_id":"576bf9115249c7870217f4ab9ee56c8e3916e765"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b60530bf0971d365fbc3a9f9342ded614509f15b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e4df1fb5_672da75a","line":40,"in_reply_to":"0eb3c9cb_35a231ca","updated":"2020-12-14 14:12:00.000000000","message":"I agree. This file should be delivered via nova rpm and we can adjust it in puppet-nova with an ini provider if we want. We shouldn\u0027t use templates unless we have to and I dont\u0027 think we have to in this case","commit_id":"576bf9115249c7870217f4ab9ee56c8e3916e765"}]}