)]}'
{"manifests/init.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"6a6875a3957bfa7a8cfe15c3e4a073e493a69ce6","unresolved":true,"context_lines":[{"line_number":647,"context_line":"    nova_config { \u0027api/auth_strategy\u0027: value \u003d\u003e $auth_strategy }"},{"line_number":648,"context_line":"  }"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"  $dhcp_domain_real \u003d pick($::nova::metadata::dhcp_domain, $dhcp_domain)"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"  nova_config {"},{"line_number":653,"context_line":"    \u0027DEFAULT/ssl_only\u0027:              value \u003d\u003e $ssl_only;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"0bb4f7b4_9bf718bf","line":650,"updated":"2021-01-05 15:46:12.000000000","message":"This would cause a warning trying to access an undefined variable for most people (probably 99.99%) since everybody is probably declaring nova::metadata in some way after nova class is defined.\n\nHow about \"if defined(\u0027$::nova::metadata::dhcp_domain\u0027) { $dhcp_domain_real \u003d .. } else { $dhcp_domain_real \u003d ... }\" instead","commit_id":"5e4cee430393ff8df1c587112309a54a83189ef0"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"043872224489201b2859773636c902e65bee1473","unresolved":false,"context_lines":[{"line_number":647,"context_line":"    nova_config { \u0027api/auth_strategy\u0027: value \u003d\u003e $auth_strategy }"},{"line_number":648,"context_line":"  }"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"  $dhcp_domain_real \u003d pick($::nova::metadata::dhcp_domain, $dhcp_domain)"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"  nova_config {"},{"line_number":653,"context_line":"    \u0027DEFAULT/ssl_only\u0027:              value \u003d\u003e $ssl_only;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"eeb2fe53_b84b3901","line":650,"in_reply_to":"0bb4f7b4_9bf718bf","updated":"2021-01-06 01:25:41.000000000","message":"That\u0027s a good catch here. I\u0027ve initiated a backport of this other change as well [1]\n\n[1] https://review.opendev.org/c/openstack/puppet-nova/+/769440","commit_id":"5e4cee430393ff8df1c587112309a54a83189ef0"}]}