)]}'
{"manifests/compute.pp":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"12ec648cd7703c75e51545c2e3e9b0198336d88e","unresolved":true,"context_lines":[{"line_number":519,"context_line":"    \u0027DEFAULT/running_deleted_instance_timeout\u0027:  value \u003d\u003e $running_deleted_instance_timeout;"},{"line_number":520,"context_line":"    \u0027DEFAULT/compute_monitors\u0027:                  value \u003d\u003e join(any2array($compute_monitors), \u0027,\u0027);"},{"line_number":521,"context_line":"    \u0027DEFAULT/default_ephemeral_format\u0027:          value \u003d\u003e $default_ephemeral_format;"},{"line_number":522,"context_line":"    \u0027compute/image_type_exclusion_list\u0027:         value \u003d\u003e $image_type_exclusion_list;"},{"line_number":523,"context_line":"  }"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"  if ($vnc_enabled) {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7573105f_277e0f95","line":522,"range":{"start_line":522,"start_character":13,"end_line":522,"end_character":38},"updated":"2021-01-11 21:57:19.000000000","message":"Should be image_type_exclude_list. The nova reno incorrectly uses image_type_exclusion_list.","commit_id":"e454d24fad3b6caf903a9ed616c254234cbfe079"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"06544a411b1b34096d929ab037d9cb66b6fe966a","unresolved":true,"context_lines":[{"line_number":370,"context_line":"  $cpu_shared_set_real \u003d pick(join(any2array($cpu_shared_set), \u0027,\u0027), $::os_service_default)"},{"line_number":371,"context_line":"  $cpu_dedicated_set_real \u003d pick(join(any2array($cpu_dedicated_set), \u0027,\u0027), $::os_service_default)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"  $image_type_exclude_list_real \u003d pick(join(any2array($image_type_exclude_list), \u0027,\u0027), $::os_service_default)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"  $max_concurrent_builds_real \u003d pick("},{"line_number":376,"context_line":"    $::nova::compute::ironic::max_concurrent_builds,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fc9db896_8a90ab85","line":373,"range":{"start_line":373,"start_character":34,"end_line":373,"end_character":109},"updated":"2021-01-12 02:35:36.000000000","message":"We don\u0027t need pick here. We can make it like;\n```\n  $image_type_exclude_list_real \u003d join(any2array($image_type_exclude_list), \u0027,\u0027)\n```","commit_id":"0d8a77fd3722e003e2033b9944438a46305691ad"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2a59b833be7b0bc2612339bc666759401070032f","unresolved":true,"context_lines":[{"line_number":370,"context_line":"  $cpu_shared_set_real \u003d pick(join(any2array($cpu_shared_set), \u0027,\u0027), $::os_service_default)"},{"line_number":371,"context_line":"  $cpu_dedicated_set_real \u003d pick(join(any2array($cpu_dedicated_set), \u0027,\u0027), $::os_service_default)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"  $image_type_exclude_list_real \u003d pick(join(any2array($image_type_exclude_list), \u0027,\u0027), $::os_service_default)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"  $max_concurrent_builds_real \u003d pick("},{"line_number":376,"context_line":"    $::nova::compute::ironic::max_concurrent_builds,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"69a5ac6a_7c512a17","line":373,"range":{"start_line":373,"start_character":34,"end_line":373,"end_character":109},"in_reply_to":"5021e803_264de76e","updated":"2021-01-12 23:19:14.000000000","message":"IMO we should not override the value given by users as possible to avoid unexpected behavior, and if a user passes [] then we should set \"empty array\" accordingly.\n\nHowever I understand we already have similar implementation for some other parameters so I\u0027m ok to land this patch now and discuss that separately.","commit_id":"0d8a77fd3722e003e2033b9944438a46305691ad"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"99f594f085ba1ad0e23fca3e88bcfd4e571cd5f1","unresolved":true,"context_lines":[{"line_number":370,"context_line":"  $cpu_shared_set_real \u003d pick(join(any2array($cpu_shared_set), \u0027,\u0027), $::os_service_default)"},{"line_number":371,"context_line":"  $cpu_dedicated_set_real \u003d pick(join(any2array($cpu_dedicated_set), \u0027,\u0027), $::os_service_default)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"  $image_type_exclude_list_real \u003d pick(join(any2array($image_type_exclude_list), \u0027,\u0027), $::os_service_default)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"  $max_concurrent_builds_real \u003d pick("},{"line_number":376,"context_line":"    $::nova::compute::ironic::max_concurrent_builds,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5021e803_264de76e","line":373,"range":{"start_line":373,"start_character":34,"end_line":373,"end_character":109},"in_reply_to":"fc9db896_8a90ab85","updated":"2021-01-12 11:24:34.000000000","message":"It\u0027s to handle the case where $image_type_exclude_list \u003d []. If we don\u0027t use the pick then the result is \u0027\u0027. It\u0027s probably ok to set it in nova.conf but $::os_service_default to remove the conf option is a little bit cleaner.","commit_id":"0d8a77fd3722e003e2033b9944438a46305691ad"}]}