)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"6545447fccced7ddb0589045aedbeac33b1b6ba4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"307f7de8_9880b69a","updated":"2023-03-27 13:29:55.000000000","message":"just a note to potential regression cause","commit_id":"2ae766f1aaf4e3ffd2626cdc9bc0905b9dca4cec"}],"manifests/init.pp":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"6545447fccced7ddb0589045aedbeac33b1b6ba4","unresolved":true,"context_lines":[{"line_number":639,"context_line":"    nova_config { \u0027glance/api_servers\u0027: value \u003d\u003e $glance_api_servers }"},{"line_number":640,"context_line":"  }"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"  $dhcp_domain_real \u003d pick($::nova::metadata::dhcp_domain, $dhcp_domain)"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"  nova_config {"},{"line_number":645,"context_line":"    \u0027DEFAULT/ssl_only\u0027:              value \u003d\u003e $ssl_only;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5ca47b90_8720e428","side":"PARENT","line":642,"updated":"2023-03-27 13:29:55.000000000","message":"this broke the connection to legacy Hiera value, so that defaul/dhcp_domain is no longer set to the same value as it used to have before https://review.opendev.org/c/openstack/puppet-tripleo/+/762415/2/manifests/profile/base/nova/compute.pp#b86","commit_id":"dbba136cae4bce23124b2e7b0a48a0c574397692"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"37c73ef444a45c50fa1168b5d1c25a95da762d00","unresolved":true,"context_lines":[{"line_number":639,"context_line":"    nova_config { \u0027glance/api_servers\u0027: value \u003d\u003e $glance_api_servers }"},{"line_number":640,"context_line":"  }"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"  $dhcp_domain_real \u003d pick($::nova::metadata::dhcp_domain, $dhcp_domain)"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"  nova_config {"},{"line_number":645,"context_line":"    \u0027DEFAULT/ssl_only\u0027:              value \u003d\u003e $ssl_only;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa7941d9_6c41652b","side":"PARENT","line":642,"in_reply_to":"5ca47b90_8720e428","updated":"2023-03-27 14:28:03.000000000","message":"We merged this quite shortly after https://review.opendev.org/c/openstack/puppet-nova/+/774414 was merged so I don\u0027t think nobody would hit that \"regression\".","commit_id":"dbba136cae4bce23124b2e7b0a48a0c574397692"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2caf9b4d70e55523f37d44cfa68a262437b7e999","unresolved":true,"context_lines":[{"line_number":639,"context_line":"    nova_config { \u0027glance/api_servers\u0027: value \u003d\u003e $glance_api_servers }"},{"line_number":640,"context_line":"  }"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"  $dhcp_domain_real \u003d pick($::nova::metadata::dhcp_domain, $dhcp_domain)"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"  nova_config {"},{"line_number":645,"context_line":"    \u0027DEFAULT/ssl_only\u0027:              value \u003d\u003e $ssl_only;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7918eccf_65000766","side":"PARENT","line":642,"in_reply_to":"eac1a24b_145eb957","updated":"2023-04-06 11:32:53.000000000","message":"to summarize, removing the pick() did not introduce a regression on its own. That is because it \"knows\" its first value, only when the corresponding nova::metadata class\u0027s manifest is also in the puppet catalog. The regression seems had been introduced since https://review.opendev.org/c/openstack/puppet-tripleo/+/774415 as we no longer include nova::metadata on computes.","commit_id":"dbba136cae4bce23124b2e7b0a48a0c574397692"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"30817fba355035a13e59e64f26f242473298fcf3","unresolved":true,"context_lines":[{"line_number":639,"context_line":"    nova_config { \u0027glance/api_servers\u0027: value \u003d\u003e $glance_api_servers }"},{"line_number":640,"context_line":"  }"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"  $dhcp_domain_real \u003d pick($::nova::metadata::dhcp_domain, $dhcp_domain)"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"  nova_config {"},{"line_number":645,"context_line":"    \u0027DEFAULT/ssl_only\u0027:              value \u003d\u003e $ssl_only;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"eac1a24b_145eb957","side":"PARENT","line":642,"in_reply_to":"fa7941d9_6c41652b","updated":"2023-03-28 15:24:21.000000000","message":"That\u0027s ok on the puppet side, but not on t-h-t side, I believe. This \"hiera disconnect\" change, plus https://review.opendev.org/c/openstack/tripleo-heat-templates/+/765132/4/deployment/nova/nova-base-puppet.yaml has opened a permanent regression possibility, as we stopped defining it from nova::metadata::dhcp_domain and switched to nova::dhcp_domain instead","commit_id":"dbba136cae4bce23124b2e7b0a48a0c574397692"}]}