)]}'
{"manifests/compute/provider.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0e32091ff69c6de52ccdf98b2b5d2d1073c42141","unresolved":true,"context_lines":[{"line_number":67,"context_line":"#   Defaults to \u0027provider.yaml\u0027"},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"class nova::compute::provider ("},{"line_number":70,"context_line":"  $provider_schema_version     \u003d \u00271.0\u0027,"},{"line_number":71,"context_line":"  $provider_custom_inventories \u003d [],"},{"line_number":72,"context_line":"  $provider_config_location    \u003d \u0027/etc/nova/provider_config\u0027,"},{"line_number":73,"context_line":"  $provider_config_file        \u003d \u0027provider.yaml\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1528fa07_09f3adf5","line":70,"range":{"start_line":70,"start_character":3,"end_line":70,"end_character":12},"updated":"2021-03-01 14:22:56.000000000","message":"do we need the redundant provider_* since this class is nova::compute::provider?","commit_id":"bc648128d1741d524e0f77f758d39d3dce755515"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"217b8bb18df5bd810a096c54f8d577318d086a99","unresolved":true,"context_lines":[{"line_number":67,"context_line":"#   Defaults to \u0027provider.yaml\u0027"},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"class nova::compute::provider ("},{"line_number":70,"context_line":"  $provider_schema_version     \u003d \u00271.0\u0027,"},{"line_number":71,"context_line":"  $provider_custom_inventories \u003d [],"},{"line_number":72,"context_line":"  $provider_config_location    \u003d \u0027/etc/nova/provider_config\u0027,"},{"line_number":73,"context_line":"  $provider_config_file        \u003d \u0027provider.yaml\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"80175b83_ee040d95","line":70,"range":{"start_line":70,"start_character":3,"end_line":70,"end_character":12},"in_reply_to":"1528fa07_09f3adf5","updated":"2021-03-01 14:36:59.000000000","message":"no, not needed, I\u0027ll update the class parameters","commit_id":"bc648128d1741d524e0f77f758d39d3dce755515"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"938ac88a4e2a3e2bdbcac2d22d8dc36de0529ebd","unresolved":true,"context_lines":[{"line_number":69,"context_line":"class nova::compute::provider ("},{"line_number":70,"context_line":"  $schema_version     \u003d \u00271.0\u0027,"},{"line_number":71,"context_line":"  $custom_inventories \u003d [],"},{"line_number":72,"context_line":"  $config_location    \u003d \u0027/etc/nova/provider_config\u0027,"},{"line_number":73,"context_line":"  $config_file        \u003d \u0027provider.yaml\u0027,"},{"line_number":74,"context_line":") {"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"e3a42d0e_29d9abed","line":72,"range":{"start_line":72,"start_character":3,"end_line":72,"end_character":18},"updated":"2021-03-05 13:20:15.000000000","message":"provider_config_location would be more consistent naming but I see that Alex suggested this and to me it\u0027s clear that this indicates provider_config_location so maybe it\u0027s ok to go ahead with  this.","commit_id":"33397340b3a80b9f26253e70e0a0011afb79aa42"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"99a6eaced228364d4f047447f4bdf7ee84aaaa68","unresolved":true,"context_lines":[{"line_number":69,"context_line":"class nova::compute::provider ("},{"line_number":70,"context_line":"  $schema_version     \u003d \u00271.0\u0027,"},{"line_number":71,"context_line":"  $custom_inventories \u003d [],"},{"line_number":72,"context_line":"  $config_location    \u003d \u0027/etc/nova/provider_config\u0027,"},{"line_number":73,"context_line":"  $config_file        \u003d \u0027provider.yaml\u0027,"},{"line_number":74,"context_line":") {"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"6c48bfae_7871b8e2","line":72,"range":{"start_line":72,"start_character":3,"end_line":72,"end_character":18},"in_reply_to":"e3a42d0e_29d9abed","updated":"2021-03-05 14:42:36.000000000","message":"yes thats how I had it initially","commit_id":"33397340b3a80b9f26253e70e0a0011afb79aa42"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"938ac88a4e2a3e2bdbcac2d22d8dc36de0529ebd","unresolved":true,"context_lines":[{"line_number":82,"context_line":"  file { \"${config_location}\":"},{"line_number":83,"context_line":"    ensure  \u003d\u003e directory,"},{"line_number":84,"context_line":"    mode    \u003d\u003e \u00270750\u0027,"},{"line_number":85,"context_line":"    owner   \u003d\u003e \u0027nova\u0027,"},{"line_number":86,"context_line":"    group   \u003d\u003e \u0027nova\u0027,"},{"line_number":87,"context_line":"    require \u003d\u003e Anchor[\u0027nova::config::begin\u0027],"},{"line_number":88,"context_line":"    before  \u003d\u003e Anchor[\u0027nova::config::end\u0027],"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"6965d750_e7634450","line":85,"range":{"start_line":85,"start_character":16,"end_line":85,"end_character":20},"updated":"2021-03-05 13:20:15.000000000","message":"This needs to be replaced by nova::params::nova_user. I\u0027ll fix hard-coded usage in the other class in a separate patch.","commit_id":"33397340b3a80b9f26253e70e0a0011afb79aa42"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"99a6eaced228364d4f047447f4bdf7ee84aaaa68","unresolved":false,"context_lines":[{"line_number":82,"context_line":"  file { \"${config_location}\":"},{"line_number":83,"context_line":"    ensure  \u003d\u003e directory,"},{"line_number":84,"context_line":"    mode    \u003d\u003e \u00270750\u0027,"},{"line_number":85,"context_line":"    owner   \u003d\u003e \u0027nova\u0027,"},{"line_number":86,"context_line":"    group   \u003d\u003e \u0027nova\u0027,"},{"line_number":87,"context_line":"    require \u003d\u003e Anchor[\u0027nova::config::begin\u0027],"},{"line_number":88,"context_line":"    before  \u003d\u003e Anchor[\u0027nova::config::end\u0027],"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"27e418d7_3a0c8e9b","line":85,"range":{"start_line":85,"start_character":16,"end_line":85,"end_character":20},"in_reply_to":"6965d750_e7634450","updated":"2021-03-05 14:42:36.000000000","message":"Done","commit_id":"33397340b3a80b9f26253e70e0a0011afb79aa42"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"938ac88a4e2a3e2bdbcac2d22d8dc36de0529ebd","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    ensure  \u003d\u003e directory,"},{"line_number":84,"context_line":"    mode    \u003d\u003e \u00270750\u0027,"},{"line_number":85,"context_line":"    owner   \u003d\u003e \u0027nova\u0027,"},{"line_number":86,"context_line":"    group   \u003d\u003e \u0027nova\u0027,"},{"line_number":87,"context_line":"    require \u003d\u003e Anchor[\u0027nova::config::begin\u0027],"},{"line_number":88,"context_line":"    before  \u003d\u003e Anchor[\u0027nova::config::end\u0027],"},{"line_number":89,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"75eef399_9806f09c","line":86,"range":{"start_line":86,"start_character":16,"end_line":86,"end_character":20},"updated":"2021-03-05 13:20:15.000000000","message":"Ditto.  nova::params::nova_group","commit_id":"33397340b3a80b9f26253e70e0a0011afb79aa42"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"938ac88a4e2a3e2bdbcac2d22d8dc36de0529ebd","unresolved":true,"context_lines":[{"line_number":93,"context_line":"      ensure  \u003d\u003e file,"},{"line_number":94,"context_line":"      mode    \u003d\u003e \u00270640\u0027,"},{"line_number":95,"context_line":"      owner   \u003d\u003e \u0027nova\u0027,"},{"line_number":96,"context_line":"      group   \u003d\u003e \u0027nova\u0027,"},{"line_number":97,"context_line":"      content \u003d\u003e template(\u0027nova/provider.yaml.erb\u0027),"},{"line_number":98,"context_line":"      require \u003d\u003e Anchor[\u0027nova::config::begin\u0027],"},{"line_number":99,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"8f5a98f7_07fc02ac","line":96,"updated":"2021-03-05 13:20:15.000000000","message":"ditto","commit_id":"33397340b3a80b9f26253e70e0a0011afb79aa42"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"99a6eaced228364d4f047447f4bdf7ee84aaaa68","unresolved":false,"context_lines":[{"line_number":93,"context_line":"      ensure  \u003d\u003e file,"},{"line_number":94,"context_line":"      mode    \u003d\u003e \u00270640\u0027,"},{"line_number":95,"context_line":"      owner   \u003d\u003e \u0027nova\u0027,"},{"line_number":96,"context_line":"      group   \u003d\u003e \u0027nova\u0027,"},{"line_number":97,"context_line":"      content \u003d\u003e template(\u0027nova/provider.yaml.erb\u0027),"},{"line_number":98,"context_line":"      require \u003d\u003e Anchor[\u0027nova::config::begin\u0027],"},{"line_number":99,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"2567c2ed_e0b3ebb9","line":96,"in_reply_to":"8f5a98f7_07fc02ac","updated":"2021-03-05 14:42:36.000000000","message":"Done","commit_id":"33397340b3a80b9f26253e70e0a0011afb79aa42"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"99fb04f4bc73b64033d6a2d603d0f4405cea8d6e","unresolved":true,"context_lines":[{"line_number":82,"context_line":"  file { \"${config_location}\":"},{"line_number":83,"context_line":"    ensure  \u003d\u003e directory,"},{"line_number":84,"context_line":"    mode    \u003d\u003e \u00270750\u0027,"},{"line_number":85,"context_line":"    owner   \u003d\u003e $::nova::params::nova_user,"},{"line_number":86,"context_line":"    group   \u003d\u003e $::nova::params::nova_group,"},{"line_number":87,"context_line":"    require \u003d\u003e Anchor[\u0027nova::config::begin\u0027],"},{"line_number":88,"context_line":"    before  \u003d\u003e Anchor[\u0027nova::config::end\u0027],"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"96e5396c_15f1f34c","line":85,"range":{"start_line":85,"start_character":15,"end_line":85,"end_character":16},"updated":"2021-03-05 15:03:47.000000000","message":"I guess you also need to add\n\ninclude nova::params\n\nto use these parameters","commit_id":"e82a79882369e9fcc9eada5c0e9cc6f206b81ba6"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"282d886a9dcc1847eab3af82f66c47d150eb2937","unresolved":false,"context_lines":[{"line_number":82,"context_line":"  file { \"${config_location}\":"},{"line_number":83,"context_line":"    ensure  \u003d\u003e directory,"},{"line_number":84,"context_line":"    mode    \u003d\u003e \u00270750\u0027,"},{"line_number":85,"context_line":"    owner   \u003d\u003e $::nova::params::nova_user,"},{"line_number":86,"context_line":"    group   \u003d\u003e $::nova::params::nova_group,"},{"line_number":87,"context_line":"    require \u003d\u003e Anchor[\u0027nova::config::begin\u0027],"},{"line_number":88,"context_line":"    before  \u003d\u003e Anchor[\u0027nova::config::end\u0027],"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"f17d5d0e_99c93983","line":85,"range":{"start_line":85,"start_character":15,"end_line":85,"end_character":16},"in_reply_to":"96e5396c_15f1f34c","updated":"2021-03-07 11:26:52.000000000","message":"Done","commit_id":"e82a79882369e9fcc9eada5c0e9cc6f206b81ba6"}],"spec/classes/nova_compute_provider_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"938ac88a4e2a3e2bdbcac2d22d8dc36de0529ebd","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  shared_examples_for \u0027nova custom resource providers\u0027 do"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    it \u0027configure nova.conf with default parameters\u0027 do"},{"line_number":18,"context_line":"        is_expected.to contain_nova_config(\u0027compute/provider_config_location\u0027).with_value(\u0027/etc/nova/provider_config\u0027)"},{"line_number":19,"context_line":"    end"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":8,"id":"dc110186_fc4f947e","line":17,"updated":"2021-03-05 13:20:15.000000000","message":"You set params so this is not testing default but behavior with the parameters you defined above.","commit_id":"33397340b3a80b9f26253e70e0a0011afb79aa42"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"99a6eaced228364d4f047447f4bdf7ee84aaaa68","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  shared_examples_for \u0027nova custom resource providers\u0027 do"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    it \u0027configure nova.conf with default parameters\u0027 do"},{"line_number":18,"context_line":"        is_expected.to contain_nova_config(\u0027compute/provider_config_location\u0027).with_value(\u0027/etc/nova/provider_config\u0027)"},{"line_number":19,"context_line":"    end"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":8,"id":"0a8d3e57_802b798e","line":17,"in_reply_to":"dc110186_fc4f947e","updated":"2021-03-05 14:42:36.000000000","message":"yes right, I updated the tests.","commit_id":"33397340b3a80b9f26253e70e0a0011afb79aa42"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"938ac88a4e2a3e2bdbcac2d22d8dc36de0529ebd","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        params.merge!("},{"line_number":36,"context_line":"          :custom_inventories \u003d\u003e ["},{"line_number":37,"context_line":"            {"},{"line_number":38,"context_line":"              \u0027uuid\u0027 \u003d\u003e \u0027$COMPUTE_NODE\u0027,"},{"line_number":39,"context_line":"              \u0027inventories\u0027 \u003d\u003e {"},{"line_number":40,"context_line":"                \u0027CUSTOM_EXAMPLE_RESOURCE_CLASS_1\u0027 \u003d\u003e {"},{"line_number":41,"context_line":"                  \u0027total\u0027            \u003d\u003e \u0027100\u0027,"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"4d9929dd_2310c0d9","line":38,"range":{"start_line":38,"start_character":14,"end_line":38,"end_character":40},"updated":"2021-03-05 13:20:15.000000000","message":"It would be better if we can add one more example without either name or uuid, then replaced this by real uuid.","commit_id":"33397340b3a80b9f26253e70e0a0011afb79aa42"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"99a6eaced228364d4f047447f4bdf7ee84aaaa68","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        params.merge!("},{"line_number":36,"context_line":"          :custom_inventories \u003d\u003e ["},{"line_number":37,"context_line":"            {"},{"line_number":38,"context_line":"              \u0027uuid\u0027 \u003d\u003e \u0027$COMPUTE_NODE\u0027,"},{"line_number":39,"context_line":"              \u0027inventories\u0027 \u003d\u003e {"},{"line_number":40,"context_line":"                \u0027CUSTOM_EXAMPLE_RESOURCE_CLASS_1\u0027 \u003d\u003e {"},{"line_number":41,"context_line":"                  \u0027total\u0027            \u003d\u003e \u0027100\u0027,"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"74cebf01_793f5420","line":38,"range":{"start_line":38,"start_character":14,"end_line":38,"end_character":40},"in_reply_to":"4d9929dd_2310c0d9","updated":"2021-03-05 14:42:36.000000000","message":"I have separated and extended the tests with:\n- no uuid or name set\n- only name set\n- only uuid set\n- multiple providers","commit_id":"33397340b3a80b9f26253e70e0a0011afb79aa42"}]}