)]}'
{"manifests/compute/libvirt.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"15c963b3ca4489af41e9bd8430c2b3eca3c7bb85","unresolved":true,"context_lines":[{"line_number":570,"context_line":"    }"},{"line_number":571,"context_line":"  }"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"  if defined(Class[nova::compute::rbd]) {"},{"line_number":574,"context_line":"    $images_type_real \u003d \u0027rbd\u0027"},{"line_number":575,"context_line":"  } else {"},{"line_number":576,"context_line":"    $images_type_real \u003d $images_type"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"85c89546_4de935c4","line":573,"range":{"start_line":573,"start_character":13,"end_line":573,"end_character":38},"updated":"2021-02-23 06:24:05.000000000","message":"This breaks the deployment if nova::compute::rbd class is defined AFTER nova::compute::libvirt class.\n\nIn fact, in current integration tests, nova::compute::rbd class is defined after nova::compute::libvirt class then images_type parameter is not properly set.\n\nhttps://zuul.opendev.org/t/openstack/build/c987fa00e1af458392f92e81361c327c/log/logs/etc/nova/nova.conf.txt#3132\nFor example we see \n\nThis parameter was used to set to rbd.\n\nhttps://zuul.opendev.org/t/openstack/build/6b5059f13c664652b16474272b0b2d08/log/logs/etc/nova/nova.conf.txt#3132-3133","commit_id":"3f6d320ec0fc239f1680eba1e581a29959c46241"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"f1c58762d554020dbd55190f3b20468867f6af03","unresolved":true,"context_lines":[{"line_number":570,"context_line":"    }"},{"line_number":571,"context_line":"  }"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"  if defined(Class[nova::compute::rbd]) {"},{"line_number":574,"context_line":"    $images_type_real \u003d \u0027rbd\u0027"},{"line_number":575,"context_line":"  } else {"},{"line_number":576,"context_line":"    $images_type_real \u003d $images_type"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"8d148249_f46c7ab6","line":573,"range":{"start_line":573,"start_character":13,"end_line":573,"end_character":38},"in_reply_to":"85c89546_4de935c4","updated":"2021-02-23 11:11:35.000000000","message":"thanks for the comments, this part is not correct. So how do you think of it if I remove the hardcoded images_type value from nova::compute::rbd class but let user to configure the correct one?","commit_id":"3f6d320ec0fc239f1680eba1e581a29959c46241"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8167d13979db3edc70e429c86aad83e201f3ad86","unresolved":true,"context_lines":[{"line_number":570,"context_line":"    }"},{"line_number":571,"context_line":"  }"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"  if defined(Class[nova::compute::rbd]) {"},{"line_number":574,"context_line":"    $images_type_real \u003d \u0027rbd\u0027"},{"line_number":575,"context_line":"  } else {"},{"line_number":576,"context_line":"    $images_type_real \u003d $images_type"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6536b8_79d4fcd5","line":573,"range":{"start_line":573,"start_character":13,"end_line":573,"end_character":38},"in_reply_to":"8d148249_f46c7ab6","updated":"2021-02-23 12:56:51.000000000","message":"As I mentioned in my second comment, that implementation is still concerning because it doesn\u0027t correctly make users aware of the change they should implement.\n\nOne option is to implement a validation logic in nova::compute::rbd to make it fail if the nova::compute::rbd is already defined and its imate_type parameter is not set to rbd. Please note that for this option we need to update puppet-openstack-integration first so that nova::compute::rbd is included before nova::compute::libvirt is included.\n\nAnother option is to make this parameter optional (defaults to undef and don\u0027t manage the parameter if it is set to undef).","commit_id":"3f6d320ec0fc239f1680eba1e581a29959c46241"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1275f60dffd1782e541ad6230c3faf82891e1d06","unresolved":false,"context_lines":[{"line_number":326,"context_line":"  $rx_queue_size                              \u003d $::os_service_default,"},{"line_number":327,"context_line":"  $tx_queue_size                              \u003d $::os_service_default,"},{"line_number":328,"context_line":"  $file_backed_memory                         \u003d undef,"},{"line_number":329,"context_line":"  $images_type                                \u003d undef,"},{"line_number":330,"context_line":"  $volume_use_multipath                       \u003d $::os_service_default,"},{"line_number":331,"context_line":"  $nfs_mount_options                          \u003d $::os_service_default,"},{"line_number":332,"context_line":"  $num_pcie_ports                             \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"4e94126c_4ba8cfd7","line":329,"updated":"2021-03-02 16:58:13.000000000","message":"Please use $::os_service_default here as you have documented","commit_id":"1f3a2bba65b96000105e4303141e4016aba858b4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1275f60dffd1782e541ad6230c3faf82891e1d06","unresolved":false,"context_lines":[{"line_number":595,"context_line":"    \u0027libvirt/swtpm_enabled\u0027:            value \u003d\u003e $swtpm_enabled;"},{"line_number":596,"context_line":"    \u0027libvirt/swtpm_user\u0027   :            value \u003d\u003e $swtpm_user;"},{"line_number":597,"context_line":"    \u0027libvirt/swtpm_group\u0027:              value \u003d\u003e $swtpm_group;"},{"line_number":598,"context_line":"    \u0027libvirt/max_queues\u0027:               value \u003d\u003e $max_queues;"},{"line_number":599,"context_line":"  }"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"  if $images_type !\u003d undef {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ecf89c42_6fdb45ea","line":598,"updated":"2021-03-02 16:58:13.000000000","message":"When you switch to $::os_service_default, just ad \u0027libvirt/image_type\u0027: vaolue \u003d\u003e $images_type and remove the if condition below","commit_id":"1f3a2bba65b96000105e4303141e4016aba858b4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"93134d0f8588e91ca1a4853ed540580da29b1ccb","unresolved":false,"context_lines":[{"line_number":595,"context_line":"    \u0027libvirt/swtpm_enabled\u0027:            value \u003d\u003e $swtpm_enabled;"},{"line_number":596,"context_line":"    \u0027libvirt/swtpm_user\u0027   :            value \u003d\u003e $swtpm_user;"},{"line_number":597,"context_line":"    \u0027libvirt/swtpm_group\u0027:              value \u003d\u003e $swtpm_group;"},{"line_number":598,"context_line":"    \u0027libvirt/max_queues\u0027:               value \u003d\u003e $max_queues;"},{"line_number":599,"context_line":"  }"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"  if $images_type !\u003d undef {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"0e80778e_535dd3bd","line":598,"in_reply_to":"ecf89c42_6fdb45ea","updated":"2021-03-03 10:57:15.000000000","message":"We can\u0027t do this because it would cause a conflict with nova::compute::rbd which sets image_type\u003d\u0027rbd\u0027","commit_id":"1f3a2bba65b96000105e4303141e4016aba858b4"}]}