)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8723d2a08f1ace106d558f22769c4f78488e79b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Christian Rohmann \u003cchristian.rohmann@inovex.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-11 10:49:40 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Expose nova config option [workaround]/ensure_libvirt_rbd_instance_dir_cleanup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This exposes the nova workaround to remove the instance directory on clean up"},{"line_number":10,"context_line":"when using rbd."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"08e7ff61_13e5481e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":78},"updated":"2021-03-11 10:32:55.000000000","message":"Can we shorten the commit title, like;\n\nExpose [workaround]/ensure_libvirt_rbd_instance_dir_cleanup\n\nI think it\u0027s clear that this is implement support for a nova config option.","commit_id":"91fc674e5755cd97f56a8fe0cb4038753b466eb1"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"032695f1280aa8a7bf0c00051ef8837ac57bea7e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Christian Rohmann \u003cchristian.rohmann@inovex.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-11 10:49:40 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Expose nova config option [workaround]/ensure_libvirt_rbd_instance_dir_cleanup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This exposes the nova workaround to remove the instance directory on clean up"},{"line_number":10,"context_line":"when using rbd."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bdbb61f9_3eec1271","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":78},"in_reply_to":"08e7ff61_13e5481e","updated":"2021-03-11 11:01:14.000000000","message":"Done","commit_id":"91fc674e5755cd97f56a8fe0cb4038753b466eb1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8723d2a08f1ace106d558f22769c4f78488e79b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Expose nova config option [workaround]/ensure_libvirt_rbd_instance_dir_cleanup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This exposes the nova workaround to remove the instance directory on clean up"},{"line_number":10,"context_line":"when using rbd."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iea47828c8022955cf0f91b891d43eff34a905174"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"603bb937_fe3be611","line":10,"updated":"2021-03-11 10:32:55.000000000","message":"Please wrap lines to 72 characters\n\nhttps://docs.openstack.org/contributors/common/git.html#commit-messages","commit_id":"91fc674e5755cd97f56a8fe0cb4038753b466eb1"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"032695f1280aa8a7bf0c00051ef8837ac57bea7e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Expose nova config option [workaround]/ensure_libvirt_rbd_instance_dir_cleanup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This exposes the nova workaround to remove the instance directory on clean up"},{"line_number":10,"context_line":"when using rbd."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iea47828c8022955cf0f91b891d43eff34a905174"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"131462b2_4321facc","line":10,"in_reply_to":"603bb937_fe3be611","updated":"2021-03-11 11:01:14.000000000","message":"Done","commit_id":"91fc674e5755cd97f56a8fe0cb4038753b466eb1"}],"manifests/workarounds.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8723d2a08f1ace106d558f22769c4f78488e79b","unresolved":true,"context_lines":[{"line_number":15,"context_line":"#   (optional) Whether to enable live migration for NUMA topology instances."},{"line_number":16,"context_line":"#   Defaults to undef"},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*ensure_libvirt_rbd_instance_dir_cleanup*]"},{"line_number":19,"context_line":"#  (optional) Ensure the instance directory is removed during clean up when using"},{"line_number":20,"context_line":"#  rbd. When enabled this workaround will ensure that the instance directory is"},{"line_number":21,"context_line":"#  always removed during cleanup on hosts using ``[libvirt]/images_type\u003drbd``"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"831a6688_cf98abf7","line":18,"range":{"start_line":18,"start_character":4,"end_line":18,"end_character":43},"updated":"2021-03-11 10:32:55.000000000","message":"This parameter is not deprecated, thus should be placed before \"DEPRECATED\"","commit_id":"91fc674e5755cd97f56a8fe0cb4038753b466eb1"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"032695f1280aa8a7bf0c00051ef8837ac57bea7e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#   (optional) Whether to enable live migration for NUMA topology instances."},{"line_number":16,"context_line":"#   Defaults to undef"},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*ensure_libvirt_rbd_instance_dir_cleanup*]"},{"line_number":19,"context_line":"#  (optional) Ensure the instance directory is removed during clean up when using"},{"line_number":20,"context_line":"#  rbd. When enabled this workaround will ensure that the instance directory is"},{"line_number":21,"context_line":"#  always removed during cleanup on hosts using ``[libvirt]/images_type\u003drbd``"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"77437dce_d7a59247","line":18,"range":{"start_line":18,"start_character":4,"end_line":18,"end_character":43},"in_reply_to":"831a6688_cf98abf7","updated":"2021-03-11 11:01:14.000000000","message":"Done","commit_id":"91fc674e5755cd97f56a8fe0cb4038753b466eb1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8723d2a08f1ace106d558f22769c4f78488e79b","unresolved":true,"context_lines":[{"line_number":19,"context_line":"#  (optional) Ensure the instance directory is removed during clean up when using"},{"line_number":20,"context_line":"#  rbd. When enabled this workaround will ensure that the instance directory is"},{"line_number":21,"context_line":"#  always removed during cleanup on hosts using ``[libvirt]/images_type\u003drbd``"},{"line_number":22,"context_line":"#  Defaults to undef"},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"class nova::workarounds ("},{"line_number":25,"context_line":"  $never_download_image_if_on_rbd \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"6a98c8d3_36ddb588","line":22,"range":{"start_line":22,"start_character":15,"end_line":22,"end_character":20},"updated":"2021-03-11 10:32:55.000000000","message":"Use $::os_service_default instead.","commit_id":"91fc674e5755cd97f56a8fe0cb4038753b466eb1"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"032695f1280aa8a7bf0c00051ef8837ac57bea7e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#  (optional) Ensure the instance directory is removed during clean up when using"},{"line_number":20,"context_line":"#  rbd. When enabled this workaround will ensure that the instance directory is"},{"line_number":21,"context_line":"#  always removed during cleanup on hosts using ``[libvirt]/images_type\u003drbd``"},{"line_number":22,"context_line":"#  Defaults to undef"},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"class nova::workarounds ("},{"line_number":25,"context_line":"  $never_download_image_if_on_rbd \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"19045ad4_0d985bcb","line":22,"range":{"start_line":22,"start_character":15,"end_line":22,"end_character":20},"in_reply_to":"6a98c8d3_36ddb588","updated":"2021-03-11 11:01:14.000000000","message":"Done","commit_id":"91fc674e5755cd97f56a8fe0cb4038753b466eb1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8723d2a08f1ace106d558f22769c4f78488e79b","unresolved":true,"context_lines":[{"line_number":25,"context_line":"  $never_download_image_if_on_rbd \u003d $::os_service_default,"},{"line_number":26,"context_line":"  # DEPRECATED PARAMETER"},{"line_number":27,"context_line":"  $enable_numa_live_migration     \u003d undef,"},{"line_number":28,"context_line":"  $ensure_libvirt_rbd_instance_dir_cleanup \u003d undef,"},{"line_number":29,"context_line":") {"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  if $enable_numa_live_migration !\u003d undef {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"18b4aab8_da1dd69b","line":28,"range":{"start_line":28,"start_character":3,"end_line":28,"end_character":42},"updated":"2021-03-11 10:32:55.000000000","message":"Ditto. Move this parameter definition above because it is not deprecated.","commit_id":"91fc674e5755cd97f56a8fe0cb4038753b466eb1"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"032695f1280aa8a7bf0c00051ef8837ac57bea7e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  $never_download_image_if_on_rbd \u003d $::os_service_default,"},{"line_number":26,"context_line":"  # DEPRECATED PARAMETER"},{"line_number":27,"context_line":"  $enable_numa_live_migration     \u003d undef,"},{"line_number":28,"context_line":"  $ensure_libvirt_rbd_instance_dir_cleanup \u003d undef,"},{"line_number":29,"context_line":") {"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  if $enable_numa_live_migration !\u003d undef {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"e343d72d_6e7384d3","line":28,"range":{"start_line":28,"start_character":3,"end_line":28,"end_character":42},"in_reply_to":"18b4aab8_da1dd69b","updated":"2021-03-11 11:01:14.000000000","message":"Done","commit_id":"91fc674e5755cd97f56a8fe0cb4038753b466eb1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"aa77521f2aa62c3578f78e7b65570dff50d449d5","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#  (optional) Ensure the instance directory is removed during clean up when using"},{"line_number":14,"context_line":"#  rbd. When enabled this workaround will ensure that the instance directory is"},{"line_number":15,"context_line":"#  always removed during cleanup on hosts using ``[libvirt]/images_type\u003drbd``"},{"line_number":16,"context_line":"#  Defaults to undef"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# DEPRECATED"},{"line_number":19,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"69f0bf68_e3352a33","line":16,"range":{"start_line":16,"start_character":15,"end_line":16,"end_character":20},"updated":"2021-03-11 12:11:26.000000000","message":"$::os_service_default","commit_id":"dc0e1a2f1f0a9fece677c9ddaac6598221a66665"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3a3cd34cf37b2b6d0c79eb84e7a159f0bcf447ed","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#  (optional) Ensure the instance directory is removed during clean up when using"},{"line_number":14,"context_line":"#  rbd. When enabled this workaround will ensure that the instance directory is"},{"line_number":15,"context_line":"#  always removed during cleanup on hosts using ``[libvirt]/images_type\u003drbd``"},{"line_number":16,"context_line":"#  Defaults to undef"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# DEPRECATED"},{"line_number":19,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"49c495cf_870221e7","line":16,"range":{"start_line":16,"start_character":15,"end_line":16,"end_character":20},"in_reply_to":"69f0bf68_e3352a33","updated":"2021-03-11 12:13:07.000000000","message":"Done","commit_id":"dc0e1a2f1f0a9fece677c9ddaac6598221a66665"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"aa77521f2aa62c3578f78e7b65570dff50d449d5","unresolved":true,"context_lines":[{"line_number":14,"context_line":"#  rbd. When enabled this workaround will ensure that the instance directory is"},{"line_number":15,"context_line":"#  always removed during cleanup on hosts using ``[libvirt]/images_type\u003drbd``"},{"line_number":16,"context_line":"#  Defaults to undef"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# DEPRECATED"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"#  [*enable_numa_live_migration*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"63d94eed_08ff526c","line":17,"updated":"2021-03-11 12:11:26.000000000","message":"# is missing","commit_id":"dc0e1a2f1f0a9fece677c9ddaac6598221a66665"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3a3cd34cf37b2b6d0c79eb84e7a159f0bcf447ed","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#  rbd. When enabled this workaround will ensure that the instance directory is"},{"line_number":15,"context_line":"#  always removed during cleanup on hosts using ``[libvirt]/images_type\u003drbd``"},{"line_number":16,"context_line":"#  Defaults to undef"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# DEPRECATED"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"#  [*enable_numa_live_migration*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"f6c868de_7e186ddc","line":17,"in_reply_to":"63d94eed_08ff526c","updated":"2021-03-11 12:13:07.000000000","message":"Done","commit_id":"dc0e1a2f1f0a9fece677c9ddaac6598221a66665"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"aa77521f2aa62c3578f78e7b65570dff50d449d5","unresolved":true,"context_lines":[{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  nova_config {"},{"line_number":43,"context_line":"    \u0027workarounds/ensure_libvirt_rbd_instance_dir_cleanup\u0027: value \u003d\u003e $ensure_libvirt_rbd_instance_dir_cleanup;"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"cc610110_d1da7dad","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":109},"updated":"2021-03-11 12:11:26.000000000","message":"I think we can merge this to the above nova_config block.","commit_id":"dc0e1a2f1f0a9fece677c9ddaac6598221a66665"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3a3cd34cf37b2b6d0c79eb84e7a159f0bcf447ed","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  nova_config {"},{"line_number":43,"context_line":"    \u0027workarounds/ensure_libvirt_rbd_instance_dir_cleanup\u0027: value \u003d\u003e $ensure_libvirt_rbd_instance_dir_cleanup;"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"8f3a17f1_0b9f6e29","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":109},"in_reply_to":"cc610110_d1da7dad","updated":"2021-03-11 12:13:07.000000000","message":"Done","commit_id":"dc0e1a2f1f0a9fece677c9ddaac6598221a66665"}],"spec/classes/nova_workarounds_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8723d2a08f1ace106d558f22769c4f78488e79b","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    context \u0027with default parameters\u0027 do"},{"line_number":12,"context_line":"      it { is_expected.not_to contain_nova_config(\u0027workarounds/enable_numa_live_migration\u0027) }"},{"line_number":13,"context_line":"      it { is_expected.to contain_nova_config(\u0027workarounds/never_download_image_if_on_rbd\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"},{"line_number":14,"context_line":"      it { is_expected.not_to contain_nova_config(\u0027workarounds/ensure_libvirt_rbd_instance_dir_cleanup\u0027) }"},{"line_number":15,"context_line":"    end"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    context \u0027with overridden parameters\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"087e90c7_d3a8c0ab","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":106},"updated":"2021-03-11 10:32:55.000000000","message":"I don\u0027t think this works. Follow the current implementation of never_download_image_if_on_rbd.","commit_id":"91fc674e5755cd97f56a8fe0cb4038753b466eb1"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"032695f1280aa8a7bf0c00051ef8837ac57bea7e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    context \u0027with default parameters\u0027 do"},{"line_number":12,"context_line":"      it { is_expected.not_to contain_nova_config(\u0027workarounds/enable_numa_live_migration\u0027) }"},{"line_number":13,"context_line":"      it { is_expected.to contain_nova_config(\u0027workarounds/never_download_image_if_on_rbd\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"},{"line_number":14,"context_line":"      it { is_expected.not_to contain_nova_config(\u0027workarounds/ensure_libvirt_rbd_instance_dir_cleanup\u0027) }"},{"line_number":15,"context_line":"    end"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    context \u0027with overridden parameters\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"68ac1ac0_5a858de8","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":106},"in_reply_to":"087e90c7_d3a8c0ab","updated":"2021-03-11 11:01:14.000000000","message":"Done","commit_id":"91fc674e5755cd97f56a8fe0cb4038753b466eb1"}]}