)]}'
{"manifests/compute/libvirt.pp":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c2d403f7b72a1d906db53b5fae522cced7d0fe7e","unresolved":true,"context_lines":[{"line_number":341,"context_line":"    }"},{"line_number":342,"context_line":"  }"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"  if !$modular_libvirt {"},{"line_number":345,"context_line":"    libvirtd_config {"},{"line_number":346,"context_line":"      \u0027log_outputs\u0027:  value \u003d\u003e pick($log_outputs, $::os_service_default), quote \u003d\u003e true;"},{"line_number":347,"context_line":"      \u0027log_filters\u0027:  value \u003d\u003e pick($log_filters, $::os_service_default), quote \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"d8cf83db_fe1728d0","line":344,"updated":"2021-09-07 13:13:14.000000000","message":"don\u0027t we need virtproxyd_config in the else path, similarly to the migration manifest?","commit_id":"060c3368b7972ad60b004a1819d9ace41ff923c5"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"c7ec16fcf34f373f782e26788f3c8e7a4061a9f2","unresolved":true,"context_lines":[{"line_number":341,"context_line":"    }"},{"line_number":342,"context_line":"  }"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"  if !$modular_libvirt {"},{"line_number":345,"context_line":"    libvirtd_config {"},{"line_number":346,"context_line":"      \u0027log_outputs\u0027:  value \u003d\u003e pick($log_outputs, $::os_service_default), quote \u003d\u003e true;"},{"line_number":347,"context_line":"      \u0027log_filters\u0027:  value \u003d\u003e pick($log_filters, $::os_service_default), quote \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"f6b691bd_d76e2177","line":344,"in_reply_to":"d8cf83db_fe1728d0","updated":"2021-09-09 11:00:15.000000000","message":"we are setting it here for virtproxyd_config.\n\nhttps://review.opendev.org/c/openstack/puppet-nova/+/785305/17/manifests/compute/libvirt/virtproxyd.pp","commit_id":"060c3368b7972ad60b004a1819d9ace41ff923c5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"08c1cf0bc308fd66666e26a4ec0499132fc9f17d","unresolved":true,"context_lines":[{"line_number":269,"context_line":"  $inject_partition                           \u003d -2,"},{"line_number":270,"context_line":"  $enabled_perf_events                        \u003d $::os_service_default,"},{"line_number":271,"context_line":"  $device_detach_attempts                     \u003d $::os_service_default,"},{"line_number":272,"context_line":"  $device_detach_timeout                      \u003d $::os_service_default,"},{"line_number":273,"context_line":"  $libvirt_service_name                       \u003d $::nova::params::libvirt_service_name,"},{"line_number":274,"context_line":"  $virtlock_service_name                      \u003d $::nova::params::virtlock_service_name,"},{"line_number":275,"context_line":"  $virtlog_service_name                       \u003d $::nova::params::virtlog_service_name,"},{"line_number":276,"context_line":"  $virtqemu_service_name                      \u003d $::nova::params::virtqemu_service_name,"},{"line_number":277,"context_line":"  $virtproxy_service_name                     \u003d $::nova::params::virtproxy_service_name,"},{"line_number":278,"context_line":"  $virtsecret_service_name                    \u003d $::nova::params::virtsecret_service_name,"},{"line_number":279,"context_line":"  $virtnodedev_service_name                   \u003d $::nova::params::virtnodedev_service_name,"},{"line_number":280,"context_line":"  $virtstorage_service_name                   \u003d $::nova::params::virtstorage_service_name,"},{"line_number":281,"context_line":"  $modular_libvirt                            \u003d $::nova::params::modular_libvirt,"},{"line_number":282,"context_line":"  $compute_driver                             \u003d \u0027libvirt.LibvirtDriver\u0027,"},{"line_number":283,"context_line":"  $preallocate_images                         \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9d6269f7_d10264ac","line":280,"range":{"start_line":272,"start_character":70,"end_line":280,"end_character":90},"updated":"2021-09-10 00:16:03.000000000","message":"(off topic. left this now) Personally I don\u0027t see very much benefit of making these service name configurable, and defining static but appropriate service names would be enough. Name of the nova services are not configurable and this looks incomplete.","commit_id":"55786df2006dd22dad72f8dfa3e4fa9d8f8f36d7"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ccfa3a46ec761aa2968245f80ead0f11204bd5b5","unresolved":false,"context_lines":[{"line_number":269,"context_line":"  $inject_partition                           \u003d -2,"},{"line_number":270,"context_line":"  $enabled_perf_events                        \u003d $::os_service_default,"},{"line_number":271,"context_line":"  $device_detach_attempts                     \u003d $::os_service_default,"},{"line_number":272,"context_line":"  $device_detach_timeout                      \u003d $::os_service_default,"},{"line_number":273,"context_line":"  $libvirt_service_name                       \u003d $::nova::params::libvirt_service_name,"},{"line_number":274,"context_line":"  $virtlock_service_name                      \u003d $::nova::params::virtlock_service_name,"},{"line_number":275,"context_line":"  $virtlog_service_name                       \u003d $::nova::params::virtlog_service_name,"},{"line_number":276,"context_line":"  $virtqemu_service_name                      \u003d $::nova::params::virtqemu_service_name,"},{"line_number":277,"context_line":"  $virtproxy_service_name                     \u003d $::nova::params::virtproxy_service_name,"},{"line_number":278,"context_line":"  $virtsecret_service_name                    \u003d $::nova::params::virtsecret_service_name,"},{"line_number":279,"context_line":"  $virtnodedev_service_name                   \u003d $::nova::params::virtnodedev_service_name,"},{"line_number":280,"context_line":"  $virtstorage_service_name                   \u003d $::nova::params::virtstorage_service_name,"},{"line_number":281,"context_line":"  $modular_libvirt                            \u003d $::nova::params::modular_libvirt,"},{"line_number":282,"context_line":"  $compute_driver                             \u003d \u0027libvirt.LibvirtDriver\u0027,"},{"line_number":283,"context_line":"  $preallocate_images                         \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"62c04c81_a427dca0","line":280,"range":{"start_line":272,"start_character":70,"end_line":280,"end_character":90},"in_reply_to":"9d6269f7_d10264ac","updated":"2021-09-10 09:25:38.000000000","message":"Done","commit_id":"55786df2006dd22dad72f8dfa3e4fa9d8f8f36d7"}],"manifests/compute/libvirt/config.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5baeedfda8dbde527d054ad5e5c4649a1170fad9","unresolved":true,"context_lines":[{"line_number":47,"context_line":"class nova::compute::libvirt::config ("},{"line_number":48,"context_line":"  $libvirtd_config \u003d {},"},{"line_number":49,"context_line":"  $virtlogd_config \u003d {},"},{"line_number":50,"context_line":"  $libvirtd_config        \u003d {},"},{"line_number":51,"context_line":"  $virtnodedevd_config    \u003d {},"},{"line_number":52,"context_line":"  $virtproxyd_config      \u003d {},"},{"line_number":53,"context_line":"  $virtqemud_config       \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"c800f69e_96179ca9","line":50,"range":{"start_line":50,"start_character":3,"end_line":50,"end_character":18},"updated":"2021-05-17 10:41:02.000000000","message":"This is duplicate","commit_id":"d06771250225c71511ef8a1720026acb2169ffd8"}],"manifests/compute/libvirt/params.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2b13523269d88db7735b3bbeb33ca4230d0d714d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: nova::compute::libvirt::params"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# These parameters are used by different libvirt modular"},{"line_number":4,"context_line":"# daemons."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"0ddbb5e4_c3bec76f","line":1,"range":{"start_line":1,"start_character":1,"end_line":1,"end_character":42},"updated":"2021-05-04 10:10:53.000000000","message":"This class includes not only common parameters but also service specific parameters. For example log_filters is supposed to be defined differently and I doubt that some parameters like ovs_timeout is used on all moduels.\nIMO we should avoid having a base class to define common parameters.","commit_id":"7dc15f29cc8128025faa70ac66950d2009cd980d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5baeedfda8dbde527d054ad5e5c4649a1170fad9","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: nova::compute::libvirt::params"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# These parameters are used by different libvirt modular"},{"line_number":4,"context_line":"# daemons."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9c13ad7f_bfd0e947","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":42},"updated":"2021-05-17 10:41:02.000000000","message":"I think this is no longer used ?","commit_id":"d06771250225c71511ef8a1720026acb2169ffd8"}],"manifests/compute/libvirt/services.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b9b6b2e51780b6b955add8be79f1109c98c8168d","unresolved":true,"context_lines":[{"line_number":50,"context_line":"  $virtlock_service_name          \u003d $::nova::params::virtlock_service_name,"},{"line_number":51,"context_line":"  $virtlog_service_name           \u003d $::nova::params::virtlog_service_name,"},{"line_number":52,"context_line":"  $libvirt_virt_type              \u003d \u0027kvm\u0027,"},{"line_number":53,"context_line":"  $enable_modular_libvirt_daemons \u003d $::nova::params::enable_modular_libvirt_daemons,"},{"line_number":54,"context_line":"  $virtsecret_service_name        \u003d $::nova::params::virtsecret_service_name,"},{"line_number":55,"context_line":"  $virtnodedev_service_name       \u003d $::nova::params::virtnodedev_service_name,"},{"line_number":56,"context_line":"  $virtqemu_service_name          \u003d $::nova::params::virtqemu_service_name,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"376279ce_bed85316","line":53,"range":{"start_line":53,"start_character":2,"end_line":53,"end_character":84},"updated":"2021-04-08 06:35:13.000000000","message":"Here enable_modular_libvirt_daemons is configurable but for the other modules, it is not.","commit_id":"a5319e07432150383c02e86031451d98ffa6ccfd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b9b6b2e51780b6b955add8be79f1109c98c8168d","unresolved":true,"context_lines":[{"line_number":146,"context_line":"        name   \u003d\u003e $virtsecret_service_name,"},{"line_number":147,"context_line":"      }"},{"line_number":148,"context_line":"      Package\u003c| name \u003d\u003d \u0027libvirt\u0027 |\u003e -\u003e Service[\u0027virtsecretd\u0027]"},{"line_number":149,"context_line":"      Service[\u0027virtlogd\u0027] -\u003e Service[\u0027virtsecretd\u0027]"},{"line_number":150,"context_line":"    }"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    if $virtnodedev_service_name {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"b27272ee_a1802b24","line":149,"range":{"start_line":149,"start_character":6,"end_line":149,"end_character":51},"updated":"2021-04-08 06:35:13.000000000","message":"We should check $virtlog_service_name .\n\nAlso, could you double check that this dependency is corret for module services ? Don\u0027t we need dependency against livirtd service?","commit_id":"a5319e07432150383c02e86031451d98ffa6ccfd"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"b77ea3e6edfdc65d5a63d8c4de86a7ba0d7a29d5","unresolved":true,"context_lines":[{"line_number":146,"context_line":"        name   \u003d\u003e $virtsecret_service_name,"},{"line_number":147,"context_line":"      }"},{"line_number":148,"context_line":"      Package\u003c| name \u003d\u003d \u0027libvirt\u0027 |\u003e -\u003e Service[\u0027virtsecretd\u0027]"},{"line_number":149,"context_line":"      Service[\u0027virtlogd\u0027] -\u003e Service[\u0027virtsecretd\u0027]"},{"line_number":150,"context_line":"    }"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    if $virtnodedev_service_name {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"6d27282f_6af10eb3","line":149,"range":{"start_line":149,"start_character":6,"end_line":149,"end_character":51},"in_reply_to":"b27272ee_a1802b24","updated":"2021-04-09 10:26:23.000000000","message":"\u003e We should check $virtlog_service_name .\n\u003e \nyes. sure\n\u003e Also, could you double check that this dependency is corret for module services ? Don\u0027t we need dependency against livirtd service?\nNo, we can\u0027t check against libvirtd service, because either deployment have monolithic libvirtd daemon or modular daemons which provides functionality as libvirtd daemon.\nFor info re modular daemons is here [1].\n\n[1] https://libvirt.org/daemons.html","commit_id":"a5319e07432150383c02e86031451d98ffa6ccfd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2b13523269d88db7735b3bbeb33ca4230d0d714d","unresolved":true,"context_lines":[{"line_number":128,"context_line":"      enable \u003d\u003e true,"},{"line_number":129,"context_line":"      name   \u003d\u003e $virtlog_service_name,"},{"line_number":130,"context_line":"    }"},{"line_number":131,"context_line":"    Package\u003c| name \u003d\u003d \u0027libvirt\u0027 |\u003e -\u003e Service[$virtlog_service_name]"},{"line_number":132,"context_line":"  }"},{"line_number":133,"context_line":"  if $libvirt_service_name and $virtlog_service_name {"},{"line_number":134,"context_line":"    Service[$virtlog_service_name] -\u003e Service[\u0027libvirt\u0027]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"0206a89b_1b20dc50","line":131,"range":{"start_line":131,"start_character":47,"end_line":131,"end_character":67},"updated":"2021-05-04 10:10:53.000000000","message":"This should point resource name thus hard-coded \u0027virtlogd\u0027 should be used. Also, it might be more simple to add require \u003d\u003e Package[\u0027libvirt\u0027] when declaring a service resource.","commit_id":"7dc15f29cc8128025faa70ac66950d2009cd980d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2b13523269d88db7735b3bbeb33ca4230d0d714d","unresolved":true,"context_lines":[{"line_number":135,"context_line":"  }"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  if $enable_modular_libvirt_daemons {"},{"line_number":138,"context_line":"    if $virtlog_service_name {"},{"line_number":139,"context_line":"      Package\u003c| name \u003d\u003d \u0027libvirt\u0027 |\u003e -\u003e Service[$virtlog_service_name]"},{"line_number":140,"context_line":"    }"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    if $virtsecret_service_name {"},{"line_number":143,"context_line":"      service { \u0027virtsecretd\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"552a4192_11d43641","line":140,"range":{"start_line":138,"start_character":0,"end_line":140,"end_character":5},"updated":"2021-05-04 10:10:53.000000000","message":"This looks like a duplicate of L131.","commit_id":"7dc15f29cc8128025faa70ac66950d2009cd980d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2b13523269d88db7735b3bbeb33ca4230d0d714d","unresolved":true,"context_lines":[{"line_number":145,"context_line":"        enable \u003d\u003e true,"},{"line_number":146,"context_line":"        name   \u003d\u003e $virtsecret_service_name,"},{"line_number":147,"context_line":"      }"},{"line_number":148,"context_line":"      Package\u003c| name \u003d\u003d \u0027libvirt\u0027 |\u003e -\u003e Service[\u0027virtsecretd\u0027]"},{"line_number":149,"context_line":"      Service[$virtlog_service_name] -\u003e Service[\u0027virtsecretd\u0027]"},{"line_number":150,"context_line":"    }"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"8602e643_bbc02e5a","line":148,"range":{"start_line":148,"start_character":6,"end_line":148,"end_character":62},"updated":"2021-05-04 10:10:53.000000000","message":"libvirt package resource is not declared when libvirt_service_name is false. Maybe it\u0027d be better to put this into the top if block.","commit_id":"7dc15f29cc8128025faa70ac66950d2009cd980d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2b13523269d88db7735b3bbeb33ca4230d0d714d","unresolved":true,"context_lines":[{"line_number":146,"context_line":"        name   \u003d\u003e $virtsecret_service_name,"},{"line_number":147,"context_line":"      }"},{"line_number":148,"context_line":"      Package\u003c| name \u003d\u003d \u0027libvirt\u0027 |\u003e -\u003e Service[\u0027virtsecretd\u0027]"},{"line_number":149,"context_line":"      Service[$virtlog_service_name] -\u003e Service[\u0027virtsecretd\u0027]"},{"line_number":150,"context_line":"    }"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    if $virtnodedev_service_name {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bfa018f3_66eaedc9","line":149,"range":{"start_line":149,"start_character":6,"end_line":149,"end_character":62},"updated":"2021-05-04 10:10:53.000000000","message":"This dependency would fail if virtlog_service_name is not defined, because \u0027virtlogd\u0027 service resource is not declared. we should ensure that virtlogd_service_name is defined.","commit_id":"7dc15f29cc8128025faa70ac66950d2009cd980d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"63531ff87cbd01570cefc8d1c78c8db6c5b2d5f6","unresolved":true,"context_lines":[{"line_number":91,"context_line":"      name   \u003d\u003e $libvirt_package_name_real,"},{"line_number":92,"context_line":"      tag    \u003d\u003e [\u0027openstack\u0027, \u0027nova-support-package\u0027],"},{"line_number":93,"context_line":"    }"},{"line_number":94,"context_line":"    service { \u0027libvirt\u0027 :"},{"line_number":95,"context_line":"      ensure  \u003d\u003e running,"},{"line_number":96,"context_line":"      enable  \u003d\u003e true,"},{"line_number":97,"context_line":"      name    \u003d\u003e $libvirt_service_name,"},{"line_number":98,"context_line":"      require \u003d\u003e Anchor[\u0027nova::install::end\u0027],"},{"line_number":99,"context_line":"    }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    # messagebus"},{"line_number":102,"context_line":"    if($::osfamily \u003d\u003d \u0027RedHat\u0027) {"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"8b9d0be8_1f4754fa","line":99,"range":{"start_line":94,"start_character":0,"end_line":99,"end_character":5},"updated":"2021-09-07 23:27:37.000000000","message":"Do we still need the base libvirt service when modular daemons are used ? This looks conflicting with the change in nova::compute::libvirt which disables logging options when modular_libvirt is true.","commit_id":"060c3368b7972ad60b004a1819d9ace41ff923c5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"08c1cf0bc308fd66666e26a4ec0499132fc9f17d","unresolved":true,"context_lines":[{"line_number":92,"context_line":"      tag    \u003d\u003e [\u0027openstack\u0027, \u0027nova-support-package\u0027],"},{"line_number":93,"context_line":"    }"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    if !$modular_libvirt {"},{"line_number":96,"context_line":"      service { \u0027libvirt\u0027 :"},{"line_number":97,"context_line":"        ensure  \u003d\u003e running,"},{"line_number":98,"context_line":"        enable  \u003d\u003e true,"},{"line_number":99,"context_line":"        name    \u003d\u003e $libvirt_service_name,"},{"line_number":100,"context_line":"        require \u003d\u003e Anchor[\u0027nova::install::end\u0027],"},{"line_number":101,"context_line":"      }"},{"line_number":102,"context_line":"    }"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    # messagebus"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"3861a412_6ecdf2ca","line":101,"range":{"start_line":95,"start_character":0,"end_line":101,"end_character":7},"updated":"2021-09-10 00:16:03.000000000","message":"Do we expect both modular services and the single libvirt service are provided by libvirt rpm in a future libvirt package ? If so, we should stop libvirt service here instead of skipping the resource.","commit_id":"55786df2006dd22dad72f8dfa3e4fa9d8f8f36d7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1e18edcbb6a2de7fa082f68d7ee9996ea1741a3a","unresolved":true,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    # Stop and disable libvirt service when modular_libvirt is enabled"},{"line_number":96,"context_line":"    if $modular_libvirt {"},{"line_number":97,"context_line":"      $ensure_real \u003d \u0027stopped\u0027"},{"line_number":98,"context_line":"      $enable_real \u003d false"},{"line_number":99,"context_line":"    } else {"},{"line_number":100,"context_line":"      $ensure_real \u003d \u0027running\u0027"}],"source_content_type":"text/x-puppet","patch_set":36,"id":"129a377a_fb38ad47","line":97,"range":{"start_line":97,"start_character":7,"end_line":97,"end_character":18},"updated":"2021-09-22 00:08:09.000000000","message":"Can we name this as libvirt_service_ensure_real ?","commit_id":"071d1847bb6e3b64677a8b91a3cf80be799f6350"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"64a1407ba33c4508d9bc6ba646d8edca1a307970","unresolved":true,"context_lines":[{"line_number":115,"context_line":"        enable \u003d\u003e true,"},{"line_number":116,"context_line":"        name   \u003d\u003e $::nova::params::messagebus_service_name,"},{"line_number":117,"context_line":"      }"},{"line_number":118,"context_line":"      Package[\u0027libvirt\u0027] -\u003e Service[\u0027messagebus\u0027] -\u003e Service[\u0027libvirt\u0027]"},{"line_number":119,"context_line":"    }"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    # when nova-compute \u0026 libvirt run together"}],"source_content_type":"text/x-puppet","patch_set":36,"id":"3b5fde82_859a8e16","line":118,"range":{"start_line":118,"start_character":53,"end_line":118,"end_character":71},"updated":"2021-09-22 02:55:12.000000000","message":"IIUC we need a dependency for modular daemon here.","commit_id":"071d1847bb6e3b64677a8b91a3cf80be799f6350"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"64a1407ba33c4508d9bc6ba646d8edca1a307970","unresolved":true,"context_lines":[{"line_number":119,"context_line":"    }"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    # when nova-compute \u0026 libvirt run together"},{"line_number":122,"context_line":"    Service[\u0027libvirt\u0027] -\u003e Service\u003c| title \u003d\u003d \u0027nova-compute\u0027|\u003e"},{"line_number":123,"context_line":"  }"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":36,"id":"17a03086_e2c6fe33","line":122,"range":{"start_line":122,"start_character":4,"end_line":122,"end_character":61},"updated":"2021-09-22 02:55:12.000000000","message":"This should be updated as well.","commit_id":"071d1847bb6e3b64677a8b91a3cf80be799f6350"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b7699c08e21c0a55095b8b3e34e4b4c81f508ff6","unresolved":true,"context_lines":[{"line_number":122,"context_line":"    Service[\u0027libvirt\u0027] -\u003e Service\u003c| title \u003d\u003d \u0027nova-compute\u0027|\u003e"},{"line_number":123,"context_line":"  }"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"  if $modular_libvirt {"},{"line_number":127,"context_line":"    [\u0027qemu\u0027, \u0027secret\u0027, \u0027storage\u0027, \u0027nodedev\u0027].each |String $daemon| {"},{"line_number":128,"context_line":"      package { \"virt${daemon}\":"},{"line_number":129,"context_line":"        ensure \u003d\u003e present,"},{"line_number":130,"context_line":"        name   \u003d\u003e \"${::nova::params::libvirt_daemon_package_prefix}driver-${daemon}\""},{"line_number":131,"context_line":"      }"},{"line_number":132,"context_line":"    }"},{"line_number":133,"context_line":"  }"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"  if $virtlock_service_name {"},{"line_number":136,"context_line":"    service { \u0027virtlockd\u0027:"}],"source_content_type":"text/x-puppet","patch_set":36,"id":"b70c4057_8848bca2","line":133,"range":{"start_line":125,"start_character":0,"end_line":133,"end_character":3},"updated":"2021-09-22 03:21:07.000000000","message":"To follow the existing implementation, package should be installed only when service name is defined.","commit_id":"071d1847bb6e3b64677a8b91a3cf80be799f6350"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"64a1407ba33c4508d9bc6ba646d8edca1a307970","unresolved":true,"context_lines":[{"line_number":149,"context_line":"    }"},{"line_number":150,"context_line":"    Package\u003c| name \u003d\u003d \u0027libvirt\u0027 |\u003e -\u003e Service[\u0027virtlogd\u0027]"},{"line_number":151,"context_line":"  }"},{"line_number":152,"context_line":"  if $libvirt_service_name and $virtlog_service_name {"},{"line_number":153,"context_line":"    Service[\u0027virtlogd\u0027] -\u003e Service[\u0027libvirt\u0027]"},{"line_number":154,"context_line":"  }"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"  if $modular_libvirt {"},{"line_number":157,"context_line":"    if $virtsecret_service_name {"}],"source_content_type":"text/x-puppet","patch_set":36,"id":"1ebfa329_3f9bae7b","line":154,"range":{"start_line":152,"start_character":0,"end_line":154,"end_character":3},"updated":"2021-09-22 02:55:12.000000000","message":"This should be disabled when modular_libvirt is true.\nAlso, we need a proper dependency to stop libvirt service before starting each modular daemons.\nOne idea here is to define something like\n\nif $modular_libvirt {\n  Service\u003c| name \u003d\u003d \u0027libvirt\u0027 |\u003e -\u003e Service\u003c| name \u003d\u003d \u0027virtlogd\u0027 |\u003e\n} else {\n  Service\u003c| name \u003d\u003d \u0027virtlogd\u0027 |\u003e -\u003e Service\u003c| name \u003d\u003d \u0027libvirt\u0027 |\u003e\n}\n\nWhen modular_libvirt is enabled libvirt is stopped before virtlogd. The other modular daemons are started after virtlogd. When modular_libvirt is false then we expect the same dependency.","commit_id":"071d1847bb6e3b64677a8b91a3cf80be799f6350"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1e18edcbb6a2de7fa082f68d7ee9996ea1741a3a","unresolved":true,"context_lines":[{"line_number":159,"context_line":"        ensure  \u003d\u003e running,"},{"line_number":160,"context_line":"        enable  \u003d\u003e true,"},{"line_number":161,"context_line":"        name    \u003d\u003e $virtsecret_service_name,"},{"line_number":162,"context_line":"        require \u003d\u003e Package[\u0027libvirt\u0027],"},{"line_number":163,"context_line":"      }"},{"line_number":164,"context_line":"      Service[\u0027virtlogd\u0027] -\u003e Service[\u0027virtsecretd\u0027]"},{"line_number":165,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":36,"id":"602f2d8b_07daffe4","line":162,"range":{"start_line":162,"start_character":28,"end_line":162,"end_character":35},"updated":"2021-09-22 00:08:09.000000000","message":"This should be updated to point the sub package.","commit_id":"071d1847bb6e3b64677a8b91a3cf80be799f6350"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1e18edcbb6a2de7fa082f68d7ee9996ea1741a3a","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        name    \u003d\u003e $virtsecret_service_name,"},{"line_number":162,"context_line":"        require \u003d\u003e Package[\u0027libvirt\u0027],"},{"line_number":163,"context_line":"      }"},{"line_number":164,"context_line":"      Service[\u0027virtlogd\u0027] -\u003e Service[\u0027virtsecretd\u0027]"},{"line_number":165,"context_line":"    }"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    if $virtnodedev_service_name {"}],"source_content_type":"text/x-puppet","patch_set":36,"id":"ec5cb07f_103be6d2","line":164,"range":{"start_line":164,"start_character":6,"end_line":164,"end_character":25},"updated":"2021-09-22 00:08:09.000000000","message":"Use Service\u003c| name \u003d\u003d \u0027virtlogd\u0027 |\u003e instead, to avoid missing resource error when virtlog service name is undef.","commit_id":"071d1847bb6e3b64677a8b91a3cf80be799f6350"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"605875a4159fc89ddca7f0ba0ef2c5d3257f5424","unresolved":true,"context_lines":[{"line_number":125,"context_line":"      enable \u003d\u003e true,"},{"line_number":126,"context_line":"      name   \u003d\u003e $virtlock_service_name,"},{"line_number":127,"context_line":"    }"},{"line_number":128,"context_line":"    Package\u003c| title \u003d\u003d \u0027libvirt\u0027 |\u003e -\u003e Service[\u0027virtlockd\u0027]"},{"line_number":129,"context_line":"  }"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  if $virtlog_service_name {"}],"source_content_type":"text/x-puppet","patch_set":39,"id":"1b15795a_db3cfecf","line":128,"updated":"2021-09-28 13:55:55.000000000","message":"bugfix?","commit_id":"6069bbfa1677cbadcf1bd95e3d3ca4abe8694054"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"605875a4159fc89ddca7f0ba0ef2c5d3257f5424","unresolved":true,"context_lines":[{"line_number":134,"context_line":"      enable \u003d\u003e true,"},{"line_number":135,"context_line":"      name   \u003d\u003e $virtlog_service_name,"},{"line_number":136,"context_line":"    }"},{"line_number":137,"context_line":"    Package\u003c| title \u003d\u003d \u0027libvirt\u0027 |\u003e -\u003e Service[\u0027virtlogd\u0027]"},{"line_number":138,"context_line":"  }"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  if ! $modular_libvirt {"}],"source_content_type":"text/x-puppet","patch_set":39,"id":"2bb7c073_5807a069","line":137,"updated":"2021-09-28 13:55:55.000000000","message":"bugfix?","commit_id":"6069bbfa1677cbadcf1bd95e3d3ca4abe8694054"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8ef25b93ae927e3155d289e81187e38a71990bae","unresolved":true,"context_lines":[{"line_number":151,"context_line":"    Service\u003c| title \u003d\u003d \u0027messagebus\u0027 |\u003e -\u003e Service\u003c| tag \u003d\u003d \u0027libvirt-modular-service\u0027 |\u003e"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    Service\u003c| title \u003d\u003d \u0027virtlogd\u0027 |\u003e"},{"line_number":154,"context_line":"    -\u003e Service\u003c| tag \u003d\u003d \u0027libvirt-modular-service\u0027 |\u003e"},{"line_number":155,"context_line":"    -\u003e Service\u003c| title \u003d\u003d \u0027nova-compute\u0027|\u003e"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    if $virtsecret_service_name {"}],"source_content_type":"text/x-puppet","patch_set":39,"id":"4659cc6f_d06e35a3","line":154,"updated":"2021-09-22 09:46:39.000000000","message":"nice trick with tags","commit_id":"6069bbfa1677cbadcf1bd95e3d3ca4abe8694054"}],"manifests/compute/libvirt/virtlogd.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"63531ff87cbd01570cefc8d1c78c8db6c5b2d5f6","unresolved":true,"context_lines":[{"line_number":64,"context_line":"  }"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"  virtlogd_config {"},{"line_number":67,"context_line":"    \u0027log_level\u0027:         value \u003d\u003e $log_level;"},{"line_number":68,"context_line":"    \u0027log_filters\u0027:       value \u003d\u003e $log_filters, quote \u003d\u003e true;"},{"line_number":69,"context_line":"    \u0027log_outputs\u0027:       value \u003d\u003e $log_outputs, quote \u003d\u003e true;"},{"line_number":70,"context_line":"    \u0027max_clients\u0027:       value \u003d\u003e $max_clients;"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"11752e9e_84cb13ab","line":67,"range":{"start_line":67,"start_character":4,"end_line":67,"end_character":45},"updated":"2021-09-07 23:27:37.000000000","message":"Usage of pick in this virtlogd manifest and libvirt manifest is intentional because we recently updated parameter defaults from undef to $::os_service_default. So the change in this manifest and libvirt manifest should be reverted.\nThe new manifests doesn\u0027t require this pick.","commit_id":"060c3368b7972ad60b004a1819d9ace41ff923c5"}],"manifests/compute/libvirt/virtnodedevd.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b9b6b2e51780b6b955add8be79f1109c98c8168d","unresolved":true,"context_lines":[{"line_number":36,"context_line":"  $log_level         \u003d undef,"},{"line_number":37,"context_line":"  $log_filters       \u003d undef,"},{"line_number":38,"context_line":"  $log_outputs       \u003d undef,"},{"line_number":39,"context_line":"  $max_clients       \u003d undef,"},{"line_number":40,"context_line":"  $admin_max_clients \u003d undef,"},{"line_number":41,"context_line":"  $ovs_timeout       \u003d undef,"},{"line_number":42,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"59863385_3f8ff69e","line":39,"updated":"2021-04-08 06:35:13.000000000","message":"Please review available parameters.","commit_id":"a5319e07432150383c02e86031451d98ffa6ccfd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b9b6b2e51780b6b955add8be79f1109c98c8168d","unresolved":true,"context_lines":[{"line_number":44,"context_line":"  include nova::deps"},{"line_number":45,"context_line":"  require nova::compute::libvirt"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  if $log_level {"},{"line_number":48,"context_line":"    virtnodedevd_config {"},{"line_number":49,"context_line":"      \u0027log_level\u0027: value \u003d\u003e $log_level;"},{"line_number":50,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ebd97aa2_5d8e5ecc","line":47,"range":{"start_line":47,"start_character":2,"end_line":47,"end_character":17},"updated":"2021-04-08 06:35:13.000000000","message":"It might make sense to create a base definition for log parameters, if we expec same set of parameters.","commit_id":"a5319e07432150383c02e86031451d98ffa6ccfd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2b4eee3e28f3fa302e9022ad60f84c7cac1923dd","unresolved":true,"context_lines":[{"line_number":45,"context_line":"  require nova::compute::libvirt"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  virtnodedevd_config {"},{"line_number":48,"context_line":"    \u0027log_level\u0027:         value \u003d\u003e pick($log_level, $::os_service_default);"},{"line_number":49,"context_line":"    \u0027log_filters\u0027:       value \u003d\u003e pick($log_filters, $::os_service_default), quote \u003d\u003e true;"},{"line_number":50,"context_line":"    \u0027log_outputs\u0027:       value \u003d\u003e pick($log_outputs, $::os_service_default), quote \u003d\u003e true;"},{"line_number":51,"context_line":"    \u0027max_clients\u0027:       value \u003d\u003e pick($max_clients, $::os_service_default);"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"c5bca3d0_ee3ae6d1","line":48,"range":{"start_line":48,"start_character":34,"end_line":48,"end_character":73},"updated":"2021-09-04 15:37:33.000000000","message":"you don\u0027t need pick here. (Please fix this in all lines, all files)","commit_id":"1fd6ae4a2615d8e2a7cabee4f61ffcf84fb2148b"}],"manifests/compute/libvirt/virtnodedevd/config.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b9b6b2e51780b6b955add8be79f1109c98c8168d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: nova::compute::libvirt::virtnodedevd::config"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# This class is used to manage arbitrary virtnodedevd configurations."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bd06f892_e9228095","line":1,"updated":"2021-04-08 06:35:13.000000000","message":"I initially created an independent class for virtlogd because I didn\u0027t expect so many services are added later, but if we have multiple services then it would be more easy to add this into as single nova::compute::libvirt::config, assuming that we don\u0027t expect services are placed in different nodes.","commit_id":"a5319e07432150383c02e86031451d98ffa6ccfd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2b5befb0ac6af63bc3b1ca762a832339fcc9239d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: nova::compute::libvirt::virtnodedevd::config"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# This class is used to manage arbitrary virtnodedevd configurations."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"cb13bfc8_1c5f4b4a","line":1,"in_reply_to":"bd06f892_e9228095","updated":"2021-04-25 13:26:25.000000000","message":"See this https://review.opendev.org/c/openstack/puppet-nova/+/787884","commit_id":"a5319e07432150383c02e86031451d98ffa6ccfd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5513a7587152d77f09e582aa91806b4153ba1a88","unresolved":true,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"# \u003d\u003d Class: nova::compute::libvirt::virtnodedevd::config"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# This class is used to manage arbitrary virtnodedevd configurations."},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"008568c7_4df49bed","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":56},"updated":"2021-05-17 10:24:54.000000000","message":"You no longer need this since the same parameter has been implemented in nova::compute::libvirt::config .","commit_id":"d06771250225c71511ef8a1720026acb2169ffd8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bf975bca947734a78642dc983709147f32594eac","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"12439222_8a2a15fb","updated":"2021-06-22 11:38:28.000000000","message":"We can remove these indivisual config.pp because all are merged into the base nova::compute::libvirt::config","commit_id":"5b42da116c2102c326bbdcdb9159a84f3b3029fe"}],"manifests/migration/libvirt.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2b13523269d88db7735b3bbeb33ca4230d0d714d","unresolved":true,"context_lines":[{"line_number":210,"context_line":"  }"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"  if $configure_libvirt {"},{"line_number":213,"context_line":"    if ! $enable_modular_libvirt_daemons {"},{"line_number":214,"context_line":"      Anchor[\u0027nova::config::begin\u0027]"},{"line_number":215,"context_line":"      -\u003e Libvirtd_config\u003c||\u003e"},{"line_number":216,"context_line":"      -\u003e File_line\u003c| tag \u003d\u003d \u0027libvirt-file_line\u0027|\u003e"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5418fc98_e61151dc","line":213,"range":{"start_line":213,"start_character":10,"end_line":213,"end_character":40},"updated":"2021-05-04 10:10:53.000000000","message":"This parameter is not declared.","commit_id":"7dc15f29cc8128025faa70ac66950d2009cd980d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2b13523269d88db7735b3bbeb33ca4230d0d714d","unresolved":true,"context_lines":[{"line_number":293,"context_line":"      }"},{"line_number":294,"context_line":"    }"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    if ! $enable_modular_libvirt_daemons {"},{"line_number":297,"context_line":"      libvirtd_config {"},{"line_number":298,"context_line":"        \u0027listen_tls\u0027: value \u003d\u003e $listen_tls;"},{"line_number":299,"context_line":"        \u0027listen_tcp\u0027: value \u003d\u003e $listen_tcp;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ea373298_b83d43bb","line":296,"range":{"start_line":296,"start_character":0,"end_line":296,"end_character":42},"updated":"2021-05-04 10:10:53.000000000","message":"The following implementation can be simplified using create_resources.\n\n```\n$resource_name \u003d $enable_modular_libvirt_daemons ? {\n  true    \u003d\u003e \u0027virtproxyd_config\u0027\n  default \u003d\u003e \u0027libvirtd_config\u0027\n}\n\n$listen_opts \u003d {\n    \u0027listen_tls\u0027: value \u003d\u003e $listen_tls;\n    \u0027listen_tcp\u0027: value \u003d\u003e $listen_tcp;\n}\n\n...\n\n$listen_addr_opt \u003d $listen_address ? {\n  true    \u003d\u003e {\u0027listen_addr\u0027 \u003d\u003e { \u0027vaue\u0027 \u003d\u003e \"\\\"${listen_address}\\\"\"}}\n  default \u003d\u003e {}\n}\n\n$opts \u003d merge($listen_opts, ..., $listen_addr_opt)\ncreate_resources($resource_name, $opts)\n```","commit_id":"7dc15f29cc8128025faa70ac66950d2009cd980d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2b13523269d88db7735b3bbeb33ca4230d0d714d","unresolved":true,"context_lines":[{"line_number":324,"context_line":"          \u0027listen_addr\u0027: value \u003d\u003e \"\\\"${listen_address}\\\"\";"},{"line_number":325,"context_line":"        }"},{"line_number":326,"context_line":"      }"},{"line_number":327,"context_line":"    } else {"},{"line_number":328,"context_line":"      virtproxyd_config {"},{"line_number":329,"context_line":"        \u0027listen_tls\u0027: value \u003d\u003e $listen_tls;"},{"line_number":330,"context_line":"        \u0027listen_tcp\u0027: value \u003d\u003e $listen_tcp;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"0dc3a460_a584205c","line":327,"range":{"start_line":327,"start_character":6,"end_line":327,"end_character":10},"updated":"2021-05-04 10:10:53.000000000","message":"Should we also check virtproxy_service_name ?\nAnother option would be to enforce separate service names when enable_modular_libvirt_daemons is true.","commit_id":"7dc15f29cc8128025faa70ac66950d2009cd980d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5513a7587152d77f09e582aa91806b4153ba1a88","unresolved":true,"context_lines":[{"line_number":149,"context_line":"  $ca_file                             \u003d undef,"},{"line_number":150,"context_line":"  $crl_file                            \u003d undef,"},{"line_number":151,"context_line":"  $libvirt_version                     \u003d $::nova::compute::libvirt::version::default,"},{"line_number":152,"context_line":"  $enable_modular_libvirt_daemons      \u003d $::nova::params::enable_modular_libvirt_daemons,"},{"line_number":153,"context_line":") inherits nova::compute::libvirt::version {"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"  include nova::deps"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"e47714a6_68ca6602","line":152,"range":{"start_line":152,"start_character":41,"end_line":152,"end_character":88},"updated":"2021-05-17 10:24:54.000000000","message":"You can\u0027t use this because this class doesn\u0027t inherit nova::params.\n\nAlternative approach would be make this class inherit nova::params and update default of libvirt_version like;\n\n\n```\nclass nova::migration::libvirt(\n  ...\n  $libvirt_version                     \u003d undef,\n  $enable_modular_libvirt_daemons      \u003d $::nova::params::enable_modular_libvirt_daemons,\n) inherits nova::params {\n\n  include nova::compute::libvirt::version\n  $libvirt_version_real \u003d pick($libvirt_version, $::nova::compute::libvirt::version::default)\n  ...\n}\n```","commit_id":"d06771250225c71511ef8a1720026acb2169ffd8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5513a7587152d77f09e582aa91806b4153ba1a88","unresolved":true,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"  if $configure_libvirt {"},{"line_number":219,"context_line":"    if ! $enable_modular_libvirt_daemons {"},{"line_number":220,"context_line":"      Anchor[\u0027nova::config::begin\u0027]"},{"line_number":221,"context_line":"      -\u003e Libvirtd_config\u003c||\u003e"},{"line_number":222,"context_line":"      -\u003e File_line\u003c| tag \u003d\u003d \u0027libvirt-file_line\u0027|\u003e"},{"line_number":223,"context_line":"      -\u003e Anchor[\u0027nova::config::end\u0027]"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"      Libvirtd_config\u003c||\u003e"},{"line_number":226,"context_line":"      ~\u003e Service[\u0027libvirt\u0027]"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"      File_line\u003c| tag \u003d\u003d \u0027libvirt-file_line\u0027 |\u003e"},{"line_number":229,"context_line":"      ~\u003e Service[\u0027libvirt\u0027]"},{"line_number":230,"context_line":"    }"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    if $override_uuid {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"cf6d8d13_f61e4bc9","line":229,"range":{"start_line":220,"start_character":0,"end_line":229,"end_character":27},"updated":"2021-05-17 10:24:54.000000000","message":"We shouldn\u0027t skip these because this is only place where relationship among config anchors, service anchors and Libvirtd_config is defined.","commit_id":"d06771250225c71511ef8a1720026acb2169ffd8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5513a7587152d77f09e582aa91806b4153ba1a88","unresolved":true,"context_lines":[{"line_number":317,"context_line":"               \u0027crl_file\u0027 \u003d $crl_file ? {"},{"line_number":318,"context_line":"                 true \u003d\u003e {\u0027value\u0027 \u003d\u003e \"\\\"${crl_file}\\\"\"}"},{"line_number":319,"context_line":"                 default \u003d\u003e {}};"},{"line_number":320,"context_line":"}"},{"line_number":321,"context_line":"      \u0027tcp\u0027 \u003d\u003e {\u0027auth_tcp\u0027: {\u0027value\u0027 \u003d\u003e \"\\\"${auth}\\\"\"}}"},{"line_number":322,"context_line":"      default \u003d\u003e {}"},{"line_number":323,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"66a29b55_f33a5804","line":320,"range":{"start_line":320,"start_character":0,"end_line":320,"end_character":1},"updated":"2021-05-17 10:24:54.000000000","message":"It\u0027d be better to put this to end of the previous line.","commit_id":"d06771250225c71511ef8a1720026acb2169ffd8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2b4eee3e28f3fa302e9022ad60f84c7cac1923dd","unresolved":true,"context_lines":[{"line_number":149,"context_line":"  $ca_file                             \u003d $::os_service_default,"},{"line_number":150,"context_line":"  $crl_file                            \u003d $::os_service_default,"},{"line_number":151,"context_line":"  $libvirt_version                     \u003d $::nova::compute::libvirt::version::default,"},{"line_number":152,"context_line":"  $modular_libvirt                     \u003d $::nova::params::modular_libvirt,"},{"line_number":153,"context_line":") inherits nova::compute::libvirt::version {"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"  include nova::deps"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"39d90b36_cc5fc116","line":152,"range":{"start_line":152,"start_character":41,"end_line":152,"end_character":73},"updated":"2021-09-04 15:37:33.000000000","message":"This doesn\u0027t work unless this class inherits the nova::params class.\nOne option is to default this to undef, and pick nova::params::modular_libvirt when the parameter is undef.","commit_id":"1fd6ae4a2615d8e2a7cabee4f61ffcf84fb2148b"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"128c58f36909a63d13683c2ee66daf108bf6ab23","unresolved":false,"context_lines":[{"line_number":149,"context_line":"  $ca_file                             \u003d $::os_service_default,"},{"line_number":150,"context_line":"  $crl_file                            \u003d $::os_service_default,"},{"line_number":151,"context_line":"  $libvirt_version                     \u003d $::nova::compute::libvirt::version::default,"},{"line_number":152,"context_line":"  $modular_libvirt                     \u003d $::nova::params::modular_libvirt,"},{"line_number":153,"context_line":") inherits nova::compute::libvirt::version {"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"  include nova::deps"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"638c6659_79acf1e1","line":152,"range":{"start_line":152,"start_character":41,"end_line":152,"end_character":73},"in_reply_to":"39d90b36_cc5fc116","updated":"2021-09-06 10:20:29.000000000","message":"Done","commit_id":"1fd6ae4a2615d8e2a7cabee4f61ffcf84fb2148b"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c2d403f7b72a1d906db53b5fae522cced7d0fe7e","unresolved":true,"context_lines":[{"line_number":253,"context_line":"          require \u003d\u003e Package[\u0027libvirt\u0027],"},{"line_number":254,"context_line":"        }"},{"line_number":255,"context_line":"      } else {"},{"line_number":256,"context_line":"        augeas { \u0027virtqemu-conf-uuid\u0027:"},{"line_number":257,"context_line":"          context \u003d\u003e \u0027/files/etc/libvirt/virtqemud.conf\u0027,"},{"line_number":258,"context_line":"          changes \u003d\u003e ["},{"line_number":259,"context_line":"            \"set host_uuid ${host_uuid_real}\","},{"line_number":260,"context_line":"          ],"},{"line_number":261,"context_line":"          notify  \u003d\u003e Service[\u0027virtqemud\u0027],"},{"line_number":262,"context_line":"          require \u003d\u003e Package[\u0027libvirt\u0027],"},{"line_number":263,"context_line":"        }"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        augeas { \u0027virtproxy-conf-uuid\u0027:"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"09b62af1_4e342c5e","line":262,"range":{"start_line":256,"start_character":0,"end_line":262,"end_character":40},"updated":"2021-09-07 13:13:14.000000000","message":"nit: in a follow-up maybe, please consider dedup some of the lines, by moving it out into the manifest global setting:\n\nAugeas {\n  changes \u003d\u003e [\"set host_uuid ${host_uuid_real}\"],\n  require \u003d\u003e Package[\u0027libvirt\u0027],\n}","commit_id":"060c3368b7972ad60b004a1819d9ace41ff923c5"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"c7ec16fcf34f373f782e26788f3c8e7a4061a9f2","unresolved":false,"context_lines":[{"line_number":253,"context_line":"          require \u003d\u003e Package[\u0027libvirt\u0027],"},{"line_number":254,"context_line":"        }"},{"line_number":255,"context_line":"      } else {"},{"line_number":256,"context_line":"        augeas { \u0027virtqemu-conf-uuid\u0027:"},{"line_number":257,"context_line":"          context \u003d\u003e \u0027/files/etc/libvirt/virtqemud.conf\u0027,"},{"line_number":258,"context_line":"          changes \u003d\u003e ["},{"line_number":259,"context_line":"            \"set host_uuid ${host_uuid_real}\","},{"line_number":260,"context_line":"          ],"},{"line_number":261,"context_line":"          notify  \u003d\u003e Service[\u0027virtqemud\u0027],"},{"line_number":262,"context_line":"          require \u003d\u003e Package[\u0027libvirt\u0027],"},{"line_number":263,"context_line":"        }"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        augeas { \u0027virtproxy-conf-uuid\u0027:"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"0a3ebf00_e2c3e8a7","line":262,"range":{"start_line":256,"start_character":0,"end_line":262,"end_character":40},"in_reply_to":"09b62af1_4e342c5e","updated":"2021-09-09 11:00:15.000000000","message":"Done","commit_id":"060c3368b7972ad60b004a1819d9ace41ff923c5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"63531ff87cbd01570cefc8d1c78c8db6c5b2d5f6","unresolved":true,"context_lines":[{"line_number":329,"context_line":"    }"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    if ! $modular_libvirt_real {"},{"line_number":332,"context_line":"      libvirtd_config {"},{"line_number":333,"context_line":"        \u0027listen_tls\u0027:  value \u003d\u003e $listen_tls;"},{"line_number":334,"context_line":"        \u0027listen_tcp\u0027:  value \u003d\u003e $listen_tcp;"},{"line_number":335,"context_line":"        \u0027auth_tls\u0027:    value \u003d\u003e $auth_tls_real, quote \u003d\u003e true;"},{"line_number":336,"context_line":"        \u0027auth_tcp\u0027:    value \u003d\u003e $auth_tcp_real, quote \u003d\u003e true;"},{"line_number":337,"context_line":"        \u0027ca_file\u0027:     value \u003d\u003e $ca_file_real, quote \u003d\u003e true;"},{"line_number":338,"context_line":"        \u0027crl_file\u0027:    value \u003d\u003e $crl_file_real, quote \u003d\u003e true;"},{"line_number":339,"context_line":"        \u0027listen_addr\u0027: value \u003d\u003e pick($listen_address, $::os_service_default), quote \u003d\u003e true;"},{"line_number":340,"context_line":"      }"},{"line_number":341,"context_line":"    } else {"},{"line_number":342,"context_line":"      virtproxyd_config {"},{"line_number":343,"context_line":"        \u0027listen_tls\u0027:  value \u003d\u003e $listen_tls;"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"a9f4bc23_987e83a0","line":340,"range":{"start_line":332,"start_character":0,"end_line":340,"end_character":7},"updated":"2021-09-07 23:27:37.000000000","message":"(low prio) Because the parameters are same for these two, you can use ensure_resources + hash of parameters to make this more simple.\n\n\n$listen_opts \u003d {\n  \u0027listen_tls\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e $listen_tls },\n  ...\n}\n\nif ! modular_libvirt_real {\n  create_resources(\u0027libvirtd_config\u0027, $listen_opts)\n} else {\n  create_resources(\u0027virtproxyd_config\u0027, $listen_opts)\n}","commit_id":"060c3368b7972ad60b004a1819d9ace41ff923c5"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"c7ec16fcf34f373f782e26788f3c8e7a4061a9f2","unresolved":true,"context_lines":[{"line_number":329,"context_line":"    }"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    if ! $modular_libvirt_real {"},{"line_number":332,"context_line":"      libvirtd_config {"},{"line_number":333,"context_line":"        \u0027listen_tls\u0027:  value \u003d\u003e $listen_tls;"},{"line_number":334,"context_line":"        \u0027listen_tcp\u0027:  value \u003d\u003e $listen_tcp;"},{"line_number":335,"context_line":"        \u0027auth_tls\u0027:    value \u003d\u003e $auth_tls_real, quote \u003d\u003e true;"},{"line_number":336,"context_line":"        \u0027auth_tcp\u0027:    value \u003d\u003e $auth_tcp_real, quote \u003d\u003e true;"},{"line_number":337,"context_line":"        \u0027ca_file\u0027:     value \u003d\u003e $ca_file_real, quote \u003d\u003e true;"},{"line_number":338,"context_line":"        \u0027crl_file\u0027:    value \u003d\u003e $crl_file_real, quote \u003d\u003e true;"},{"line_number":339,"context_line":"        \u0027listen_addr\u0027: value \u003d\u003e pick($listen_address, $::os_service_default), quote \u003d\u003e true;"},{"line_number":340,"context_line":"      }"},{"line_number":341,"context_line":"    } else {"},{"line_number":342,"context_line":"      virtproxyd_config {"},{"line_number":343,"context_line":"        \u0027listen_tls\u0027:  value \u003d\u003e $listen_tls;"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"8f3b2753_ec18a867","line":340,"range":{"start_line":332,"start_character":0,"end_line":340,"end_character":7},"in_reply_to":"a9f4bc23_987e83a0","updated":"2021-09-09 11:00:15.000000000","message":"I made this modification in earlier patch-set [1] as per your comment, but during testing I was getting some error, that\u0027s why I reverted it to make if-else condition.\n\n[1] https://review.opendev.org/c/openstack/puppet-nova/+/785305/6/manifests/migration/libvirt.pp\n\n[2] puppet-user: Error: Evaluation Error: Error while evaluating a Function Call, no implicit conversion of String into Hash (file: /etc/puppet/modules/nova/manifests/migration/libvirt.pp, line: 331, column: 5) on node overcloud-novacompute-1.localdomain\n\nIt was long back, so I don\u0027t have all the logs.","commit_id":"060c3368b7972ad60b004a1819d9ace41ff923c5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c2d403f7b72a1d906db53b5fae522cced7d0fe7e","unresolved":true,"context_lines":[{"line_number":339,"context_line":"        \u0027listen_addr\u0027: value \u003d\u003e pick($listen_address, $::os_service_default), quote \u003d\u003e true;"},{"line_number":340,"context_line":"      }"},{"line_number":341,"context_line":"    } else {"},{"line_number":342,"context_line":"      virtproxyd_config {"},{"line_number":343,"context_line":"        \u0027listen_tls\u0027:  value \u003d\u003e $listen_tls;"},{"line_number":344,"context_line":"        \u0027listen_tcp\u0027:  value \u003d\u003e $listen_tcp;"},{"line_number":345,"context_line":"        \u0027auth_tls\u0027:    value \u003d\u003e $auth_tls_real, quote \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"e2fe27e5_6fb5e00d","line":342,"updated":"2021-09-07 13:13:14.000000000","message":"isn\u0027t this also needed for the compute manifest?","commit_id":"060c3368b7972ad60b004a1819d9ace41ff923c5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2fa669c1f2543d3b1a7a6d8bb32c9cf3f2b87b85","unresolved":true,"context_lines":[{"line_number":339,"context_line":"        \u0027listen_addr\u0027: value \u003d\u003e pick($listen_address, $::os_service_default), quote \u003d\u003e true;"},{"line_number":340,"context_line":"      }"},{"line_number":341,"context_line":"    } else {"},{"line_number":342,"context_line":"      virtproxyd_config {"},{"line_number":343,"context_line":"        \u0027listen_tls\u0027:  value \u003d\u003e $listen_tls;"},{"line_number":344,"context_line":"        \u0027listen_tcp\u0027:  value \u003d\u003e $listen_tcp;"},{"line_number":345,"context_line":"        \u0027auth_tls\u0027:    value \u003d\u003e $auth_tls_real, quote \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"235376d9_756ead45","line":342,"in_reply_to":"21fed4f4_00ee668a","updated":"2021-09-17 10:05:01.000000000","message":"ack, thanks! now it looks consistent across both compute and migration manifests","commit_id":"060c3368b7972ad60b004a1819d9ace41ff923c5"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"c7ec16fcf34f373f782e26788f3c8e7a4061a9f2","unresolved":true,"context_lines":[{"line_number":339,"context_line":"        \u0027listen_addr\u0027: value \u003d\u003e pick($listen_address, $::os_service_default), quote \u003d\u003e true;"},{"line_number":340,"context_line":"      }"},{"line_number":341,"context_line":"    } else {"},{"line_number":342,"context_line":"      virtproxyd_config {"},{"line_number":343,"context_line":"        \u0027listen_tls\u0027:  value \u003d\u003e $listen_tls;"},{"line_number":344,"context_line":"        \u0027listen_tcp\u0027:  value \u003d\u003e $listen_tcp;"},{"line_number":345,"context_line":"        \u0027auth_tls\u0027:    value \u003d\u003e $auth_tls_real, quote \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"21fed4f4_00ee668a","line":342,"in_reply_to":"e2fe27e5_6fb5e00d","updated":"2021-09-09 11:00:15.000000000","message":"Don\u0027t think so, because we are already setting it here [1]\n\n[1] https://review.opendev.org/c/openstack/puppet-nova/+/785305/17/manifests/compute/libvirt/virtproxyd.pp","commit_id":"060c3368b7972ad60b004a1819d9ace41ff923c5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c2d403f7b72a1d906db53b5fae522cced7d0fe7e","unresolved":true,"context_lines":[{"line_number":346,"context_line":"        \u0027auth_tcp\u0027:    value \u003d\u003e $auth_tcp_real, quote \u003d\u003e true;"},{"line_number":347,"context_line":"        \u0027ca_file\u0027:     value \u003d\u003e $ca_file_real, quote \u003d\u003e true;"},{"line_number":348,"context_line":"        \u0027crl_file\u0027:    value \u003d\u003e $crl_file_real, quote \u003d\u003e true;"},{"line_number":349,"context_line":"        \u0027listen_addr\u0027: value \u003d\u003e pick($listen_address, $::os_service_default), quote \u003d\u003e true;"},{"line_number":350,"context_line":"      }"},{"line_number":351,"context_line":"    }"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":17,"id":"c47b0f4e_09dda6ac","line":349,"range":{"start_line":349,"start_character":0,"end_line":349,"end_character":92},"updated":"2021-09-07 13:13:14.000000000","message":"nit: since you\u0027ve removed pick() calls for manifests/compute/libvirt/virtlogd.pp, perhaps these two no longer needed as well?","commit_id":"060c3368b7972ad60b004a1819d9ace41ff923c5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2fa669c1f2543d3b1a7a6d8bb32c9cf3f2b87b85","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        \u0027auth_tcp\u0027:    value \u003d\u003e $auth_tcp_real, quote \u003d\u003e true;"},{"line_number":347,"context_line":"        \u0027ca_file\u0027:     value \u003d\u003e $ca_file_real, quote \u003d\u003e true;"},{"line_number":348,"context_line":"        \u0027crl_file\u0027:    value \u003d\u003e $crl_file_real, quote \u003d\u003e true;"},{"line_number":349,"context_line":"        \u0027listen_addr\u0027: value \u003d\u003e pick($listen_address, $::os_service_default), quote \u003d\u003e true;"},{"line_number":350,"context_line":"      }"},{"line_number":351,"context_line":"    }"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":17,"id":"b7fed538_759b1055","line":349,"range":{"start_line":349,"start_character":0,"end_line":349,"end_character":92},"in_reply_to":"a1adb9ae_0ccce842","updated":"2021-09-17 10:05:01.000000000","message":"Ack","commit_id":"060c3368b7972ad60b004a1819d9ace41ff923c5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"63531ff87cbd01570cefc8d1c78c8db6c5b2d5f6","unresolved":true,"context_lines":[{"line_number":346,"context_line":"        \u0027auth_tcp\u0027:    value \u003d\u003e $auth_tcp_real, quote \u003d\u003e true;"},{"line_number":347,"context_line":"        \u0027ca_file\u0027:     value \u003d\u003e $ca_file_real, quote \u003d\u003e true;"},{"line_number":348,"context_line":"        \u0027crl_file\u0027:    value \u003d\u003e $crl_file_real, quote \u003d\u003e true;"},{"line_number":349,"context_line":"        \u0027listen_addr\u0027: value \u003d\u003e pick($listen_address, $::os_service_default), quote \u003d\u003e true;"},{"line_number":350,"context_line":"      }"},{"line_number":351,"context_line":"    }"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":17,"id":"a1adb9ae_0ccce842","line":349,"range":{"start_line":349,"start_character":0,"end_line":349,"end_character":92},"in_reply_to":"c47b0f4e_09dda6ac","updated":"2021-09-07 23:27:37.000000000","message":"This pick was intentionally added when we change the default of listen_address from undef to $::os_service_default. IIRC the change was made in this cycle and we need to keep it one cycle.","commit_id":"060c3368b7972ad60b004a1819d9ace41ff923c5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"08c1cf0bc308fd66666e26a4ec0499132fc9f17d","unresolved":true,"context_lines":[{"line_number":244,"context_line":"        $host_uuid_real \u003d $::libvirt_uuid"},{"line_number":245,"context_line":"      }"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"      Augeas {"},{"line_number":248,"context_line":"        changes \u003d\u003e [\"set host_uuid ${host_uuid_real}\"],"},{"line_number":249,"context_line":"        require \u003d\u003e Package[\u0027libvirt\u0027],"},{"line_number":250,"context_line":"      }"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"      if !$modular_libvirt_real {"},{"line_number":253,"context_line":"        augeas { \u0027libvirt-conf-uuid\u0027:"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"71e444b8_8ab036d6","line":250,"range":{"start_line":247,"start_character":5,"end_line":250,"end_character":7},"updated":"2021-09-10 00:16:03.000000000","message":"Augeas is a common resource and overriding its default would be confusing in case we want to add a different augeas resource in the future.\nI\u0027ve submitted a change to refactor this. wdyt ?\n\nhttps://review.opendev.org/c/openstack/puppet-nova/+/808078","commit_id":"55786df2006dd22dad72f8dfa3e4fa9d8f8f36d7"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ccfa3a46ec761aa2968245f80ead0f11204bd5b5","unresolved":true,"context_lines":[{"line_number":244,"context_line":"        $host_uuid_real \u003d $::libvirt_uuid"},{"line_number":245,"context_line":"      }"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"      Augeas {"},{"line_number":248,"context_line":"        changes \u003d\u003e [\"set host_uuid ${host_uuid_real}\"],"},{"line_number":249,"context_line":"        require \u003d\u003e Package[\u0027libvirt\u0027],"},{"line_number":250,"context_line":"      }"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"      if !$modular_libvirt_real {"},{"line_number":253,"context_line":"        augeas { \u0027libvirt-conf-uuid\u0027:"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"e23f0315_464749c1","line":250,"range":{"start_line":247,"start_character":5,"end_line":250,"end_character":7},"in_reply_to":"71e444b8_8ab036d6","updated":"2021-09-10 09:25:38.000000000","message":"I think, now its well organised and concise.\nThanks a lot for your help here and in create_resources logic.","commit_id":"55786df2006dd22dad72f8dfa3e4fa9d8f8f36d7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"08c1cf0bc308fd66666e26a4ec0499132fc9f17d","unresolved":true,"context_lines":[{"line_number":311,"context_line":"    }"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    if !$modular_libvirt_real {"},{"line_number":314,"context_line":"      libvirtd_config {"},{"line_number":315,"context_line":"        \u0027listen_tls\u0027:  value \u003d\u003e $listen_tls;"},{"line_number":316,"context_line":"        \u0027listen_tcp\u0027:  value \u003d\u003e $listen_tcp;"},{"line_number":317,"context_line":"        \u0027auth_tls\u0027:    value \u003d\u003e $auth_tls_real, quote \u003d\u003e true;"},{"line_number":318,"context_line":"        \u0027auth_tcp\u0027:    value \u003d\u003e $auth_tcp_real, quote \u003d\u003e true;"},{"line_number":319,"context_line":"        \u0027ca_file\u0027:     value \u003d\u003e $ca_file_real, quote \u003d\u003e true;"},{"line_number":320,"context_line":"        \u0027crl_file\u0027:    value \u003d\u003e $crl_file_real, quote \u003d\u003e true;"},{"line_number":321,"context_line":"        \u0027listen_addr\u0027: value \u003d\u003e pick($listen_address, $::os_service_default), quote \u003d\u003e true;"},{"line_number":322,"context_line":"      }"},{"line_number":323,"context_line":"    } else {"},{"line_number":324,"context_line":"      virtproxyd_config {"},{"line_number":325,"context_line":"        \u0027listen_tls\u0027:  value \u003d\u003e $listen_tls;"},{"line_number":326,"context_line":"        \u0027listen_tcp\u0027:  value \u003d\u003e $listen_tcp;"},{"line_number":327,"context_line":"        \u0027auth_tls\u0027:    value \u003d\u003e $auth_tls_real, quote \u003d\u003e true;"},{"line_number":328,"context_line":"        \u0027auth_tcp\u0027:    value \u003d\u003e $auth_tcp_real, quote \u003d\u003e true;"},{"line_number":329,"context_line":"        \u0027ca_file\u0027:     value \u003d\u003e $ca_file_real, quote \u003d\u003e true;"},{"line_number":330,"context_line":"        \u0027crl_file\u0027:    value \u003d\u003e $crl_file_real, quote \u003d\u003e true;"},{"line_number":331,"context_line":"        \u0027listen_addr\u0027: value \u003d\u003e pick($listen_address, $::os_service_default), quote \u003d\u003e true;"},{"line_number":332,"context_line":"      }"},{"line_number":333,"context_line":"    }"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    if $transport_real \u003d\u003d \u0027tls\u0027 or $transport_real \u003d\u003d \u0027tcp\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"331f6952_b6312f89","line":332,"range":{"start_line":314,"start_character":6,"end_line":332,"end_character":7},"updated":"2021-09-10 00:16:03.000000000","message":"Please check https://review.opendev.org/c/openstack/puppet-nova/+/808078 which shows how to implement this create_resources.","commit_id":"55786df2006dd22dad72f8dfa3e4fa9d8f8f36d7"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ccfa3a46ec761aa2968245f80ead0f11204bd5b5","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    }"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    if !$modular_libvirt_real {"},{"line_number":314,"context_line":"      libvirtd_config {"},{"line_number":315,"context_line":"        \u0027listen_tls\u0027:  value \u003d\u003e $listen_tls;"},{"line_number":316,"context_line":"        \u0027listen_tcp\u0027:  value \u003d\u003e $listen_tcp;"},{"line_number":317,"context_line":"        \u0027auth_tls\u0027:    value \u003d\u003e $auth_tls_real, quote \u003d\u003e true;"},{"line_number":318,"context_line":"        \u0027auth_tcp\u0027:    value \u003d\u003e $auth_tcp_real, quote \u003d\u003e true;"},{"line_number":319,"context_line":"        \u0027ca_file\u0027:     value \u003d\u003e $ca_file_real, quote \u003d\u003e true;"},{"line_number":320,"context_line":"        \u0027crl_file\u0027:    value \u003d\u003e $crl_file_real, quote \u003d\u003e true;"},{"line_number":321,"context_line":"        \u0027listen_addr\u0027: value \u003d\u003e pick($listen_address, $::os_service_default), quote \u003d\u003e true;"},{"line_number":322,"context_line":"      }"},{"line_number":323,"context_line":"    } else {"},{"line_number":324,"context_line":"      virtproxyd_config {"},{"line_number":325,"context_line":"        \u0027listen_tls\u0027:  value \u003d\u003e $listen_tls;"},{"line_number":326,"context_line":"        \u0027listen_tcp\u0027:  value \u003d\u003e $listen_tcp;"},{"line_number":327,"context_line":"        \u0027auth_tls\u0027:    value \u003d\u003e $auth_tls_real, quote \u003d\u003e true;"},{"line_number":328,"context_line":"        \u0027auth_tcp\u0027:    value \u003d\u003e $auth_tcp_real, quote \u003d\u003e true;"},{"line_number":329,"context_line":"        \u0027ca_file\u0027:     value \u003d\u003e $ca_file_real, quote \u003d\u003e true;"},{"line_number":330,"context_line":"        \u0027crl_file\u0027:    value \u003d\u003e $crl_file_real, quote \u003d\u003e true;"},{"line_number":331,"context_line":"        \u0027listen_addr\u0027: value \u003d\u003e pick($listen_address, $::os_service_default), quote \u003d\u003e true;"},{"line_number":332,"context_line":"      }"},{"line_number":333,"context_line":"    }"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    if $transport_real \u003d\u003d \u0027tls\u0027 or $transport_real \u003d\u003d \u0027tcp\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"0f103e4a_5cca7630","line":332,"range":{"start_line":314,"start_character":6,"end_line":332,"end_character":7},"in_reply_to":"331f6952_b6312f89","updated":"2021-09-10 09:25:38.000000000","message":"Done","commit_id":"55786df2006dd22dad72f8dfa3e4fa9d8f8f36d7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"08c1cf0bc308fd66666e26a4ec0499132fc9f17d","unresolved":true,"context_lines":[{"line_number":339,"context_line":"        $manage_services \u003d pick($::nova::compute::libvirt::manage_libvirt_services, true)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        if $manage_services {"},{"line_number":342,"context_line":"          # libvirtd.service should be stopped before socket service is started."},{"line_number":343,"context_line":"          # Otherwise, socket service fails to start."},{"line_number":344,"context_line":"          exec { \u0027stop libvirtd.service\u0027:"},{"line_number":345,"context_line":"            path    \u003d\u003e [\u0027/sbin\u0027, \u0027/usr/sbin\u0027, \u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":346,"context_line":"            command \u003d\u003e \u0027systemctl -q stop libvirtd.service\u0027,"},{"line_number":347,"context_line":"            unless  \u003d\u003e \"systemctl -q is-active libvirtd-${transport_real}.socket\","},{"line_number":348,"context_line":"            require \u003d\u003e Anchor[\u0027nova::install::end\u0027]"},{"line_number":349,"context_line":"          }"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"          service { \"libvirtd-${transport_real}\":"},{"line_number":352,"context_line":"            ensure  \u003d\u003e \u0027running\u0027,"},{"line_number":353,"context_line":"            name    \u003d\u003e \"libvirtd-${transport_real}.socket\","},{"line_number":354,"context_line":"            enable  \u003d\u003e true,"},{"line_number":355,"context_line":"            require \u003d\u003e Anchor[\u0027nova::config::end\u0027]"},{"line_number":356,"context_line":"          }"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"          Exec[\u0027stop libvirtd.service\u0027] -\u003e Service[\"libvirtd-${transport_real}\"] -\u003e Service\u003c| title \u003d\u003d \u0027libvirt\u0027 |\u003e"},{"line_number":359,"context_line":"        }"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        # --listen option should be disabled in newer libvirt"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"dbfcb0e5_fd5a7f2d","line":358,"range":{"start_line":342,"start_character":10,"end_line":358,"end_character":115},"updated":"2021-09-10 00:16:03.000000000","message":"This logic should be skipped in when modular_libvirt is true.","commit_id":"55786df2006dd22dad72f8dfa3e4fa9d8f8f36d7"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ccfa3a46ec761aa2968245f80ead0f11204bd5b5","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        $manage_services \u003d pick($::nova::compute::libvirt::manage_libvirt_services, true)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        if $manage_services {"},{"line_number":342,"context_line":"          # libvirtd.service should be stopped before socket service is started."},{"line_number":343,"context_line":"          # Otherwise, socket service fails to start."},{"line_number":344,"context_line":"          exec { \u0027stop libvirtd.service\u0027:"},{"line_number":345,"context_line":"            path    \u003d\u003e [\u0027/sbin\u0027, \u0027/usr/sbin\u0027, \u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":346,"context_line":"            command \u003d\u003e \u0027systemctl -q stop libvirtd.service\u0027,"},{"line_number":347,"context_line":"            unless  \u003d\u003e \"systemctl -q is-active libvirtd-${transport_real}.socket\","},{"line_number":348,"context_line":"            require \u003d\u003e Anchor[\u0027nova::install::end\u0027]"},{"line_number":349,"context_line":"          }"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"          service { \"libvirtd-${transport_real}\":"},{"line_number":352,"context_line":"            ensure  \u003d\u003e \u0027running\u0027,"},{"line_number":353,"context_line":"            name    \u003d\u003e \"libvirtd-${transport_real}.socket\","},{"line_number":354,"context_line":"            enable  \u003d\u003e true,"},{"line_number":355,"context_line":"            require \u003d\u003e Anchor[\u0027nova::config::end\u0027]"},{"line_number":356,"context_line":"          }"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"          Exec[\u0027stop libvirtd.service\u0027] -\u003e Service[\"libvirtd-${transport_real}\"] -\u003e Service\u003c| title \u003d\u003d \u0027libvirt\u0027 |\u003e"},{"line_number":359,"context_line":"        }"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        # --listen option should be disabled in newer libvirt"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"f84dccf8_76c3dd62","line":358,"range":{"start_line":342,"start_character":10,"end_line":358,"end_character":115},"in_reply_to":"dbfcb0e5_fd5a7f2d","updated":"2021-09-10 09:25:38.000000000","message":"Done","commit_id":"55786df2006dd22dad72f8dfa3e4fa9d8f8f36d7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2fa669c1f2543d3b1a7a6d8bb32c9cf3f2b87b85","unresolved":true,"context_lines":[{"line_number":245,"context_line":"      }"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"      if $modular_libvirt_real {"},{"line_number":248,"context_line":"        [\u0027virtqemud\u0027, \u0027virtproxyd\u0027, \u0027virtsecretd\u0027, \u0027virtnodedevd\u0027, \u0027virtstoraged\u0027].each |String $daemon| {"},{"line_number":249,"context_line":"          augeas { \"${daemon}-conf-uuid\":"},{"line_number":250,"context_line":"            context \u003d\u003e \"/files/etc/libvirt/${daemon}.conf\","},{"line_number":251,"context_line":"            changes \u003d\u003e [\"set host_uuid ${host_uuid_real}\"],"}],"source_content_type":"text/x-puppet","patch_set":31,"id":"c3f26e7f_0f2d98df","line":248,"updated":"2021-09-17 10:05:01.000000000","message":"this way it looks much better, thanks! sorry for the bad idea with global Augeas{} :)","commit_id":"89ecf01bbd0ba9af7f3ddb0feb582f0fec6e5970"}],"manifests/params.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b9b6b2e51780b6b955add8be79f1109c98c8168d","unresolved":true,"context_lines":[{"line_number":37,"context_line":"      $libvirt_service_name              \u003d \u0027libvirtd\u0027"},{"line_number":38,"context_line":"      $libvirt_guests_service_name       \u003d \u0027libvirt-guests\u0027"},{"line_number":39,"context_line":"      $virtlock_service_name             \u003d \u0027virtlockd\u0027"},{"line_number":40,"context_line":"      $virtlog_service_name              \u003d undef"},{"line_number":41,"context_line":"      $virtsecret_service_name           \u003d \u0027virtsecretd\u0027"},{"line_number":42,"context_line":"      $virtnodedev_service_name          \u003d \u0027virtnodedevd\u0027"},{"line_number":43,"context_line":"      $virtqemu_service_name             \u003d \u0027virtqemud\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"b7089604_ec7a7f29","line":40,"range":{"start_line":40,"start_character":43,"end_line":40,"end_character":48},"updated":"2021-04-08 06:35:13.000000000","message":"Side note: I think we should fix this...","commit_id":"a5319e07432150383c02e86031451d98ffa6ccfd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b9b6b2e51780b6b955add8be79f1109c98c8168d","unresolved":true,"context_lines":[{"line_number":49,"context_line":"      $vncproxy_service_name             \u003d \u0027openstack-nova-novncproxy\u0027"},{"line_number":50,"context_line":"      $serialproxy_service_name          \u003d \u0027openstack-nova-serialproxy\u0027"},{"line_number":51,"context_line":"      $spicehtml5proxy_service_name      \u003d \u0027openstack-nova-spicehtml5proxy\u0027"},{"line_number":52,"context_line":"      $enable_modular_libvirt_daemons    \u003d false"},{"line_number":53,"context_line":"      # redhat specific config defaults"},{"line_number":54,"context_line":"      $root_helper                       \u003d \u0027sudo nova-rootwrap\u0027"},{"line_number":55,"context_line":"      $lock_path                         \u003d \u0027/var/lib/nova/tmp\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"d9d0c336_4688776a","line":52,"range":{"start_line":52,"start_character":6,"end_line":52,"end_character":48},"updated":"2021-04-08 06:35:13.000000000","message":"Please add this for Debian as well.","commit_id":"a5319e07432150383c02e86031451d98ffa6ccfd"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"0238a25d1241131f6c97634df14275ce240d9436","unresolved":true,"context_lines":[{"line_number":50,"context_line":"      $vncproxy_service_name             \u003d \u0027openstack-nova-novncproxy\u0027"},{"line_number":51,"context_line":"      $serialproxy_service_name          \u003d \u0027openstack-nova-serialproxy\u0027"},{"line_number":52,"context_line":"      $spicehtml5proxy_service_name      \u003d \u0027openstack-nova-spicehtml5proxy\u0027"},{"line_number":53,"context_line":"      $modular_libvirt                   \u003d true"},{"line_number":54,"context_line":"      # redhat specific config defaults"},{"line_number":55,"context_line":"      $root_helper                       \u003d \u0027sudo nova-rootwrap\u0027"},{"line_number":56,"context_line":"      $lock_path                         \u003d \u0027/var/lib/nova/tmp\u0027"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"b87e4db4_100fb695","line":53,"updated":"2021-09-05 15:22:16.000000000","message":"I am not sure if we should default in puppet-nova to modular libvirt. it is ok for tripleo to default in puppet-tripleo to use modular libvirt, but we probably should not set this as the default for all users of puppet-nova","commit_id":"1fd6ae4a2615d8e2a7cabee4f61ffcf84fb2148b"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"128c58f36909a63d13683c2ee66daf108bf6ab23","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      $vncproxy_service_name             \u003d \u0027openstack-nova-novncproxy\u0027"},{"line_number":51,"context_line":"      $serialproxy_service_name          \u003d \u0027openstack-nova-serialproxy\u0027"},{"line_number":52,"context_line":"      $spicehtml5proxy_service_name      \u003d \u0027openstack-nova-spicehtml5proxy\u0027"},{"line_number":53,"context_line":"      $modular_libvirt                   \u003d true"},{"line_number":54,"context_line":"      # redhat specific config defaults"},{"line_number":55,"context_line":"      $root_helper                       \u003d \u0027sudo nova-rootwrap\u0027"},{"line_number":56,"context_line":"      $lock_path                         \u003d \u0027/var/lib/nova/tmp\u0027"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"535e7c21_6062d933","line":53,"in_reply_to":"b87e4db4_100fb695","updated":"2021-09-06 10:20:29.000000000","message":"Done","commit_id":"1fd6ae4a2615d8e2a7cabee4f61ffcf84fb2148b"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8546e7823f2964b309b2c871bff778644fcba59d","unresolved":true,"context_lines":[{"line_number":50,"context_line":"      $vncproxy_service_name             \u003d \u0027openstack-nova-novncproxy\u0027"},{"line_number":51,"context_line":"      $serialproxy_service_name          \u003d \u0027openstack-nova-serialproxy\u0027"},{"line_number":52,"context_line":"      $spicehtml5proxy_service_name      \u003d \u0027openstack-nova-spicehtml5proxy\u0027"},{"line_number":53,"context_line":"      $modular_libvirt                   \u003d false"},{"line_number":54,"context_line":"      # redhat specific config defaults"},{"line_number":55,"context_line":"      $root_helper                       \u003d \u0027sudo nova-rootwrap\u0027"},{"line_number":56,"context_line":"      $lock_path                         \u003d \u0027/var/lib/nova/tmp\u0027"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"bc4c881d_68bbb1a7","line":53,"updated":"2021-09-17 14:18:57.000000000","message":"oh nvm, it\u0027s off by default... confused the patch with puppet-tripleo","commit_id":"e7b3d72496434095a92305de9c0ebf5d92dfedb8"}],"releasenotes/notes/modular-libvirt-52048e6e9935c25c.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"563c04d9ca5677c5e5756c4265dbc48696473e8e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This change adds functionality to enable modular libvirt daemons"},{"line_number":5,"context_line":"    support. Also all the daemons runs in separate containers, so the"},{"line_number":6,"context_line":"    configuration is done for all the daemon containers."},{"line_number":7,"context_line":"    Here is the list of daemons added in this change."}],"source_content_type":"text/x-yaml","patch_set":36,"id":"b72a4476_e07bb93c","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":15},"updated":"2021-09-22 03:15:06.000000000","message":"This is added to a release note document so mentioning \u0027this change\u0027 is a bit odd.","commit_id":"071d1847bb6e3b64677a8b91a3cf80be799f6350"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"563c04d9ca5677c5e5756c4265dbc48696473e8e","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This change adds functionality to enable modular libvirt daemons"},{"line_number":5,"context_line":"    support. Also all the daemons runs in separate containers, so the"},{"line_number":6,"context_line":"    configuration is done for all the daemon containers."},{"line_number":7,"context_line":"    Here is the list of daemons added in this change."},{"line_number":8,"context_line":"    - virtnodedevd"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"146eba3c_98075b5e","line":5,"range":{"start_line":5,"start_character":42,"end_line":5,"end_character":61},"updated":"2021-09-22 03:15:06.000000000","message":"This is not true in Puppet OpenStack.","commit_id":"071d1847bb6e3b64677a8b91a3cf80be799f6350"}],"spec/classes/nova_compute_libvirt_services_spec.rb":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"f56943c245bf9e794d0bba7b01e37ed6e4b61333","unresolved":true,"context_lines":[{"line_number":10,"context_line":"        is_expected.to contain_service(\u0027libvirt\u0027)"},{"line_number":11,"context_line":"      end"},{"line_number":12,"context_line":"    end"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    context \u0027with overridden parameters\u0027 do"},{"line_number":15,"context_line":"      let :params do"},{"line_number":16,"context_line":"        {"}],"source_content_type":"text/x-ruby","patch_set":29,"id":"1a206bee_1c8bc7fd","line":13,"updated":"2021-09-15 10:01:46.000000000","message":"we should check for modular libvirt for the packages","commit_id":"eadc4fc61ace360717204e998078379b886c2f3a"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"600d1984187852bc613053da14b9098e2f007501","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        is_expected.to contain_service(\u0027libvirt\u0027)"},{"line_number":11,"context_line":"      end"},{"line_number":12,"context_line":"    end"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    context \u0027with overridden parameters\u0027 do"},{"line_number":15,"context_line":"      let :params do"},{"line_number":16,"context_line":"        {"}],"source_content_type":"text/x-ruby","patch_set":29,"id":"f2a0f3ab_95735291","line":13,"in_reply_to":"1a206bee_1c8bc7fd","updated":"2021-09-16 11:08:52.000000000","message":"Done","commit_id":"eadc4fc61ace360717204e998078379b886c2f3a"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"372ddd7d73c2daa873127387a2d25d530329f97b","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"      it \u0027deploys libvirt packages and services with modular-libvirt\u0027 do"},{"line_number":36,"context_line":"        is_expected.to contain_package(\u0027libvirt\u0027)"},{"line_number":37,"context_line":"        is_expected.to contain_package(\u0027libvirt-daemon-driver-qemu\u0027)"},{"line_number":38,"context_line":"        is_expected.to contain_package(\u0027libvirt-daemon-driver-secret\u0027)"},{"line_number":39,"context_line":"        is_expected.to contain_package(\u0027libvirt-daemon-driver-storage\u0027)"},{"line_number":40,"context_line":"        is_expected.to contain_package(\u0027libvirt-daemon-driver-nodedev\u0027)"},{"line_number":41,"context_line":"        is_expected.to contain_service(\u0027virtlogd\u0027)"},{"line_number":42,"context_line":"        is_expected.to contain_service(\u0027virtproxyd\u0027)"},{"line_number":43,"context_line":"        is_expected.to contain_service(\u0027virtnodedevd\u0027)"}],"source_content_type":"text/x-ruby","patch_set":35,"id":"59dc78e9_a9d00899","line":40,"range":{"start_line":37,"start_character":0,"end_line":40,"end_character":71},"updated":"2021-09-20 07:36:20.000000000","message":"you call those packages in the class just:\n \u0027package { \"virt${daemon}\":\u0027\n\nso it would be virtqemu, virtsecret, virtstorage and virtnodedev in here","commit_id":"7cce633b7c87fffc3b2326b350ccd4b24d25ebf9"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"a1e0b9bad79eef9ee8e02130e29c2191d1bb3b94","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"      it \u0027deploys libvirt packages and services with modular-libvirt\u0027 do"},{"line_number":36,"context_line":"        is_expected.to contain_package(\u0027libvirt\u0027)"},{"line_number":37,"context_line":"        is_expected.to contain_package(\u0027libvirt-daemon-driver-qemu\u0027)"},{"line_number":38,"context_line":"        is_expected.to contain_package(\u0027libvirt-daemon-driver-secret\u0027)"},{"line_number":39,"context_line":"        is_expected.to contain_package(\u0027libvirt-daemon-driver-storage\u0027)"},{"line_number":40,"context_line":"        is_expected.to contain_package(\u0027libvirt-daemon-driver-nodedev\u0027)"},{"line_number":41,"context_line":"        is_expected.to contain_service(\u0027virtlogd\u0027)"},{"line_number":42,"context_line":"        is_expected.to contain_service(\u0027virtproxyd\u0027)"},{"line_number":43,"context_line":"        is_expected.to contain_service(\u0027virtnodedevd\u0027)"}],"source_content_type":"text/x-ruby","patch_set":35,"id":"4202141d_6b6d38a6","line":40,"range":{"start_line":37,"start_character":0,"end_line":40,"end_character":71},"in_reply_to":"59dc78e9_a9d00899","updated":"2021-09-20 10:48:34.000000000","message":"Done","commit_id":"7cce633b7c87fffc3b2326b350ccd4b24d25ebf9"}],"spec/classes/nova_compute_libvirt_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"63531ff87cbd01570cefc8d1c78c8db6c5b2d5f6","unresolved":true,"context_lines":[{"line_number":72,"context_line":"      it { is_expected.to contain_nova_config(\u0027libvirt/swtpm_user\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)}"},{"line_number":73,"context_line":"      it { is_expected.to contain_nova_config(\u0027libvirt/swtpm_group\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)}"},{"line_number":74,"context_line":"      it { is_expected.to contain_nova_config(\u0027libvirt/max_queues\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)}"},{"line_number":75,"context_line":"      it { is_expected.to contain_nova_config(\u0027libvirt/num_memory_encrypted_guests\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)}"},{"line_number":76,"context_line":"      it { is_expected.to contain_libvirtd_config(\u0027log_outputs\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027).with_quote(true)}"},{"line_number":77,"context_line":"      it { is_expected.to contain_libvirtd_config(\u0027log_filters\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027).with_quote(true)}"},{"line_number":78,"context_line":"      it { is_expected.to contain_libvirtd_config(\u0027tls_priority\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027).with_quote(true)}"},{"line_number":79,"context_line":"      it { is_expected.to contain_libvirtd_config(\u0027ovs_timeout\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)}"},{"line_number":80,"context_line":"    end"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    describe \u0027with params\u0027 do"},{"line_number":83,"context_line":"      let :params do"}],"source_content_type":"text/x-ruby","patch_set":17,"id":"99c733f5_974d3cce","side":"PARENT","line":80,"range":{"start_line":75,"start_character":117,"end_line":80,"end_character":7},"updated":"2021-09-07 23:27:37.000000000","message":"These should not be removed.","commit_id":"f1b48f23ce199afea41de376907c47a556ca7d6d"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"c7ec16fcf34f373f782e26788f3c8e7a4061a9f2","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      it { is_expected.to contain_nova_config(\u0027libvirt/swtpm_user\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)}"},{"line_number":73,"context_line":"      it { is_expected.to contain_nova_config(\u0027libvirt/swtpm_group\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)}"},{"line_number":74,"context_line":"      it { is_expected.to contain_nova_config(\u0027libvirt/max_queues\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)}"},{"line_number":75,"context_line":"      it { is_expected.to contain_nova_config(\u0027libvirt/num_memory_encrypted_guests\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)}"},{"line_number":76,"context_line":"      it { is_expected.to contain_libvirtd_config(\u0027log_outputs\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027).with_quote(true)}"},{"line_number":77,"context_line":"      it { is_expected.to contain_libvirtd_config(\u0027log_filters\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027).with_quote(true)}"},{"line_number":78,"context_line":"      it { is_expected.to contain_libvirtd_config(\u0027tls_priority\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027).with_quote(true)}"},{"line_number":79,"context_line":"      it { is_expected.to contain_libvirtd_config(\u0027ovs_timeout\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)}"},{"line_number":80,"context_line":"    end"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    describe \u0027with params\u0027 do"},{"line_number":83,"context_line":"      let :params do"}],"source_content_type":"text/x-ruby","patch_set":17,"id":"c2adbdac_a5693695","side":"PARENT","line":80,"range":{"start_line":75,"start_character":117,"end_line":80,"end_character":7},"in_reply_to":"99c733f5_974d3cce","updated":"2021-09-09 11:00:15.000000000","message":"Done","commit_id":"f1b48f23ce199afea41de376907c47a556ca7d6d"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"f56943c245bf9e794d0bba7b01e37ed6e4b61333","unresolved":true,"context_lines":[{"line_number":117,"context_line":"          :ovs_timeout                                \u003d\u003e 10,"},{"line_number":118,"context_line":"          :max_queues                                 \u003d\u003e 4,"},{"line_number":119,"context_line":"          :num_memory_encrypted_guests                \u003d\u003e 255,"},{"line_number":120,"context_line":"          :modular_libvirt                            \u003d\u003e false,"},{"line_number":121,"context_line":"        }"},{"line_number":122,"context_line":"      end"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":29,"id":"aac6c14b_87cb5d2b","line":120,"updated":"2021-09-15 10:01:46.000000000","message":"this is the default, so it won\u0027t hurt, but should not be required, right?","commit_id":"eadc4fc61ace360717204e998078379b886c2f3a"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"600d1984187852bc613053da14b9098e2f007501","unresolved":false,"context_lines":[{"line_number":117,"context_line":"          :ovs_timeout                                \u003d\u003e 10,"},{"line_number":118,"context_line":"          :max_queues                                 \u003d\u003e 4,"},{"line_number":119,"context_line":"          :num_memory_encrypted_guests                \u003d\u003e 255,"},{"line_number":120,"context_line":"          :modular_libvirt                            \u003d\u003e false,"},{"line_number":121,"context_line":"        }"},{"line_number":122,"context_line":"      end"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":29,"id":"a26aa661_57950d80","line":120,"in_reply_to":"aac6c14b_87cb5d2b","updated":"2021-09-16 11:08:52.000000000","message":"Done","commit_id":"eadc4fc61ace360717204e998078379b886c2f3a"}]}