)]}'
{"manifests/compute/libvirt/qemu.pp":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"7157be308a214bd1b68c694353d6deeb017059cf","unresolved":true,"context_lines":[{"line_number":78,"context_line":"      $vnc_tls_value \u003d 0"},{"line_number":79,"context_line":"      $vnc_tls_verify_value \u003d 0"},{"line_number":80,"context_line":"    }"},{"line_number":81,"context_line":"    if $tls_priority {"},{"line_number":82,"context_line":"      $default_tls_verify_value \u003d $default_tls_verify ? { true \u003d\u003e 1, false \u003d\u003e 0 }"},{"line_number":83,"context_line":"    } else {"},{"line_number":84,"context_line":"      $default_tls_verify_value \u003d 0"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"6ca57f74_21569a7a","line":81,"updated":"2021-04-13 06:11:19.000000000","message":"I am not sure I understand the relation to tls_priority. Why not just set 1/0 depending of $default_tls_verify ?","commit_id":"9694f5b9cd87099cdb630d0ee350fe7136ca9a14"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"fe17044abd66501f51d317739c4d04a794f6522b","unresolved":true,"context_lines":[{"line_number":79,"context_line":"      $vnc_tls_verify_value \u003d 0"},{"line_number":80,"context_line":"    }"},{"line_number":81,"context_line":"    if $default_tls_verify {"},{"line_number":82,"context_line":"      $default_tls_verify_value \u003d $default_tls_verify"},{"line_number":83,"context_line":"    } else {"},{"line_number":84,"context_line":"      $default_tls_verify_value \u003d 0"},{"line_number":85,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"d1af2ab9_26f3e354","line":82,"range":{"start_line":82,"start_character":34,"end_line":82,"end_character":53},"updated":"2021-04-14 14:59:59.000000000","message":"needs to be 1 not true\n\nmaybe default to undef and use\nif $default_tls_verify {\n  $default_tls_verify_value \u003d $default_tls_verify ? { true \u003d\u003e 1, false \u003d\u003e 0 }\n}","commit_id":"a5f59c7605a686ac64c8b75f42274c336da10341"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"3fcf2f664893207da6cb2e4351ac92747b67d093","unresolved":false,"context_lines":[{"line_number":79,"context_line":"      $vnc_tls_verify_value \u003d 0"},{"line_number":80,"context_line":"    }"},{"line_number":81,"context_line":"    if $default_tls_verify {"},{"line_number":82,"context_line":"      $default_tls_verify_value \u003d $default_tls_verify"},{"line_number":83,"context_line":"    } else {"},{"line_number":84,"context_line":"      $default_tls_verify_value \u003d 0"},{"line_number":85,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"8ac9d222_32fb8527","line":82,"range":{"start_line":82,"start_character":34,"end_line":82,"end_character":53},"in_reply_to":"d1af2ab9_26f3e354","updated":"2021-04-16 14:35:45.000000000","message":"Done","commit_id":"a5f59c7605a686ac64c8b75f42274c336da10341"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"da34d28bf288da5ae1134623f2e556a9670a1da3","unresolved":true,"context_lines":[{"line_number":37,"context_line":"#   (optional) Enables TLS for nbd connections."},{"line_number":38,"context_line":"#   Defaults to false."},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*default_tls_verify*]"},{"line_number":41,"context_line":"#   (optional) Enables TLS client cert verification."},{"line_number":42,"context_line":"#   Defaults to true."},{"line_number":43,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"e56e9135_5512cfe7","line":40,"updated":"2021-04-20 06:04:24.000000000","message":"Let\u0027s put this just after vnc_tls_verify to have consistent order.","commit_id":"cbfa5d063b92a8bf14bd23f4e2b56292d79d9e1d"}],"spec/classes/nova_compute_libvirt_qemu_spec.rb":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"fe17044abd66501f51d317739c4d04a794f6522b","unresolved":true,"context_lines":[{"line_number":65,"context_line":"            \"set max_processes 4096\","},{"line_number":66,"context_line":"            \"set vnc_tls 0\","},{"line_number":67,"context_line":"            \"set vnc_tls_x509_verify 0\","},{"line_number":68,"context_line":"            \"set default_tls_x509_verify 0\","},{"line_number":69,"context_line":"        ],"},{"line_number":70,"context_line":"        :tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"},{"line_number":71,"context_line":"      }).that_notifies(\u0027Service[libvirt]\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"94d036db_3d55ce1e","line":68,"range":{"start_line":68,"start_character":41,"end_line":68,"end_character":42},"updated":"2021-04-14 14:59:59.000000000","message":"default is right now true, intended?","commit_id":"a5f59c7605a686ac64c8b75f42274c336da10341"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"3fcf2f664893207da6cb2e4351ac92747b67d093","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \"set max_processes 4096\","},{"line_number":66,"context_line":"            \"set vnc_tls 0\","},{"line_number":67,"context_line":"            \"set vnc_tls_x509_verify 0\","},{"line_number":68,"context_line":"            \"set default_tls_x509_verify 0\","},{"line_number":69,"context_line":"        ],"},{"line_number":70,"context_line":"        :tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"},{"line_number":71,"context_line":"      }).that_notifies(\u0027Service[libvirt]\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"92be2d14_756445b5","line":68,"range":{"start_line":68,"start_character":41,"end_line":68,"end_character":42},"in_reply_to":"94d036db_3d55ce1e","updated":"2021-04-16 14:35:45.000000000","message":"Done","commit_id":"a5f59c7605a686ac64c8b75f42274c336da10341"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"fe17044abd66501f51d317739c4d04a794f6522b","unresolved":true,"context_lines":[{"line_number":85,"context_line":"            \"set max_processes 4096\","},{"line_number":86,"context_line":"            \"set vnc_tls 0\","},{"line_number":87,"context_line":"            \"set vnc_tls_x509_verify 0\","},{"line_number":88,"context_line":"            \"set default_tls_x509_verify 0\","},{"line_number":89,"context_line":"            \"set nbd_tls 0\","},{"line_number":90,"context_line":"        ],"},{"line_number":91,"context_line":"        :tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5987a575_1ad5c5eb","line":88,"range":{"start_line":88,"start_character":41,"end_line":88,"end_character":42},"updated":"2021-04-14 14:59:59.000000000","message":"same","commit_id":"a5f59c7605a686ac64c8b75f42274c336da10341"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"3fcf2f664893207da6cb2e4351ac92747b67d093","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            \"set max_processes 4096\","},{"line_number":86,"context_line":"            \"set vnc_tls 0\","},{"line_number":87,"context_line":"            \"set vnc_tls_x509_verify 0\","},{"line_number":88,"context_line":"            \"set default_tls_x509_verify 0\","},{"line_number":89,"context_line":"            \"set nbd_tls 0\","},{"line_number":90,"context_line":"        ],"},{"line_number":91,"context_line":"        :tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"7c52cff3_73b7db37","line":88,"range":{"start_line":88,"start_character":41,"end_line":88,"end_character":42},"in_reply_to":"5987a575_1ad5c5eb","updated":"2021-04-16 14:35:45.000000000","message":"Done","commit_id":"a5f59c7605a686ac64c8b75f42274c336da10341"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"fe17044abd66501f51d317739c4d04a794f6522b","unresolved":true,"context_lines":[{"line_number":108,"context_line":"            \"set max_processes 131072\","},{"line_number":109,"context_line":"            \"set vnc_tls 0\","},{"line_number":110,"context_line":"            \"set vnc_tls_x509_verify 0\","},{"line_number":111,"context_line":"            \"set default_tls_x509_verify 0\","},{"line_number":112,"context_line":"        ],"},{"line_number":113,"context_line":"        :tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"},{"line_number":114,"context_line":"      }).that_notifies(\u0027Service[libvirt]\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3cd16235_a51b1c07","line":111,"range":{"start_line":111,"start_character":41,"end_line":111,"end_character":42},"updated":"2021-04-14 14:59:59.000000000","message":"same","commit_id":"a5f59c7605a686ac64c8b75f42274c336da10341"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"3fcf2f664893207da6cb2e4351ac92747b67d093","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            \"set max_processes 131072\","},{"line_number":109,"context_line":"            \"set vnc_tls 0\","},{"line_number":110,"context_line":"            \"set vnc_tls_x509_verify 0\","},{"line_number":111,"context_line":"            \"set default_tls_x509_verify 0\","},{"line_number":112,"context_line":"        ],"},{"line_number":113,"context_line":"        :tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"},{"line_number":114,"context_line":"      }).that_notifies(\u0027Service[libvirt]\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"981a1744_3367aba5","line":111,"range":{"start_line":111,"start_character":41,"end_line":111,"end_character":42},"in_reply_to":"3cd16235_a51b1c07","updated":"2021-04-16 14:35:45.000000000","message":"Done","commit_id":"a5f59c7605a686ac64c8b75f42274c336da10341"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"fe17044abd66501f51d317739c4d04a794f6522b","unresolved":true,"context_lines":[{"line_number":130,"context_line":"            \"set max_processes 131072\","},{"line_number":131,"context_line":"            \"set vnc_tls 0\","},{"line_number":132,"context_line":"            \"set vnc_tls_x509_verify 0\","},{"line_number":133,"context_line":"            \"set default_tls_x509_verify 0\","},{"line_number":134,"context_line":"            \"set nbd_tls 0\","},{"line_number":135,"context_line":"        ],"},{"line_number":136,"context_line":"        :tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"a5b1d113_734f07e2","line":133,"range":{"start_line":133,"start_character":41,"end_line":133,"end_character":42},"updated":"2021-04-14 14:59:59.000000000","message":"same","commit_id":"a5f59c7605a686ac64c8b75f42274c336da10341"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"3fcf2f664893207da6cb2e4351ac92747b67d093","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            \"set max_processes 131072\","},{"line_number":131,"context_line":"            \"set vnc_tls 0\","},{"line_number":132,"context_line":"            \"set vnc_tls_x509_verify 0\","},{"line_number":133,"context_line":"            \"set default_tls_x509_verify 0\","},{"line_number":134,"context_line":"            \"set nbd_tls 0\","},{"line_number":135,"context_line":"        ],"},{"line_number":136,"context_line":"        :tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"17603ac5_ab8a5e08","line":133,"range":{"start_line":133,"start_character":41,"end_line":133,"end_character":42},"in_reply_to":"a5b1d113_734f07e2","updated":"2021-04-16 14:35:45.000000000","message":"Done","commit_id":"a5f59c7605a686ac64c8b75f42274c336da10341"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"fe17044abd66501f51d317739c4d04a794f6522b","unresolved":true,"context_lines":[{"line_number":155,"context_line":"            \"set max_processes 131072\","},{"line_number":156,"context_line":"            \"set vnc_tls 0\","},{"line_number":157,"context_line":"            \"set vnc_tls_x509_verify 0\","},{"line_number":158,"context_line":"            \"set default_tls_x509_verify 0\","},{"line_number":159,"context_line":"            \"set group openvswitch\","},{"line_number":160,"context_line":"            \"set memory_backing_dir /tmp\","},{"line_number":161,"context_line":"        ],"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"e181e0b0_9f66febe","line":158,"range":{"start_line":158,"start_character":41,"end_line":158,"end_character":42},"updated":"2021-04-14 14:59:59.000000000","message":"same","commit_id":"a5f59c7605a686ac64c8b75f42274c336da10341"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"3fcf2f664893207da6cb2e4351ac92747b67d093","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            \"set max_processes 131072\","},{"line_number":156,"context_line":"            \"set vnc_tls 0\","},{"line_number":157,"context_line":"            \"set vnc_tls_x509_verify 0\","},{"line_number":158,"context_line":"            \"set default_tls_x509_verify 0\","},{"line_number":159,"context_line":"            \"set group openvswitch\","},{"line_number":160,"context_line":"            \"set memory_backing_dir /tmp\","},{"line_number":161,"context_line":"        ],"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"0bab7205_e7838dc8","line":158,"range":{"start_line":158,"start_character":41,"end_line":158,"end_character":42},"in_reply_to":"e181e0b0_9f66febe","updated":"2021-04-16 14:35:45.000000000","message":"Done","commit_id":"a5f59c7605a686ac64c8b75f42274c336da10341"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"da34d28bf288da5ae1134623f2e556a9670a1da3","unresolved":true,"context_lines":[{"line_number":186,"context_line":"      }).that_notifies(\u0027Service[libvirt]\u0027) }"},{"line_number":187,"context_line":"    end"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    context \u0027when configuring qemu with default_tls_verify\u0027 do"},{"line_number":190,"context_line":"      let :params do"},{"line_number":191,"context_line":"        {"},{"line_number":192,"context_line":"          :configure_qemu \u003d\u003e true,"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"4579a9cc_b59af4a7","line":189,"range":{"start_line":189,"start_character":35,"end_line":189,"end_character":58},"updated":"2021-04-20 06:04:24.000000000","message":"how about with default_tls_verify enabled ?","commit_id":"cbfa5d063b92a8bf14bd23f4e2b56292d79d9e1d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"da34d28bf288da5ae1134623f2e556a9670a1da3","unresolved":true,"context_lines":[{"line_number":229,"context_line":"      }).that_notifies(\u0027Service[libvirt]\u0027) }"},{"line_number":230,"context_line":"    end"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    context \u0027when configuring qemu without default_tls_verify\u0027 do"},{"line_number":233,"context_line":"      let :params do"},{"line_number":234,"context_line":"        {"},{"line_number":235,"context_line":"          :configure_qemu \u003d\u003e true,"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"84cc96ec_3c19c7a1","line":232,"range":{"start_line":232,"start_character":35,"end_line":232,"end_character":62},"updated":"2021-04-20 06:04:24.000000000","message":"how about \"with default_tls_verity disabled\". I think this more clearly explains that we use that parameter but disable the feature.","commit_id":"cbfa5d063b92a8bf14bd23f4e2b56292d79d9e1d"}]}